)]}'
{"horizon/middleware.py":[{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"609d042516e6af62cdb11c11ca9fa634cf3ea5d5","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        request.horizon \u003d {\u0027dashboard\u0027: None,"},{"line_number":66,"context_line":"                           \u0027panel\u0027: None,"},{"line_number":67,"context_line":"                           \u0027async_messages\u0027: []}"},{"line_number":68,"context_line":"        if last_activity and (timestamp - last_activity) \u003e timeout:"},{"line_number":69,"context_line":"            request.session.pop(\u0027last_activity\u0027)"},{"line_number":70,"context_line":"            response \u003d HttpResponseRedirect("},{"line_number":71,"context_line":"                \u0027%s?next\u003d%s\u0027 % (settings.LOGOUT_URL, request.path))"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F97fg%3D","line":68,"updated":"2013-12-04 10:56:29.000000000","message":"Won\u0027t this cause\n\nTypeError: unsupported operand type(s) for -: \u0027datetime.datetime\u0027 and \u0027int\u0027\n\nin Django versions \u003c 1.6?","commit_id":"6a27987b338188c476d95bc386c9aed933b1d2e2"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"3d7a4c3beaad481ea6d247931f8620aca1d1cb78","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        request.horizon \u003d {\u0027dashboard\u0027: None,"},{"line_number":66,"context_line":"                           \u0027panel\u0027: None,"},{"line_number":67,"context_line":"                           \u0027async_messages\u0027: []}"},{"line_number":68,"context_line":"        if last_activity and (timestamp - last_activity) \u003e timeout:"},{"line_number":69,"context_line":"            request.session.pop(\u0027last_activity\u0027)"},{"line_number":70,"context_line":"            response \u003d HttpResponseRedirect("},{"line_number":71,"context_line":"                \u0027%s?next\u003d%s\u0027 % (settings.LOGOUT_URL, request.path))"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F97ew%3D","line":68,"in_reply_to":"AAAATn%2F97fg%3D","updated":"2013-12-04 11:01:23.000000000","message":"l 64: timestamp \u003d int(time.time()), so you\u0027re subtracting two ints.\n\nHonestly, there is no reason to store a more structured information here.","commit_id":"6a27987b338188c476d95bc386c9aed933b1d2e2"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"e70f6d61d0fe16b1aad846a16543ef1b79d34c46","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                    )"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        if isinstance(last_activity, int) and \\"},{"line_number":102,"context_line":"                (timestamp - last_activity) \u003e timeout:"},{"line_number":103,"context_line":"            request.session.pop(\u0027last_activity\u0027)"},{"line_number":104,"context_line":"            response \u003d HttpResponseRedirect("},{"line_number":105,"context_line":"                \u0027%s?next\u003d%s\u0027 % (settings.LOGOUT_URL, request.path))"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAT3%2F%2FwEk%3D","line":102,"updated":"2014-01-02 11:47:57.000000000","message":"A new rule just landed in Hacking against such use of backslashes, and I suppose it will eventually be enabled. Maybe it would be nice to avoid it in new code, so that we have less fixing later.","commit_id":"f5662bbc9e5ad1aa27761deb452d460c2dfd361e"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"6cc2e17b2273a13e96f01ec1fbcea54077289a3c","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                    )"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        if isinstance(last_activity, int) and \\"},{"line_number":102,"context_line":"                (timestamp - last_activity) \u003e timeout:"},{"line_number":103,"context_line":"            request.session.pop(\u0027last_activity\u0027)"},{"line_number":104,"context_line":"            response \u003d HttpResponseRedirect("},{"line_number":105,"context_line":"                \u0027%s?next\u003d%s\u0027 % (settings.LOGOUT_URL, request.path))"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAT3%2F%2FvcA%3D","line":102,"in_reply_to":"AAAAT3%2F%2FwEk%3D","updated":"2014-01-02 15:59:45.000000000","message":"ok, I changed that in changeset 6 to fix this potential issue. good catch!","commit_id":"f5662bbc9e5ad1aa27761deb452d460c2dfd361e"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"9e8c69c460c145d7bac453a8e3bd87a4e35aa092","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                    )"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        if isinstance(last_activity, int) and ("},{"line_number":102,"context_line":"                timestamp - last_activity) \u003e timeout:"},{"line_number":103,"context_line":"            request.session.pop(\u0027last_activity\u0027)"},{"line_number":104,"context_line":"            response \u003d HttpResponseRedirect("},{"line_number":105,"context_line":"                \u0027%s?next\u003d%s\u0027 % (settings.LOGOUT_URL, request.path))"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAT3%2F%2FvKQ%3D","line":102,"updated":"2014-01-02 16:52:08.000000000","message":"This code block is a bit hard to read. We should be adding parenthesis instead according to HACKING: \"Long lines should be wrapped in parentheses in preference to using a backslash for line continuation.\"","commit_id":"ca77cff2a720888f998916af0bd91901abf5cd5f"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"10a5070b05acbc22ebdb3d01ebfc36cc7d4db828","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                    )"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        if isinstance(last_activity, int) and ("},{"line_number":102,"context_line":"                timestamp - last_activity) \u003e timeout:"},{"line_number":103,"context_line":"            request.session.pop(\u0027last_activity\u0027)"},{"line_number":104,"context_line":"            response \u003d HttpResponseRedirect("},{"line_number":105,"context_line":"                \u0027%s?next\u003d%s\u0027 % (settings.LOGOUT_URL, request.path))"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAT3%2F%2Fs6A%3D","line":102,"in_reply_to":"AAAAT3%2F%2Fs%2BI%3D","updated":"2014-01-03 07:22:37.000000000","message":"Ah yes. Got that, changed in next patch.","commit_id":"ca77cff2a720888f998916af0bd91901abf5cd5f"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"83e6eb948ff4d0958a4836f99d40aabd0fb8b88b","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                    )"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        if isinstance(last_activity, int) and ("},{"line_number":102,"context_line":"                timestamp - last_activity) \u003e timeout:"},{"line_number":103,"context_line":"            request.session.pop(\u0027last_activity\u0027)"},{"line_number":104,"context_line":"            response \u003d HttpResponseRedirect("},{"line_number":105,"context_line":"                \u0027%s?next\u003d%s\u0027 % (settings.LOGOUT_URL, request.path))"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAT3%2F%2Fs%2BI%3D","line":102,"in_reply_to":"AAAAT3%2F%2FtAg%3D","updated":"2014-01-03 06:51:19.000000000","message":"Ah I meant changing it to:\n\nif (isinstance(last_activity, int)\n    and (timestamp - last_activity) \u003e timeout):\n\nWhich encloses the two lines in parenthesis, while maintaining readability.","commit_id":"ca77cff2a720888f998916af0bd91901abf5cd5f"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"f43ae85f52b78337039d64dcb55dc7966e50f5ea","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                    )"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        if isinstance(last_activity, int) and ("},{"line_number":102,"context_line":"                timestamp - last_activity) \u003e timeout:"},{"line_number":103,"context_line":"            request.session.pop(\u0027last_activity\u0027)"},{"line_number":104,"context_line":"            response \u003d HttpResponseRedirect("},{"line_number":105,"context_line":"                \u0027%s?next\u003d%s\u0027 % (settings.LOGOUT_URL, request.path))"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAT3%2F%2FtAg%3D","line":102,"in_reply_to":"AAAAT3%2F%2FvKQ%3D","updated":"2014-01-03 06:31:55.000000000","message":"I agree here. On the other side, I have Radomirs request not to use \\, following\nhttp://lists.openstack.org/pipermail/openstack-dev/2013-November/019024.html\nand\nhttp://www.python.org/dev/peps/pep-0008/#maximum-line-length","commit_id":"ca77cff2a720888f998916af0bd91901abf5cd5f"}],"horizon/test/tests/middleware.py":[{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"f2834c6ef9a44e38cf59637657fdc878b05e4586","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        except AttributeError:"},{"line_number":45,"context_line":"            timeout \u003d 1800"},{"line_number":46,"context_line":"        request.session[\u0027last_activity\u0027] \u003d\\"},{"line_number":47,"context_line":"            int(time.time()) - (timeout + 10)"},{"line_number":48,"context_line":"        mw \u003d middleware.HorizonMiddleware()"},{"line_number":49,"context_line":"        resp \u003d mw.process_request(request)"},{"line_number":50,"context_line":"        self.assertEqual(resp.status_code, 302)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F9pXA%3D","line":47,"updated":"2013-12-09 10:46:54.000000000","message":"nitpick: it fits on a line...","commit_id":"8d376ad83be0237105d109b9209ff157a64a758f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"aabbd3f2f5c52b86f4ecd62a3e6e91a5f936fbbc","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        except AttributeError:"},{"line_number":45,"context_line":"            timeout \u003d 1800"},{"line_number":46,"context_line":"        request.session[\u0027last_activity\u0027] \u003d\\"},{"line_number":47,"context_line":"            int(time.time()) - (timeout + 10)"},{"line_number":48,"context_line":"        mw \u003d middleware.HorizonMiddleware()"},{"line_number":49,"context_line":"        resp \u003d mw.process_request(request)"},{"line_number":50,"context_line":"        self.assertEqual(resp.status_code, 302)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F8t8Q%3D","line":47,"in_reply_to":"AAAATn%2F8t9M%3D","updated":"2013-12-21 10:43:22.000000000","message":"I hope this will be fixed when rebasing.","commit_id":"8d376ad83be0237105d109b9209ff157a64a758f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"49f75b899a506a146436da04750b23dd4ae18f42","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        except AttributeError:"},{"line_number":45,"context_line":"            timeout \u003d 1800"},{"line_number":46,"context_line":"        request.session[\u0027last_activity\u0027] \u003d\\"},{"line_number":47,"context_line":"            int(time.time()) - (timeout + 10)"},{"line_number":48,"context_line":"        mw \u003d middleware.HorizonMiddleware()"},{"line_number":49,"context_line":"        resp \u003d mw.process_request(request)"},{"line_number":50,"context_line":"        self.assertEqual(resp.status_code, 302)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F8t9M%3D","line":47,"in_reply_to":"AAAATn%2F8vz0%3D","updated":"2013-12-21 10:30:07.000000000","message":"Hmm... difficult choice. We don\u0027t have an explicit policy on it. I am okay to approve. Personally I would like to move forward Django 1.6 support rather than waiting for the next patch.","commit_id":"8d376ad83be0237105d109b9209ff157a64a758f"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"0d590f9054b8503506d502b09ec2b998e95f9687","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        except AttributeError:"},{"line_number":45,"context_line":"            timeout \u003d 1800"},{"line_number":46,"context_line":"        request.session[\u0027last_activity\u0027] \u003d\\"},{"line_number":47,"context_line":"            int(time.time()) - (timeout + 10)"},{"line_number":48,"context_line":"        mw \u003d middleware.HorizonMiddleware()"},{"line_number":49,"context_line":"        resp \u003d mw.process_request(request)"},{"line_number":50,"context_line":"        self.assertEqual(resp.status_code, 302)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F8vz0%3D","line":47,"in_reply_to":"AAAATn%2F9pRc%3D","updated":"2013-12-20 18:24:10.000000000","message":"I\u0027m not sure if we should wait for the next patch set for this small fix, so \"+1\" from me instead of \"+2\".","commit_id":"8d376ad83be0237105d109b9209ff157a64a758f"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"8751b1b1dd9a60d853af7bfec6befa7aa844447b","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        except AttributeError:"},{"line_number":45,"context_line":"            timeout \u003d 1800"},{"line_number":46,"context_line":"        request.session[\u0027last_activity\u0027] \u003d\\"},{"line_number":47,"context_line":"            int(time.time()) - (timeout + 10)"},{"line_number":48,"context_line":"        mw \u003d middleware.HorizonMiddleware()"},{"line_number":49,"context_line":"        resp \u003d mw.process_request(request)"},{"line_number":50,"context_line":"        self.assertEqual(resp.status_code, 302)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F9pRc%3D","line":47,"in_reply_to":"AAAATn%2F9pXA%3D","updated":"2013-12-09 11:33:02.000000000","message":"you\u0027re right. of course!","commit_id":"8d376ad83be0237105d109b9209ff157a64a758f"}]}
