)]}'
{"openstack_dashboard/dashboards/project/loadbalancers/workflows.py":[{"author":{"_account_id":6966,"name":"Jeffrey J. Walls","email":"jeff.walls@hpe.com","username":"ftcjeff"},"change_message_id":"69e623e76a89614e35454ffbff7546caba8457ff","unresolved":false,"context_lines":[{"line_number":541,"context_line":"        return name % params"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":""},{"line_number":544,"context_line":"class AddPMAssociationAction(workflows.Action, MonitorMixin):"},{"line_number":545,"context_line":"    monitor_id \u003d forms.ChoiceField(label\u003d_(\"Monitor\"))"},{"line_number":546,"context_line":""},{"line_number":547,"context_line":"    def __init__(self, request, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2F28Y%3D","line":544,"updated":"2014-01-07 15:44:24.000000000","message":"I\u0027m not sure why you chose multiple inheritance rather than just creating a utility method?","commit_id":"440fde20333fcdb65b15725b7589b5808589346b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"27348109e69da625cc9c750898a7b8560c39c364","unresolved":false,"context_lines":[{"line_number":541,"context_line":"        return name % params"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":""},{"line_number":544,"context_line":"class AddPMAssociationAction(workflows.Action, MonitorMixin):"},{"line_number":545,"context_line":"    monitor_id \u003d forms.ChoiceField(label\u003d_(\"Monitor\"))"},{"line_number":546,"context_line":""},{"line_number":547,"context_line":"    def __init__(self, request, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FzB4%3D","line":544,"in_reply_to":"AAAAUH%2F%2F28Y%3D","updated":"2014-01-08 10:37:39.000000000","message":"It is a review for stable backport branch and I don\u0027t think it is a blocking issue (the reason of -1) of stable backport. IMO this is a kind of coding style and such things is better to be discussed in reviews in master branch.\n\nRegarding your  comment, I don\u0027t know the exact reason of the choice as I am not the original author of the patch. I don\u0027t have a strong opinion on mixin vs utility method. While a utility method is global in a module, mixin method is local to child classes.","commit_id":"440fde20333fcdb65b15725b7589b5808589346b"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"498b590eaf53211443c5b657c80ac585350ef997","unresolved":false,"context_lines":[{"line_number":541,"context_line":"        return name % params"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":""},{"line_number":544,"context_line":"class AddPMAssociationAction(workflows.Action, MonitorMixin):"},{"line_number":545,"context_line":"    monitor_id \u003d forms.ChoiceField(label\u003d_(\"Monitor\"))"},{"line_number":546,"context_line":""},{"line_number":547,"context_line":"    def __init__(self, request, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Fy9w%3D","line":544,"in_reply_to":"AAAAUH%2F%2FzB4%3D","updated":"2014-01-08 10:57:06.000000000","message":"Agree that this conversation doesn\u0027t belong here, so the -1 makes no sense here.\n\nBtw. I guess a utility method would make sense here, cause the method is not accessing self at all.","commit_id":"440fde20333fcdb65b15725b7589b5808589346b"}]}