)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"695a63370383041843dbc711ca27bb631de0d7bf","unresolved":false,"context_lines":[{"line_number":11,"context_line":"section due to the fact that it uses a different edit API which"},{"line_number":12,"context_line":"is not meant to be used for the user-side of things."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch adds a policy change in order to hide the change password"},{"line_number":15,"context_line":"link for normal users, while keeping the functionality inside"},{"line_number":16,"context_line":"the Settings panel still intact."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This change was first broken by I76eb9f95c7112bcbad75ee151f363f892298d081"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_1c7f4e15","line":16,"range":{"start_line":14,"start_character":0,"end_line":16,"end_character":32},"updated":"2018-08-27 20:53:12.000000000","message":"Just to note, keystone still supports end-users changing their password, but we don\u0027t protect the operation using a policy. Instead we use logic about the provided passwords.\n\nThis surfaced in bug 1641645 because deployments relying on the ability to lock user password updates in v2.0 didn\u0027t have a similar path in v3. We do expose the same functionality, but the administrator can select which users to lock password changes by setting an explicit option on the user entity.","commit_id":"734211eb11e6ee7b14cc66a6ef6c7d10d51a714b"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"516763f8f43f29223b9b1b0a91f15063872f7198","unresolved":false,"context_lines":[{"line_number":11,"context_line":"section due to the fact that it uses a different edit API which"},{"line_number":12,"context_line":"is not meant to be used for the user-side of things."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch adds a policy change in order to hide the change password"},{"line_number":15,"context_line":"link for normal users, while keeping the functionality inside"},{"line_number":16,"context_line":"the Settings panel still intact."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This change was first broken by I76eb9f95c7112bcbad75ee151f363f892298d081"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_03919f46","line":16,"range":{"start_line":14,"start_character":0,"end_line":16,"end_character":32},"in_reply_to":"3f79a3b5_1c7f4e15","updated":"2018-09-03 17:58:27.000000000","message":"Good catch, Lance!","commit_id":"734211eb11e6ee7b14cc66a6ef6c7d10d51a714b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8a677b7e58bb86ec7bd46528aeee516b617b68c8","unresolved":false,"context_lines":[{"line_number":15,"context_line":"link for normal users, while keeping the functionality inside"},{"line_number":16,"context_line":"the Settings panel still intact."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This change was first broken by I76eb9f95c7112bcbad75ee151f363f892298d081"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I7a64257ac274c9dac5705ba72a85833f8e7a1591"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_5924381a","line":18,"updated":"2018-11-23 23:47:05.000000000","message":"question: ChangePasswordLink class referred to identity:change_password policy and it was \"rule:admin_or_owner\". \"owner\" means a log-in user, so I cannot understand this changed the behavior.","commit_id":"595b39d4902f9bd649ea4fa5f74815e3dda24f1d"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"1fd23ca3b589e199c5d051ad5ed8ffaebea33863","unresolved":false,"context_lines":[{"line_number":15,"context_line":"link for normal users, while keeping the functionality inside"},{"line_number":16,"context_line":"the Settings panel still intact."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This change was first broken by I76eb9f95c7112bcbad75ee151f363f892298d081"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I7a64257ac274c9dac5705ba72a85833f8e7a1591"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_5a7f47bb","line":18,"in_reply_to":"3f79a3b5_5924381a","updated":"2018-11-24 11:18:38.000000000","message":"The behavior was changed because the policy rules was removed completely, the identity:change_password should have been updated to identity:update_user. This is mostly a UX issue since Keystone will reject the request, but the button should only be shown for admins as specified by the \"rule:admin_and_matching_target_user_domain_id\" rule in keystone policy so we need to feed the user and domain id to that policy.","commit_id":"595b39d4902f9bd649ea4fa5f74815e3dda24f1d"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"12e6ad88acfe70cd9f4439d391a898a2e5957c59","unresolved":false,"context_lines":[{"line_number":15,"context_line":"link for normal users, while keeping the functionality inside"},{"line_number":16,"context_line":"the Settings panel still intact."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This change was first broken by I76eb9f95c7112bcbad75ee151f363f892298d081"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I7a64257ac274c9dac5705ba72a85833f8e7a1591"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_7da0fda3","line":18,"in_reply_to":"3f79a3b5_5a7f47bb","updated":"2018-11-24 14:12:45.000000000","message":"I wonder the feature was broken even if I made a change you mentioned. identity:change_password policy was checked for UpdatePassword, but the corresponding policy was \"rule:admin_or_owner\". \"owner\" means a user themselve. Thus I think \"Update Password\" was shown and it was broken.\nI just would like to understand what happened, but...\n\nAnyway the commit itself works fine and there is no reason to block this by discussion.","commit_id":"595b39d4902f9bd649ea4fa5f74815e3dda24f1d"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8a677b7e58bb86ec7bd46528aeee516b617b68c8","unresolved":false,"context_lines":[{"line_number":16,"context_line":"the Settings panel still intact."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This change was first broken by I76eb9f95c7112bcbad75ee151f363f892298d081"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I7a64257ac274c9dac5705ba72a85833f8e7a1591"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_192a40e4","line":19,"updated":"2018-11-23 23:47:05.000000000","message":"It is nice to add \"Partial-Bug: 1788384\".","commit_id":"595b39d4902f9bd649ea4fa5f74815e3dda24f1d"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"1fd23ca3b589e199c5d051ad5ed8ffaebea33863","unresolved":false,"context_lines":[{"line_number":16,"context_line":"the Settings panel still intact."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This change was first broken by I76eb9f95c7112bcbad75ee151f363f892298d081"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I7a64257ac274c9dac5705ba72a85833f8e7a1591"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_da9357fe","line":19,"in_reply_to":"3f79a3b5_192a40e4","updated":"2018-11-24 11:18:38.000000000","message":"Done","commit_id":"595b39d4902f9bd649ea4fa5f74815e3dda24f1d"}],"openstack_dashboard/dashboards/identity/users/tables.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"516763f8f43f29223b9b1b0a91f15063872f7198","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    url \u003d \"horizon:identity:users:change_password\""},{"line_number":61,"context_line":"    classes \u003d (\"ajax-modal\",)"},{"line_number":62,"context_line":"    icon \u003d \"key\""},{"line_number":63,"context_line":"    policy_rules \u003d ((\"identity\", \"identity:update_user\"),)"},{"line_number":64,"context_line":"    policy_target_attrs \u003d ((\"user_id\", \"id\"),"},{"line_number":65,"context_line":"                           (\"target.user.domain_id\", \"domain_id\"))"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_63a17395","line":63,"updated":"2018-09-03 17:58:27.000000000","message":"It\u0027s a user-facing fix, so release notes are required. Please, add it too","commit_id":"734211eb11e6ee7b14cc66a6ef6c7d10d51a714b"}]}