)]}'
{"openstack_dashboard/dashboards/project/images_and_snapshots/images/tables.py":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"e1b4760a5a4a8cb2ecfb415211c445d6ed98ad10","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        return \"?\".join([base_url, params])"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def allowed(self, request, image\u003dNone):"},{"line_number":52,"context_line":"        if image and not image.container_format in NOT_LAUNCHABLE_FORMATS:"},{"line_number":53,"context_line":"            return image.status in (\"active\",)"},{"line_number":54,"context_line":"        return False"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9jZU%3D","line":52,"updated":"2013-12-10 10:25:35.000000000","message":"Please use  \"\u003citem\u003e not in \u003clist\u003e\" instead of \"not \u003citem\u003e in \u003clist\u003e\" for readability. It is easier to read positive checks.","commit_id":"ad82797789c3061b2a10f82517c76936a04ba275"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"e1b4760a5a4a8cb2ecfb415211c445d6ed98ad10","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        return \"?\".join([base_url, params])"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def allowed(self, request, image\u003dNone):"},{"line_number":108,"context_line":"        if image and not image.container_format in NOT_LAUNCHABLE_FORMATS:"},{"line_number":109,"context_line":"            return image.status \u003d\u003d \"active\""},{"line_number":110,"context_line":"        return False"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9jZQ%3D","line":108,"updated":"2013-12-10 10:25:35.000000000","message":"same here","commit_id":"ad82797789c3061b2a10f82517c76936a04ba275"}],"openstack_dashboard/dashboards/project/images_and_snapshots/views.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0902919e04ede0905a17d45f229fad8dfca60056","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            images_tables.ImagesTable._meta.pagination_param, None)"},{"line_number":55,"context_line":"        try:"},{"line_number":56,"context_line":"            (images,"},{"line_number":57,"context_line":"             self._more_images) \u003d api.glance.image_list_detailed(self.request,"},{"line_number":58,"context_line":"                                                                 marker\u003dmarker)"},{"line_number":59,"context_line":"        except Exception:"},{"line_number":60,"context_line":"            images \u003d []"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F8tz8%3D","line":57,"updated":"2013-12-21 13:06:41.000000000","message":"Is self._more_images still required? Otherwise, it should be a class attribute? It is not directly related to this patch but I believe it is worth fixed in this patch.","commit_id":"d6068065cb3d02af37ad662dfc587557273fbaf6"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"3a9244345e45dd7cf836a53e415488f14d4687be","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            images_tables.ImagesTable._meta.pagination_param, None)"},{"line_number":55,"context_line":"        try:"},{"line_number":56,"context_line":"            (images,"},{"line_number":57,"context_line":"             self._more_images) \u003d api.glance.image_list_detailed(self.request,"},{"line_number":58,"context_line":"                                                                 marker\u003dmarker)"},{"line_number":59,"context_line":"        except Exception:"},{"line_number":60,"context_line":"            images \u003d []"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAT3%2F%2FwEU%3D","line":57,"in_reply_to":"AAAATn%2F8tz8%3D","updated":"2014-01-02 11:48:35.000000000","message":"Hmm, I would see it as a different patch, as it is truly not related to this patch.","commit_id":"d6068065cb3d02af37ad662dfc587557273fbaf6"},{"author":{"_account_id":6704,"name":"chenhaiq","email":"chenhaiq@cn.ibm.com","username":"chenhaiq"},"change_message_id":"ab98a6f49f894d450f9abbe73831f72d512f3abc","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            images_tables.ImagesTable._meta.pagination_param, None)"},{"line_number":55,"context_line":"        try:"},{"line_number":56,"context_line":"            (images,"},{"line_number":57,"context_line":"             self._more_images) \u003d api.glance.image_list_detailed(self.request,"},{"line_number":58,"context_line":"                                                                 marker\u003dmarker)"},{"line_number":59,"context_line":"        except Exception:"},{"line_number":60,"context_line":"            images \u003d []"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2FUzU%3D","line":57,"in_reply_to":"AAAATn%2F8tz8%3D","updated":"2014-01-15 01:28:35.000000000","message":"It is not related to this patch","commit_id":"d6068065cb3d02af37ad662dfc587557273fbaf6"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"c8b2928ef8e6ceb063bca20536ffd60deb1adb86","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            images_tables.ImagesTable._meta.pagination_param, None)"},{"line_number":55,"context_line":"        try:"},{"line_number":56,"context_line":"            (images,"},{"line_number":57,"context_line":"             self._more_images) \u003d api.glance.image_list_detailed(self.request,"},{"line_number":58,"context_line":"                                                                 marker\u003dmarker)"},{"line_number":59,"context_line":"        except Exception:"},{"line_number":60,"context_line":"            images \u003d []"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2FRKM%3D","line":57,"in_reply_to":"AAAAUH%2F%2FUzU%3D","updated":"2014-01-15 17:03:40.000000000","message":"pagination seems to be muddled here, but I think that\u0027s a separate bug.","commit_id":"d6068065cb3d02af37ad662dfc587557273fbaf6"}]}