)]}'
{"doc/source/topics/settings.rst":[{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"87c72cec53f54a8fc4a4aac7830cc67709c76536","unresolved":false,"context_lines":[{"line_number":313,"context_line":"---------------------------"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"Default: ``{ \u0027flavor_keys\u0027: [(\u0027quota:read_bytes_sec\u0027, _(\u0027Read quota\u0027)),"},{"line_number":316,"context_line":"(\u0027quota:write_bytes_sec\u0027, _(\u0027Write quota\u0027)), (\u0027quota:cpu_quota\u0027, _(\u0027Cpu quota\u0027)),"},{"line_number":317,"context_line":"(\u0027quota:cpu_period\u0027, _(\u0027Cpu period\u0027)), (\u0027quota:inboud_average\u0027, _(\u0027Inboud average\u0027)),"},{"line_number":318,"context_line":"(\u0027quota:outboud_average\u0027, _(\u0027Outboud average\u0027))] }``"},{"line_number":319,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"AAAATn%2F9DaU%3D","line":316,"updated":"2013-12-17 09:07:38.000000000","message":"CPU instead of Cpu","commit_id":"32aa8be88d0037dd913fd73a86029737a7900c7e"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"87c72cec53f54a8fc4a4aac7830cc67709c76536","unresolved":false,"context_lines":[{"line_number":314,"context_line":""},{"line_number":315,"context_line":"Default: ``{ \u0027flavor_keys\u0027: [(\u0027quota:read_bytes_sec\u0027, _(\u0027Read quota\u0027)),"},{"line_number":316,"context_line":"(\u0027quota:write_bytes_sec\u0027, _(\u0027Write quota\u0027)), (\u0027quota:cpu_quota\u0027, _(\u0027Cpu quota\u0027)),"},{"line_number":317,"context_line":"(\u0027quota:cpu_period\u0027, _(\u0027Cpu period\u0027)), (\u0027quota:inboud_average\u0027, _(\u0027Inboud average\u0027)),"},{"line_number":318,"context_line":"(\u0027quota:outboud_average\u0027, _(\u0027Outboud average\u0027))] }``"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"Used to customize flavor extra specs keys"}],"source_content_type":"text/x-rst","patch_set":5,"id":"AAAATn%2F9DaQ%3D","line":317,"updated":"2013-12-17 09:07:38.000000000","message":"same","commit_id":"32aa8be88d0037dd913fd73a86029737a7900c7e"},{"author":{"_account_id":5280,"name":"Nicolas Simonds","email":"nic@metacloud.com","username":"nicolas.simonds"},"change_message_id":"7568d526cb2db0edbd269bb64f51b055a1fcc083","unresolved":false,"context_lines":[{"line_number":314,"context_line":""},{"line_number":315,"context_line":"Default: ``{ \u0027flavor_keys\u0027: [(\u0027quota:read_bytes_sec\u0027, _(\u0027Read quota\u0027)),"},{"line_number":316,"context_line":"(\u0027quota:write_bytes_sec\u0027, _(\u0027Write quota\u0027)), (\u0027quota:cpu_quota\u0027, _(\u0027CPU quota\u0027)),"},{"line_number":317,"context_line":"(\u0027quota:cpu_period\u0027, _(\u0027CPU period\u0027)), (\u0027quota:inboud_average\u0027, _(\u0027Inboud average\u0027)),"},{"line_number":318,"context_line":"(\u0027quota:outboud_average\u0027, _(\u0027Outboud average\u0027))] }``"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"Used to customize flavor extra specs keys"}],"source_content_type":"text/x-rst","patch_set":6,"id":"AAAATn%2F86cw%3D","line":317,"updated":"2013-12-18 21:23:57.000000000","message":"\"inbound\", not \"inboud\"","commit_id":"0f28cdcc90b279474976ec3fa83b4777f74a93e9"},{"author":{"_account_id":5280,"name":"Nicolas Simonds","email":"nic@metacloud.com","username":"nicolas.simonds"},"change_message_id":"7568d526cb2db0edbd269bb64f51b055a1fcc083","unresolved":false,"context_lines":[{"line_number":315,"context_line":"Default: ``{ \u0027flavor_keys\u0027: [(\u0027quota:read_bytes_sec\u0027, _(\u0027Read quota\u0027)),"},{"line_number":316,"context_line":"(\u0027quota:write_bytes_sec\u0027, _(\u0027Write quota\u0027)), (\u0027quota:cpu_quota\u0027, _(\u0027CPU quota\u0027)),"},{"line_number":317,"context_line":"(\u0027quota:cpu_period\u0027, _(\u0027CPU period\u0027)), (\u0027quota:inboud_average\u0027, _(\u0027Inboud average\u0027)),"},{"line_number":318,"context_line":"(\u0027quota:outboud_average\u0027, _(\u0027Outboud average\u0027))] }``"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"Used to customize flavor extra specs keys"},{"line_number":321,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"AAAATn%2F86cs%3D","line":318,"updated":"2013-12-18 21:23:57.000000000","message":"\"outbound\", not \"outboud\"","commit_id":"0f28cdcc90b279474976ec3fa83b4777f74a93e9"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"129503ddc6b6818e8495f54b11b6c6d64a83b520","unresolved":false,"context_lines":[{"line_number":312,"context_line":"``FLAVOR_EXTRA_KEYS``"},{"line_number":313,"context_line":"---------------------------"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"Default:: "},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"    {"},{"line_number":318,"context_line":"        \u0027flavor_keys\u0027: ["}],"source_content_type":"text/x-rst","patch_set":7,"id":"AAAATn%2F846g%3D","line":315,"updated":"2013-12-19 05:50:09.000000000","message":"Please remove a trailing space.","commit_id":"70e61e34e56a9f1bfae6a5c9a7d6d1425e0c9574"}],"openstack_dashboard/dashboards/admin/flavors/extras/forms.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"31c2c1d7189203169752625ae04dfd43b7c0434a","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class CreateExtraSpec(forms.SelfHandlingForm):"},{"line_number":32,"context_line":"    key \u003d forms.ChoiceField(label\u003d_(\"Key\"),"},{"line_number":33,"context_line":"                             widget\u003dforms.Select(attrs\u003d{"},{"line_number":34,"context_line":"                                 \u0027class\u0027: \u0027switchable\u0027,"},{"line_number":35,"context_line":"                                 \u0027data-slug\u0027: \u0027name\u0027}))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9v5o%3D","line":32,"updated":"2013-12-06 12:43:55.000000000","message":"This change prevents admin to create extra specs without changing Dashboard configuration. IMO we should still allow admin to create extra spec with a free word. What do you think?","commit_id":"8829fc3e84048f56692490ce6556d6bf3ebfd72f"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"19faf2dd9410a5f8e8f3c2b2c501b0e7505c8111","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class CreateExtraSpec(forms.SelfHandlingForm):"},{"line_number":32,"context_line":"    key \u003d forms.ChoiceField(label\u003d_(\"Key\"),"},{"line_number":33,"context_line":"                             widget\u003dforms.Select(attrs\u003d{"},{"line_number":34,"context_line":"                                 \u0027class\u0027: \u0027switchable\u0027,"},{"line_number":35,"context_line":"                                 \u0027data-slug\u0027: \u0027name\u0027}))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F80Fw%3D","line":32,"in_reply_to":"AAAATn%2F81lU%3D","updated":"2013-12-20 01:59:53.000000000","message":"I would like to get more people\u0027s opinion/feedback about this...","commit_id":"8829fc3e84048f56692490ce6556d6bf3ebfd72f"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"0beb9ea8c2c99d2f9a93ea51d934d44762b369d6","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class CreateExtraSpec(forms.SelfHandlingForm):"},{"line_number":32,"context_line":"    key \u003d forms.ChoiceField(label\u003d_(\"Key\"),"},{"line_number":33,"context_line":"                             widget\u003dforms.Select(attrs\u003d{"},{"line_number":34,"context_line":"                                 \u0027class\u0027: \u0027switchable\u0027,"},{"line_number":35,"context_line":"                                 \u0027data-slug\u0027: \u0027name\u0027}))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F84Lk%3D","line":32,"in_reply_to":"AAAATn%2F846s%3D","updated":"2013-12-19 09:03:29.000000000","message":"Akihiro: Thanks for the suggestion, Agree, alghough editing host aggregate in Horizon is not supported at the moment, flavor extra spec form should have no assumptions here. I\u0027ll add a custom option to allow admin to create extra spec with a free word.","commit_id":"8829fc3e84048f56692490ce6556d6bf3ebfd72f"},{"author":{"_account_id":5280,"name":"Nicolas Simonds","email":"nic@metacloud.com","username":"nicolas.simonds"},"change_message_id":"40e2a1fb458acfeac6cda12bdaf30ab2ca6b8b72","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class CreateExtraSpec(forms.SelfHandlingForm):"},{"line_number":32,"context_line":"    key \u003d forms.ChoiceField(label\u003d_(\"Key\"),"},{"line_number":33,"context_line":"                             widget\u003dforms.Select(attrs\u003d{"},{"line_number":34,"context_line":"                                 \u0027class\u0027: \u0027switchable\u0027,"},{"line_number":35,"context_line":"                                 \u0027data-slug\u0027: \u0027name\u0027}))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F81lU%3D","line":32,"in_reply_to":"AAAATn%2F846s%3D","updated":"2013-12-19 17:56:18.000000000","message":"I\u0027ve flipped my previous stance on this issue: I think having admins configure the dashboard to display the supported extra_specs is a very handy feature.  It deftly avoids the problem of typos in the key names, and human-readable strings make for self-documenting options.\n\nAnd workflows surrounding aggregate operations should likely just add the extra_specs to the flavor directly and sidestep this dialog anyhow, so it seems like an orthogonal concern.  Existing keys can still be edited/deleted regardless of their presence in the select field.","commit_id":"8829fc3e84048f56692490ce6556d6bf3ebfd72f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"aec7dd148945fe86a9e7ee513af0902e696032c5","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class CreateExtraSpec(forms.SelfHandlingForm):"},{"line_number":32,"context_line":"    key \u003d forms.ChoiceField(label\u003d_(\"Key\"),"},{"line_number":33,"context_line":"                             widget\u003dforms.Select(attrs\u003d{"},{"line_number":34,"context_line":"                                 \u0027class\u0027: \u0027switchable\u0027,"},{"line_number":35,"context_line":"                                 \u0027data-slug\u0027: \u0027name\u0027}))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F846s%3D","line":32,"in_reply_to":"AAAATn%2F9uK0%3D","updated":"2013-12-19 05:46:54.000000000","message":"Sorry for the late response.\n\nFor example, extraspec is used to associate flavor with host aggregates. We need to specify host aggregates metadata as flavor extra specs. Admin can define metadata key as he/she wants. I don\u0027t think it is a good idea to define all such fields in local_settings.py whenever admin defines new aggregate.  Although editing host aggregate in Horizon at the moment, it is better flavor extra spec form has no assumptions. These operations should be done by CLI only?\nThis is the background of my last comment.\n\n(Personally I do such operations through CLI, so it is not a problem to me, but....)","commit_id":"8829fc3e84048f56692490ce6556d6bf3ebfd72f"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"9c82b39d32b7c04ecbe40ac66c0f55c8a16e043f","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class CreateExtraSpec(forms.SelfHandlingForm):"},{"line_number":32,"context_line":"    key \u003d forms.ChoiceField(label\u003d_(\"Key\"),"},{"line_number":33,"context_line":"                             widget\u003dforms.Select(attrs\u003d{"},{"line_number":34,"context_line":"                                 \u0027class\u0027: \u0027switchable\u0027,"},{"line_number":35,"context_line":"                                 \u0027data-slug\u0027: \u0027name\u0027}))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9vwU%3D","line":32,"in_reply_to":"AAAATn%2F9v5o%3D","updated":"2013-12-06 13:39:21.000000000","message":"IMO nova only support some flavor keys which we can set in dashboard configration, creating extra spec keys with free words is not useful to the flavor.","commit_id":"8829fc3e84048f56692490ce6556d6bf3ebfd72f"},{"author":{"_account_id":5280,"name":"Nicolas Simonds","email":"nic@metacloud.com","username":"nicolas.simonds"},"change_message_id":"7e00ed584454ae2ae818f2f2ec3c72fba90510a6","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class CreateExtraSpec(forms.SelfHandlingForm):"},{"line_number":32,"context_line":"    key \u003d forms.ChoiceField(label\u003d_(\"Key\"),"},{"line_number":33,"context_line":"                             widget\u003dforms.Select(attrs\u003d{"},{"line_number":34,"context_line":"                                 \u0027class\u0027: \u0027switchable\u0027,"},{"line_number":35,"context_line":"                                 \u0027data-slug\u0027: \u0027name\u0027}))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9uK0%3D","line":32,"in_reply_to":"AAAATn%2F9vwU%3D","updated":"2013-12-06 18:44:29.000000000","message":"Free-form input is prone to typos and other errors, which can make for some interesting failure modes.  \"Canned\" specs sidestep the issue pretty nicely, but introduce another set of knobs and dials for admins to have to fiddle with.\n\nThere\u0027s also the idea that extra specs can be used by software other than nova for various purposes (e.g., attach an extra spec to a flavor that defines the cost per hour for billing) which is probably more common than you\u0027d think; it makes a pretty god argument for leaving in a free-form option.","commit_id":"8829fc3e84048f56692490ce6556d6bf3ebfd72f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"31c2c1d7189203169752625ae04dfd43b7c0434a","unresolved":false,"context_lines":[{"line_number":33,"context_line":"                             widget\u003dforms.Select(attrs\u003d{"},{"line_number":34,"context_line":"                                 \u0027class\u0027: \u0027switchable\u0027,"},{"line_number":35,"context_line":"                                 \u0027data-slug\u0027: \u0027name\u0027}))"},{"line_number":36,"context_line":"    #key \u003d forms.CharField(max_length\u003d\"255\", label\u003d_(\"Key\"))"},{"line_number":37,"context_line":"    value \u003d forms.CharField(max_length\u003d\"255\", label\u003d_(\"Value\"))"},{"line_number":38,"context_line":"    flavor_id \u003d forms.CharField(widget\u003dforms.widgets.HiddenInput)"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9v6Q%3D","line":36,"updated":"2013-12-06 12:43:55.000000000","message":"Looks unnecessary","commit_id":"8829fc3e84048f56692490ce6556d6bf3ebfd72f"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"9c82b39d32b7c04ecbe40ac66c0f55c8a16e043f","unresolved":false,"context_lines":[{"line_number":33,"context_line":"                             widget\u003dforms.Select(attrs\u003d{"},{"line_number":34,"context_line":"                                 \u0027class\u0027: \u0027switchable\u0027,"},{"line_number":35,"context_line":"                                 \u0027data-slug\u0027: \u0027name\u0027}))"},{"line_number":36,"context_line":"    #key \u003d forms.CharField(max_length\u003d\"255\", label\u003d_(\"Key\"))"},{"line_number":37,"context_line":"    value \u003d forms.CharField(max_length\u003d\"255\", label\u003d_(\"Value\"))"},{"line_number":38,"context_line":"    flavor_id \u003d forms.CharField(widget\u003dforms.widgets.HiddenInput)"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9vt8%3D","line":36,"in_reply_to":"AAAATn%2F9v6Q%3D","updated":"2013-12-06 13:39:21.000000000","message":"Yes, I forgot to delete it.","commit_id":"8829fc3e84048f56692490ce6556d6bf3ebfd72f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"129503ddc6b6818e8495f54b11b6c6d64a83b520","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class CreateExtraSpec(forms.SelfHandlingForm):"},{"line_number":32,"context_line":"    key \u003d forms.ChoiceField(label\u003d_(\"Key\"),"},{"line_number":33,"context_line":"                             widget\u003dforms.Select(attrs\u003d{"},{"line_number":34,"context_line":"                                 \u0027class\u0027: \u0027switchable\u0027,"},{"line_number":35,"context_line":"                                 \u0027data-slug\u0027: \u0027name\u0027}))"},{"line_number":36,"context_line":"    value \u003d forms.CharField(max_length\u003d\"255\", label\u003d_(\"Value\"))"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F846M%3D","line":33,"updated":"2013-12-19 05:50:09.000000000","message":"No field is \"switched\" by this field now. It looks unnecessary.","commit_id":"70e61e34e56a9f1bfae6a5c9a7d6d1425e0c9574"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"129503ddc6b6818e8495f54b11b6c6d64a83b520","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    key \u003d forms.ChoiceField(label\u003d_(\"Key\"),"},{"line_number":33,"context_line":"                             widget\u003dforms.Select(attrs\u003d{"},{"line_number":34,"context_line":"                                 \u0027class\u0027: \u0027switchable\u0027,"},{"line_number":35,"context_line":"                                 \u0027data-slug\u0027: \u0027name\u0027}))"},{"line_number":36,"context_line":"    value \u003d forms.CharField(max_length\u003d\"255\", label\u003d_(\"Value\"))"},{"line_number":37,"context_line":"    flavor_id \u003d forms.CharField(widget\u003dforms.widgets.HiddenInput)"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F846Y%3D","line":35,"updated":"2013-12-19 05:50:09.000000000","message":"I still think we need a field for free key input. There is a discussion in patch set 2 and I added a new comment. Please see my comment at patch set 2.","commit_id":"70e61e34e56a9f1bfae6a5c9a7d6d1425e0c9574"},{"author":{"_account_id":5280,"name":"Nicolas Simonds","email":"nic@metacloud.com","username":"nicolas.simonds"},"change_message_id":"62732fcf3e7854f5ffaccd8298a0679360535ca4","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        super(CreateExtraSpec, self).__init__(*args, **kwargs)"},{"line_number":41,"context_line":"        key_settings \u003d getattr(settings, \u0027FLAVOR_EXTRA_KEYS\u0027, {})"},{"line_number":42,"context_line":"        key_list \u003d key_settings.get(\u0027flavor_keys\u0027, [])"},{"line_number":43,"context_line":"        self.fields[\u0027key\u0027].choices \u003d key_list"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def handle(self, request, data):"},{"line_number":46,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F81Xs%3D","line":43,"updated":"2013-12-19 18:55:25.000000000","message":"Making FLAVOR_EXTRA_SETTINGS a collections.OrderedDict object would allow for the same behaviour in fewer steps.","commit_id":"70e61e34e56a9f1bfae6a5c9a7d6d1425e0c9574"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"4af731a1d348725a47e600f746b28252c081f361","unresolved":false,"context_lines":[{"line_number":18,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":19,"context_line":"#    under the License."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from django.conf import settings  # noqa"},{"line_number":22,"context_line":"from django.forms import ValidationError  # noqa"},{"line_number":23,"context_line":"from django.utils.translation import ugettext_lazy as _  # noqa"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUH%2F%2BTW8%3D","line":21,"updated":"2014-01-28 07:43:02.000000000","message":"\"noqa\" is not needed here.","commit_id":"e71c570e09a1f9ea6c6eccc19551d671f13f5116"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"cccb385ce08a66df1617e53a98af098d0e4a29f7","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        keys \u003d cleaned_data.get(\u0027keys\u0027, None)"},{"line_number":64,"context_line":"        key \u003d cleaned_data.get(\u0027key\u0027, None)"},{"line_number":65,"context_line":"        if keys \u003d\u003d \u0027custom\u0027:"},{"line_number":66,"context_line":"            if (key \u003d\u003d \"\") or (key is None):"},{"line_number":67,"context_line":"                msg \u003d _(\u0027The specified key is invalid.\u0027)"},{"line_number":68,"context_line":"                raise ValidationError(msg)"},{"line_number":69,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAVn%2F%2F22E%3D","line":66,"updated":"2014-03-03 19:22:34.000000000","message":"From pep8, using  \"if not key:\" seems preferred.","commit_id":"7fa182d74526fc1d3c892b97eb2295a2c9980b47"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"d96050aaaa9a1577693df3d267c48eefe3542534","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        keys \u003d cleaned_data.get(\u0027keys\u0027, None)"},{"line_number":64,"context_line":"        key \u003d cleaned_data.get(\u0027key\u0027, None)"},{"line_number":65,"context_line":"        if keys \u003d\u003d \u0027custom\u0027:"},{"line_number":66,"context_line":"            if (key \u003d\u003d \"\") or (key is None):"},{"line_number":67,"context_line":"                msg \u003d _(\u0027The specified key is invalid.\u0027)"},{"line_number":68,"context_line":"                raise ValidationError(msg)"},{"line_number":69,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAVn%2F%2FzmU%3D","line":66,"in_reply_to":"AAAAVn%2F%2F22E%3D","updated":"2014-03-04 02:28:30.000000000","message":"I\u0027ll change this to if key \u003d\u003d \"\", we should not contain key is None here as when key name format is invalid the error message should be like L45. thanks for the comment Lin.","commit_id":"7fa182d74526fc1d3c892b97eb2295a2c9980b47"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"cccb385ce08a66df1617e53a98af098d0e4a29f7","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        key \u003d cleaned_data.get(\u0027key\u0027, None)"},{"line_number":65,"context_line":"        if keys \u003d\u003d \u0027custom\u0027:"},{"line_number":66,"context_line":"            if (key \u003d\u003d \"\") or (key is None):"},{"line_number":67,"context_line":"                msg \u003d _(\u0027The specified key is invalid.\u0027)"},{"line_number":68,"context_line":"                raise ValidationError(msg)"},{"line_number":69,"context_line":"        else:"},{"line_number":70,"context_line":"            cleaned_data[\u0027key\u0027] \u003d cleaned_data[\u0027keys\u0027]"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAVn%2F%2F2%2FI%3D","line":67,"updated":"2014-03-03 19:22:34.000000000","message":"The message doesn\u0027t sound right. The key name is required for custom keys, should it be  \"This field is required.\" instead?","commit_id":"7fa182d74526fc1d3c892b97eb2295a2c9980b47"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"d96050aaaa9a1577693df3d267c48eefe3542534","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        key \u003d cleaned_data.get(\u0027key\u0027, None)"},{"line_number":65,"context_line":"        if keys \u003d\u003d \u0027custom\u0027:"},{"line_number":66,"context_line":"            if (key \u003d\u003d \"\") or (key is None):"},{"line_number":67,"context_line":"                msg \u003d _(\u0027The specified key is invalid.\u0027)"},{"line_number":68,"context_line":"                raise ValidationError(msg)"},{"line_number":69,"context_line":"        else:"},{"line_number":70,"context_line":"            cleaned_data[\u0027key\u0027] \u003d cleaned_data[\u0027keys\u0027]"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAVn%2F%2Fzlo%3D","line":67,"in_reply_to":"AAAAVn%2F%2F2%2FI%3D","updated":"2014-03-04 02:28:30.000000000","message":"Sure. will be done in the latest patch.","commit_id":"7fa182d74526fc1d3c892b97eb2295a2c9980b47"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"cccb385ce08a66df1617e53a98af098d0e4a29f7","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        if keys \u003d\u003d \u0027custom\u0027:"},{"line_number":66,"context_line":"            if (key \u003d\u003d \"\") or (key is None):"},{"line_number":67,"context_line":"                msg \u003d _(\u0027The specified key is invalid.\u0027)"},{"line_number":68,"context_line":"                raise ValidationError(msg)"},{"line_number":69,"context_line":"        else:"},{"line_number":70,"context_line":"            cleaned_data[\u0027key\u0027] \u003d cleaned_data[\u0027keys\u0027]"},{"line_number":71,"context_line":"        return cleaned_data"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAVn%2F%2F2%2Fc%3D","line":68,"updated":"2014-03-03 19:22:34.000000000","message":"It would be nicer to display the msg next to the \"key\" field.\n\nYou could use something like:\nmsg \u003d _(... )\nself._errors[\"key\"] \u003d self.error_class([msg])","commit_id":"7fa182d74526fc1d3c892b97eb2295a2c9980b47"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"d96050aaaa9a1577693df3d267c48eefe3542534","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        if keys \u003d\u003d \u0027custom\u0027:"},{"line_number":66,"context_line":"            if (key \u003d\u003d \"\") or (key is None):"},{"line_number":67,"context_line":"                msg \u003d _(\u0027The specified key is invalid.\u0027)"},{"line_number":68,"context_line":"                raise ValidationError(msg)"},{"line_number":69,"context_line":"        else:"},{"line_number":70,"context_line":"            cleaned_data[\u0027key\u0027] \u003d cleaned_data[\u0027keys\u0027]"},{"line_number":71,"context_line":"        return cleaned_data"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAVn%2F%2Fzkc%3D","line":68,"in_reply_to":"AAAAVn%2F%2F2%2Fc%3D","updated":"2014-03-04 02:28:30.000000000","message":"Done","commit_id":"7fa182d74526fc1d3c892b97eb2295a2c9980b47"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"cccb385ce08a66df1617e53a98af098d0e4a29f7","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                msg \u003d _(\u0027The specified key is invalid.\u0027)"},{"line_number":68,"context_line":"                raise ValidationError(msg)"},{"line_number":69,"context_line":"        else:"},{"line_number":70,"context_line":"            cleaned_data[\u0027key\u0027] \u003d cleaned_data[\u0027keys\u0027]"},{"line_number":71,"context_line":"        return cleaned_data"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def handle(self, request, data):"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAVn%2F%2F28E%3D","line":70,"updated":"2014-03-03 19:22:34.000000000","message":"Copying value from \"keys\" to \"key\" doesn\u0027t look like something clean() should be responsible for, it should be just validating data.  Would moving this logic be to handle() method make it more logical?","commit_id":"7fa182d74526fc1d3c892b97eb2295a2c9980b47"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"d96050aaaa9a1577693df3d267c48eefe3542534","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                msg \u003d _(\u0027The specified key is invalid.\u0027)"},{"line_number":68,"context_line":"                raise ValidationError(msg)"},{"line_number":69,"context_line":"        else:"},{"line_number":70,"context_line":"            cleaned_data[\u0027key\u0027] \u003d cleaned_data[\u0027keys\u0027]"},{"line_number":71,"context_line":"        return cleaned_data"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def handle(self, request, data):"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAVn%2F%2FzkY%3D","line":70,"in_reply_to":"AAAAVn%2F%2F28E%3D","updated":"2014-03-04 02:28:30.000000000","message":"Done","commit_id":"7fa182d74526fc1d3c892b97eb2295a2c9980b47"}],"openstack_dashboard/dashboards/admin/flavors/extras/views.py":[{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"1836888be2706f1c922ad45aaf952708b1a7f81f","unresolved":false,"context_lines":[{"line_number":18,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":19,"context_line":"#    under the License."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from django.core.urlresolvers import reverse  # noqa"},{"line_number":22,"context_line":"from django.utils.translation import ugettext_lazy as _  # noqa"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from horizon import exceptions"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUH%2F%2BRx8%3D","line":21,"updated":"2014-01-28 13:29:01.000000000","message":"ditto","commit_id":"e71c570e09a1f9ea6c6eccc19551d671f13f5116"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"1836888be2706f1c922ad45aaf952708b1a7f81f","unresolved":false,"context_lines":[{"line_number":19,"context_line":"#    under the License."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from django.core.urlresolvers import reverse  # noqa"},{"line_number":22,"context_line":"from django.utils.translation import ugettext_lazy as _  # noqa"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from horizon import exceptions"},{"line_number":25,"context_line":"from horizon import forms"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUH%2F%2BRx0%3D","line":22,"updated":"2014-01-28 13:29:01.000000000","message":"ditto","commit_id":"e71c570e09a1f9ea6c6eccc19551d671f13f5116"}],"openstack_dashboard/local/local_settings.py.example":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"31c2c1d7189203169752625ae04dfd43b7c0434a","unresolved":false,"context_lines":[{"line_number":456,"context_line":""},{"line_number":457,"context_line":"FLAVOR_EXTRA_KEYS \u003d {"},{"line_number":458,"context_line":"    \u0027flavor_keys\u0027: ["},{"line_number":459,"context_line":"        (\u0027quota:read_bytes_sec\u0027, _(\u0027Read quota\u0027)),"},{"line_number":460,"context_line":"        (\u0027quota:write_bytes_sec\u0027, _(\u0027Write quota\u0027)),"},{"line_number":461,"context_line":"        (\u0027quota:quota:cpu_quota\u0027, _(\u0027Cpu quota\u0027)),"},{"line_number":462,"context_line":"        (\u0027quota:cpu_period\u0027, _(\u0027Cpu period\u0027)),"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAATn%2F9v68%3D","line":459,"updated":"2013-12-06 12:43:55.000000000","message":"In general, I don\u0027t think it is a good idea to drop \"quota:\" from user visible strings. I think the meaning of quota is important and \"quota\" is used as a meaning of \"the upper limit\". Do you think the meaning does not change after dropping \"quota\"?\n(I don\u0027t check the actual meaning of these keys in flavor.)","commit_id":"8829fc3e84048f56692490ce6556d6bf3ebfd72f"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"9c82b39d32b7c04ecbe40ac66c0f55c8a16e043f","unresolved":false,"context_lines":[{"line_number":456,"context_line":""},{"line_number":457,"context_line":"FLAVOR_EXTRA_KEYS \u003d {"},{"line_number":458,"context_line":"    \u0027flavor_keys\u0027: ["},{"line_number":459,"context_line":"        (\u0027quota:read_bytes_sec\u0027, _(\u0027Read quota\u0027)),"},{"line_number":460,"context_line":"        (\u0027quota:write_bytes_sec\u0027, _(\u0027Write quota\u0027)),"},{"line_number":461,"context_line":"        (\u0027quota:quota:cpu_quota\u0027, _(\u0027Cpu quota\u0027)),"},{"line_number":462,"context_line":"        (\u0027quota:cpu_period\u0027, _(\u0027Cpu period\u0027)),"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAATn%2F9vqA%3D","line":459,"in_reply_to":"AAAATn%2F9v68%3D","updated":"2013-12-06 13:39:21.000000000","message":"IMO we should use human readable string here,  \u0027Read quota\u0027 doesn\u0027t actually drop quota:","commit_id":"8829fc3e84048f56692490ce6556d6bf3ebfd72f"},{"author":{"_account_id":5280,"name":"Nicolas Simonds","email":"nic@metacloud.com","username":"nicolas.simonds"},"change_message_id":"e0e30369c524454e2a37d9e90c54d2d93d888fe4","unresolved":false,"context_lines":[{"line_number":458,"context_line":"    \u0027flavor_keys\u0027: ["},{"line_number":459,"context_line":"        (\u0027quota:read_bytes_sec\u0027, _(\u0027Read quota\u0027)),"},{"line_number":460,"context_line":"        (\u0027quota:write_bytes_sec\u0027, _(\u0027Write quota\u0027)),"},{"line_number":461,"context_line":"        (\u0027quota:quota:cpu_quota\u0027, _(\u0027Cpu quota\u0027)),"},{"line_number":462,"context_line":"        (\u0027quota:cpu_period\u0027, _(\u0027Cpu period\u0027)),"},{"line_number":463,"context_line":"        (\u0027quota:inboud_average\u0027, _(\u0027Inboud average\u0027)),"},{"line_number":464,"context_line":"        (\u0027quota:outboud_average\u0027, _(\u0027Outboud average\u0027)),"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAATn%2F9s5c%3D","line":461,"updated":"2013-12-06 23:44:40.000000000","message":"There\u0027s an extra \"quota\" here.","commit_id":"8829fc3e84048f56692490ce6556d6bf3ebfd72f"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"87c72cec53f54a8fc4a4aac7830cc67709c76536","unresolved":false,"context_lines":[{"line_number":458,"context_line":"    \u0027flavor_keys\u0027: ["},{"line_number":459,"context_line":"        (\u0027quota:read_bytes_sec\u0027, _(\u0027Read quota\u0027)),"},{"line_number":460,"context_line":"        (\u0027quota:write_bytes_sec\u0027, _(\u0027Write quota\u0027)),"},{"line_number":461,"context_line":"        (\u0027quota:cpu_quota\u0027, _(\u0027Cpu quota\u0027)),"},{"line_number":462,"context_line":"        (\u0027quota:cpu_period\u0027, _(\u0027Cpu period\u0027)),"},{"line_number":463,"context_line":"        (\u0027quota:inboud_average\u0027, _(\u0027Inboud average\u0027)),"},{"line_number":464,"context_line":"        (\u0027quota:outboud_average\u0027, _(\u0027Outboud average\u0027)),"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"AAAATn%2F9DZM%3D","line":461,"updated":"2013-12-17 09:07:38.000000000","message":"CPU instead of Cpu","commit_id":"32aa8be88d0037dd913fd73a86029737a7900c7e"},{"author":{"_account_id":5280,"name":"Nicolas Simonds","email":"nic@metacloud.com","username":"nicolas.simonds"},"change_message_id":"7568d526cb2db0edbd269bb64f51b055a1fcc083","unresolved":false,"context_lines":[{"line_number":460,"context_line":"        (\u0027quota:write_bytes_sec\u0027, _(\u0027Write quota\u0027)),"},{"line_number":461,"context_line":"        (\u0027quota:cpu_quota\u0027, _(\u0027CPU quota\u0027)),"},{"line_number":462,"context_line":"        (\u0027quota:cpu_period\u0027, _(\u0027CPU period\u0027)),"},{"line_number":463,"context_line":"        (\u0027quota:inboud_average\u0027, _(\u0027Inboud average\u0027)),"},{"line_number":464,"context_line":"        (\u0027quota:outboud_average\u0027, _(\u0027Outboud average\u0027)),"},{"line_number":465,"context_line":"    ]"},{"line_number":466,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"AAAATn%2F86dM%3D","line":463,"updated":"2013-12-18 21:23:57.000000000","message":"\"inbound\", not \"inboud\"","commit_id":"0f28cdcc90b279474976ec3fa83b4777f74a93e9"},{"author":{"_account_id":5280,"name":"Nicolas Simonds","email":"nic@metacloud.com","username":"nicolas.simonds"},"change_message_id":"7568d526cb2db0edbd269bb64f51b055a1fcc083","unresolved":false,"context_lines":[{"line_number":461,"context_line":"        (\u0027quota:cpu_quota\u0027, _(\u0027CPU quota\u0027)),"},{"line_number":462,"context_line":"        (\u0027quota:cpu_period\u0027, _(\u0027CPU period\u0027)),"},{"line_number":463,"context_line":"        (\u0027quota:inboud_average\u0027, _(\u0027Inboud average\u0027)),"},{"line_number":464,"context_line":"        (\u0027quota:outboud_average\u0027, _(\u0027Outboud average\u0027)),"},{"line_number":465,"context_line":"    ]"},{"line_number":466,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"AAAATn%2F86dE%3D","line":464,"updated":"2013-12-18 21:23:57.000000000","message":"\"outbound\", not \"outboud\"","commit_id":"0f28cdcc90b279474976ec3fa83b4777f74a93e9"},{"author":{"_account_id":5280,"name":"Nicolas Simonds","email":"nic@metacloud.com","username":"nicolas.simonds"},"change_message_id":"62732fcf3e7854f5ffaccd8298a0679360535ca4","unresolved":false,"context_lines":[{"line_number":463,"context_line":"        (\u0027quota:inbound_average\u0027, _(\u0027Quota: Inbound average\u0027)),"},{"line_number":464,"context_line":"        (\u0027quota:outbound_average\u0027, _(\u0027Quota: Outbound average\u0027)),"},{"line_number":465,"context_line":"    ]"},{"line_number":466,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"AAAATn%2F81X8%3D","line":466,"updated":"2013-12-19 18:55:25.000000000","message":"a collections.OrderedDict object would be far more straightforward to work with.","commit_id":"70e61e34e56a9f1bfae6a5c9a7d6d1425e0c9574"}],"openstack_dashboard/test/settings.py":[{"author":{"_account_id":5280,"name":"Nicolas Simonds","email":"nic@metacloud.com","username":"nicolas.simonds"},"change_message_id":"69726ef1b4075a215d715a2c51b80522743ed13d","unresolved":false,"context_lines":[{"line_number":196,"context_line":"    \u0027flavor_keys\u0027: ["},{"line_number":197,"context_line":"        (\u0027quota:read_bytes_sec\u0027, _(\u0027Read quota\u0027)),"},{"line_number":198,"context_line":"        (\u0027quota:write_bytes_sec\u0027, _(\u0027Write quota\u0027)),"},{"line_number":199,"context_line":"        (\u0027quota:quota:cpu_quota\u0027, _(\u0027Cpu quota\u0027)),"},{"line_number":200,"context_line":"        (\u0027quota:cpu_period\u0027, _(\u0027Cpu period\u0027)),"},{"line_number":201,"context_line":"        (\u0027quota:inboud_average\u0027, _(\u0027Inboud average\u0027)),"},{"line_number":202,"context_line":"        (\u0027quota:outboud_average\u0027, _(\u0027Outboud average\u0027)),"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9s5M%3D","line":199,"updated":"2013-12-06 23:46:35.000000000","message":"There\u0027s an extra \"quota\" in there.  The names are supposed to be only 2 fields in width, yes?","commit_id":"8829fc3e84048f56692490ce6556d6bf3ebfd72f"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"87c72cec53f54a8fc4a4aac7830cc67709c76536","unresolved":false,"context_lines":[{"line_number":196,"context_line":"    \u0027flavor_keys\u0027: ["},{"line_number":197,"context_line":"        (\u0027quota:read_bytes_sec\u0027, _(\u0027Read quota\u0027)),"},{"line_number":198,"context_line":"        (\u0027quota:write_bytes_sec\u0027, _(\u0027Write quota\u0027)),"},{"line_number":199,"context_line":"        (\u0027quota:cpu_quota\u0027, _(\u0027Cpu quota\u0027)),"},{"line_number":200,"context_line":"        (\u0027quota:cpu_period\u0027, _(\u0027Cpu period\u0027)),"},{"line_number":201,"context_line":"        (\u0027quota:inboud_average\u0027, _(\u0027Inboud average\u0027)),"},{"line_number":202,"context_line":"        (\u0027quota:outboud_average\u0027, _(\u0027Outboud average\u0027)),"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F9DZY%3D","line":199,"updated":"2013-12-17 09:07:38.000000000","message":"CPU instead of Cpu","commit_id":"32aa8be88d0037dd913fd73a86029737a7900c7e"},{"author":{"_account_id":5280,"name":"Nicolas Simonds","email":"nic@metacloud.com","username":"nicolas.simonds"},"change_message_id":"7568d526cb2db0edbd269bb64f51b055a1fcc083","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        (\u0027quota:write_bytes_sec\u0027, _(\u0027Write quota\u0027)),"},{"line_number":203,"context_line":"        (\u0027quota:cpu_quota\u0027, _(\u0027CPU quota\u0027)),"},{"line_number":204,"context_line":"        (\u0027quota:cpu_period\u0027, _(\u0027CPU period\u0027)),"},{"line_number":205,"context_line":"        (\u0027quota:inboud_average\u0027, _(\u0027Inboud average\u0027)),"},{"line_number":206,"context_line":"        (\u0027quota:outboud_average\u0027, _(\u0027Outboud average\u0027)),"},{"line_number":207,"context_line":"    ]"},{"line_number":208,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F86dY%3D","line":205,"updated":"2013-12-18 21:23:57.000000000","message":"\"inbound\", not \"inboud\"","commit_id":"0f28cdcc90b279474976ec3fa83b4777f74a93e9"},{"author":{"_account_id":5280,"name":"Nicolas Simonds","email":"nic@metacloud.com","username":"nicolas.simonds"},"change_message_id":"7568d526cb2db0edbd269bb64f51b055a1fcc083","unresolved":false,"context_lines":[{"line_number":203,"context_line":"        (\u0027quota:cpu_quota\u0027, _(\u0027CPU quota\u0027)),"},{"line_number":204,"context_line":"        (\u0027quota:cpu_period\u0027, _(\u0027CPU period\u0027)),"},{"line_number":205,"context_line":"        (\u0027quota:inboud_average\u0027, _(\u0027Inboud average\u0027)),"},{"line_number":206,"context_line":"        (\u0027quota:outboud_average\u0027, _(\u0027Outboud average\u0027)),"},{"line_number":207,"context_line":"    ]"},{"line_number":208,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F86dQ%3D","line":206,"updated":"2013-12-18 21:23:57.000000000","message":"\"outbound\", not \"outboud\"","commit_id":"0f28cdcc90b279474976ec3fa83b4777f74a93e9"},{"author":{"_account_id":5280,"name":"Nicolas Simonds","email":"nic@metacloud.com","username":"nicolas.simonds"},"change_message_id":"62732fcf3e7854f5ffaccd8298a0679360535ca4","unresolved":false,"context_lines":[{"line_number":205,"context_line":"        (\u0027quota:inbound_average\u0027, _(\u0027Quota: Inbound average\u0027)),"},{"line_number":206,"context_line":"        (\u0027quota:outbound_average\u0027, _(\u0027Quota: Outbound average\u0027)),"},{"line_number":207,"context_line":"    ]"},{"line_number":208,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F81X4%3D","line":208,"updated":"2013-12-19 18:55:25.000000000","message":"a collections.OrderedDict object would be far more straightforward to work with.","commit_id":"70e61e34e56a9f1bfae6a5c9a7d6d1425e0c9574"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"1836888be2706f1c922ad45aaf952708b1a7f81f","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import os"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from django.utils.translation import ugettext_lazy as _  # noqa"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from horizon.test.settings import *  # noqa"},{"line_number":18,"context_line":"from horizon.utils import secret_key"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUH%2F%2BRxg%3D","line":15,"updated":"2014-01-28 13:29:01.000000000","message":"ditto","commit_id":"e71c570e09a1f9ea6c6eccc19551d671f13f5116"}]}
