)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9225,"name":"Cristian A Sanchez","email":"cabsanchez@gmail.com","username":"casanch1"},"change_message_id":"5d928df0dbb5a6cc9d5fe5ea1a926aadcf9251a7","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding security rules for ingress/egress doesn\u0027t work properly"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The idea of the path is to avoid the combo value overwrite"},{"line_number":10,"context_line":"when there is no \"direction\" value in the settings file."},{"line_number":11,"context_line":"This fixes the problem of always having and \"ingress\""},{"line_number":12,"context_line":"direction, even when set manually by the combo."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F9AjU%3D","line":9,"updated":"2013-12-17 18:57:57.000000000","message":"I guess it should say patch instead of path.","commit_id":"7b76961db7023b26a743da9fd2bf9e84d8dc8d85"}],"openstack_dashboard/dashboards/project/access_and_security/security_groups/forms.py":[{"author":{"_account_id":9450,"name":"Juan Manuel Ollé","email":"juan.m.olle@intel.com","username":"jmolle"},"change_message_id":"e9a445c7b4c41eaae3f877ea8a04331b444ebd29","unresolved":false,"context_lines":[{"line_number":333,"context_line":"            cleaned_data[\u0027ip_protocol\u0027] \u003d self.rules[rule_menu][\u0027ip_protocol\u0027]"},{"line_number":334,"context_line":"            cleaned_data[\u0027from_port\u0027] \u003d int(self.rules[rule_menu][\u0027from_port\u0027])"},{"line_number":335,"context_line":"            cleaned_data[\u0027to_port\u0027] \u003d int(self.rules[rule_menu][\u0027to_port\u0027])"},{"line_number":336,"context_line":"            if self.rules[rule_menu].get(\u0027direction\u0027) is not None:"},{"line_number":337,"context_line":"                cleaned_data[\u0027direction\u0027] \u003d self.rules[rule_menu].get("},{"line_number":338,"context_line":"                    \u0027direction\u0027)"},{"line_number":339,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9VaM%3D","line":336,"updated":"2013-12-12 15:07:42.000000000","message":"Perhaps, it has less overhead to get the object and store in a local variable. and if it is !\u003d None, use it and not look for it again in the dictionary.","commit_id":"01c9f5aabeed02f68b288e82aee3c6bcae9e514e"},{"author":{"_account_id":9275,"name":"Leandro Ignacio Costantino","email":"leandro.i.costantino@intel.com","username":"lcostantino"},"change_message_id":"479956e004f72543bbac5a38f04310d5128f91f7","unresolved":false,"context_lines":[{"line_number":333,"context_line":"            cleaned_data[\u0027ip_protocol\u0027] \u003d self.rules[rule_menu][\u0027ip_protocol\u0027]"},{"line_number":334,"context_line":"            cleaned_data[\u0027from_port\u0027] \u003d int(self.rules[rule_menu][\u0027from_port\u0027])"},{"line_number":335,"context_line":"            cleaned_data[\u0027to_port\u0027] \u003d int(self.rules[rule_menu][\u0027to_port\u0027])"},{"line_number":336,"context_line":"            if self.rules[rule_menu].get(\u0027direction\u0027) is not None:"},{"line_number":337,"context_line":"                cleaned_data[\u0027direction\u0027] \u003d self.rules[rule_menu].get("},{"line_number":338,"context_line":"                    \u0027direction\u0027)"},{"line_number":339,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9TsU%3D","line":336,"in_reply_to":"AAAATn%2F9VaM%3D","updated":"2013-12-12 19:51:56.000000000","message":"Actually, the if is not needed, just.\ncleaned_data[\u0027direction\u0027] \u003d self.rules[rule_menu].get(\u0027direction\u0027)\n\nsince will be checked again below","commit_id":"01c9f5aabeed02f68b288e82aee3c6bcae9e514e"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"2abe37d68da9d47f65b7d2cf062a24ca936597d9","unresolved":false,"context_lines":[{"line_number":334,"context_line":"            cleaned_data[\u0027from_port\u0027] \u003d int(self.rules[rule_menu][\u0027from_port\u0027])"},{"line_number":335,"context_line":"            cleaned_data[\u0027to_port\u0027] \u003d int(self.rules[rule_menu][\u0027to_port\u0027])"},{"line_number":336,"context_line":"            if self.rules[rule_menu].get(\u0027direction\u0027) is not None:"},{"line_number":337,"context_line":"                cleaned_data[\u0027direction\u0027] \u003d self.rules[rule_menu].get("},{"line_number":338,"context_line":"                    \u0027direction\u0027)"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"        # NOTE(amotoki): There are two cases where cleaned_data[\u0027direction\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9KE8%3D","line":337,"updated":"2013-12-16 07:33:16.000000000","message":"agree with leandro, the if is not needed.","commit_id":"01c9f5aabeed02f68b288e82aee3c6bcae9e514e"},{"author":{"_account_id":9275,"name":"Leandro Ignacio Costantino","email":"leandro.i.costantino@intel.com","username":"lcostantino"},"change_message_id":"bdacc59c6793de2664f4dc43212c88be8bfc1989","unresolved":false,"context_lines":[{"line_number":334,"context_line":"            cleaned_data[\u0027from_port\u0027] \u003d int(self.rules[rule_menu][\u0027from_port\u0027])"},{"line_number":335,"context_line":"            cleaned_data[\u0027to_port\u0027] \u003d int(self.rules[rule_menu][\u0027to_port\u0027])"},{"line_number":336,"context_line":"            if self.rules[rule_menu].get(\u0027direction\u0027) is not None:"},{"line_number":337,"context_line":"                cleaned_data[\u0027direction\u0027] \u003d self.rules[rule_menu].get("},{"line_number":338,"context_line":"                    \u0027direction\u0027)"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"        # NOTE(amotoki): There are two cases where cleaned_data[\u0027direction\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9GzE%3D","line":337,"in_reply_to":"AAAATn%2F9G2I%3D","updated":"2013-12-16 18:42:00.000000000","message":"I would like to keep the proposed behavior, but include a comment on that line, so nobody get tempted to remove it because it looks like a \u0027not needed if\u0027.","commit_id":"01c9f5aabeed02f68b288e82aee3c6bcae9e514e"},{"author":{"_account_id":9409,"name":"Facundo Maldonado","email":"facundo.n.maldonado@intel.com","username":"facundo.n.maldonado"},"change_message_id":"5d5986c35f7f5968a050257074a7da38e10daf9f","unresolved":false,"context_lines":[{"line_number":334,"context_line":"            cleaned_data[\u0027from_port\u0027] \u003d int(self.rules[rule_menu][\u0027from_port\u0027])"},{"line_number":335,"context_line":"            cleaned_data[\u0027to_port\u0027] \u003d int(self.rules[rule_menu][\u0027to_port\u0027])"},{"line_number":336,"context_line":"            if self.rules[rule_menu].get(\u0027direction\u0027) is not None:"},{"line_number":337,"context_line":"                cleaned_data[\u0027direction\u0027] \u003d self.rules[rule_menu].get("},{"line_number":338,"context_line":"                    \u0027direction\u0027)"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"        # NOTE(amotoki): There are two cases where cleaned_data[\u0027direction\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9G2I%3D","line":337,"in_reply_to":"AAAATn%2F9KE8%3D","updated":"2013-12-16 18:35:56.000000000","message":"The if is necessary since if not, the value selected by the user is overriden.\nBUT if there is a value in the template, that value will be used. no matter what the user selects, it will be discarded.","commit_id":"01c9f5aabeed02f68b288e82aee3c6bcae9e514e"},{"author":{"_account_id":9412,"name":"Andres Buraschi","email":"andres.buraschi@intel.com","username":"aburaschi"},"change_message_id":"d99e0bdd5511502f597560b859e500ce12189d3e","unresolved":false,"context_lines":[{"line_number":334,"context_line":"            cleaned_data[\u0027from_port\u0027] \u003d int(self.rules[rule_menu][\u0027from_port\u0027])"},{"line_number":335,"context_line":"            cleaned_data[\u0027to_port\u0027] \u003d int(self.rules[rule_menu][\u0027to_port\u0027])"},{"line_number":336,"context_line":"            if self.rules[rule_menu].get(\u0027direction\u0027) is not None:"},{"line_number":337,"context_line":"                cleaned_data[\u0027direction\u0027] \u003d self.rules[rule_menu].get("},{"line_number":338,"context_line":"                    \u0027direction\u0027)"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"        # NOTE(amotoki): There are two cases where cleaned_data[\u0027direction\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9IvY%3D","line":337,"in_reply_to":"AAAATn%2F9KE8%3D","updated":"2013-12-16 13:11:36.000000000","message":"The thing is, if the \"if\" is removed, and the settings field is empty, the combo box value will be overwritten. And this is not the expected behavior... The combo box value should prevail if no setting is found for the selected template.","commit_id":"01c9f5aabeed02f68b288e82aee3c6bcae9e514e"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"12e1d9f0d36dccc563a2476ddc65f5e1ad9ad3c1","unresolved":false,"context_lines":[{"line_number":335,"context_line":"            cleaned_data[\u0027to_port\u0027] \u003d int(self.rules[rule_menu][\u0027to_port\u0027])"},{"line_number":336,"context_line":"            if self.rules[rule_menu].get(\u0027direction\u0027) is not None:"},{"line_number":337,"context_line":"                cleaned_data[\u0027direction\u0027] \u003d self.rules[rule_menu].get("},{"line_number":338,"context_line":"                    \u0027direction\u0027)"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"        # NOTE(amotoki): There are two cases where cleaned_data[\u0027direction\u0027]"},{"line_number":341,"context_line":"        # is empty: (1) Nova Security Group is used. Since \"direction\" is"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9EN4%3D","line":338,"updated":"2013-12-17 05:41:43.000000000","message":"This can probably be simplified to:\ncleaned_data[\u0027direction\u0027] \u003d self.rules[rule_menu].get(\u0027direction\u0027,\n                                                                           cleaned_data[\u0027direction\u0027])","commit_id":"01c9f5aabeed02f68b288e82aee3c6bcae9e514e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c6fb7fd8336a94eac9722e8bd1bc8960daed2718","unresolved":false,"context_lines":[{"line_number":333,"context_line":"            cleaned_data[\u0027ip_protocol\u0027] \u003d self.rules[rule_menu][\u0027ip_protocol\u0027]"},{"line_number":334,"context_line":"            cleaned_data[\u0027from_port\u0027] \u003d int(self.rules[rule_menu][\u0027from_port\u0027])"},{"line_number":335,"context_line":"            cleaned_data[\u0027to_port\u0027] \u003d int(self.rules[rule_menu][\u0027to_port\u0027])"},{"line_number":336,"context_line":"            # not overwrite combo when no \"direction\" value in settings file"},{"line_number":337,"context_line":"            cleaned_data[\u0027direction\u0027] \u003d self.rules[rule_menu].get(\u0027direction\u0027,"},{"line_number":338,"context_line":"                cleaned_data[\u0027direction\u0027])"},{"line_number":339,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F8t%2Fw%3D","line":336,"updated":"2013-12-21 09:56:37.000000000","message":"Could you mention all_tcp/udp/icmp cases here? I believe it helps us to understand the code.\n\n  Honor the original \"direction\" when no \"direction\" value settings file.\n  In all_tcp/udp/icmp templates, \"direction\" is provided\n  from the form input and we shuld not overwrite it.","commit_id":"6953e363bca237f01f6ad85b248f5ab583012d0b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c6fb7fd8336a94eac9722e8bd1bc8960daed2718","unresolved":false,"context_lines":[{"line_number":335,"context_line":"            cleaned_data[\u0027to_port\u0027] \u003d int(self.rules[rule_menu][\u0027to_port\u0027])"},{"line_number":336,"context_line":"            # not overwrite combo when no \"direction\" value in settings file"},{"line_number":337,"context_line":"            cleaned_data[\u0027direction\u0027] \u003d self.rules[rule_menu].get(\u0027direction\u0027,"},{"line_number":338,"context_line":"                cleaned_data[\u0027direction\u0027])"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"        # NOTE(amotoki): There are two cases where cleaned_data[\u0027direction\u0027]"},{"line_number":341,"context_line":"        # is empty: (1) Nova Security Group is used. Since \"direction\" is"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F8t%2Fc%3D","line":338,"updated":"2013-12-21 09:56:37.000000000","message":"In cases of all_tcp/udp/icmp, cleaned_data[\u0027direction\u0027] should be used rather than rule_menu[\u0027direction\u0027]. Should we depend the contents of local_settings.py? Operators can customize local_setting.\n\nIs it better to check rule_menu and ignore \u0027direction\u0027 for all_tcp/udp/icmp?\n\n  if rule_menu in (\u0027all_tcp\u0027, \u0027all_udp\u0027, \u0027all_icmp\u0027):\n      pass\n  else:\n      cleaned_data[\u0027direction\u0027] \u003d self.rules[rule_menu].get(\u0027direction\u0027)","commit_id":"6953e363bca237f01f6ad85b248f5ab583012d0b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c6fb7fd8336a94eac9722e8bd1bc8960daed2718","unresolved":false,"context_lines":[{"line_number":340,"context_line":"        # NOTE(amotoki): There are two cases where cleaned_data[\u0027direction\u0027]"},{"line_number":341,"context_line":"        # is empty: (1) Nova Security Group is used. Since \"direction\" is"},{"line_number":342,"context_line":"        # HiddenInput, direction field exists but its value is \u0027\u0027."},{"line_number":343,"context_line":"        # (2) Template is used. In this case, the default value is None."},{"line_number":344,"context_line":"        # To make sure \u0027direction\u0027 field has \u0027ingress\u0027 or \u0027egress\u0027,"},{"line_number":345,"context_line":"        # fill this field here if it is not specified."},{"line_number":346,"context_line":"        if not cleaned_data[\u0027direction\u0027]:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F8t%2FU%3D","line":343,"updated":"2013-12-21 09:56:37.000000000","message":"The comment should be \"(2) Template except all_* is used ....\". Could you update the comment to keep it more accurate?","commit_id":"6953e363bca237f01f6ad85b248f5ab583012d0b"}]}
