)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"845dc77b1022bcadd2923b7f10e6ec0fda4edf67","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     wangliangyu \u003cwangliangyu@gohighsec.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-10-30 16:14:58 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Return empty list when retrieve by not uuid"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"On identity-projects python page:"},{"line_number":10,"context_line":"  Retrieve project list filtered by id, witch is not uuid format like \u0027%\u0027,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_18c98c22","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":17},"updated":"2018-10-30 08:49:46.000000000","message":"Is this correct? Your change is to raise NotFound error.","commit_id":"b6abbe0cb5decdf7843e74af989bfaf806f89d34"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"845dc77b1022bcadd2923b7f10e6ec0fda4edf67","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     wangliangyu \u003cwangliangyu@gohighsec.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-10-30 16:14:58 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Return empty list when retrieve by not uuid"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"On identity-projects python page:"},{"line_number":10,"context_line":"  Retrieve project list filtered by id, witch is not uuid format like \u0027%\u0027,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_d8d6b4c4","line":7,"range":{"start_line":7,"start_character":23,"end_line":7,"end_character":31},"updated":"2018-10-30 08:49:46.000000000","message":"retrieve -\u003e retrieved","commit_id":"b6abbe0cb5decdf7843e74af989bfaf806f89d34"},{"author":{"_account_id":25946,"name":"Wangliangyu","email":"wangly2097@chinaunicom.cn","username":"wangliangyu"},"change_message_id":"6ce20a0774eea73461d77ef250438324bc30755e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     wangliangyu \u003cwangliangyu@gohighsec.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-10-30 16:14:58 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Return empty list when retrieve by not uuid"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"On identity-projects python page:"},{"line_number":10,"context_line":"  Retrieve project list filtered by id, witch is not uuid format like \u0027%\u0027,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_93401da5","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":17},"in_reply_to":"3f79a3b5_18c98c22","updated":"2018-10-30 09:41:00.000000000","message":"Done","commit_id":"b6abbe0cb5decdf7843e74af989bfaf806f89d34"},{"author":{"_account_id":25946,"name":"Wangliangyu","email":"wangly2097@chinaunicom.cn","username":"wangliangyu"},"change_message_id":"6ce20a0774eea73461d77ef250438324bc30755e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     wangliangyu \u003cwangliangyu@gohighsec.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-10-30 16:14:58 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Return empty list when retrieve by not uuid"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"On identity-projects python page:"},{"line_number":10,"context_line":"  Retrieve project list filtered by id, witch is not uuid format like \u0027%\u0027,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_f335d143","line":7,"range":{"start_line":7,"start_character":23,"end_line":7,"end_character":31},"in_reply_to":"3f79a3b5_d8d6b4c4","updated":"2018-10-30 09:41:00.000000000","message":"Done","commit_id":"b6abbe0cb5decdf7843e74af989bfaf806f89d34"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"845dc77b1022bcadd2923b7f10e6ec0fda4edf67","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Return empty list when retrieve by not uuid"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"On identity-projects python page:"},{"line_number":10,"context_line":"  Retrieve project list filtered by id, witch is not uuid format like \u0027%\u0027,"},{"line_number":11,"context_line":"there will throw an error message on top-right page."},{"line_number":12,"context_line":"And the same for identity-users python page."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_5875c4fe","line":9,"range":{"start_line":9,"start_character":21,"end_line":9,"end_character":32},"updated":"2018-10-30 08:49:46.000000000","message":"\"python\" is not needed. \"page\" is enough.","commit_id":"b6abbe0cb5decdf7843e74af989bfaf806f89d34"},{"author":{"_account_id":25946,"name":"Wangliangyu","email":"wangly2097@chinaunicom.cn","username":"wangliangyu"},"change_message_id":"6ce20a0774eea73461d77ef250438324bc30755e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Return empty list when retrieve by not uuid"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"On identity-projects python page:"},{"line_number":10,"context_line":"  Retrieve project list filtered by id, witch is not uuid format like \u0027%\u0027,"},{"line_number":11,"context_line":"there will throw an error message on top-right page."},{"line_number":12,"context_line":"And the same for identity-users python page."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_531045ab","line":9,"range":{"start_line":9,"start_character":21,"end_line":9,"end_character":32},"in_reply_to":"3f79a3b5_5875c4fe","updated":"2018-10-30 09:41:00.000000000","message":"Done","commit_id":"b6abbe0cb5decdf7843e74af989bfaf806f89d34"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"845dc77b1022bcadd2923b7f10e6ec0fda4edf67","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Return empty list when retrieve by not uuid"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"On identity-projects python page:"},{"line_number":10,"context_line":"  Retrieve project list filtered by id, witch is not uuid format like \u0027%\u0027,"},{"line_number":11,"context_line":"there will throw an error message on top-right page."},{"line_number":12,"context_line":"And the same for identity-users python page."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_f81e10ba","line":10,"range":{"start_line":10,"start_character":38,"end_line":10,"end_character":45},"updated":"2018-10-30 08:49:46.000000000","message":"- A comma is not needed\n- witch -\u003e which","commit_id":"b6abbe0cb5decdf7843e74af989bfaf806f89d34"},{"author":{"_account_id":25946,"name":"Wangliangyu","email":"wangly2097@chinaunicom.cn","username":"wangliangyu"},"change_message_id":"6ce20a0774eea73461d77ef250438324bc30755e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Return empty list when retrieve by not uuid"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"On identity-projects python page:"},{"line_number":10,"context_line":"  Retrieve project list filtered by id, witch is not uuid format like \u0027%\u0027,"},{"line_number":11,"context_line":"there will throw an error message on top-right page."},{"line_number":12,"context_line":"And the same for identity-users python page."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_731301b8","line":10,"range":{"start_line":10,"start_character":38,"end_line":10,"end_character":45},"in_reply_to":"3f79a3b5_f81e10ba","updated":"2018-10-30 09:41:00.000000000","message":"Done","commit_id":"b6abbe0cb5decdf7843e74af989bfaf806f89d34"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"845dc77b1022bcadd2923b7f10e6ec0fda4edf67","unresolved":false,"context_lines":[{"line_number":9,"context_line":"On identity-projects python page:"},{"line_number":10,"context_line":"  Retrieve project list filtered by id, witch is not uuid format like \u0027%\u0027,"},{"line_number":11,"context_line":"there will throw an error message on top-right page."},{"line_number":12,"context_line":"And the same for identity-users python page."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"It is reasonable that return an empty list without error prompt."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_187bccf2","line":12,"range":{"start_line":12,"start_character":32,"end_line":12,"end_character":44},"updated":"2018-10-30 08:49:46.000000000","message":"\"python\" is not needed. \"page\" is enough.","commit_id":"b6abbe0cb5decdf7843e74af989bfaf806f89d34"},{"author":{"_account_id":25946,"name":"Wangliangyu","email":"wangly2097@chinaunicom.cn","username":"wangliangyu"},"change_message_id":"6ce20a0774eea73461d77ef250438324bc30755e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"On identity-projects python page:"},{"line_number":10,"context_line":"  Retrieve project list filtered by id, witch is not uuid format like \u0027%\u0027,"},{"line_number":11,"context_line":"there will throw an error message on top-right page."},{"line_number":12,"context_line":"And the same for identity-users python page."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"It is reasonable that return an empty list without error prompt."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_13064d75","line":12,"range":{"start_line":12,"start_character":32,"end_line":12,"end_character":44},"in_reply_to":"3f79a3b5_187bccf2","updated":"2018-10-30 09:41:00.000000000","message":"Done","commit_id":"b6abbe0cb5decdf7843e74af989bfaf806f89d34"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1ff66aca9921e5c5235967d374104e615f864b1e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Raise NotFound error when retrieved by not uuid"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"On identity-projects page:"},{"line_number":10,"context_line":"  Retrieve project list filtered by id wihch is not uuid format like \u0027%\u0027,"},{"line_number":11,"context_line":"there will throw an error message on top-right page."},{"line_number":12,"context_line":"And the same for identity-users page."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_ae6e0b2b","line":10,"range":{"start_line":10,"start_character":39,"end_line":10,"end_character":44},"updated":"2018-10-30 15:34:24.000000000","message":"still typo, but the author seems not to take care of typo much.","commit_id":"19ffd45bc6ce5d4e6d1d87100c1a9c731eaa0a30"}],"openstack_dashboard/api/keystone.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"845dc77b1022bcadd2923b7f10e6ec0fda4edf67","unresolved":false,"context_lines":[{"line_number":353,"context_line":"        uuid.UUID(project)"},{"line_number":354,"context_line":"        return manager.get(project)"},{"line_number":355,"context_line":"    except (ValueError, AttributeError):"},{"line_number":356,"context_line":"        raise keystone_exceptions.NotFound()"},{"line_number":357,"context_line":"    except keystone_exceptions.NotFound:"},{"line_number":358,"context_line":"        LOG.info(\"Tenant \u0027%s\u0027 not found.\", project)"},{"line_number":359,"context_line":"        raise"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_b842d891","line":356,"updated":"2018-10-30 08:49:46.000000000","message":"Consider using oslo_utis.uuidutils.is_uuid_like().\n\n  if not uuidutils.is_uuid_like(project):\n      raise keystone_exceptions.NotFound()\n\nIn addition, the UUID check should be handled outside of the original try-except clause.","commit_id":"b6abbe0cb5decdf7843e74af989bfaf806f89d34"},{"author":{"_account_id":25946,"name":"Wangliangyu","email":"wangly2097@chinaunicom.cn","username":"wangliangyu"},"change_message_id":"6ce20a0774eea73461d77ef250438324bc30755e","unresolved":false,"context_lines":[{"line_number":353,"context_line":"        uuid.UUID(project)"},{"line_number":354,"context_line":"        return manager.get(project)"},{"line_number":355,"context_line":"    except (ValueError, AttributeError):"},{"line_number":356,"context_line":"        raise keystone_exceptions.NotFound()"},{"line_number":357,"context_line":"    except keystone_exceptions.NotFound:"},{"line_number":358,"context_line":"        LOG.info(\"Tenant \u0027%s\u0027 not found.\", project)"},{"line_number":359,"context_line":"        raise"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_33090982","line":356,"in_reply_to":"3f79a3b5_b842d891","updated":"2018-10-30 09:41:00.000000000","message":"Done","commit_id":"b6abbe0cb5decdf7843e74af989bfaf806f89d34"}]}
