)]}'
{"openstack_auth/middleware.py":[{"author":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"change_message_id":"31a9457b0c567eb0aa8b554d770bb1d08cf2d6a9","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class OpenstackAuthMonkeyPatchMiddleware(object):"},{"line_number":19,"context_line":"    def __init__(self, get_response):"},{"line_number":20,"context_line":"        self.get_response \u003d get_response"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    def __call__(self, request):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_b3e64413","line":19,"updated":"2018-11-01 13:27:04.000000000","message":"This needs to be get_response\u003dNone otherwise I\u0027m getting this error with Django 1.11.9:\n\n  TypeError: __init__() takes exactly 2 arguments (1 given)","commit_id":"d9893d75f8091586e55cfd92ba8f8b889f2ec9ee"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b425b07fefd0e58ea4ff6a885c66cb09166ecb56","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class OpenstackAuthMonkeyPatchMiddleware(object):"},{"line_number":19,"context_line":"    def __init__(self, get_response):"},{"line_number":20,"context_line":"        self.get_response \u003d get_response"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    def __call__(self, request):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_6716754d","line":19,"in_reply_to":"3f79a3b5_b3e64413","updated":"2018-11-05 00:11:12.000000000","message":"This sounds tricky. Django 1.11 document says __init__() accepts get_response as an argument. Django 1.9 or older does not pass get_response argument, but it it not a supported version.\n\nhttps://docs.djangoproject.com/en/1.11/topics/http/middleware/","commit_id":"d9893d75f8091586e55cfd92ba8f8b889f2ec9ee"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"48aca8334a66b6bcd0d746176f73fbac593e3b7d","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from openstack_auth import utils"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"utils.patch_middleware_get_user()"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class OpenstackAuthMonkeyPatchMiddleware(object):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_122ecba9","line":15,"updated":"2018-11-05 19:05:52.000000000","message":"Since we need this only for tests, it should be placed somewhere under \u0027tests\u0027 directory","commit_id":"f8668025b4f977e37dcf6fbc4dc4a6f72297dfbf"},{"author":{"_account_id":10420,"name":"Adrian Turjak","email":"devs+openstack@uncaught-exceptions.com","username":"adriant"},"change_message_id":"0603e9275c67abed7dd800b2f30cc4fbc5be72f2","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from openstack_auth import utils"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"utils.patch_middleware_get_user()"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class OpenstackAuthMonkeyPatchMiddleware(object):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_ca473752","line":15,"in_reply_to":"3f79a3b5_122ecba9","updated":"2018-11-06 00:06:17.000000000","message":"I\u0027m not sure what you mean. This isn\u0027t needed just for tests, this needs to happen all the time. This monkeypatch is required for horizon to work at all.","commit_id":"f8668025b4f977e37dcf6fbc4dc4a6f72297dfbf"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b425b07fefd0e58ea4ff6a885c66cb09166ecb56","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class OpenstackAuthMonkeyPatchMiddleware(object):"},{"line_number":19,"context_line":"    def __init__(self, get_response\u003dNone):"},{"line_number":20,"context_line":"        self.get_response \u003d get_response"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    def __call__(self, request):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_87115153","line":19,"range":{"start_line":19,"start_character":23,"end_line":19,"end_character":40},"updated":"2018-11-05 00:11:12.000000000","message":"Django 1.11 always passes get_response, so \u0027\u003dNone\u0027 is unnecessary.\n\nhttps://docs.djangoproject.com/en/1.11/topics/http/middleware/","commit_id":"f8668025b4f977e37dcf6fbc4dc4a6f72297dfbf"},{"author":{"_account_id":10420,"name":"Adrian Turjak","email":"devs+openstack@uncaught-exceptions.com","username":"adriant"},"change_message_id":"0603e9275c67abed7dd800b2f30cc4fbc5be72f2","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class OpenstackAuthMonkeyPatchMiddleware(object):"},{"line_number":19,"context_line":"    def __init__(self, get_response\u003dNone):"},{"line_number":20,"context_line":"        self.get_response \u003d get_response"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    def __call__(self, request):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_ea4c7376","line":19,"range":{"start_line":19,"start_character":23,"end_line":19,"end_character":40},"in_reply_to":"3f79a3b5_328c27d7","updated":"2018-11-06 00:06:17.000000000","message":"See his comment on the patch itself.","commit_id":"f8668025b4f977e37dcf6fbc4dc4a6f72297dfbf"},{"author":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"change_message_id":"222dbd7057f6957c80cc622f2fb26319c566aaa4","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class OpenstackAuthMonkeyPatchMiddleware(object):"},{"line_number":19,"context_line":"    def __init__(self, get_response\u003dNone):"},{"line_number":20,"context_line":"        self.get_response \u003d get_response"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    def __call__(self, request):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_bc7c90ea","line":19,"range":{"start_line":19,"start_character":23,"end_line":19,"end_character":40},"in_reply_to":"3f79a3b5_5ce8dca5","updated":"2018-11-05 17:18:53.000000000","message":"Here is the traceback I\u0027m getting:\n\n    Traceback (most recent call last):\n      File \"/opt/openstack/horizon/lib/python2.7/site-packages/openstack_dashboard/wsgi/django.wsgi\", line 33, in \u003cmodule\u003e\n        application \u003d get_wsgi_application()\n      File \"/opt/openstack/horizon/lib/python2.7/site-packages/django/core/wsgi.py\", line 14, in get_wsgi_application\n        return WSGIHandler()\n      File \"/opt/openstack/horizon/lib/python2.7/site-packages/django/core/handlers/wsgi.py\", line 151, in __init__\n        self.load_middleware()\n      File \"/opt/openstack/horizon/lib/python2.7/site-packages/django/core/handlers/base.py\", line 58, in load_middleware\n        mw_instance \u003d mw_class()\n    TypeError: __init__() takes exactly 2 arguments (1 given)","commit_id":"f8668025b4f977e37dcf6fbc4dc4a6f72297dfbf"},{"author":{"_account_id":10420,"name":"Adrian Turjak","email":"devs+openstack@uncaught-exceptions.com","username":"adriant"},"change_message_id":"2bf84b8e8b9c95860758f7d2c5f225fe07c0473d","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class OpenstackAuthMonkeyPatchMiddleware(object):"},{"line_number":19,"context_line":"    def __init__(self, get_response\u003dNone):"},{"line_number":20,"context_line":"        self.get_response \u003d get_response"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    def __call__(self, request):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_dde078ce","line":19,"range":{"start_line":19,"start_character":23,"end_line":19,"end_character":40},"in_reply_to":"3f79a3b5_87115153","updated":"2018-11-05 04:50:47.000000000","message":"Mostly added because Mathieu was getting errors:\n\"This needs to be get_response\u003dNone otherwise I\u0027m getting this error with Django 1.11.9:\"\n\nThe None doesn\u0027t do any harm, and we can always potentially remove it later.","commit_id":"f8668025b4f977e37dcf6fbc4dc4a6f72297dfbf"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"48aca8334a66b6bcd0d746176f73fbac593e3b7d","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class OpenstackAuthMonkeyPatchMiddleware(object):"},{"line_number":19,"context_line":"    def __init__(self, get_response\u003dNone):"},{"line_number":20,"context_line":"        self.get_response \u003d get_response"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    def __call__(self, request):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_328c27d7","line":19,"range":{"start_line":19,"start_character":23,"end_line":19,"end_character":40},"in_reply_to":"3f79a3b5_bc7c90ea","updated":"2018-11-05 19:05:52.000000000","message":"Mathieu, could you please check your django version?","commit_id":"f8668025b4f977e37dcf6fbc4dc4a6f72297dfbf"},{"author":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"change_message_id":"d8b126419aab4860fb0d7b85d834273848f4da3b","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class OpenstackAuthMonkeyPatchMiddleware(object):"},{"line_number":19,"context_line":"    def __init__(self, get_response\u003dNone):"},{"line_number":20,"context_line":"        self.get_response \u003d get_response"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    def __call__(self, request):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_5ce8dca5","line":19,"range":{"start_line":19,"start_character":23,"end_line":19,"end_character":40},"in_reply_to":"3f79a3b5_dde078ce","updated":"2018-11-05 17:16:21.000000000","message":"Yes, was getting errors without it with Django 1.11.9.","commit_id":"f8668025b4f977e37dcf6fbc4dc4a6f72297dfbf"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"48aca8334a66b6bcd0d746176f73fbac593e3b7d","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    def __call__(self, request):"},{"line_number":23,"context_line":"        if self.get_response:"},{"line_number":24,"context_line":"            response \u003d self.get_response(request)"},{"line_number":25,"context_line":"            return response"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_1249eb8b","line":24,"range":{"start_line":24,"start_character":13,"end_line":24,"end_character":49},"updated":"2018-11-05 19:05:52.000000000","message":"we don\u0027t need \u0027response\u0027 variable here. Please, change to:\nreturn self.get_response(request)","commit_id":"f8668025b4f977e37dcf6fbc4dc4a6f72297dfbf"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"48aca8334a66b6bcd0d746176f73fbac593e3b7d","unresolved":false,"context_lines":[{"line_number":20,"context_line":"        self.get_response \u003d get_response"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    def __call__(self, request):"},{"line_number":23,"context_line":"        if self.get_response:"},{"line_number":24,"context_line":"            response \u003d self.get_response(request)"},{"line_number":25,"context_line":"            return response"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_d26933f7","line":25,"range":{"start_line":23,"start_character":8,"end_line":25,"end_character":27},"updated":"2018-11-05 19:05:52.000000000","message":"nit: try-except will be more pythonic but I won\u0027t block patch for it:\ntry:\n    return self.get_response(request)\nexcept AttributeError:\n    pass","commit_id":"f8668025b4f977e37dcf6fbc4dc4a6f72297dfbf"},{"author":{"_account_id":10420,"name":"Adrian Turjak","email":"devs+openstack@uncaught-exceptions.com","username":"adriant"},"change_message_id":"0603e9275c67abed7dd800b2f30cc4fbc5be72f2","unresolved":false,"context_lines":[{"line_number":20,"context_line":"        self.get_response \u003d get_response"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    def __call__(self, request):"},{"line_number":23,"context_line":"        if self.get_response:"},{"line_number":24,"context_line":"            response \u003d self.get_response(request)"},{"line_number":25,"context_line":"            return response"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_aa52fb0f","line":25,"range":{"start_line":23,"start_character":8,"end_line":25,"end_character":27},"in_reply_to":"3f79a3b5_d26933f7","updated":"2018-11-06 00:06:17.000000000","message":"Done","commit_id":"f8668025b4f977e37dcf6fbc4dc4a6f72297dfbf"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"534411b90c31fa12f0040040430e37bb14c619f4","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class OpenstackAuthMonkeyPatchMiddleware(object):"},{"line_number":19,"context_line":"    def __init__(self, get_response\u003dNone):"},{"line_number":20,"context_line":"        self.get_response \u003d get_response"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    def __call__(self, request):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_6be7f3d8","line":19,"range":{"start_line":19,"start_character":23,"end_line":19,"end_character":41},"updated":"2018-11-06 18:48:38.000000000","message":"I am still not convinced.\n\nDiscussion from patch set 4.\n\nI cannot reproduce the issue Mathieu commented with Django 1.11.16. If it happens only with Django 1.11.9, it should be a bug of Django. In addition, I tested this patch with Django 1.11.9 (you mentioned) with apache deployment, I cannot reproduce the traceback above.\n\nIn Django 1.10 or later, __init__ takes get_response, so there is no need to make get_response optional. [1]\n\n[1] https://docs.djangoproject.com/en/1.11/topics/http/middleware/","commit_id":"c1a7fb1fe8af797b1fd3f278b1592ea18570a410"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b74a955feb7cc6d7c8ee8bd50c3f2ddcb162995e","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class OpenstackAuthMonkeyPatchMiddleware(object):"},{"line_number":19,"context_line":"    def __init__(self, get_response\u003dNone):"},{"line_number":20,"context_line":"        self.get_response \u003d get_response"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    def __call__(self, request):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_9dbdf2d2","line":19,"range":{"start_line":19,"start_character":23,"end_line":19,"end_character":41},"in_reply_to":"3f79a3b5_4b7797d3","updated":"2018-11-06 19:28:54.000000000","message":"My estimation looks correct. When MIDDLEWARE_CLASSES is used, a middlware class is instantiated without argument.\n\nhttps://github.com/django/django/blob/1.11.16/django/core/handlers/base.py#L55-L65","commit_id":"c1a7fb1fe8af797b1fd3f278b1592ea18570a410"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"29f00eaf740213b3d3e5cd8f51df59cdfc8665eb","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class OpenstackAuthMonkeyPatchMiddleware(object):"},{"line_number":19,"context_line":"    def __init__(self, get_response\u003dNone):"},{"line_number":20,"context_line":"        self.get_response \u003d get_response"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    def __call__(self, request):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_4b7797d3","line":19,"range":{"start_line":19,"start_character":23,"end_line":19,"end_character":41},"in_reply_to":"3f79a3b5_6b15b394","updated":"2018-11-06 19:26:26.000000000","message":"ah.... I didn\u0027t notice the follow-up reply in the comment. It is not easy to track discussion in both inline and cover comments :(\n\n\u003e I found that it is because I\u0027m using settings.MIDDLEWARE_CLASSES which is deprecated. settings.MIDDLEWARE is preferred now which uses the get_response parameter.\n\u003e \n\u003e But Horizon Queens still use settings.MIDDLEWARE_CLASSES: https://github.com/openstack/horizon/blob/6d58d3550cce5abfad9a851f3a5b3ac35b20ffb4/openstack_dashboard/settings.py#L110\n\nIt seems the legacy middleware interface (process_request and process_response) is used when MIDDLEWARE_CLAASES is used. If so, it seems better to implement the legacy interface in Queens backport.\n\nI don\u0027t see any reason we need to introduce the legacy way in the master branch.","commit_id":"c1a7fb1fe8af797b1fd3f278b1592ea18570a410"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d974c06694642c10a3caa299b8bee615be65815e","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class OpenstackAuthMonkeyPatchMiddleware(object):"},{"line_number":19,"context_line":"    def __init__(self, get_response\u003dNone):"},{"line_number":20,"context_line":"        self.get_response \u003d get_response"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    def __call__(self, request):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_6b15b394","line":19,"range":{"start_line":19,"start_character":23,"end_line":19,"end_character":41},"in_reply_to":"3f79a3b5_6be7f3d8","updated":"2018-11-06 18:49:08.000000000","message":"Can anyone reproduce the issue Mathieu mentioned?","commit_id":"c1a7fb1fe8af797b1fd3f278b1592ea18570a410"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9665f4d59fb0c404c71a7737a100950a95fedd0f","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class OpenstackAuthMonkeyPatchMiddleware(object):"},{"line_number":19,"context_line":"    def __init__(self, get_response\u003dNone):"},{"line_number":20,"context_line":"        self.get_response \u003d get_response"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    def __call__(self, request):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_bd1f8e6f","line":19,"range":{"start_line":19,"start_character":23,"end_line":19,"end_character":41},"in_reply_to":"3f79a3b5_9dbdf2d2","updated":"2018-11-06 19:49:37.000000000","message":"NOTE: When backporting this to queens or older, we can rewrite this middleware as follows (using the legacy middleware interface):\n\n  class OpenstackAuthMonkeyPatchMiddleware(object):\n      pass\n\n* __init__ is called without any argument.\n* __call__ method is unnecessary. process_request, process_response and process_exception are the interface of the legacy middleware and if they are not defined the middleware will be skipped.\n\nThe above is based on MIDDLEWARE_CLASSES code in Django 1.11.\nhttps://github.com/django/django/blob/1.11.16/django/core/handlers/base.py#L55-L76","commit_id":"c1a7fb1fe8af797b1fd3f278b1592ea18570a410"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"534411b90c31fa12f0040040430e37bb14c619f4","unresolved":false,"context_lines":[{"line_number":23,"context_line":"        try:"},{"line_number":24,"context_line":"            return self.get_response(request)"},{"line_number":25,"context_line":"        except AttributeError:"},{"line_number":26,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_6bacd3ea","line":26,"updated":"2018-11-06 18:48:38.000000000","message":"In the protocol of Django middleware, __call__ must return \u0027response\u0027. What happens when \u0027pass\u0027 is processed?","commit_id":"c1a7fb1fe8af797b1fd3f278b1592ea18570a410"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9665f4d59fb0c404c71a7737a100950a95fedd0f","unresolved":false,"context_lines":[{"line_number":23,"context_line":"        try:"},{"line_number":24,"context_line":"            return self.get_response(request)"},{"line_number":25,"context_line":"        except AttributeError:"},{"line_number":26,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_1d69e2f5","line":26,"in_reply_to":"3f79a3b5_1d8002f6","updated":"2018-11-06 19:49:37.000000000","message":"On second thought, raising MiddlewareNotUsed is too much. Removing try-except is fine to me.","commit_id":"c1a7fb1fe8af797b1fd3f278b1592ea18570a410"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"82e63d99c058d621d2fa49f72f9589d69c6fc6f0","unresolved":false,"context_lines":[{"line_number":23,"context_line":"        try:"},{"line_number":24,"context_line":"            return self.get_response(request)"},{"line_number":25,"context_line":"        except AttributeError:"},{"line_number":26,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_1d8002f6","line":26,"in_reply_to":"3f79a3b5_6bacd3ea","updated":"2018-11-06 19:33:19.000000000","message":"Considering the speciality of this middleware, what is important is to load this module. Actually there is no need to call the middleware itself during processing a request.\nHow about raising MiddlewareNotUsed in __init__()?","commit_id":"c1a7fb1fe8af797b1fd3f278b1592ea18570a410"}],"openstack_auth/utils.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b425b07fefd0e58ea4ff6a885c66cb09166ecb56","unresolved":false,"context_lines":[{"line_number":37,"context_line":"existing django.contrib.auth.get_user method. To do so we update the"},{"line_number":38,"context_line":"auth middleware to point to our overridden method."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Calling the \"patch_middleware_get_user\" is done in our custom middleware at"},{"line_number":41,"context_line":"\"openstack_auth.middleware\" to monkeypatch the code in before it is needed."},{"line_number":42,"context_line":"\"\"\""},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_f5022e0d","line":40,"range":{"start_line":40,"start_character":0,"end_line":40,"end_character":47},"updated":"2018-11-05 00:11:12.000000000","message":"In this case we usually say:\n\n  The \"patch_middleware_get_user\" is called ....","commit_id":"f8668025b4f977e37dcf6fbc4dc4a6f72297dfbf"},{"author":{"_account_id":10420,"name":"Adrian Turjak","email":"devs+openstack@uncaught-exceptions.com","username":"adriant"},"change_message_id":"2bf84b8e8b9c95860758f7d2c5f225fe07c0473d","unresolved":false,"context_lines":[{"line_number":37,"context_line":"existing django.contrib.auth.get_user method. To do so we update the"},{"line_number":38,"context_line":"auth middleware to point to our overridden method."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Calling the \"patch_middleware_get_user\" is done in our custom middleware at"},{"line_number":41,"context_line":"\"openstack_auth.middleware\" to monkeypatch the code in before it is needed."},{"line_number":42,"context_line":"\"\"\""},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_9dca0045","line":40,"range":{"start_line":40,"start_character":0,"end_line":40,"end_character":47},"in_reply_to":"3f79a3b5_f5022e0d","updated":"2018-11-05 04:50:47.000000000","message":"yeah.. the grammar in my change here is weird. I\u0027ll fix it.","commit_id":"f8668025b4f977e37dcf6fbc4dc4a6f72297dfbf"}],"openstack_dashboard/settings.py":[{"author":{"_account_id":10420,"name":"Adrian Turjak","email":"devs+openstack@uncaught-exceptions.com","username":"adriant"},"change_message_id":"6c3d343302e09a83c867b63c97affd1eb3812503","unresolved":false,"context_lines":[{"line_number":110,"context_line":"}"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"MIDDLEWARE \u003d ("},{"line_number":113,"context_line":"    \u0027openstack_auth.middleware.OpenstackAuthMonkeyPatchMiddleware\u0027,"},{"line_number":114,"context_line":"    \u0027debreach.middleware.RandomCommentMiddleware\u0027,"},{"line_number":115,"context_line":"    \u0027django.middleware.common.CommonMiddleware\u0027,"},{"line_number":116,"context_line":"    \u0027django.middleware.csrf.CsrfViewMiddleware\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_8a74df8b","line":113,"range":{"start_line":113,"start_character":4,"end_line":113,"end_character":67},"updated":"2018-11-06 00:11:58.000000000","message":"@Ivan\n\nAs you can see, we call the monkeypatch (and need to call it) in the core settings file. If this isn\u0027t here, auth breaks.","commit_id":"c1a7fb1fe8af797b1fd3f278b1592ea18570a410"}],"openstack_dashboard/test/helpers.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b425b07fefd0e58ea4ff6a885c66cb09166ecb56","unresolved":false,"context_lines":[{"line_number":411,"context_line":"# NOTE(adriant): APITestCase was only needed for some openstack_auth"},{"line_number":412,"context_line":"# monkeypatching. With the new monkeypatch middleware from openstack_auth this"},{"line_number":413,"context_line":"# is not needed."},{"line_number":414,"context_line":"# TODO(adriant): Clean up APITestCase usage in horizon plugins."},{"line_number":415,"context_line":"APITestCase \u003d TestCase"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_d507f21d","line":414,"range":{"start_line":414,"start_character":17,"end_line":414,"end_character":63},"updated":"2018-11-05 00:11:12.000000000","message":"If so, some deprecation warning would be fine, but it applies to APIMockTestCase below. Let\u0027s clean up them seprarately.","commit_id":"f8668025b4f977e37dcf6fbc4dc4a6f72297dfbf"},{"author":{"_account_id":10420,"name":"Adrian Turjak","email":"devs+openstack@uncaught-exceptions.com","username":"adriant"},"change_message_id":"2bf84b8e8b9c95860758f7d2c5f225fe07c0473d","unresolved":false,"context_lines":[{"line_number":411,"context_line":"# NOTE(adriant): APITestCase was only needed for some openstack_auth"},{"line_number":412,"context_line":"# monkeypatching. With the new monkeypatch middleware from openstack_auth this"},{"line_number":413,"context_line":"# is not needed."},{"line_number":414,"context_line":"# TODO(adriant): Clean up APITestCase usage in horizon plugins."},{"line_number":415,"context_line":"APITestCase \u003d TestCase"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_bdc57c37","line":414,"range":{"start_line":414,"start_character":17,"end_line":414,"end_character":63},"in_reply_to":"3f79a3b5_d507f21d","updated":"2018-11-05 04:50:47.000000000","message":"Do you want me to add a release note with a deprecation?","commit_id":"f8668025b4f977e37dcf6fbc4dc4a6f72297dfbf"}]}
