)]}'
{"horizon/tables/views.py":[{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"559d08dccb9667710d62ff1322dfe55f697e2e25","unresolved":false,"context_lines":[{"line_number":309,"context_line":"                    filter_keys \u003d filter_map.keys()"},{"line_number":310,"context_line":"                    filter_values \u003d filter_map.values()"},{"line_number":311,"context_line":"                    filter_map2 \u003d {}"},{"line_number":312,"context_line":"                    for i in range(len(filter_map)):"},{"line_number":313,"context_line":"                        filter_map2[filter_keys[i].lower()] \u003d filter_values[i]"},{"line_number":314,"context_line":"                    # We use the filter_string given by the user and"},{"line_number":315,"context_line":"                    # look for valid values in the filter_map that\u0027s why"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_77745404","line":312,"updated":"2018-11-12 11:10:14.000000000","message":"Try this:\nfilter_map2 \u003d {(key.lower(), value) for (key, value) in filter_map.items()}","commit_id":"c78532ae43429ddf615d61525ad541960edca62c"},{"author":{"_account_id":25946,"name":"Wangliangyu","email":"wangly2097@chinaunicom.cn","username":"wangliangyu"},"change_message_id":"4875c5c01191669a4c9fd7ec58e88219c4b5072b","unresolved":false,"context_lines":[{"line_number":306,"context_line":"                    filter_map \u003d filters_map.get(filter_field, {})"},{"line_number":307,"context_line":"                    # The filter_map keys are django.utils.functional.__proxy__"},{"line_number":308,"context_line":"                    # We need convert them to unicode, like filter_string"},{"line_number":309,"context_line":"                    filter_keys \u003d filter_map.keys()"},{"line_number":310,"context_line":"                    filter_values \u003d filter_map.values()"},{"line_number":311,"context_line":"                    filter_map2 \u003d {}"},{"line_number":312,"context_line":"                    for i in range(len(filter_map)):"},{"line_number":313,"context_line":"                        filter_map2[filter_keys[i].lower()] \u003d filter_values[i]"},{"line_number":314,"context_line":"                    # We use the filter_string given by the user and"},{"line_number":315,"context_line":"                    # look for valid values in the filter_map that\u0027s why"},{"line_number":316,"context_line":"                    # we apply lower()"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_07a076a3","line":313,"range":{"start_line":309,"start_character":20,"end_line":313,"end_character":78},"updated":"2018-11-09 03:18:25.000000000","message":"Starting, I used below code, but filter_map.get(k) could not get the value. Maybe someone else could explain it:\nfilter_map2 \u003d {k.lower(): filter_map.get(k) for k in filter_map}","commit_id":"c78532ae43429ddf615d61525ad541960edca62c"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"559d08dccb9667710d62ff1322dfe55f697e2e25","unresolved":false,"context_lines":[{"line_number":314,"context_line":"                    # We use the filter_string given by the user and"},{"line_number":315,"context_line":"                    # look for valid values in the filter_map that\u0027s why"},{"line_number":316,"context_line":"                    # we apply lower()"},{"line_number":317,"context_line":"                    filters[filter_field] \u003d filter_map2.get("},{"line_number":318,"context_line":"                        filter_string.lower(), filter_string)"},{"line_number":319,"context_line":"        return filters"},{"line_number":320,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_d768c81f","line":317,"updated":"2018-11-12 11:10:14.000000000","message":"What\u0027s the point of using a dict here, if you first iterate over it anyways? Wouldn\u0027t it be better to simply do a linear search while you are iterating?","commit_id":"c78532ae43429ddf615d61525ad541960edca62c"},{"author":{"_account_id":25946,"name":"Wangliangyu","email":"wangly2097@chinaunicom.cn","username":"wangliangyu"},"change_message_id":"6a7400b6f11b83ee2bb1008565d6afe2ea44750d","unresolved":false,"context_lines":[{"line_number":314,"context_line":"                    # We use the filter_string given by the user and"},{"line_number":315,"context_line":"                    # look for valid values in the filter_map that\u0027s why"},{"line_number":316,"context_line":"                    # we apply lower()"},{"line_number":317,"context_line":"                    filters[filter_field] \u003d filter_map2.get("},{"line_number":318,"context_line":"                        filter_string.lower(), filter_string)"},{"line_number":319,"context_line":"        return filters"},{"line_number":320,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_7dcf4b8a","line":317,"in_reply_to":"3f79a3b5_d768c81f","updated":"2018-11-13 03:06:17.000000000","message":"You are right, one iteration is enough.","commit_id":"c78532ae43429ddf615d61525ad541960edca62c"}]}
