)]}'
{"horizon/test/urls.py":[{"author":{"_account_id":2455,"name":"Tihomir Trifonov","email":"t.trifonov@gmail.com","username":"ttrifonov"},"change_message_id":"41322abdf7005f3c0e35794ea5ea020a83281d9c","unresolved":false,"context_lines":[{"line_number":45,"context_line":"urlpatterns +\u003d staticfiles_urlpatterns()"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"class GlanceClientTest():"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def testUrlGlanceNoChange(self):"},{"line_number":51,"context_line":"        urlInput \u003d \u0027http://192.168.10.11/my/image/api/path/\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9AvQ%3D","line":48,"updated":"2013-12-17 18:15:10.000000000","message":"The unit tests should be placed into files named tests.py.\nThese tests here are not executed from run_tests.sh, and I seriously doubt if they will pass at all... This class doesn\u0027t inherit the base UnitTest class...","commit_id":"9fbc2e77f385c0c61f243690dcfd2f83614f913c"},{"author":{"_account_id":2455,"name":"Tihomir Trifonov","email":"t.trifonov@gmail.com","username":"ttrifonov"},"change_message_id":"41322abdf7005f3c0e35794ea5ea020a83281d9c","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def testUrlGlanceNoChange(self):"},{"line_number":51,"context_line":"        urlInput \u003d \u0027http://192.168.10.11/my/image/api/path/\u0027"},{"line_number":52,"context_line":"        urlOutput \u003d openstack_dashboard.api.glance.glanceclient(urlInput)"},{"line_number":53,"context_line":"        self.assertEqual(urlInput, urlOutput)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def testUrlGlanceWithVersion(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9AuE%3D","line":52,"updated":"2013-12-17 18:15:10.000000000","message":"Uh.. glanceclient expects \u0027request\u0027 object, not string...","commit_id":"9fbc2e77f385c0c61f243690dcfd2f83614f913c"}],"openstack_dashboard/api/glance.py":[{"author":{"_account_id":2455,"name":"Tihomir Trifonov","email":"t.trifonov@gmail.com","username":"ttrifonov"},"change_message_id":"41322abdf7005f3c0e35794ea5ea020a83281d9c","unresolved":false,"context_lines":[{"line_number":38,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"def glanceclient(request):"},{"line_number":42,"context_line":"    url \u003d base.url_for(request, \u0027image\u0027)"},{"line_number":43,"context_line":"    # Get rid of trailing \u0027/\u0027 if present"},{"line_number":44,"context_line":"    if url.endswith(\u0027/\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9Atg%3D","line":41,"updated":"2013-12-17 18:15:10.000000000","message":"If glanceclient is already doing the stripping of vX.X from url, why should we do it here again? Also, Glance is doing it on purpose, here we should only pass the full path, and (probably) not stripping anything..","commit_id":"9fbc2e77f385c0c61f243690dcfd2f83614f913c"},{"author":{"_account_id":9659,"name":"Matt Wood","email":"matt.wood@hpe.com","username":"woodm1979"},"change_message_id":"927f47ab5b6fb921639d28b0fce286bc3e74fb3e","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    url \u003d base.url_for(request, \u0027image\u0027)"},{"line_number":43,"context_line":"    # Get rid of trailing \u0027/\u0027 if present"},{"line_number":44,"context_line":"    if url.endswith(\u0027/\u0027):"},{"line_number":45,"context_line":"        url \u003d url[:-1]"},{"line_number":46,"context_line":"    url_bits \u003d url.split(\u0027/\u0027)"},{"line_number":47,"context_line":"    # regex to match \u0027v1\u0027 or \u0027v2.0\u0027 etc"},{"line_number":48,"context_line":"    if re.match(\u0027v\\d+\\.?\\d*\u0027, url_bits[-1]):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9BHc%3D","line":45,"updated":"2013-12-17 16:50:02.000000000","message":"Would this be easier?\n\n    url \u003d base.url_for(request, \u0027image\u0027).rstrip(\u0027/\u0027)\n\nor do you need to limit the removal to only one \u0027/\u0027 char for some reason?","commit_id":"9fbc2e77f385c0c61f243690dcfd2f83614f913c"},{"author":{"_account_id":9659,"name":"Matt Wood","email":"matt.wood@hpe.com","username":"woodm1979"},"change_message_id":"927f47ab5b6fb921639d28b0fce286bc3e74fb3e","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        url \u003d url[:-1]"},{"line_number":46,"context_line":"    url_bits \u003d url.split(\u0027/\u0027)"},{"line_number":47,"context_line":"    # regex to match \u0027v1\u0027 or \u0027v2.0\u0027 etc"},{"line_number":48,"context_line":"    if re.match(\u0027v\\d+\\.?\\d*\u0027, url_bits[-1]):"},{"line_number":49,"context_line":"        url \u003d \u0027/\u0027.join(url_bits[:-1])"},{"line_number":50,"context_line":"    insecure \u003d getattr(settings, \u0027OPENSTACK_SSL_NO_VERIFY\u0027, False)"},{"line_number":51,"context_line":"    cacert \u003d getattr(settings, \u0027OPENSTACK_SSL_CACERT\u0027, None)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9BIA%3D","line":48,"updated":"2013-12-17 16:50:02.000000000","message":"Pardon my ignorance, but how does this pass your testUrlGlanceWithVersion test?  Doesn\u0027t the regex only get matched on the last element of your url.split(\u0027/\u0027) ?  \n\nMaybe I\u0027m just missing something.","commit_id":"9fbc2e77f385c0c61f243690dcfd2f83614f913c"}],"openstack_dashboard/test/api_tests/glance_tests.py":[{"author":{"_account_id":10099,"name":"Charles Prince","email":"charles.prince@hp.com","username":"charles-prince"},"change_message_id":"22acb271cc2554c0cfc675bd84ee5bc8c6de8cbe","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        image \u003d api.glance.image_get(self.request, \u0027empty\u0027)"},{"line_number":116,"context_line":"        self.assertIsNone(image.name)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    # tests the piece of code of removing version in the url glance"},{"line_number":119,"context_line":"    def testUrlGlanceNoChange(self):"},{"line_number":120,"context_line":"        url \u003d \u0027http://192.168.10.11/my/image/api/path\u0027"},{"line_number":121,"context_line":"        #  Get rid of trailing \u0027/\u0027 if present"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2Bgps%3D","line":118,"updated":"2014-01-24 22:32:31.000000000","message":"These two tests do not test any application code.","commit_id":"ceda14d7eb8cdd8e1601956bd8488948461e70d6"}]}
