)]}'
{"horizon/static/horizon/js/horizon.modals.js":[{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"a679b6a7191d0f9aa2dbf8687e4bf8e358cb4c91","unresolved":false,"context_lines":[{"line_number":189,"context_line":"      });"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"      // Handle errors."},{"line_number":192,"context_line":"      horizon.instances. del_network_errors();  // delete previous errors."},{"line_number":193,"context_line":"      if (response.has_errors) {"},{"line_number":194,"context_line":"        var first_field \u003d true;"},{"line_number":195,"context_line":""}],"source_content_type":"text/javascript","patch_set":27,"id":"7adec928_8e982ec1","line":192,"updated":"2014-05-20 14:32:35.000000000","message":"I really don\u0027t like putting code that is specific to a single view in the general horizon javascript libraries.","commit_id":"62c2b8d37bb637a007833fa13bf50e4d95c7aab8"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"9f3aa5a157227fcf7a7a5714fc9594221fbeda25","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    });"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    // Handle errors."},{"line_number":94,"context_line":"    horizon.instances. del_network_errors(); // delete previous errors."},{"line_number":95,"context_line":"    if (response.has_errors) {"},{"line_number":96,"context_line":"      var first_field \u003d true;"},{"line_number":97,"context_line":""}],"source_content_type":"text/javascript","patch_set":28,"id":"baada198_17d1bcfa","line":94,"updated":"2014-07-28 07:05:46.000000000","message":"I still don\u0027t like having dashboard-specific code in something that will go to horizon_lib. Maybe we could have some sort of a callback that you would register?","commit_id":"6a6cdcbb15b34dbbf9f8adaa71e62a8d769d0aee"}],"openstack_dashboard/dashboards/project/instances/workflows/create_instance.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"178207035577971536fca16012db167d560f1974","unresolved":false,"context_lines":[{"line_number":327,"context_line":"                                             initial\u003dFalse,"},{"line_number":328,"context_line":"                                             required\u003dFalse,"},{"line_number":329,"context_line":"                                             help_text\u003d_(\"Delete volume on \""},{"line_number":330,"context_line":"                                                         \"instance terminate\"))"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"    def __init__(self, request, context, *args, **kwargs):"},{"line_number":333,"context_line":"        self._init_images_cache()"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F8t0E%3D","line":330,"updated":"2013-12-21 13:00:49.000000000","message":"I don\u0027t think volume_size, device_name and delete_on_terminate are related to Flavor. What is the reason of this classification?","commit_id":"b303727cbd7ec7dbe7a1c83f16b81736a519859a"},{"author":{"_account_id":8674,"name":"Yves-Gwenael Bourhis","email":"ygbourhis@gmail.com","username":"yves"},"change_message_id":"a805e584d176ca896c91731c2445fa593734549b","unresolved":false,"context_lines":[{"line_number":327,"context_line":"                                             initial\u003dFalse,"},{"line_number":328,"context_line":"                                             required\u003dFalse,"},{"line_number":329,"context_line":"                                             help_text\u003d_(\"Delete volume on \""},{"line_number":330,"context_line":"                                                         \"instance terminate\"))"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"    def __init__(self, request, context, *args, **kwargs):"},{"line_number":333,"context_line":"        self._init_images_cache()"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F8rFA%3D","line":330,"in_reply_to":"AAAATn%2F8t0E%3D","updated":"2013-12-23 12:32:16.000000000","message":"Well, The reason to this is that the flavor concerns disk, cpu and memory sizes, so I assumed that volume size was related (and it thought logical to have the device name corresponding to the volume to be held at the same place), but I can be wrong :-)","commit_id":"b303727cbd7ec7dbe7a1c83f16b81736a519859a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"178207035577971536fca16012db167d560f1974","unresolved":false,"context_lines":[{"line_number":628,"context_line":"            self._images_cache \u003d {}"},{"line_number":629,"context_line":"            for step in self.steps:"},{"line_number":630,"context_line":"                if ("},{"line_number":631,"context_line":"                    hasattr(step.action, \u0027_images_cache\u0027)"},{"line_number":632,"context_line":"                    and isinstance(step.action._images_cache, dict)"},{"line_number":633,"context_line":"                    and step.action._images_cache is not self._images_cache"},{"line_number":634,"context_line":"                ):"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F8t0Q%3D","line":631,"updated":"2013-12-21 13:00:49.000000000","message":"I think most of horizon codes use the style of \"if (hasattr(...))\". I don\u0027t have a strong objection on it, but it is better to use one style throughout the code.","commit_id":"b303727cbd7ec7dbe7a1c83f16b81736a519859a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"178207035577971536fca16012db167d560f1974","unresolved":false,"context_lines":[{"line_number":633,"context_line":"                    and step.action._images_cache is not self._images_cache"},{"line_number":634,"context_line":"                ):"},{"line_number":635,"context_line":"                    self._images_cache.update(step.action._images_cache)"},{"line_number":636,"context_line":"                step.action._images_cache \u003d self._images_cache"},{"line_number":637,"context_line":""},{"line_number":638,"context_line":"    def format_status_message(self, message):"},{"line_number":639,"context_line":"        name \u003d self.context.get(\u0027name\u0027, \u0027unknown instance\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F8t0U%3D","line":636,"updated":"2013-12-21 13:00:49.000000000","message":"It doesn\u0027t look natural that multiple classes have _images_cahce. Can\u0027t each action refer to images_caches in the workflow class?","commit_id":"b303727cbd7ec7dbe7a1c83f16b81736a519859a"},{"author":{"_account_id":8674,"name":"Yves-Gwenael Bourhis","email":"ygbourhis@gmail.com","username":"yves"},"change_message_id":"a805e584d176ca896c91731c2445fa593734549b","unresolved":false,"context_lines":[{"line_number":633,"context_line":"                    and step.action._images_cache is not self._images_cache"},{"line_number":634,"context_line":"                ):"},{"line_number":635,"context_line":"                    self._images_cache.update(step.action._images_cache)"},{"line_number":636,"context_line":"                step.action._images_cache \u003d self._images_cache"},{"line_number":637,"context_line":""},{"line_number":638,"context_line":"    def format_status_message(self, message):"},{"line_number":639,"context_line":"        name \u003d self.context.get(\u0027name\u0027, \u0027unknown instance\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F8rZU%3D","line":636,"in_reply_to":"AAAATn%2F8t0U%3D","updated":"2013-12-23 12:32:16.000000000","message":"Action classes are not aware of the workflow class by design (however Step classes are).\n\nIf they do not share the same cache, the whole unittests fail because we have unregistered extra api calls (and mox complains about unregistered api calls in an amount of unittests which could make anyone fall of his chair like I did ;-) ).\n\nMaking the Action instances \"workflow aware\" requires modifying the Action\u0027s __init__ method and requires refactoring a lot of code, it is not a trivial task.\n\nThis was the quickest solution I found,\n\nAnother quick solution is that I can do what follows to access the workflow in the Action\u0027s subclasses __init__:\n\ninspect.currentframe().f_back.f_locals[\u0027self\u0027].workflow\n\nBut I really find it a little dirty ^_^\n\nWhich solution would you prefer?\n\nIMHO the best would be to redesign the Action class, but this requires tons of modifications in both all action initializations and unittests.\n\nA nice way would be instead to have action instances initialized on the class definition, and to have the Actions have a __get__(self, instance, owner) method so that it would automatically be aware of the holding instance. But this would imply deep redesign.\n\nWhich way do you suggest would be the best?","commit_id":"b303727cbd7ec7dbe7a1c83f16b81736a519859a"},{"author":{"_account_id":9317,"name":"Ana Krivokapic","email":"akrivoka@redhat.com","username":"akrivoka"},"change_message_id":"bc19af75e63e08b8ac70aa2282f08dcbe90df5e7","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    class Meta:"},{"line_number":108,"context_line":"        name \u003d _(\"Instance \u0026 Image\")"},{"line_number":109,"context_line":"        help_text \u003d (\"Specify the details for launching an instance.\")"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def __init__(self, request, context, *args, **kwargs):"},{"line_number":112,"context_line":"        self._init_images_cache()"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAT3%2F%2FsAo%3D","line":109,"updated":"2014-01-03 15:28:37.000000000","message":"Please use _() here, so that the string gets translated.","commit_id":"00d1dd72c8f7a562ce49700ea3c9dd40994e7171"}]}
