)]}'
{"openstack_dashboard/dashboards/project/stacks/forms.py":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"8d09a4d2346cc90d5f8a7874af1d6e4ddc54a31e","unresolved":false,"context_lines":[{"line_number":137,"context_line":"            validated \u003d api.heat.template_validate(self.request, **kwargs)"},{"line_number":138,"context_line":"            cleaned[\u0027template_validate\u0027] \u003d validated"},{"line_number":139,"context_line":"        except Exception as e:"},{"line_number":140,"context_line":"            msg \u003d exception_to_validation_msg(e.message)"},{"line_number":141,"context_line":"            if not msg:"},{"line_number":142,"context_line":"                msg \u003d _(\u0027An unknown problem occurred validating the template.\u0027)"},{"line_number":143,"context_line":"                LOG.exception(msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAT3%2F%2Fwtk%3D","line":140,"updated":"2014-01-02 06:47:26.000000000","message":"Looking at the heat-client code, seems like passing \"e\" should be just fine since the __str__ has already been overridden to display the right message. \n\nFrom the bug report, seems like the root case is the proxy issue.  Would changing this to unicode(e) fix the issue?","commit_id":"aa0cb9b3fed34f9d2ca6ead3bf000b26eee579f6"},{"author":{"_account_id":7976,"name":"Maxime Vidori","email":"mvidori@redhat.com","username":"MaxV"},"change_message_id":"27923f1c19933cb937ff14d1c0b61caac4b6cdd6","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    \"\"\"Extracts a validation message to display to the user.\"\"\""},{"line_number":33,"context_line":"    try:"},{"line_number":34,"context_line":"        error \u003d json.loads(getattr(e, \u0027message\u0027, {}))"},{"line_number":35,"context_line":"        # NOTE(jianingy): if no message exists, we just return \u0027None\u0027"},{"line_number":36,"context_line":"        # and let the caller to deciede what to show"},{"line_number":37,"context_line":"        return error[\u0027error\u0027].get(\u0027message\u0027, None)"},{"line_number":38,"context_line":"    except Exception:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2FAng%3D","line":35,"updated":"2014-01-19 09:48:30.000000000","message":"Fix the typo of decide","commit_id":"539ec6b13783cbe2028fb250d924d3befb8a6f98"},{"author":{"_account_id":9659,"name":"Matt Wood","email":"matt.wood@hpe.com","username":"woodm1979"},"change_message_id":"b98b475439b95a697d1cb1dd6cb12864df5a4747","unresolved":false,"context_lines":[{"line_number":45,"context_line":"            \u0027400 Bad Request\\n\\nThe server could not comply with the request \u0027"},{"line_number":46,"context_line":"            \u0027since it is either malformed or otherwise incorrect.\\n\\n (.*)\u0027,"},{"line_number":47,"context_line":"            \u0027(ParserError: .*)\u0027,"},{"line_number":48,"context_line":"            \u0027ERROR: (.*)\u0027"},{"line_number":49,"context_line":"        ]"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        for pattern in validation_patterns:"}],"source_content_type":"text/x-python","patch_set":8,"id":"7adec928_de58a834","line":48,"updated":"2014-05-14 19:03:04.000000000","message":"Nit: I\u0027d like to see a trailing \u0027,\u0027 char.","commit_id":"42eaa7a593051ae815db0f9ad3331f94b74e0bd3"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"5e389bc56e33937df113afb01985e9ded2bfe7a8","unresolved":false,"context_lines":[{"line_number":28,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"def exception_to_validation_msg(e):"},{"line_number":32,"context_line":"    \"\"\"Extracts a validation message to display to the user.\"\"\""},{"line_number":33,"context_line":"    try:"},{"line_number":34,"context_line":"        error \u003d json.loads(str(e))"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa98f980_62c12280","line":31,"updated":"2014-09-01 12:20:00.000000000","message":"Can you please use a more meaningful variable name than \"e\"?\n\nPlease also avoid abbreviations, write \"message\" rather than \"msg\".","commit_id":"df8b470c887643703cc60f84f19b87df181d81e7"},{"author":{"_account_id":8533,"name":"Marcos Fermín Lobo","email":"lobo@lukos.org","username":"mlobo"},"change_message_id":"3ce729c8c17d3cdba424ae7acc8e601bd5463011","unresolved":false,"context_lines":[{"line_number":28,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"def exception_to_validation_msg(e):"},{"line_number":32,"context_line":"    \"\"\"Extracts a validation message to display to the user.\"\"\""},{"line_number":33,"context_line":"    try:"},{"line_number":34,"context_line":"        error \u003d json.loads(str(e))"}],"source_content_type":"text/x-python","patch_set":10,"id":"baa201ad_b61697a5","line":31,"in_reply_to":"fa98f980_62c12280","updated":"2014-10-03 09:05:29.000000000","message":"Done","commit_id":"df8b470c887643703cc60f84f19b87df181d81e7"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"5e389bc56e33937df113afb01985e9ded2bfe7a8","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        error \u003d json.loads(str(e))"},{"line_number":35,"context_line":"        # NOTE(jianingy): if no message exists, we just return \u0027None\u0027"},{"line_number":36,"context_line":"        # and let the caller to decide what to show"},{"line_number":37,"context_line":"        return error[\u0027error\u0027].get(\u0027message\u0027, None)"},{"line_number":38,"context_line":"    except Exception:"},{"line_number":39,"context_line":"        # NOTE(jianingy): fallback to legacy message parsing approach"},{"line_number":40,"context_line":"        # either if error message isn\u0027t a json nor the json isn\u0027t in"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa98f980_a2b6aa3b","line":37,"updated":"2014-09-01 12:20:00.000000000","message":"Can you leave only one line in the try-except block, so that you only catch the exceptions from where you expect them?","commit_id":"df8b470c887643703cc60f84f19b87df181d81e7"},{"author":{"_account_id":8533,"name":"Marcos Fermín Lobo","email":"lobo@lukos.org","username":"mlobo"},"change_message_id":"3ce729c8c17d3cdba424ae7acc8e601bd5463011","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        error \u003d json.loads(str(e))"},{"line_number":35,"context_line":"        # NOTE(jianingy): if no message exists, we just return \u0027None\u0027"},{"line_number":36,"context_line":"        # and let the caller to decide what to show"},{"line_number":37,"context_line":"        return error[\u0027error\u0027].get(\u0027message\u0027, None)"},{"line_number":38,"context_line":"    except Exception:"},{"line_number":39,"context_line":"        # NOTE(jianingy): fallback to legacy message parsing approach"},{"line_number":40,"context_line":"        # either if error message isn\u0027t a json nor the json isn\u0027t in"}],"source_content_type":"text/x-python","patch_set":10,"id":"baa201ad_f6873fd5","line":37,"in_reply_to":"fa98f980_a2b6aa3b","updated":"2014-10-03 09:05:29.000000000","message":"Done","commit_id":"df8b470c887643703cc60f84f19b87df181d81e7"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"5e389bc56e33937df113afb01985e9ded2bfe7a8","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        # NOTE(jianingy): if no message exists, we just return \u0027None\u0027"},{"line_number":36,"context_line":"        # and let the caller to decide what to show"},{"line_number":37,"context_line":"        return error[\u0027error\u0027].get(\u0027message\u0027, None)"},{"line_number":38,"context_line":"    except Exception:"},{"line_number":39,"context_line":"        # NOTE(jianingy): fallback to legacy message parsing approach"},{"line_number":40,"context_line":"        # either if error message isn\u0027t a json nor the json isn\u0027t in"},{"line_number":41,"context_line":"        # valid format."}],"source_content_type":"text/x-python","patch_set":10,"id":"fa98f980_2282ba4f","line":38,"updated":"2014-09-01 12:20:00.000000000","message":"Can you catch the specific exceptions that you expect?","commit_id":"df8b470c887643703cc60f84f19b87df181d81e7"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"36ecc5116091d4136e7b10e7553636733a1fa394","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    try:"},{"line_number":35,"context_line":"        error \u003d json.loads(str(exception))"},{"line_number":36,"context_line":"    except Exception:"},{"line_number":37,"context_line":"        # NOTE(jianingy): fallback to legacy message parsing approach"},{"line_number":38,"context_line":"        # either if error message isn\u0027t a json nor the json isn\u0027t in"},{"line_number":39,"context_line":"        # valid format."},{"line_number":40,"context_line":"        validation_patterns \u003d ["}],"source_content_type":"text/x-python","patch_set":12,"id":"9a80dd14_d93e68b7","line":37,"updated":"2015-03-10 11:47:01.000000000","message":"is that you? If you\u0027re adding a note here, you should insert your own name","commit_id":"527986719152edf1785a91722b5f74ca91a8824b"}],"openstack_dashboard/dashboards/project/stacks/tests.py":[{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"5e389bc56e33937df113afb01985e9ded2bfe7a8","unresolved":false,"context_lines":[{"line_number":515,"context_line":"[u\u0027\u003cTraceback\u003e\u0027].\"\"\""},{"line_number":516,"context_line":""},{"line_number":517,"context_line":"        msg \u003d forms.exception_to_validation_msg(Exception(json_error))"},{"line_number":518,"context_line":"        self.assertEqual(msg, \"The Key (none) could not be found.\")"},{"line_number":519,"context_line":""},{"line_number":520,"context_line":"    def test_exception_to_validation_malformed(self):"},{"line_number":521,"context_line":"        json_error \u003d \"\"\"{"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa98f980_42725e7d","line":518,"updated":"2014-09-01 12:20:00.000000000","message":"Can you try an example of every patter, to make sure there are no errors in the patterns?","commit_id":"df8b470c887643703cc60f84f19b87df181d81e7"},{"author":{"_account_id":16769,"name":"Lucas Palm","email":"lapalm@us.ibm.com","username":"lucaspalm"},"change_message_id":"4b95369d7a25c4bd092905e69cbdbac647d73edc","unresolved":false,"context_lines":[{"line_number":905,"context_line":"    \"explanation\": \"The server could not comply with the request\","},{"line_number":906,"context_line":"    \"title\": \"Bad Request\""},{"line_number":907,"context_line":"}\"\"\""},{"line_number":908,"context_line":""},{"line_number":909,"context_line":"        msg \u003d forms.exception_to_validation_message(Exception(json_error))"},{"line_number":910,"context_line":"        self.assertIsNone(msg)"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa80f949_ef6e4495","line":908,"updated":"2015-11-05 20:31:01.000000000","message":"Could the string literals introduced here be formatted a little better?  Their indentation is way off and makes it hard to read/follow.","commit_id":"43b352d4d20ee14090a98ec607a7e6c4fad36ebe"}]}
