)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"77612a941c6732400140a2af3d773c42a8bdf993","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     pengyuesheng \u003cpengyuesheng@gohighsec.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-02-18 09:58:44 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add \u0027data-required-when-shown\u0027: \u0027true\u0027 to cidr Field"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Cidr is not required on the Add Rule form,"},{"line_number":10,"context_line":"but there will be an error message if you do not filled."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I2125813d6fb58e311b6bef821a88c78ab0fc6cfc"},{"line_number":13,"context_line":"Closes-Bug: #1816330"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_d15d08ea","line":10,"range":{"start_line":7,"start_character":0,"end_line":10,"end_character":56},"updated":"2019-03-20 06:37:26.000000000","message":"IMO commit message can be improved like:\n\nMarking CIDR as mandatory field\n\nWhen selecting the remote as CIDR, the CIDR value field is mandatory but isn\u0027t marked as mandatory.\nThis patch marks it as mandatory.","commit_id":"ca4e39e7d1f47ab781bce50ad3b8ac49b0745ecc"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"bf2dc40f6efdc56977fa6d9a8e205b032cf1c557","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     pengyuesheng \u003cpengyuesheng@gohighsec.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-04-03 09:40:18 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Marking CIDR as mandatory field on Addrule form in security_group panel"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When selecting the remote as CIDR,"},{"line_number":10,"context_line":"the CIDR value field is mandatory but isn\u0027t marked as mandatory."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5fc1f717_fd1f8ab4","line":7,"range":{"start_line":7,"start_character":38,"end_line":7,"end_character":42},"updated":"2019-04-03 13:49:34.000000000","message":"Space required between these two words.","commit_id":"1f59c3ef6ecef802d9de42813de25ac0968ad98e"}],"openstack_dashboard/dashboards/project/security_groups/forms.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"cdb47b98f414aaa56670a685648c570ae9a8b71d","unresolved":false,"context_lines":[{"line_number":234,"context_line":"                                    \u0027data-switch-on\u0027: \u0027remote\u0027,"},{"line_number":235,"context_line":"                                    \u0027data-remote-cidr\u0027: _(\u0027CIDR\u0027)}))"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"    security_group \u003d forms.ChoiceField(label\u003d_(\u0027Security Group\u0027),"},{"line_number":238,"context_line":"                                       required\u003dFalse,"},{"line_number":239,"context_line":"                                       widget\u003dforms.ThemableSelectWidget("},{"line_number":240,"context_line":"                                           attrs\u003d{"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_9a325af1","line":237,"updated":"2019-03-29 09:54:35.000000000","message":"Don\u0027t we need the similar to \"security_group\" (remote group) too?","commit_id":"3f255b460559b7dbb728aad02b67caf52b4bb835"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b8110ca0d0f6eb30225d3b2b5605a53eac9de60e","unresolved":false,"context_lines":[{"line_number":240,"context_line":"                                           attrs\u003d{"},{"line_number":241,"context_line":"                                               \u0027class\u0027: \u0027switched\u0027,"},{"line_number":242,"context_line":"                                               \u0027data-required-when-shown\u0027:"},{"line_number":243,"context_line":"                                               \u0027true\u0027,"},{"line_number":244,"context_line":"                                               \u0027data-switch-on\u0027: \u0027remote\u0027,"},{"line_number":245,"context_line":"                                               \u0027data-remote-sg\u0027: _(\u0027Security \u0027"},{"line_number":246,"context_line":"                                                                   \u0027Group\u0027)}))"}],"source_content_type":"text/x-python","patch_set":6,"id":"5fc1f717_d477db07","line":243,"updated":"2019-04-05 09:58:04.000000000","message":"nit: it is not easy to read. How about wrapping lines after \"ChoiceField(\" at L.237? It would be much easier to read. This is a good chance to do so.","commit_id":"5f171158db762dc03c01c63a380af1077a6d2a2d"}]}
