)]}'
{"openstack_dashboard/dashboards/admin/snapshots/views.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"734dc7db05bf3d661878079b03af72d5ce789a0d","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                tenant_id \u003d getattr("},{"line_number":69,"context_line":"                    snapshot,"},{"line_number":70,"context_line":"                    \u0027os-extended-snapshot-attributes:project_id\u0027,"},{"line_number":71,"context_line":"                    None)"},{"line_number":72,"context_line":"                tenant \u003d tenant_dict.get(tenant_id, None)"},{"line_number":73,"context_line":"                snapshot._volume \u003d volume"},{"line_number":74,"context_line":"                snapshot.tenant_name \u003d getattr(tenant, \"name\", None)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_cad5591d","line":71,"updated":"2019-02-19 10:27:13.000000000","message":"Can\u0027t we use project_id property?\n\nhttps://github.com/openstack/horizon/blob/master/openstack_dashboard/api/cinder.py#L112","commit_id":"d2c905a769f0cd9034aa712068baf447c6328044"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"d7a77d5fd79a99462d04a0f1e2de91fa7744d70f","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                tenant_id \u003d getattr("},{"line_number":69,"context_line":"                    snapshot,"},{"line_number":70,"context_line":"                    \u0027os-extended-snapshot-attributes:project_id\u0027,"},{"line_number":71,"context_line":"                    None)"},{"line_number":72,"context_line":"                tenant \u003d tenant_dict.get(tenant_id, None)"},{"line_number":73,"context_line":"                snapshot._volume \u003d volume"},{"line_number":74,"context_line":"                snapshot.tenant_name \u003d getattr(tenant, \"name\", None)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_b0df240b","line":71,"in_reply_to":"9fdfeff1_cad5591d","updated":"2019-02-19 12:24:20.000000000","message":"done.","commit_id":"d2c905a769f0cd9034aa712068baf447c6328044"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"7b03fb5ae695679a62c8e1ddd4a032056db470b6","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            tenant_dict \u003d dict((t.id, t) for t in tenants)"},{"line_number":66,"context_line":"            for snapshot in snapshots:"},{"line_number":67,"context_line":"                volume \u003d volumes.get(snapshot.volume_id)"},{"line_number":68,"context_line":"                tenant_id \u003d snapshot._apiresource.project_id"},{"line_number":69,"context_line":"                tenant \u003d tenant_dict.get(tenant_id, None)"},{"line_number":70,"context_line":"                snapshot._volume \u003d volume"},{"line_number":71,"context_line":"                snapshot.tenant_name \u003d getattr(tenant, \"name\", None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_56cef02d","line":68,"updated":"2019-02-19 14:14:15.000000000","message":"Hmm.... why not snapshot.project_id?\nproject_id is defined as @property, so \"snapshot\" object should have \"project_id\" attribute.\n\nIn addition, _apiresource is the original object from cinderclient, so I think it does not have \"project_id\" attribute.","commit_id":"b282b49460584dd6dfb1af021df956a8a86aa1a3"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"01c3bd84c4919f6ce5f7e5be2e09aac4305479bc","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            tenant_dict \u003d dict((t.id, t) for t in tenants)"},{"line_number":66,"context_line":"            for snapshot in snapshots:"},{"line_number":67,"context_line":"                volume \u003d volumes.get(snapshot.volume_id)"},{"line_number":68,"context_line":"                tenant_id \u003d snapshot._apiresource.project_id"},{"line_number":69,"context_line":"                tenant \u003d tenant_dict.get(tenant_id, None)"},{"line_number":70,"context_line":"                snapshot._volume \u003d volume"},{"line_number":71,"context_line":"                snapshot.tenant_name \u003d getattr(tenant, \"name\", None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_0ae4bc3b","line":68,"in_reply_to":"9fdfeff1_56cef02d","updated":"2019-02-19 14:33:39.000000000","message":"yeah agreed,\nDone.\nthanks","commit_id":"b282b49460584dd6dfb1af021df956a8a86aa1a3"}]}
