)]}'
{"openstack_dashboard/dashboards/project/volume_groups/tables.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2ce20e2e69084cfa44dbb36d8256f855c69c2bd7","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def allowed(self, request, datum\u003dNone):"},{"line_number":43,"context_line":"        # we need to gracefully delete present groups without has_snapshots"},{"line_number":44,"context_line":"        if datum and getattr(datum, \u0027has_snapshots\u0027, False):"},{"line_number":45,"context_line":"            return False"},{"line_number":46,"context_line":"        return True"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_b1590f5c","line":44,"updated":"2019-02-23 06:05:54.000000000","message":"If you ensure \"has_snapshots\" attribute in api/cinder.py, this change would be unnecessary.","commit_id":"0e3008d8006013cdd9440f43663905bc1333d84f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2ce20e2e69084cfa44dbb36d8256f855c69c2bd7","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def get_data(self, request, group_id):"},{"line_number":111,"context_line":"        try:"},{"line_number":112,"context_line":"            return cinder.group_get_with_vol_type_names(request, group_id)"},{"line_number":113,"context_line":"        except cinder_exc.NotFound:"},{"line_number":114,"context_line":"            # NotFound error must be raised to make ajax UpdateRow work."},{"line_number":115,"context_line":"            raise"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_5158e354","line":112,"updated":"2019-02-23 06:05:54.000000000","message":"\"has_snapshots\" attribute is populated in project/volume_groups/views.py in the usual workflow.\nWhat we didn\u0027t covered is here. \"has_snapshots\" needs to be populated here.","commit_id":"0e3008d8006013cdd9440f43663905bc1333d84f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3feaea9bbc2089968d65ab3bcc6ea093885ab2f9","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def get_data(self, request, group_id):"},{"line_number":111,"context_line":"        try:"},{"line_number":112,"context_line":"            return cinder.group_get_with_vol_type_names(request, group_id)"},{"line_number":113,"context_line":"        except cinder_exc.NotFound:"},{"line_number":114,"context_line":"            # NotFound error must be raised to make ajax UpdateRow work."},{"line_number":115,"context_line":"            raise"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_75115253","line":112,"in_reply_to":"9fdfeff1_5158e354","updated":"2019-02-23 06:11:27.000000000","message":"More precisely, this is done at [1]. The same logic is required in UpdateRow.get_data().\n\n[1] https://github.com/openstack/horizon/blob/2aabd80b20c554d08dae9803717a18f529be5753/openstack_dashboard/dashboards/project/volume_groups/views.py#L59","commit_id":"0e3008d8006013cdd9440f43663905bc1333d84f"},{"author":{"_account_id":27822,"name":"pengyuesheng","email":"pengyuesheng@gohighsec.com","username":"pengyuesheng"},"change_message_id":"9ae7b841b94716d90a8a2ecb4f1c9c09214c7f06","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    def get_data(self, request, group_id):"},{"line_number":108,"context_line":"        group \u003d cinder.group_get_with_vol_type_names(request, group_id)"},{"line_number":109,"context_line":"        search_opts \u003d {\u0027group_id\u0027: group_id}"},{"line_number":110,"context_line":"        try:"},{"line_number":111,"context_line":"            group_snapshots \u003d cinder.group_snapshot_list("},{"line_number":112,"context_line":"                request, search_opts\u003dsearch_opts)"},{"line_number":113,"context_line":"            group.has_snapshots \u003d bool(group_snapshots)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9fdfeff1_2bf02767","line":110,"range":{"start_line":110,"start_character":8,"end_line":110,"end_character":12},"updated":"2019-02-26 03:43:15.000000000","message":"Could you move \"try\" to between L.107 and 108?","commit_id":"5e53e014d96e4a221be4479a1584c2b329fa7c9d"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6450bd2995c26089d3448aa8b43394925ce533b6","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    def get_data(self, request, group_id):"},{"line_number":108,"context_line":"        group \u003d cinder.group_get_with_vol_type_names(request, group_id)"},{"line_number":109,"context_line":"        search_opts \u003d {\u0027group_id\u0027: group_id}"},{"line_number":110,"context_line":"        try:"},{"line_number":111,"context_line":"            group_snapshots \u003d cinder.group_snapshot_list("},{"line_number":112,"context_line":"                request, search_opts\u003dsearch_opts)"},{"line_number":113,"context_line":"            group.has_snapshots \u003d bool(group_snapshots)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9fdfeff1_9a5f1a0e","line":110,"range":{"start_line":110,"start_character":8,"end_line":110,"end_character":12},"in_reply_to":"9fdfeff1_2bf02767","updated":"2019-02-26 05:51:18.000000000","message":"No, L.108 needs to be outside of this try/except.\nIt is handled by maybe_preempt() of DataTable class [1].\nThis is important to handle NotFound exception correctly by the data table. Previously L.112-114 did this, but it turns out to be unnecessary.\n\n[1] https://github.com/openstack/horizon/blob/master/horizon/tables/base.py#L1688-L1702","commit_id":"5e53e014d96e4a221be4479a1584c2b329fa7c9d"},{"author":{"_account_id":27822,"name":"pengyuesheng","email":"pengyuesheng@gohighsec.com","username":"pengyuesheng"},"change_message_id":"9baa4b4b8f7ef0c2e8c58b0dd31e516d632e8024","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    def get_data(self, request, group_id):"},{"line_number":108,"context_line":"        group \u003d cinder.group_get_with_vol_type_names(request, group_id)"},{"line_number":109,"context_line":"        search_opts \u003d {\u0027group_id\u0027: group_id}"},{"line_number":110,"context_line":"        try:"},{"line_number":111,"context_line":"            group_snapshots \u003d cinder.group_snapshot_list("},{"line_number":112,"context_line":"                request, search_opts\u003dsearch_opts)"},{"line_number":113,"context_line":"            group.has_snapshots \u003d bool(group_snapshots)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9fdfeff1_1a0b2ad5","line":110,"range":{"start_line":110,"start_character":8,"end_line":110,"end_character":12},"in_reply_to":"9fdfeff1_9a5f1a0e","updated":"2019-02-26 06:05:47.000000000","message":"thank you for your reply","commit_id":"5e53e014d96e4a221be4479a1584c2b329fa7c9d"}]}
