)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0d27860d9f69ee0180e73311cedee6d1367d9ff9","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Modify the success message of \u0027Edit\u0027 user information"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch add user name in sucess meassage"},{"line_number":10,"context_line":"when \u0027Edit\u0027 a user information."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ic43952c1388a055863a76719f239f9a6d1176fc1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5fc1f717_bf459619","line":9,"range":{"start_line":9,"start_character":28,"end_line":9,"end_character":34},"updated":"2019-03-07 10:47:20.000000000","message":"typo: success","commit_id":"c07b43839a39be240461051e721f78fb2e14d0a0"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"5e7b191b1dd1a3ece65ed5035230125119b97bf1","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Modify the success message of \u0027Edit\u0027 user information"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch add user name in sucess meassage"},{"line_number":10,"context_line":"when \u0027Edit\u0027 a user information."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ic43952c1388a055863a76719f239f9a6d1176fc1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5fc1f717_915af727","line":9,"range":{"start_line":9,"start_character":28,"end_line":9,"end_character":34},"in_reply_to":"5fc1f717_bf459619","updated":"2019-03-08 09:47:45.000000000","message":"done.\nthanks","commit_id":"c07b43839a39be240461051e721f78fb2e14d0a0"}],"openstack_dashboard/dashboards/identity/users/forms.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0d27860d9f69ee0180e73311cedee6d1367d9ff9","unresolved":false,"context_lines":[{"line_number":265,"context_line":"                data[\u0027email\u0027] \u003d data[\u0027email\u0027]"},{"line_number":266,"context_line":"            response \u003d api.keystone.user_update(request, user, **data)"},{"line_number":267,"context_line":"            messages.success(request,"},{"line_number":268,"context_line":"                             _(\u0027User %s has been updated \u0027"},{"line_number":269,"context_line":"                               \u0027successfully.\u0027) % data[\u0027name\u0027])"},{"line_number":270,"context_line":"        except exceptions.Conflict:"},{"line_number":271,"context_line":"            msg \u003d _(\u0027User name \"%s\" is already used.\u0027) % data[\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_1f54eac9","line":268,"range":{"start_line":268,"start_character":37,"end_line":268,"end_character":39},"updated":"2019-03-07 10:47:20.000000000","message":"It is better to quote the username.\n\n \"%s\"","commit_id":"c07b43839a39be240461051e721f78fb2e14d0a0"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"5e7b191b1dd1a3ece65ed5035230125119b97bf1","unresolved":false,"context_lines":[{"line_number":265,"context_line":"                data[\u0027email\u0027] \u003d data[\u0027email\u0027]"},{"line_number":266,"context_line":"            response \u003d api.keystone.user_update(request, user, **data)"},{"line_number":267,"context_line":"            messages.success(request,"},{"line_number":268,"context_line":"                             _(\u0027User %s has been updated \u0027"},{"line_number":269,"context_line":"                               \u0027successfully.\u0027) % data[\u0027name\u0027])"},{"line_number":270,"context_line":"        except exceptions.Conflict:"},{"line_number":271,"context_line":"            msg \u003d _(\u0027User name \"%s\" is already used.\u0027) % data[\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_5a0ee98d","line":268,"range":{"start_line":268,"start_character":37,"end_line":268,"end_character":39},"in_reply_to":"5fc1f717_1f54eac9","updated":"2019-03-08 09:47:45.000000000","message":"Done.\nthanks","commit_id":"c07b43839a39be240461051e721f78fb2e14d0a0"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0d27860d9f69ee0180e73311cedee6d1367d9ff9","unresolved":false,"context_lines":[{"line_number":273,"context_line":"            return False"},{"line_number":274,"context_line":"        except Exception:"},{"line_number":275,"context_line":"            response \u003d exceptions.handle(request, ignore\u003dTrue)"},{"line_number":276,"context_line":"            messages.error(request, _(\u0027Unable to update the user.\u0027))"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"        if isinstance(response, http.HttpResponse):"},{"line_number":279,"context_line":"            return response"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_df5f42e3","line":276,"updated":"2019-03-07 10:47:20.000000000","message":"It is better to add a username here too...","commit_id":"c07b43839a39be240461051e721f78fb2e14d0a0"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"34a4e2c2137e2f50c589f4e51ed6c9e610bede4a","unresolved":false,"context_lines":[{"line_number":273,"context_line":"            return False"},{"line_number":274,"context_line":"        except Exception:"},{"line_number":275,"context_line":"            response \u003d exceptions.handle(request, ignore\u003dTrue)"},{"line_number":276,"context_line":"            messages.error(request, _(\u0027Unable to update the user.\u0027))"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"        if isinstance(response, http.HttpResponse):"},{"line_number":279,"context_line":"            return response"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_8372727a","line":276,"in_reply_to":"5fc1f717_8e2bb22e","updated":"2019-03-12 09:54:50.000000000","message":"While updating the \u0027data\u0027 dict at L#268, when the keystoneclient isn\u0027t able to edit data, keystone client exception is raised and \u0027name\u0027 key isn\u0027t updated in \u0027data\u0027 dict.\nSo it\u0027s not certain that \u0027name\u0027 key will always be available here therefore UTs failed.\nI\u0027ve restored it to previous code, kindly suggest if it can be updated alternatively.","commit_id":"c07b43839a39be240461051e721f78fb2e14d0a0"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"5e7b191b1dd1a3ece65ed5035230125119b97bf1","unresolved":false,"context_lines":[{"line_number":273,"context_line":"            return False"},{"line_number":274,"context_line":"        except Exception:"},{"line_number":275,"context_line":"            response \u003d exceptions.handle(request, ignore\u003dTrue)"},{"line_number":276,"context_line":"            messages.error(request, _(\u0027Unable to update the user.\u0027))"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"        if isinstance(response, http.HttpResponse):"},{"line_number":279,"context_line":"            return response"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_8e2bb22e","line":276,"in_reply_to":"5fc1f717_df5f42e3","updated":"2019-03-08 09:47:45.000000000","message":"done.\nthanks","commit_id":"c07b43839a39be240461051e721f78fb2e14d0a0"}]}
