)]}'
{"openstack_dashboard/dashboards/admin/volume_types/extras/forms.py":[{"author":{"_account_id":27822,"name":"pengyuesheng","email":"pengyuesheng@gohighsec.com","username":"pengyuesheng"},"change_message_id":"c733037f3a7d828fdbeef2beb8256e0a974708be","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def handle(self, request, data):"},{"line_number":38,"context_line":"        type_id \u003d self.initial[\u0027type_id\u0027]"},{"line_number":39,"context_line":"        error_msg \u003d _(\u0027key with name \"%s\" already exists.Use Edit to \u0027"},{"line_number":40,"context_line":"                      \u0027update the value, else create key with different \u0027"},{"line_number":41,"context_line":"                      \u0027name.\u0027) % data[\u0027key\u0027]"},{"line_number":42,"context_line":"        try:"},{"line_number":43,"context_line":"            extras_list \u003d api.cinder.volume_type_extra_get(self.request,"},{"line_number":44,"context_line":"                                                           type_id)"},{"line_number":45,"context_line":"            for extra in extras_list:"},{"line_number":46,"context_line":"                if extra.key.lower() \u003d\u003d data[\u0027key\u0027].lower():"},{"line_number":47,"context_line":"                    raise forms.ValidationError(error_msg)"},{"line_number":48,"context_line":"            api.cinder.volume_type_extra_set(request,"},{"line_number":49,"context_line":"                                             type_id,"},{"line_number":50,"context_line":"                                             {data[\u0027key\u0027]: data[\u0027value\u0027]})"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_73668ff0","line":47,"range":{"start_line":39,"start_character":8,"end_line":47,"end_character":58},"updated":"2019-03-07 07:14:43.000000000","message":"Why not use clean_x","commit_id":"6b5de60098b087871f71a2715ce52ca78ee03a87"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"fca28a71bb134e69167889b159db7a6241fe1640","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def handle(self, request, data):"},{"line_number":38,"context_line":"        type_id \u003d self.initial[\u0027type_id\u0027]"},{"line_number":39,"context_line":"        error_msg \u003d _(\u0027key with name \"%s\" already exists.Use Edit to \u0027"},{"line_number":40,"context_line":"                      \u0027update the value, else create key with different \u0027"},{"line_number":41,"context_line":"                      \u0027name.\u0027) % data[\u0027key\u0027]"},{"line_number":42,"context_line":"        try:"},{"line_number":43,"context_line":"            extras_list \u003d api.cinder.volume_type_extra_get(self.request,"},{"line_number":44,"context_line":"                                                           type_id)"},{"line_number":45,"context_line":"            for extra in extras_list:"},{"line_number":46,"context_line":"                if extra.key.lower() \u003d\u003d data[\u0027key\u0027].lower():"},{"line_number":47,"context_line":"                    raise forms.ValidationError(error_msg)"},{"line_number":48,"context_line":"            api.cinder.volume_type_extra_set(request,"},{"line_number":49,"context_line":"                                             type_id,"},{"line_number":50,"context_line":"                                             {data[\u0027key\u0027]: data[\u0027value\u0027]})"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_89f508ce","line":47,"range":{"start_line":39,"start_character":8,"end_line":47,"end_character":58},"in_reply_to":"5fc1f717_73668ff0","updated":"2019-03-07 09:20:51.000000000","message":"+1\n\nclean() method should be used at least.","commit_id":"6b5de60098b087871f71a2715ce52ca78ee03a87"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"4eec3c7c68a170ebc868843fc8b412aaaf8052a9","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def handle(self, request, data):"},{"line_number":38,"context_line":"        type_id \u003d self.initial[\u0027type_id\u0027]"},{"line_number":39,"context_line":"        error_msg \u003d _(\u0027key with name \"%s\" already exists.Use Edit to \u0027"},{"line_number":40,"context_line":"                      \u0027update the value, else create key with different \u0027"},{"line_number":41,"context_line":"                      \u0027name.\u0027) % data[\u0027key\u0027]"},{"line_number":42,"context_line":"        try:"},{"line_number":43,"context_line":"            extras_list \u003d api.cinder.volume_type_extra_get(self.request,"},{"line_number":44,"context_line":"                                                           type_id)"},{"line_number":45,"context_line":"            for extra in extras_list:"},{"line_number":46,"context_line":"                if extra.key.lower() \u003d\u003d data[\u0027key\u0027].lower():"},{"line_number":47,"context_line":"                    raise forms.ValidationError(error_msg)"},{"line_number":48,"context_line":"            api.cinder.volume_type_extra_set(request,"},{"line_number":49,"context_line":"                                             type_id,"},{"line_number":50,"context_line":"                                             {data[\u0027key\u0027]: data[\u0027value\u0027]})"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_96048016","line":47,"range":{"start_line":39,"start_character":8,"end_line":47,"end_character":58},"in_reply_to":"5fc1f717_89f508ce","updated":"2019-03-18 16:08:04.000000000","message":"Done.\nthanks.","commit_id":"6b5de60098b087871f71a2715ce52ca78ee03a87"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"789596a4cdc98cfefd6ed2bfc89d1dd484329f88","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    def clean(self):"},{"line_number":38,"context_line":"        data \u003d super(CreateExtraSpec, self).clean()"},{"line_number":39,"context_line":"        type_id \u003d self.initial[\u0027type_id\u0027]"},{"line_number":40,"context_line":"        extras_list \u003d api.cinder.volume_type_extra_get(self.request,"},{"line_number":41,"context_line":"                                                       type_id)"},{"line_number":42,"context_line":"        for extra in extras_list:"},{"line_number":43,"context_line":"            if extra.key.lower() \u003d\u003d data[\u0027key\u0027].lower():"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_c271d00e","line":40,"range":{"start_line":40,"start_character":7,"end_line":40,"end_character":19},"updated":"2019-03-19 10:05:25.000000000","message":"nit: the variable name sounds odd a bit. Consider \"extra_list\" or \"extras\" instead. \"\u003cplural\u003e_list\" means a list of collection of something.","commit_id":"9e71c03119ac14671df7e2ae4534e7b2ce2ebffc"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"9ef83e7782ba4bd5ee6aa0af20a7db3bad2eb580","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    def clean(self):"},{"line_number":38,"context_line":"        data \u003d super(CreateExtraSpec, self).clean()"},{"line_number":39,"context_line":"        type_id \u003d self.initial[\u0027type_id\u0027]"},{"line_number":40,"context_line":"        extras_list \u003d api.cinder.volume_type_extra_get(self.request,"},{"line_number":41,"context_line":"                                                       type_id)"},{"line_number":42,"context_line":"        for extra in extras_list:"},{"line_number":43,"context_line":"            if extra.key.lower() \u003d\u003d data[\u0027key\u0027].lower():"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_2ffe786b","line":40,"range":{"start_line":40,"start_character":7,"end_line":40,"end_character":19},"in_reply_to":"5fc1f717_c271d00e","updated":"2019-03-19 12:46:09.000000000","message":"done.\nthanks","commit_id":"9e71c03119ac14671df7e2ae4534e7b2ce2ebffc"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"789596a4cdc98cfefd6ed2bfc89d1dd484329f88","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                                                       type_id)"},{"line_number":42,"context_line":"        for extra in extras_list:"},{"line_number":43,"context_line":"            if extra.key.lower() \u003d\u003d data[\u0027key\u0027].lower():"},{"line_number":44,"context_line":"                error_msg \u003d _(\u0027key with name \"%s\" already exists.Use Edit to \u0027"},{"line_number":45,"context_line":"                              \u0027update the value, else create key with \u0027"},{"line_number":46,"context_line":"                              \u0027different name.\u0027) % data[\u0027key\u0027]"},{"line_number":47,"context_line":"                raise forms.ValidationError(error_msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_e2d88cf1","line":44,"range":{"start_line":44,"start_character":31,"end_line":44,"end_character":34},"updated":"2019-03-19 10:05:25.000000000","message":"- Capitalize the first word of a sentence.\n- Add a space after a period.","commit_id":"9e71c03119ac14671df7e2ae4534e7b2ce2ebffc"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"9ef83e7782ba4bd5ee6aa0af20a7db3bad2eb580","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                                                       type_id)"},{"line_number":42,"context_line":"        for extra in extras_list:"},{"line_number":43,"context_line":"            if extra.key.lower() \u003d\u003d data[\u0027key\u0027].lower():"},{"line_number":44,"context_line":"                error_msg \u003d _(\u0027key with name \"%s\" already exists.Use Edit to \u0027"},{"line_number":45,"context_line":"                              \u0027update the value, else create key with \u0027"},{"line_number":46,"context_line":"                              \u0027different name.\u0027) % data[\u0027key\u0027]"},{"line_number":47,"context_line":"                raise forms.ValidationError(error_msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_0f685c1f","line":44,"range":{"start_line":44,"start_character":31,"end_line":44,"end_character":34},"in_reply_to":"5fc1f717_e2d88cf1","updated":"2019-03-19 12:46:09.000000000","message":"done.\nthanks","commit_id":"9e71c03119ac14671df7e2ae4534e7b2ce2ebffc"}]}
