)]}'
{"openstack_dashboard/dashboards/project/instances/views.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"68ca041e00ba102f86cdb79ad2de199335057e2c","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        # Gather our images to correlate our instances to them"},{"line_number":83,"context_line":"        try:"},{"line_number":84,"context_line":"            # Community images have to be retrieved separately and merged,"},{"line_number":85,"context_line":"            # because their visibility has to be explicitly defined in the"},{"line_number":86,"context_line":"            # API call and the Glance API currently does not support filtering"},{"line_number":87,"context_line":"            # by multiple values in the visibility field."},{"line_number":88,"context_line":"            # TODO(gabriel): Handle pagination."},{"line_number":89,"context_line":"            images \u003d api.glance.image_list_detailed(self.request)[0]"},{"line_number":90,"context_line":"            community_images \u003d api.glance.image_list_detailed("}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_1db6e33f","line":87,"range":{"start_line":85,"start_character":29,"end_line":87,"end_character":57},"updated":"2019-03-12 08:08:15.000000000","message":"Do we have any bug or blueprint filed for glance?","commit_id":"84b733de5b07ddc5c50c05b635104f183a1b538c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e4d3f8bca9af27000fea9097f0d565e44e91b7f0","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                image.id: image for image in images"},{"line_number":94,"context_line":"            }"},{"line_number":95,"context_line":"            # Images have to be filtered by their uuids; some users"},{"line_number":96,"context_line":"            # have default access to certain community images."},{"line_number":97,"context_line":"            for image in community_images:"},{"line_number":98,"context_line":"                image_map.setdefault(image.id, image)"},{"line_number":99,"context_line":"            return image_map"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_15828e50","line":96,"updated":"2019-06-19 05:52:18.000000000","message":"(question from curiosity)\n\nis there any negative impact if we override certain community image info by the response of community image list?","commit_id":"6f807b6b05ea4a9df93ed23111f10a5041377612"},{"author":{"_account_id":26546,"name":"Marek Lyčka","email":"marek.lycka@ultimum.io","username":"mareklycka"},"change_message_id":"ef780f5e63e4f1b087af247c3f79cc7f0b03abe2","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                image.id: image for image in images"},{"line_number":94,"context_line":"            }"},{"line_number":95,"context_line":"            # Images have to be filtered by their uuids; some users"},{"line_number":96,"context_line":"            # have default access to certain community images."},{"line_number":97,"context_line":"            for image in community_images:"},{"line_number":98,"context_line":"                image_map.setdefault(image.id, image)"},{"line_number":99,"context_line":"            return image_map"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_b5f702d5","line":96,"in_reply_to":"9fb8cfa7_15828e50","updated":"2019-06-19 06:07:03.000000000","message":"setdefault shouldn\u0027t overwrite an existing key, i.e. if the community image was retrieved in the general retrieval call, the image_map dictionary should contain that instance, not the one from the filtered call.\n\nThat said, since both retrievals are done using api.glance.image_list_detailed, the retrieved data should be exactly the same if a single image is retrieved twice.\n\n...unless the image changes in-between the two calls. Then you\u0027d technically have an out of date version. Arguably that\u0027s no different to a change being made between the image being loaded and rendered though.","commit_id":"6f807b6b05ea4a9df93ed23111f10a5041377612"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6b9136db13a2f78a2fdc9f84c2ff9608cefdbcbd","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                image.id: image for image in images"},{"line_number":94,"context_line":"            }"},{"line_number":95,"context_line":"            # Images have to be filtered by their uuids; some users"},{"line_number":96,"context_line":"            # have default access to certain community images."},{"line_number":97,"context_line":"            for image in community_images:"},{"line_number":98,"context_line":"                image_map.setdefault(image.id, image)"},{"line_number":99,"context_line":"            return image_map"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_9b178dee","line":96,"in_reply_to":"9fb8cfa7_b5f702d5","updated":"2019-06-19 08:22:32.000000000","message":"Thanks. I just wondered there is some corner case when maintaining the code, but it turns out it is just a taste-of-matter. I am relieved.","commit_id":"6f807b6b05ea4a9df93ed23111f10a5041377612"}]}