)]}'
{"openstack_dashboard/dashboards/project/volumes/forms.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b47c403d0b421b5b77301d304fa7bee007475443","unresolved":false,"context_lines":[{"line_number":818,"context_line":"                      for t in volume_types]"},{"line_number":819,"context_line":""},{"line_number":820,"context_line":"        if types_list:"},{"line_number":821,"context_line":"            types_list.insert(0, (\"\", _(\"Select a new volume type\")))"},{"line_number":822,"context_line":"        else:"},{"line_number":823,"context_line":"            types_list.insert(0, (\"\", _(\"No other volume types available\")))"},{"line_number":824,"context_line":"        self.fields[\u0027volume_type\u0027].choices \u003d sorted(types_list)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_d7dca1e5","line":821,"updated":"2019-03-13 07:43:09.000000000","message":"When I tested this patch, I noticed this message is no longer meaningless.\nInstead, it looks better to add \" (current)\" suffix to the current volume type like \"lvmdriver-1 (current)\".","commit_id":"78c4c20df409ca5311a2f8a8a72c75f9b27f620a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b47c403d0b421b5b77301d304fa7bee007475443","unresolved":false,"context_lines":[{"line_number":826,"context_line":"    def clean_volume_type(self):"},{"line_number":827,"context_line":"        volume_type \u003d self.cleaned_data.get(\"volume_type\")"},{"line_number":828,"context_line":"        if self.initial[\u0027volume_type\u0027] \u003d\u003d volume_type:"},{"line_number":829,"context_line":"            msg \u003d _(\u0027The \"Type\" selected must be different from the \u0027"},{"line_number":830,"context_line":"                    \u0027current volume type.\u0027)"},{"line_number":831,"context_line":"            raise forms.ValidationError(msg)"},{"line_number":832,"context_line":"        return volume_type"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_f7d99df2","line":829,"updated":"2019-03-13 07:43:09.000000000","message":"The \"Type\" selected -\u003e The selected type","commit_id":"78c4c20df409ca5311a2f8a8a72c75f9b27f620a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c6cd72f056596f6d2ba0a6482f2619fbad87970e","unresolved":false,"context_lines":[{"line_number":815,"context_line":"            exceptions.handle(request, error_message, redirect\u003dredirect_url)"},{"line_number":816,"context_line":""},{"line_number":817,"context_line":"        origin_type \u003d self.initial[\u0027volume_type\u0027]"},{"line_number":818,"context_line":"        types_list \u003d [(t.name,"},{"line_number":819,"context_line":"                       origin_type\u003d\u003dt.name and t.name + \"(current)\" or t.name)"},{"line_number":820,"context_line":"                      for t in volume_types]"},{"line_number":821,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_6f85bc59","line":818,"updated":"2019-03-14 04:06:01.000000000","message":"How about the following? \"x if cond else y\" is more straight-forward than \"cond and x or y\".\n\n  type_list \u003d [(t.name,\n                _(\"%s (current)\") % t.name\n                if origin_type \u003d\u003d t.name else t.name]\n\nIn addition, \nnit: s/types_list/type_list/","commit_id":"db25b9c255e9d1e1cadefb73996ac25c72ec894e"},{"author":{"_account_id":27822,"name":"pengyuesheng","email":"pengyuesheng@gohighsec.com","username":"pengyuesheng"},"change_message_id":"8d8413500ae1bb2992fa166feb30ce6abe54885f","unresolved":false,"context_lines":[{"line_number":815,"context_line":"            exceptions.handle(request, error_message, redirect\u003dredirect_url)"},{"line_number":816,"context_line":""},{"line_number":817,"context_line":"        origin_type \u003d self.initial[\u0027volume_type\u0027]"},{"line_number":818,"context_line":"        types_list \u003d [(t.name,"},{"line_number":819,"context_line":"                       origin_type\u003d\u003dt.name and t.name + \"(current)\" or t.name)"},{"line_number":820,"context_line":"                      for t in volume_types]"},{"line_number":821,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_f70debe7","line":818,"in_reply_to":"5fc1f717_6f85bc59","updated":"2019-03-15 07:54:34.000000000","message":"Done","commit_id":"db25b9c255e9d1e1cadefb73996ac25c72ec894e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c6cd72f056596f6d2ba0a6482f2619fbad87970e","unresolved":false,"context_lines":[{"line_number":816,"context_line":""},{"line_number":817,"context_line":"        origin_type \u003d self.initial[\u0027volume_type\u0027]"},{"line_number":818,"context_line":"        types_list \u003d [(t.name,"},{"line_number":819,"context_line":"                       origin_type\u003d\u003dt.name and t.name + \"(current)\" or t.name)"},{"line_number":820,"context_line":"                      for t in volume_types]"},{"line_number":821,"context_line":""},{"line_number":822,"context_line":"        if types_list:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_af47244c","line":819,"range":{"start_line":819,"start_character":56,"end_line":819,"end_character":66},"updated":"2019-03-14 04:06:01.000000000","message":"This needs to be translatable. Consider \"%s (current)\" instead.","commit_id":"db25b9c255e9d1e1cadefb73996ac25c72ec894e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c6cd72f056596f6d2ba0a6482f2619fbad87970e","unresolved":false,"context_lines":[{"line_number":820,"context_line":"                      for t in volume_types]"},{"line_number":821,"context_line":""},{"line_number":822,"context_line":"        if types_list:"},{"line_number":823,"context_line":"            types_list.insert(0, (\"\", _(\"Select a new volume type\")))"},{"line_number":824,"context_line":"        else:"},{"line_number":825,"context_line":"            types_list.insert(0, (\"\", _(\"No other volume types available\")))"},{"line_number":826,"context_line":"        self.fields[\u0027volume_type\u0027].choices \u003d sorted(types_list)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_ef6a0cb1","line":823,"range":{"start_line":823,"start_character":11,"end_line":823,"end_character":69},"updated":"2019-03-14 04:06:01.000000000","message":"Could you drop this? The default value is the current volume type, so this message is shown only after the dropdown list is opened. I think this is redundant.","commit_id":"db25b9c255e9d1e1cadefb73996ac25c72ec894e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c6cd72f056596f6d2ba0a6482f2619fbad87970e","unresolved":false,"context_lines":[{"line_number":828,"context_line":"    def clean_volume_type(self):"},{"line_number":829,"context_line":"        volume_type \u003d self.cleaned_data.get(\"volume_type\")"},{"line_number":830,"context_line":"        if self.initial[\u0027volume_type\u0027] \u003d\u003d volume_type:"},{"line_number":831,"context_line":"            msg \u003d _(\u0027The selected type must be different from the \u0027"},{"line_number":832,"context_line":"                    \u0027current volume type.\u0027)"},{"line_number":833,"context_line":"            raise forms.ValidationError(msg)"},{"line_number":834,"context_line":"        return volume_type"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_0f7518cb","line":831,"range":{"start_line":831,"start_character":25,"end_line":831,"end_character":33},"updated":"2019-03-14 04:06:01.000000000","message":"selected -\u003e new\n\n\"new\" looks more appropriate.","commit_id":"db25b9c255e9d1e1cadefb73996ac25c72ec894e"}]}
