)]}'
{"horizon/static/horizon/js/horizon.d3linechart.js":[{"author":{"_account_id":9692,"name":"Gabriel Pettier","email":"gabriel.pettier@cloudwatt.com","username":"Gabriel-Pettier"},"change_message_id":"e3d9e7652bb3c0f4b4e7a490ef5f7c98afa4d234","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":" Example:"},{"line_number":23,"context_line":" \u003cdiv id\u003d\"line_chart\""},{"line_number":24,"context_line":" data-chart-type\u003d\"line_chart\""},{"line_number":25,"context_line":" data-url\u003d\"{% url \u0027horizon:admin:metering:samples\u0027%}\""},{"line_number":26,"context_line":" data-form-selector\u003d\u0027#linechart_general_form\u0027\u003e"}],"source_content_type":"text/javascript","patch_set":1,"id":"AAAAT3%2F%2F07o%3D","line":23,"updated":"2013-12-30 16:28:43.000000000","message":"Wouldn\u0027t it be better to preserve html indent here? (and in the other examples below)","commit_id":"9fa1fffd3405bdbccacb2bd64d324ba88ea8e134"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"243ff586775b63f8ba0906db4f36206034b06169","unresolved":false,"context_lines":[{"line_number":273,"context_line":"      // allowed: verbose"},{"line_number":274,"context_line":"      self.hover_formatter \u003d \u0027verbose\u0027;"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"      /* Applying settings. The later application rewrites the previous"},{"line_number":277,"context_line":"       therefore it has bigger priority. */"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"      // Settings defined in the init method of the chart"}],"source_content_type":"text/javascript","patch_set":3,"id":"AAAAT3%2F%2FwoA%3D","line":276,"updated":"2014-01-02 08:06:22.000000000","message":"Instead of this format, can you change it to:\n\n/*\n  Applying...\n*/\n\nThat way the text would be all aligned and looks cleaner.","commit_id":"9665ab18752c09cc073ca0bedbbf8edbb70f80e1"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"243ff586775b63f8ba0906db4f36206034b06169","unresolved":false,"context_lines":[{"line_number":316,"context_line":"    self.get_size \u003d function(){"},{"line_number":317,"context_line":"      /* The height will be determined by css or window size,"},{"line_number":318,"context_line":"       I have to hide everything inside that could mess with"},{"line_number":319,"context_line":"       the size, so it is fully determined by outer CSS. */"},{"line_number":320,"context_line":"      $(self.html_element).css(\u0027height\u0027, \u0027\u0027);"},{"line_number":321,"context_line":"      $(self.html_element).css(\u0027width\u0027, \u0027\u0027);"},{"line_number":322,"context_line":"      var svg \u003d $(self.html_element).find(\u0027svg\u0027);"}],"source_content_type":"text/javascript","patch_set":3,"id":"AAAAT3%2F%2Fwn8%3D","line":319,"updated":"2014-01-02 08:06:22.000000000","message":"same here","commit_id":"9665ab18752c09cc073ca0bedbbf8edbb70f80e1"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"243ff586775b63f8ba0906db4f36206034b06169","unresolved":false,"context_lines":[{"line_number":329,"context_line":"      // Set either the minimal height defined by CSS."},{"line_number":330,"context_line":"      self.height \u003d jquery_element.height();"},{"line_number":331,"context_line":"      /* Or stretch it to the remaining height of the window if there"},{"line_number":332,"context_line":"       is a place. + some space on the bottom, lets say 30px. */"},{"line_number":333,"context_line":"      if (self.settings.auto_size) {"},{"line_number":334,"context_line":"        var auto_height \u003d $(window).height() - jquery_element.offset().top - 30;"},{"line_number":335,"context_line":"        if (auto_height \u003e self.height) {"}],"source_content_type":"text/javascript","patch_set":3,"id":"AAAAT3%2F%2Fwn4%3D","line":332,"updated":"2014-01-02 08:06:22.000000000","message":"same here","commit_id":"9665ab18752c09cc073ca0bedbbf8edbb70f80e1"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"243ff586775b63f8ba0906db4f36206034b06169","unresolved":false,"context_lines":[{"line_number":348,"context_line":"    /************************************************************************/"},{"line_number":349,"context_line":"    /****************************** Initialization **************************/"},{"line_number":350,"context_line":"    /************************************************************************/"},{"line_number":351,"context_line":"      // Init of the object"},{"line_number":352,"context_line":"    self.init();"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"    /************************************************************************/"}],"source_content_type":"text/javascript","patch_set":3,"id":"AAAAT3%2F%2Fwn0%3D","line":351,"updated":"2014-01-02 08:06:22.000000000","message":"why the need for indent here?","commit_id":"9665ab18752c09cc073ca0bedbbf8edbb70f80e1"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"243ff586775b63f8ba0906db4f36206034b06169","unresolved":false,"context_lines":[{"line_number":432,"context_line":"        yMax: self.settings.yMax,"},{"line_number":433,"context_line":"      });"},{"line_number":434,"context_line":""},{"line_number":435,"context_line":"      /* TODO(lsmola) add JQuery UI slider to make this work"},{"line_number":436,"context_line":"        if (self.slider_element) {"},{"line_number":437,"context_line":"          var slider \u003d new Rickshaw.Graph.RangeSlider({"},{"line_number":438,"context_line":"            graph: graph,"}],"source_content_type":"text/javascript","patch_set":3,"id":"AAAAT3%2F%2Fwnw%3D","line":435,"updated":"2014-01-02 08:06:22.000000000","message":"same here","commit_id":"9665ab18752c09cc073ca0bedbbf8edbb70f80e1"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"243ff586775b63f8ba0906db4f36206034b06169","unresolved":false,"context_lines":[{"line_number":488,"context_line":"        axes_y.render();"},{"line_number":489,"context_line":"      }"},{"line_number":490,"context_line":""},{"line_number":491,"context_line":"      /* Setting a fix height breaks things when chart is refreshed and"},{"line_number":492,"context_line":"       legend is getting bigger. */"},{"line_number":493,"context_line":"      $(self.legend_element).css(\u0027height\u0027, \u0027\u0027);"},{"line_number":494,"context_line":""}],"source_content_type":"text/javascript","patch_set":3,"id":"AAAAT3%2F%2Fwns%3D","line":491,"updated":"2014-01-02 08:06:22.000000000","message":"here too","commit_id":"9665ab18752c09cc073ca0bedbbf8edbb70f80e1"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"243ff586775b63f8ba0906db4f36206034b06169","unresolved":false,"context_lines":[{"line_number":540,"context_line":"      // Show the spinner."},{"line_number":541,"context_line":"      self.spinner \u003d $(\u0027\u003cdiv class\u003d\"spinner_wrapper\"\u003e\u003c/div\u003e\u0027);"},{"line_number":542,"context_line":"      $(self.html_element).append(self.spinner);"},{"line_number":543,"context_line":"      /* TODO(lsmola) a loader for in-line tables spark-lines has to be"},{"line_number":544,"context_line":"       prepared, the parameters of loader could be sent in settings. */"},{"line_number":545,"context_line":"      self.spinner.spin(horizon.conf.spinner_options.line_chart);"},{"line_number":546,"context_line":""}],"source_content_type":"text/javascript","patch_set":3,"id":"AAAAT3%2F%2Fwno%3D","line":543,"updated":"2014-01-02 08:06:22.000000000","message":"same here","commit_id":"9665ab18752c09cc073ca0bedbbf8edbb70f80e1"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"243ff586775b63f8ba0906db4f36206034b06169","unresolved":false,"context_lines":[{"line_number":579,"context_line":"    });"},{"line_number":580,"context_line":""},{"line_number":581,"context_line":"    if (settings !\u003d\u003d undefined \u0026\u0026 settings.auto_resize) {"},{"line_number":582,"context_line":"      /* I want to refresh chart on resize of the window, but only"},{"line_number":583,"context_line":"       at the end of the resize. Nice code from mr. Google. */"},{"line_number":584,"context_line":"      var rtime \u003d new Date(1, 1, 2000, 12, 0, 0);"},{"line_number":585,"context_line":"      var timeout \u003d false;"}],"source_content_type":"text/javascript","patch_set":3,"id":"AAAAT3%2F%2Fwnk%3D","line":582,"updated":"2014-01-02 08:06:22.000000000","message":"and here :)","commit_id":"9665ab18752c09cc073ca0bedbbf8edbb70f80e1"}],"horizon/static/horizon/js/horizon.heattop.js":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"243ff586775b63f8ba0906db4f36206034b06169","unresolved":false,"context_lines":[{"line_number":8,"context_line":" * Stacks, Resources, and related Properties in a Resource Topology Graph."},{"line_number":9,"context_line":" *"},{"line_number":10,"context_line":" * Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":11,"context_line":" not use this file except in compliance with the License. You may obtain"},{"line_number":12,"context_line":" a copy of the License at"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":" http://www.apache.org/licenses/LICENSE-2.0"}],"source_content_type":"text/javascript","patch_set":3,"id":"AAAAT3%2F%2FwoM%3D","line":11,"updated":"2014-01-02 08:06:22.000000000","message":"Can you put an \"* \" so that the remaining comments aligned with \"Licensed\"? It would be a lot easier to read that way.","commit_id":"9665ab18752c09cc073ca0bedbbf8edbb70f80e1"}],"horizon/static/horizon/js/horizon.modals.js":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"243ff586775b63f8ba0906db4f36206034b06169","unresolved":false,"context_lines":[{"line_number":185,"context_line":"      },"},{"line_number":186,"context_line":"      success: function (data, textStatus, jqXHR) {"},{"line_number":187,"context_line":"        var update_field_id \u003d $this.attr(\u0027data-add-to-field\u0027),"},{"line_number":188,"context_line":"          modal, form;"},{"line_number":189,"context_line":"        modal \u003d horizon.modals.success(data, textStatus, jqXHR);"},{"line_number":190,"context_line":"        if (update_field_id) {"},{"line_number":191,"context_line":"          form \u003d modal.find(\"form\");"}],"source_content_type":"text/javascript","patch_set":3,"id":"AAAAT3%2F%2FwpY%3D","line":188,"updated":"2014-01-02 08:06:22.000000000","message":"Should \"form\" move to next line as well?","commit_id":"9665ab18752c09cc073ca0bedbbf8edbb70f80e1"}],"horizon/static/horizon/js/horizon.networktopology.js":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"243ff586775b63f8ba0906db4f36206034b06169","unresolved":false,"context_lines":[{"line_number":283,"context_line":"        this.appendChild(d3.select(device_template).node().cloneNode(true));"},{"line_number":284,"context_line":"      });"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    device_enter.on(\u0027mouseenter\u0027,function(d){"},{"line_number":287,"context_line":"      var $this \u003d $(this);"},{"line_number":288,"context_line":"      self.show_balloon(d,$this);"},{"line_number":289,"context_line":"    })"}],"source_content_type":"text/javascript","patch_set":3,"id":"AAAAT3%2F%2Fwo8%3D","line":286,"updated":"2014-01-02 08:06:22.000000000","message":"Move the .on() method to next line for consistency with the succeeding code.","commit_id":"9665ab18752c09cc073ca0bedbbf8edbb70f80e1"}],"horizon/static/horizon/js/horizon.tables.js":[{"author":{"_account_id":9692,"name":"Gabriel Pettier","email":"gabriel.pettier@cloudwatt.com","username":"Gabriel-Pettier"},"change_message_id":"e3d9e7652bb3c0f4b4e7a490ef5f7c98afa4d234","unresolved":false,"context_lines":[{"line_number":183,"context_line":"  },"},{"line_number":184,"context_line":"  // compare int values"},{"line_number":185,"context_line":"  format: function(s) {"},{"line_number":186,"context_line":"    var sizes \u003d {BYTE: 0, B: 0, KB: 1, MB: 2,"},{"line_number":187,"context_line":"      GB: 3, TB: 4, PB: 5};"},{"line_number":188,"context_line":"    var regex \u003d /([\\d\\.,]+)\\s*(byte|B|KB|MB|GB|TB|PB)+/i;"},{"line_number":189,"context_line":"    var match \u003d s.match(regex);"}],"source_content_type":"text/javascript","patch_set":1,"id":"AAAAT3%2F%2F0%2FQ%3D","line":186,"updated":"2013-12-30 16:28:43.000000000","message":"NIT: maybe go to next line after { for alignment?\n\n(edit: it\u0027ll probably even fit on one line then)","commit_id":"9fa1fffd3405bdbccacb2bd64d324ba88ea8e134"}],"horizon/static/horizon/tests/tables.js":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"243ff586775b63f8ba0906db4f36206034b06169","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"test(\"Footer count update\", function () {"},{"line_number":24,"context_line":"  var fixture \u003d $(\"#qunit-fixture\");"},{"line_number":25,"context_line":"  var table \u003d  fixture.find(\"#table1\");"},{"line_number":26,"context_line":"  var tbody \u003d table.find(\u0027tbody\u0027);"},{"line_number":27,"context_line":"  var table_count \u003d table.find(\"span.table_count\");"},{"line_number":28,"context_line":"  var rows \u003d tbody.find(\u0027tr\u0027);"}],"source_content_type":"text/javascript","patch_set":3,"id":"AAAAT3%2F%2Fwpo%3D","line":25,"updated":"2014-01-02 08:06:22.000000000","message":"Extra space after the \"\u003d\" sign. Not part of the change, but can you please fix this as well.","commit_id":"9665ab18752c09cc073ca0bedbbf8edbb70f80e1"}]}