)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"cff032d8a628dd2b2b3773b992068111650c5b2f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It was created a validation that checks if an external url location"},{"line_number":10,"context_line":"provided for a new image is valid and reacheable.  This change pretends"},{"line_number":11,"context_line":"to ensure that only valid images are hosted."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I63dd52866956b0f0af85973b9f026f77a5acb712"},{"line_number":14,"context_line":"Closes-Bug: #1261893"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAT3%2F%2Fv9U%3D","line":11,"updated":"2014-01-02 12:31:19.000000000","message":"A validation was created that checks if...\n\nThis change ensures that...\n(there is no pretending here)","commit_id":"a8c2f40e72a733c7c702640f4aaa3f376c6628c6"}],"openstack_dashboard/dashboards/project/images_and_snapshots/images/forms.py":[{"author":{"_account_id":9692,"name":"Gabriel Pettier","email":"gabriel.pettier@cloudwatt.com","username":"Gabriel-Pettier"},"change_message_id":"4694faf09c9c1e3a85d48ed316141b019968893c","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        if copy_from:"},{"line_number":132,"context_line":"            self._check_copy_from(copy_from)"},{"line_number":133,"context_line":"            if image_file:"},{"line_number":134,"context_line":"                raise ValidationError("},{"line_number":135,"context_line":"                    _(\"Can not specify both image and external image \""},{"line_number":136,"context_line":"                      \"location.\"))"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAT3%2F%2F1YM%3D","line":133,"updated":"2013-12-30 13:57:45.000000000","message":"NIT: Maybe better to do that check before trying to download the image?","commit_id":"984c6191d9ec1b103b8c5fde8628fd209613fdfe"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"cff032d8a628dd2b2b3773b992068111650c5b2f","unresolved":false,"context_lines":[{"line_number":22,"context_line":"Views for managing images."},{"line_number":23,"context_line":"\"\"\""},{"line_number":24,"context_line":"from django.conf import settings  # noqa"},{"line_number":25,"context_line":"from django.core.validators import URLValidator  # noqa"},{"line_number":26,"context_line":"from django.forms import ValidationError  # noqa"},{"line_number":27,"context_line":"from django.forms.widgets import HiddenInput  # noqa"},{"line_number":28,"context_line":"from django.utils.translation import ugettext_lazy as _  # noqa"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAT3%2F%2Fv%2BE%3D","line":25,"updated":"2014-01-02 12:31:19.000000000","message":"Wouldn\u0027t it be better to just   from django.core import validators  and skip the #noqa?","commit_id":"a8c2f40e72a733c7c702640f4aaa3f376c6628c6"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"cff032d8a628dd2b2b3773b992068111650c5b2f","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"from urllib2 import Request  # noqa"},{"line_number":31,"context_line":"from urllib2 import URLError  # noqa"},{"line_number":32,"context_line":"from urllib2 import urlopen  # noqa"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"from horizon import exceptions"},{"line_number":35,"context_line":"from horizon import forms"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAT3%2F%2Fv%2BA%3D","line":32,"updated":"2014-01-02 12:31:19.000000000","message":"Just  \"import urllib2\" would look better.","commit_id":"a8c2f40e72a733c7c702640f4aaa3f376c6628c6"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"eaadbfbd9c355f9876310bbb924d4283c1fd8af6","unresolved":false,"context_lines":[{"line_number":27,"context_line":"from django.forms.widgets import HiddenInput  # noqa"},{"line_number":28,"context_line":"from django.utils.translation import ugettext_lazy as _  # noqa"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"import urllib2"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"from horizon import exceptions"},{"line_number":33,"context_line":"from horizon import forms"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAT3%2F%2Fsdo%3D","line":30,"updated":"2014-01-03 10:36:08.000000000","message":"Although we\u0027re not gating on python3 yet, I\u0027d prefer not to use urllib2.\n\n\nFrom http://www.python.org/doc//current/library/urllib2.html:\nNote\n\nThe urllib2 module has been split across several modules in Python 3.0 named urllib.request and urllib.error. The 2to3 tool will automatically adapt imports when converting your sources to 3.0.","commit_id":"9b05df46689518764e2a90f50038b29a53c1a7d6"},{"author":{"_account_id":6966,"name":"Jeffrey J. Walls","email":"jeff.walls@hpe.com","username":"ftcjeff"},"change_message_id":"f5f609262669bb9131faf4e67992d3d4766b8cb3","unresolved":false,"context_lines":[{"line_number":39,"context_line":"IMAGE_BACKEND_SETTINGS \u003d getattr(settings, \u0027OPENSTACK_IMAGE_BACKEND\u0027, {})"},{"line_number":40,"context_line":"IMAGE_FORMAT_CHOICES \u003d IMAGE_BACKEND_SETTINGS.get(\u0027image_formats\u0027, [])"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"unknow_schemes \u003d [\u0027http\u0027, \u0027https\u0027, \u0027swift\u0027, \u0027swift+http\u0027, \u0027swift+https\u0027,"},{"line_number":43,"context_line":"\u0027file\u0027, \u0027filesystem\u0027, \u0027s3\u0027, \u0027s3+http\u0027, \u0027s3+https\u0027, \u0027sheepdog\u0027, \u0027rbd\u0027,"},{"line_number":44,"context_line":"\u0027cinder\u0027, \u0027gridfs\u0027]"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUH%2F%2FW%2FY%3D","line":42,"updated":"2014-01-14 17:11:39.000000000","message":"should be: known_schemes or supported_schemes","commit_id":"33179f4122bf6e73087c5481dd83f88ca5bd93ba"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"d2daeffef1f39c272c9c1a7e97b96194a111c2d3","unresolved":false,"context_lines":[{"line_number":39,"context_line":"IMAGE_BACKEND_SETTINGS \u003d getattr(settings, \u0027OPENSTACK_IMAGE_BACKEND\u0027, {})"},{"line_number":40,"context_line":"IMAGE_FORMAT_CHOICES \u003d IMAGE_BACKEND_SETTINGS.get(\u0027image_formats\u0027, [])"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"unknow_schemes \u003d [\u0027http\u0027, \u0027https\u0027, \u0027swift\u0027, \u0027swift+http\u0027, \u0027swift+https\u0027,"},{"line_number":43,"context_line":"\u0027file\u0027, \u0027filesystem\u0027, \u0027s3\u0027, \u0027s3+http\u0027, \u0027s3+https\u0027, \u0027sheepdog\u0027, \u0027rbd\u0027,"},{"line_number":44,"context_line":"\u0027cinder\u0027, \u0027gridfs\u0027]"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUH%2F%2FVak%3D","line":42,"in_reply_to":"AAAAUH%2F%2FW%2FY%3D","updated":"2014-01-16 00:25:56.000000000","message":"You\u0027re right, I should change the variable name, actually I should use upper case instead of lower.","commit_id":"33179f4122bf6e73087c5481dd83f88ca5bd93ba"},{"author":{"_account_id":6966,"name":"Jeffrey J. Walls","email":"jeff.walls@hpe.com","username":"ftcjeff"},"change_message_id":"f5f609262669bb9131faf4e67992d3d4766b8cb3","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        if pieces.scheme not in unknow_schemes:"},{"line_number":118,"context_line":"            msg \u003d _(\"Unknown scheme \u0027%s\u0027 found in Image Location URI\")"},{"line_number":119,"context_line":"            raise ValidationError(msg % pieces.scheme)"},{"line_number":120,"context_line":"        if pieces.scheme in (\u0027http\u0027, \u0027https\u0027):"},{"line_number":121,"context_line":"            try:"},{"line_number":122,"context_line":"                req \u003d request.Request(copy_from)"},{"line_number":123,"context_line":"                req.get_method \u003d lambda: \u0027HEAD\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUH%2F%2FW%2BU%3D","line":120,"updated":"2014-01-14 17:11:39.000000000","message":"I don\u0027t understand this.  You have a bunch of schemes listed in \"unknow_shemes\", but you only handle http and https.  Is there no way to validate the other \"supported\" schemes?","commit_id":"33179f4122bf6e73087c5481dd83f88ca5bd93ba"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"d2daeffef1f39c272c9c1a7e97b96194a111c2d3","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        if pieces.scheme not in unknow_schemes:"},{"line_number":118,"context_line":"            msg \u003d _(\"Unknown scheme \u0027%s\u0027 found in Image Location URI\")"},{"line_number":119,"context_line":"            raise ValidationError(msg % pieces.scheme)"},{"line_number":120,"context_line":"        if pieces.scheme in (\u0027http\u0027, \u0027https\u0027):"},{"line_number":121,"context_line":"            try:"},{"line_number":122,"context_line":"                req \u003d request.Request(copy_from)"},{"line_number":123,"context_line":"                req.get_method \u003d lambda: \u0027HEAD\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUH%2F%2FVZ4%3D","line":120,"in_reply_to":"AAAAUH%2F%2FW%2BU%3D","updated":"2014-01-16 00:25:56.000000000","message":"urlopen method only works with http and/or https protocols, that\u0027s the main reason behind this conditional.","commit_id":"33179f4122bf6e73087c5481dd83f88ca5bd93ba"}]}
