)]}'
{"openstack_dashboard/api/network.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"23c53a2d3a67bc1f73d281eed546fb9c6455916d","unresolved":false,"context_lines":[{"line_number":135,"context_line":"def security_group_backend(request):"},{"line_number":136,"context_line":"    return NetworkClient(request).secgroups.backend"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"def _retrieve_networking_info(request, instances):"},{"line_number":140,"context_line":"    def _format_address(mac, ip, type):"},{"line_number":141,"context_line":"        return {u\u0027OS-EXT-IPS-MAC:mac_addr\u0027: mac,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2F9Cc%3D","line":138,"updated":"2014-01-06 09:24:18.000000000","message":"I agree with lsmola. it is better to move neutron-specific processing to api/neutron.py.\n\nAs the module docstring says, this module is to provide an abstraction layer for network functionalities and as a basic policy we avoid to implement the actual logic in this module as possible as we can. \n\nIn addition, it may be better to use an approach of ****Manager (e.g., NetworkManager) through NetworkClient method. The merits to do so are that we can hide nova-network/neutron differences by NetworkClient method and implement these logics as a class. The demerit is NetworkClient instantiated other manager (floating IP and security group) too, but this can be improved in a separate patch.","commit_id":"cd34d989029fa8be1c6ef5d2d1f96523daa53ec2"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"daa0328d94577c385bf8cd5b38ca9baa5cda9181","unresolved":false,"context_lines":[{"line_number":135,"context_line":"def security_group_backend(request):"},{"line_number":136,"context_line":"    return NetworkClient(request).secgroups.backend"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"def _retrieve_networking_info(request, instances):"},{"line_number":140,"context_line":"    def _format_address(mac, ip, type):"},{"line_number":141,"context_line":"        return {u\u0027OS-EXT-IPS-MAC:mac_addr\u0027: mac,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FymQ%3D","line":138,"in_reply_to":"AAAAUH%2F%2F9Cc%3D","updated":"2014-01-09 18:24:37.000000000","message":"I moved the logic to api/neutron.py, but kept the method here.\n\nFor the next patch set I decided against using a ***Manager:\n\nI thought to implement NetworkClient.api \u003d neutron if neutron_enabled else nova\n\nBut nova\u0027s implementation for \u0027update_servers_addresses\u0027 would be a mock. I thought it\u0027d make more sense for api/network.py:update_servers_addresses to not using a manager, but to just check if neutron is enabled and if so pass the arguments along to api/neutron.py.\n\nI thought that approach makes more sense in this specific case (Even though network.py:update_servers_addresses will now look odd compared to the other module functions, that all use a manager). Please tell me what you think once you see the next patch set.","commit_id":"cd34d989029fa8be1c6ef5d2d1f96523daa53ec2"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"108260dd0a7f4b3ba10da69b0d7abff8683724c8","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    # Get all needed information from Neutron"},{"line_number":147,"context_line":"    ports \u003d neutron.port_list(request)"},{"line_number":148,"context_line":"    floating_ips \u003d tenant_floating_ip_list(request)"},{"line_number":149,"context_line":"    networks \u003d neutron.network_list(request)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    for instance in instances:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAT3%2F%2FvvA%3D","line":148,"updated":"2014-01-02 14:19:25.000000000","message":"Can we call here also Neutron? Seems like this code runs only for neutron enabled. \nThen maybe the method could be rename to \u0027_retrieve_neutron_info\u0027","commit_id":"cd34d989029fa8be1c6ef5d2d1f96523daa53ec2"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"daa0328d94577c385bf8cd5b38ca9baa5cda9181","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    # Get all needed information from Neutron"},{"line_number":147,"context_line":"    ports \u003d neutron.port_list(request)"},{"line_number":148,"context_line":"    floating_ips \u003d tenant_floating_ip_list(request)"},{"line_number":149,"context_line":"    networks \u003d neutron.network_list(request)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    for instance in instances:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FymI%3D","line":148,"in_reply_to":"AAAAT3%2F%2FvvA%3D","updated":"2014-01-09 18:24:37.000000000","message":"Done","commit_id":"cd34d989029fa8be1c6ef5d2d1f96523daa53ec2"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"108260dd0a7f4b3ba10da69b0d7abff8683724c8","unresolved":false,"context_lines":[{"line_number":146,"context_line":"    # Get all needed information from Neutron"},{"line_number":147,"context_line":"    ports \u003d neutron.port_list(request)"},{"line_number":148,"context_line":"    floating_ips \u003d tenant_floating_ip_list(request)"},{"line_number":149,"context_line":"    networks \u003d neutron.network_list(request)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    for instance in instances:"},{"line_number":152,"context_line":"        instance.addresses \u003d collections.defaultdict(list)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAT3%2F%2FvxU%3D","line":149,"updated":"2014-01-02 14:19:25.000000000","message":"Filtering neutron entities, so we get only those that are related to \u0027instances\u0027 we have is not probably possible in neutron, right? Because always getting everything from Neutron will be costly for solutions at scale.","commit_id":"cd34d989029fa8be1c6ef5d2d1f96523daa53ec2"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"daa0328d94577c385bf8cd5b38ca9baa5cda9181","unresolved":false,"context_lines":[{"line_number":146,"context_line":"    # Get all needed information from Neutron"},{"line_number":147,"context_line":"    ports \u003d neutron.port_list(request)"},{"line_number":148,"context_line":"    floating_ips \u003d tenant_floating_ip_list(request)"},{"line_number":149,"context_line":"    networks \u003d neutron.network_list(request)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    for instance in instances:"},{"line_number":152,"context_line":"        instance.addresses \u003d collections.defaultdict(list)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FymA%3D","line":149,"in_reply_to":"AAAAT3%2F%2FvxU%3D","updated":"2014-01-09 18:24:37.000000000","message":"I\u0027ll get only the relevant data.","commit_id":"cd34d989029fa8be1c6ef5d2d1f96523daa53ec2"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"108260dd0a7f4b3ba10da69b0d7abff8683724c8","unresolved":false,"context_lines":[{"line_number":154,"context_line":"                          port.device_id \u003d\u003d instance.id]"},{"line_number":155,"context_line":"        for port in instance_ports:"},{"line_number":156,"context_line":"            network_of_port \u003d next((network for network in networks if"},{"line_number":157,"context_line":"                                    port.network_id \u003d\u003d network.id), None)"},{"line_number":158,"context_line":"            if network_of_port is not None:"},{"line_number":159,"context_line":"                for fixed_ip in port.fixed_ips:"},{"line_number":160,"context_line":"                    instance.addresses[network_of_port.name].append("}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAT3%2F%2Fvw0%3D","line":157,"updated":"2014-01-02 14:19:25.000000000","message":"You are going trough this array over and over again, it would be better to go through it once, then save it to dictionary.","commit_id":"cd34d989029fa8be1c6ef5d2d1f96523daa53ec2"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"daa0328d94577c385bf8cd5b38ca9baa5cda9181","unresolved":false,"context_lines":[{"line_number":154,"context_line":"                          port.device_id \u003d\u003d instance.id]"},{"line_number":155,"context_line":"        for port in instance_ports:"},{"line_number":156,"context_line":"            network_of_port \u003d next((network for network in networks if"},{"line_number":157,"context_line":"                                    port.network_id \u003d\u003d network.id), None)"},{"line_number":158,"context_line":"            if network_of_port is not None:"},{"line_number":159,"context_line":"                for fixed_ip in port.fixed_ips:"},{"line_number":160,"context_line":"                    instance.addresses[network_of_port.name].append("}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Fyl8%3D","line":157,"in_reply_to":"AAAAT3%2F%2Fvw0%3D","updated":"2014-01-09 18:24:37.000000000","message":"Done","commit_id":"cd34d989029fa8be1c6ef5d2d1f96523daa53ec2"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"108260dd0a7f4b3ba10da69b0d7abff8683724c8","unresolved":false,"context_lines":[{"line_number":163,"context_line":"                                        u\u0027fixed\u0027))"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"            instance_floating_ips \u003d [fip for fip in floating_ips if"},{"line_number":166,"context_line":"                                     fip.port_id \u003d\u003d port.id]"},{"line_number":167,"context_line":"            for fip in instance_floating_ips:"},{"line_number":168,"context_line":"                instance.addresses[network_of_port.name].append("},{"line_number":169,"context_line":"                    _format_address(port.mac_address,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAT3%2F%2Fvws%3D","line":166,"updated":"2014-01-02 14:19:25.000000000","message":"Same here, better to go through it once and save it to dictionary.\n\ngiven you will have solution at scale (more then 1000 instances), this would take a very long time","commit_id":"cd34d989029fa8be1c6ef5d2d1f96523daa53ec2"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"daa0328d94577c385bf8cd5b38ca9baa5cda9181","unresolved":false,"context_lines":[{"line_number":163,"context_line":"                                        u\u0027fixed\u0027))"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"            instance_floating_ips \u003d [fip for fip in floating_ips if"},{"line_number":166,"context_line":"                                     fip.port_id \u003d\u003d port.id]"},{"line_number":167,"context_line":"            for fip in instance_floating_ips:"},{"line_number":168,"context_line":"                instance.addresses[network_of_port.name].append("},{"line_number":169,"context_line":"                    _format_address(port.mac_address,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Fyl0%3D","line":166,"in_reply_to":"AAAAT3%2F%2Fvws%3D","updated":"2014-01-09 18:24:37.000000000","message":"Done","commit_id":"cd34d989029fa8be1c6ef5d2d1f96523daa53ec2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"23c53a2d3a67bc1f73d281eed546fb9c6455916d","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        instance.addresses \u003d dict(instance.addresses)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"def servers_update_networking(request, servers):"},{"line_number":177,"context_line":"    \"\"\"Retrieve servers networking information from Neutron if enabled."},{"line_number":178,"context_line":"       Should be used when up to date networking information is required,"},{"line_number":179,"context_line":"       and Nova\u0027s networking info caching mechanism is not fast enough."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2F9B0%3D","line":176,"updated":"2014-01-06 09:24:18.000000000","message":"\"servers_update_network_info\" may be a better name. Updating \"networking\" sounds a bit odd.","commit_id":"cd34d989029fa8be1c6ef5d2d1f96523daa53ec2"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"daa0328d94577c385bf8cd5b38ca9baa5cda9181","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        instance.addresses \u003d dict(instance.addresses)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"def servers_update_networking(request, servers):"},{"line_number":177,"context_line":"    \"\"\"Retrieve servers networking information from Neutron if enabled."},{"line_number":178,"context_line":"       Should be used when up to date networking information is required,"},{"line_number":179,"context_line":"       and Nova\u0027s networking info caching mechanism is not fast enough."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FylM%3D","line":176,"in_reply_to":"AAAAUH%2F%2F9B0%3D","updated":"2014-01-09 18:24:37.000000000","message":"I thought:\n\nservers_update_addresses\n\nBecause that\u0027s the only thing that the function actually updates.","commit_id":"cd34d989029fa8be1c6ef5d2d1f96523daa53ec2"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"108260dd0a7f4b3ba10da69b0d7abff8683724c8","unresolved":false,"context_lines":[{"line_number":174,"context_line":""},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"def servers_update_networking(request, servers):"},{"line_number":177,"context_line":"    \"\"\"Retrieve servers networking information from Neutron if enabled."},{"line_number":178,"context_line":"       Should be used when up to date networking information is required,"},{"line_number":179,"context_line":"       and Nova\u0027s networking info caching mechanism is not fast enough."},{"line_number":180,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAT3%2F%2FvtI%3D","line":177,"updated":"2014-01-02 14:19:25.000000000","message":"Wrong pep8 doc\n\nThere should be brief one first line, blank line then description.","commit_id":"cd34d989029fa8be1c6ef5d2d1f96523daa53ec2"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"daa0328d94577c385bf8cd5b38ca9baa5cda9181","unresolved":false,"context_lines":[{"line_number":174,"context_line":""},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"def servers_update_networking(request, servers):"},{"line_number":177,"context_line":"    \"\"\"Retrieve servers networking information from Neutron if enabled."},{"line_number":178,"context_line":"       Should be used when up to date networking information is required,"},{"line_number":179,"context_line":"       and Nova\u0027s networking info caching mechanism is not fast enough."},{"line_number":180,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FylI%3D","line":177,"in_reply_to":"AAAAT3%2F%2FvtI%3D","updated":"2014-01-09 18:24:37.000000000","message":"Done","commit_id":"cd34d989029fa8be1c6ef5d2d1f96523daa53ec2"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"026028787f9fcb5df113b2642fd715350e17bdd8","unresolved":false,"context_lines":[{"line_number":174,"context_line":""},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"def servers_update_networking(request, servers):"},{"line_number":177,"context_line":"    \"\"\"Retrieve servers networking information from Neutron if enabled."},{"line_number":178,"context_line":"       Should be used when up to date networking information is required,"},{"line_number":179,"context_line":"       and Nova\u0027s networking info caching mechanism is not fast enough."},{"line_number":180,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Fq9A%3D","line":177,"in_reply_to":"AAAAT3%2F%2FvtI%3D","updated":"2014-01-12 11:44:01.000000000","message":"I just noticed that I forgot to fix this.\n\nFixed according to:\nhttp://www.python.org/dev/peps/pep-0008/#documentation-strings","commit_id":"cd34d989029fa8be1c6ef5d2d1f96523daa53ec2"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"6fc2c210b0c8746ee4fb8952728f780040232468","unresolved":false,"context_lines":[{"line_number":143,"context_line":"    \"\"\""},{"line_number":144,"context_line":"    neutron_enabled \u003d base.is_service_enabled(request, \u0027network\u0027)"},{"line_number":145,"context_line":"    if neutron_enabled:"},{"line_number":146,"context_line":"        neutron.servers_update_addresses(request, servers)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2BnBM%3D","line":146,"updated":"2014-01-23 22:14:35.000000000","message":"else?","commit_id":"e4898139fcc56abba4a0df51771c1a9956101532"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"206512a98c71d34a924d9a5755550fe88bc06001","unresolved":false,"context_lines":[{"line_number":143,"context_line":"    \"\"\""},{"line_number":144,"context_line":"    neutron_enabled \u003d base.is_service_enabled(request, \u0027network\u0027)"},{"line_number":145,"context_line":"    if neutron_enabled:"},{"line_number":146,"context_line":"        neutron.servers_update_addresses(request, servers)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2BceM%3D","line":146,"in_reply_to":"AAAAUH%2F%2BdxU%3D","updated":"2014-01-26 09:45:51.000000000","message":"I wouldn\u0027t expect a Nova API call to internally make Neutron calls, that\u0027s why I created this function. It is order-sensitive though, because if this function is called before nova get servers then the \u0027address\u0027 field of each server will be overwritten.\n\nEven in light of that, though, I still think that this approach is better. What do you guys think?","commit_id":"e4898139fcc56abba4a0df51771c1a9956101532"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"b56c07528c6d98edb653b23b35e867230b70e1de","unresolved":false,"context_lines":[{"line_number":143,"context_line":"    \"\"\""},{"line_number":144,"context_line":"    neutron_enabled \u003d base.is_service_enabled(request, \u0027network\u0027)"},{"line_number":145,"context_line":"    if neutron_enabled:"},{"line_number":146,"context_line":"        neutron.servers_update_addresses(request, servers)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2BdxU%3D","line":146,"in_reply_to":"AAAAUH%2F%2Bdzs%3D","updated":"2014-01-25 17:16:26.000000000","message":"Integrating sounds like an appropriate solution.  Otherwise, this needs to be fixed.","commit_id":"e4898139fcc56abba4a0df51771c1a9956101532"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"188f54699016c8a7ff1ce4ab53fe0b7483055215","unresolved":false,"context_lines":[{"line_number":143,"context_line":"    \"\"\""},{"line_number":144,"context_line":"    neutron_enabled \u003d base.is_service_enabled(request, \u0027network\u0027)"},{"line_number":145,"context_line":"    if neutron_enabled:"},{"line_number":146,"context_line":"        neutron.servers_update_addresses(request, servers)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2Bdzs%3D","line":146,"in_reply_to":"AAAAUH%2F%2Bjcw%3D","updated":"2014-01-25 17:03:02.000000000","message":"I see, so it doesn\u0027t seem appropriate we have this method as a separate API because this method is apparently expected to call after server_list. Is it better to enhance api.nova.server_list/server_get?","commit_id":"e4898139fcc56abba4a0df51771c1a9956101532"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"ddd573a25b5a17aeb6b6029c40cc7b0bec66afa9","unresolved":false,"context_lines":[{"line_number":143,"context_line":"    \"\"\""},{"line_number":144,"context_line":"    neutron_enabled \u003d base.is_service_enabled(request, \u0027network\u0027)"},{"line_number":145,"context_line":"    if neutron_enabled:"},{"line_number":146,"context_line":"        neutron.servers_update_addresses(request, servers)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2Bjcw%3D","line":146,"in_reply_to":"AAAAUH%2F%2BkkA%3D","updated":"2014-01-24 13:02:05.000000000","message":"This is a method in the network api there is no guarantee of call order should someone else decide to use this method in a different use case.","commit_id":"e4898139fcc56abba4a0df51771c1a9956101532"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3ad0b3720be57becdb08666f26b52ecd86416831","unresolved":false,"context_lines":[{"line_number":143,"context_line":"    \"\"\""},{"line_number":144,"context_line":"    neutron_enabled \u003d base.is_service_enabled(request, \u0027network\u0027)"},{"line_number":145,"context_line":"    if neutron_enabled:"},{"line_number":146,"context_line":"        neutron.servers_update_addresses(request, servers)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2BkkA%3D","line":146,"in_reply_to":"AAAAUH%2F%2BnBM%3D","updated":"2014-01-24 10:08:59.000000000","message":"Actually \"else\"-clause is unnecessary. Before this method is called, server detail is retrieved through nova API, so there is nothing to do here. In case of nova-network, all information is retrieved from nova.\n\nI think we need to improve docstring to describe the above.","commit_id":"e4898139fcc56abba4a0df51771c1a9956101532"}],"openstack_dashboard/api/neutron.py":[{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"04835f16e05e5cb5219105a295b37cd556480462","unresolved":false,"context_lines":[{"line_number":745,"context_line":"    # Get all (filtered for relevant servers) information from Neutron"},{"line_number":746,"context_line":"    try:"},{"line_number":747,"context_line":"        ports \u003d port_list("},{"line_number":748,"context_line":"            request, **{\u0027device_id\u0027: [instance.id for instance in servers]})"},{"line_number":749,"context_line":"        floating_ips \u003d FloatingIpManager(request).list("},{"line_number":750,"context_line":"            **{\u0027port_id\u0027: [port.id for port in ports]})"},{"line_number":751,"context_line":"        networks \u003d network_list("}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2B7%2BI%3D","line":748,"updated":"2014-01-21 16:23:59.000000000","message":"this is not very nice way\n\ndevice_id\u003d[instance.id for instance in servers]  is nicer and more readable","commit_id":"15cfa9a773d958c249d45cd81b37166c379bcdd1"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"f717a6b2315d47028c36a2ccc607fba997b08d34","unresolved":false,"context_lines":[{"line_number":745,"context_line":"    # Get all (filtered for relevant servers) information from Neutron"},{"line_number":746,"context_line":"    try:"},{"line_number":747,"context_line":"        ports \u003d port_list("},{"line_number":748,"context_line":"            request, **{\u0027device_id\u0027: [instance.id for instance in servers]})"},{"line_number":749,"context_line":"        floating_ips \u003d FloatingIpManager(request).list("},{"line_number":750,"context_line":"            **{\u0027port_id\u0027: [port.id for port in ports]})"},{"line_number":751,"context_line":"        networks \u003d network_list("}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2B1Og%3D","line":748,"in_reply_to":"AAAAUH%2F%2B7%2BI%3D","updated":"2014-01-21 16:30:45.000000000","message":"You\u0027re absolutely right - I\u0027ll push a fix soon.","commit_id":"15cfa9a773d958c249d45cd81b37166c379bcdd1"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"04835f16e05e5cb5219105a295b37cd556480462","unresolved":false,"context_lines":[{"line_number":747,"context_line":"        ports \u003d port_list("},{"line_number":748,"context_line":"            request, **{\u0027device_id\u0027: [instance.id for instance in servers]})"},{"line_number":749,"context_line":"        floating_ips \u003d FloatingIpManager(request).list("},{"line_number":750,"context_line":"            **{\u0027port_id\u0027: [port.id for port in ports]})"},{"line_number":751,"context_line":"        networks \u003d network_list("},{"line_number":752,"context_line":"            request, **{\u0027id\u0027: [port.network_id for port in ports]})"},{"line_number":753,"context_line":"    except Exception:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2B7%2BA%3D","line":750,"updated":"2014-01-21 16:23:59.000000000","message":"ditto","commit_id":"15cfa9a773d958c249d45cd81b37166c379bcdd1"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"f717a6b2315d47028c36a2ccc607fba997b08d34","unresolved":false,"context_lines":[{"line_number":747,"context_line":"        ports \u003d port_list("},{"line_number":748,"context_line":"            request, **{\u0027device_id\u0027: [instance.id for instance in servers]})"},{"line_number":749,"context_line":"        floating_ips \u003d FloatingIpManager(request).list("},{"line_number":750,"context_line":"            **{\u0027port_id\u0027: [port.id for port in ports]})"},{"line_number":751,"context_line":"        networks \u003d network_list("},{"line_number":752,"context_line":"            request, **{\u0027id\u0027: [port.network_id for port in ports]})"},{"line_number":753,"context_line":"    except Exception:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2B1Oc%3D","line":750,"in_reply_to":"AAAAUH%2F%2B7%2BA%3D","updated":"2014-01-21 16:30:45.000000000","message":"Done","commit_id":"15cfa9a773d958c249d45cd81b37166c379bcdd1"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"04835f16e05e5cb5219105a295b37cd556480462","unresolved":false,"context_lines":[{"line_number":749,"context_line":"        floating_ips \u003d FloatingIpManager(request).list("},{"line_number":750,"context_line":"            **{\u0027port_id\u0027: [port.id for port in ports]})"},{"line_number":751,"context_line":"        networks \u003d network_list("},{"line_number":752,"context_line":"            request, **{\u0027id\u0027: [port.network_id for port in ports]})"},{"line_number":753,"context_line":"    except Exception:"},{"line_number":754,"context_line":"        error_message \u003d _(\u0027Unable to connect to Neutron\u0027)"},{"line_number":755,"context_line":"        LOG.error(error_message)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2B798%3D","line":752,"updated":"2014-01-21 16:23:59.000000000","message":"ditto","commit_id":"15cfa9a773d958c249d45cd81b37166c379bcdd1"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"f717a6b2315d47028c36a2ccc607fba997b08d34","unresolved":false,"context_lines":[{"line_number":749,"context_line":"        floating_ips \u003d FloatingIpManager(request).list("},{"line_number":750,"context_line":"            **{\u0027port_id\u0027: [port.id for port in ports]})"},{"line_number":751,"context_line":"        networks \u003d network_list("},{"line_number":752,"context_line":"            request, **{\u0027id\u0027: [port.network_id for port in ports]})"},{"line_number":753,"context_line":"    except Exception:"},{"line_number":754,"context_line":"        error_message \u003d _(\u0027Unable to connect to Neutron\u0027)"},{"line_number":755,"context_line":"        LOG.error(error_message)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2B1OY%3D","line":752,"in_reply_to":"AAAAUH%2F%2B798%3D","updated":"2014-01-21 16:30:45.000000000","message":"Done","commit_id":"15cfa9a773d958c249d45cd81b37166c379bcdd1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3ad0b3720be57becdb08666f26b52ecd86416831","unresolved":false,"context_lines":[{"line_number":753,"context_line":"    except Exception:"},{"line_number":754,"context_line":"        error_message \u003d _(\u0027Unable to connect to Neutron\u0027)"},{"line_number":755,"context_line":"        LOG.error(error_message)"},{"line_number":756,"context_line":"        messages.error(request, error_message)"},{"line_number":757,"context_line":""},{"line_number":758,"context_line":"    # Map instance to its ports"},{"line_number":759,"context_line":"    instances_ports \u003d collections.defaultdict(list)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2BkeA%3D","line":756,"updated":"2014-01-24 10:08:59.000000000","message":"message.error does not terminate the processing. We need to return here, or ensure that ports, floating_ips, networks are defined. IMO, if an exception occurs, it is better to use nova information (i.e., do not update addresses with neutron information).","commit_id":"e4898139fcc56abba4a0df51771c1a9956101532"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"206512a98c71d34a924d9a5755550fe88bc06001","unresolved":false,"context_lines":[{"line_number":753,"context_line":"    except Exception:"},{"line_number":754,"context_line":"        error_message \u003d _(\u0027Unable to connect to Neutron\u0027)"},{"line_number":755,"context_line":"        LOG.error(error_message)"},{"line_number":756,"context_line":"        messages.error(request, error_message)"},{"line_number":757,"context_line":""},{"line_number":758,"context_line":"    # Map instance to its ports"},{"line_number":759,"context_line":"    instances_ports \u003d collections.defaultdict(list)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2BceE%3D","line":756,"in_reply_to":"AAAAUH%2F%2BkeA%3D","updated":"2014-01-26 09:45:51.000000000","message":"Right - A return is missing. A failure here is OK as Nova will eventually update his cache.","commit_id":"e4898139fcc56abba4a0df51771c1a9956101532"},{"author":{"_account_id":6650,"name":"Eric Peterson","email":"ejpetey@gmail.com","username":"ericpeterson-l"},"change_message_id":"5df3b7d9df7efd25d30fc98bbefa7a123a9d0ba7","unresolved":false,"context_lines":[{"line_number":762,"context_line":""},{"line_number":763,"context_line":"    # Map port to its floating ips"},{"line_number":764,"context_line":"    ports_floating_ips \u003d collections.defaultdict(list)"},{"line_number":765,"context_line":"    for fip in floating_ips:"},{"line_number":766,"context_line":"        ports_floating_ips[fip.port_id].append(fip)"},{"line_number":767,"context_line":""},{"line_number":768,"context_line":"    # Map network id to its name"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2Bmqo%3D","line":765,"updated":"2014-01-23 23:17:12.000000000","message":"floating ips might not be defined, depending how the try / catch above worked out.  this is kind of true for a few variables like networks too  etc","commit_id":"e4898139fcc56abba4a0df51771c1a9956101532"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"206512a98c71d34a924d9a5755550fe88bc06001","unresolved":false,"context_lines":[{"line_number":762,"context_line":""},{"line_number":763,"context_line":"    # Map port to its floating ips"},{"line_number":764,"context_line":"    ports_floating_ips \u003d collections.defaultdict(list)"},{"line_number":765,"context_line":"    for fip in floating_ips:"},{"line_number":766,"context_line":"        ports_floating_ips[fip.port_id].append(fip)"},{"line_number":767,"context_line":""},{"line_number":768,"context_line":"    # Map network id to its name"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2Bcd4%3D","line":765,"in_reply_to":"AAAAUH%2F%2Bmqo%3D","updated":"2014-01-26 09:45:51.000000000","message":"I\u0027ll add a return if Neutron was unresponsive.","commit_id":"e4898139fcc56abba4a0df51771c1a9956101532"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3ad0b3720be57becdb08666f26b52ecd86416831","unresolved":false,"context_lines":[{"line_number":768,"context_line":"    # Map network id to its name"},{"line_number":769,"context_line":"    network_names \u003d {}"},{"line_number":770,"context_line":"    for network in networks:"},{"line_number":771,"context_line":"        network_names[network.id] \u003d network.name"},{"line_number":772,"context_line":""},{"line_number":773,"context_line":"    for server in servers:"},{"line_number":774,"context_line":"        server.addresses \u003d server_get_addresses("}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2Bkeo%3D","line":771,"updated":"2014-01-24 10:08:59.000000000","message":"network_names \u003d dict([(network.id, network.name)\n                      for network in networks)])","commit_id":"e4898139fcc56abba4a0df51771c1a9956101532"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"206512a98c71d34a924d9a5755550fe88bc06001","unresolved":false,"context_lines":[{"line_number":768,"context_line":"    # Map network id to its name"},{"line_number":769,"context_line":"    network_names \u003d {}"},{"line_number":770,"context_line":"    for network in networks:"},{"line_number":771,"context_line":"        network_names[network.id] \u003d network.name"},{"line_number":772,"context_line":""},{"line_number":773,"context_line":"    for server in servers:"},{"line_number":774,"context_line":"        server.addresses \u003d server_get_addresses("}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2Bcd0%3D","line":771,"in_reply_to":"AAAAUH%2F%2Bkeo%3D","updated":"2014-01-26 09:45:51.000000000","message":"Done","commit_id":"e4898139fcc56abba4a0df51771c1a9956101532"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3ad0b3720be57becdb08666f26b52ecd86416831","unresolved":false,"context_lines":[{"line_number":779,"context_line":"            network_names)"},{"line_number":780,"context_line":""},{"line_number":781,"context_line":""},{"line_number":782,"context_line":"def server_get_addresses(request, server, ports, floating_ips, network_names):"},{"line_number":783,"context_line":"    def _format_address(mac, ip, type):"},{"line_number":784,"context_line":"        try:"},{"line_number":785,"context_line":"            version \u003d netaddr.IPAddress(ip).version"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2Bkiw%3D","line":782,"updated":"2014-01-24 10:08:59.000000000","message":"I think it is a private method in this module. If so _server_get_addresses() looks better.","commit_id":"e4898139fcc56abba4a0df51771c1a9956101532"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"206512a98c71d34a924d9a5755550fe88bc06001","unresolved":false,"context_lines":[{"line_number":779,"context_line":"            network_names)"},{"line_number":780,"context_line":""},{"line_number":781,"context_line":""},{"line_number":782,"context_line":"def server_get_addresses(request, server, ports, floating_ips, network_names):"},{"line_number":783,"context_line":"    def _format_address(mac, ip, type):"},{"line_number":784,"context_line":"        try:"},{"line_number":785,"context_line":"            version \u003d netaddr.IPAddress(ip).version"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2Bcdo%3D","line":782,"in_reply_to":"AAAAUH%2F%2Bkiw%3D","updated":"2014-01-26 09:45:51.000000000","message":"Done","commit_id":"e4898139fcc56abba4a0df51771c1a9956101532"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3ad0b3720be57becdb08666f26b52ecd86416831","unresolved":false,"context_lines":[{"line_number":786,"context_line":"        except Exception:"},{"line_number":787,"context_line":"            error_message \u003d _(\u0027Unable to parse IP address %s\u0027) % ip"},{"line_number":788,"context_line":"            LOG.error(error_message)"},{"line_number":789,"context_line":"            messages.error(request, error_message)"},{"line_number":790,"context_line":"        return {u\u0027OS-EXT-IPS-MAC:mac_addr\u0027: mac,"},{"line_number":791,"context_line":"                u\u0027version\u0027: version,"},{"line_number":792,"context_line":"                u\u0027addr\u0027: ip,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2Bkgo%3D","line":789,"updated":"2014-01-24 10:08:59.000000000","message":"Even when an exception is caught, return at L.790 is called but \"version\" is not defined. It leads to another exception and it will abort the processing of server_get_addresses itself. We need to consider another way to handle an exception.","commit_id":"e4898139fcc56abba4a0df51771c1a9956101532"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"206512a98c71d34a924d9a5755550fe88bc06001","unresolved":false,"context_lines":[{"line_number":786,"context_line":"        except Exception:"},{"line_number":787,"context_line":"            error_message \u003d _(\u0027Unable to parse IP address %s\u0027) % ip"},{"line_number":788,"context_line":"            LOG.error(error_message)"},{"line_number":789,"context_line":"            messages.error(request, error_message)"},{"line_number":790,"context_line":"        return {u\u0027OS-EXT-IPS-MAC:mac_addr\u0027: mac,"},{"line_number":791,"context_line":"                u\u0027version\u0027: version,"},{"line_number":792,"context_line":"                u\u0027addr\u0027: ip,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2BcZ0%3D","line":789,"in_reply_to":"AAAAUH%2F%2Bkgo%3D","updated":"2014-01-26 09:45:51.000000000","message":"Done","commit_id":"e4898139fcc56abba4a0df51771c1a9956101532"},{"author":{"_account_id":6650,"name":"Eric Peterson","email":"ejpetey@gmail.com","username":"ericpeterson-l"},"change_message_id":"5df3b7d9df7efd25d30fc98bbefa7a123a9d0ba7","unresolved":false,"context_lines":[{"line_number":793,"context_line":"                u\u0027OS-EXT-IPS:type\u0027: type}"},{"line_number":794,"context_line":""},{"line_number":795,"context_line":"    addresses \u003d collections.defaultdict(list)"},{"line_number":796,"context_line":"    instance_ports \u003d ports[server.id]"},{"line_number":797,"context_line":"    for port in instance_ports:"},{"line_number":798,"context_line":"        network_name \u003d network_names.get(port.network_id)"},{"line_number":799,"context_line":"        if network_name is not None:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2Bmp8%3D","line":796,"updated":"2014-01-23 23:17:12.000000000","message":"how do you know ports contains the key server.id ? might want to be a bit more defensive here","commit_id":"e4898139fcc56abba4a0df51771c1a9956101532"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"206512a98c71d34a924d9a5755550fe88bc06001","unresolved":false,"context_lines":[{"line_number":793,"context_line":"                u\u0027OS-EXT-IPS:type\u0027: type}"},{"line_number":794,"context_line":""},{"line_number":795,"context_line":"    addresses \u003d collections.defaultdict(list)"},{"line_number":796,"context_line":"    instance_ports \u003d ports[server.id]"},{"line_number":797,"context_line":"    for port in instance_ports:"},{"line_number":798,"context_line":"        network_name \u003d network_names.get(port.network_id)"},{"line_number":799,"context_line":"        if network_name is not None:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2Bcdc%3D","line":796,"in_reply_to":"AAAAUH%2F%2Bmp8%3D","updated":"2014-01-26 09:45:51.000000000","message":"Thanks, this is a good point. There\u0027s talks of letting instances boot without vNICs, for example.","commit_id":"e4898139fcc56abba4a0df51771c1a9956101532"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3ad0b3720be57becdb08666f26b52ecd86416831","unresolved":false,"context_lines":[{"line_number":804,"context_line":"                                    u\u0027fixed\u0027))"},{"line_number":805,"context_line":"            port_fips \u003d floating_ips.get(port.id)"},{"line_number":806,"context_line":"            if port_fips is not None:"},{"line_number":807,"context_line":"                for fip in port_fips:"},{"line_number":808,"context_line":"                    addresses[network_name].append("},{"line_number":809,"context_line":"                        _format_address(port.mac_address,"},{"line_number":810,"context_line":"                                        fip.floating_ip_address,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2Bke0%3D","line":807,"updated":"2014-01-24 10:08:59.000000000","message":"Pedantic: Consider the following:\n\n  port_fips \u003d floating_ips.get(port.id, [])\n  for fip in port_ips:\n    ....","commit_id":"e4898139fcc56abba4a0df51771c1a9956101532"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"206512a98c71d34a924d9a5755550fe88bc06001","unresolved":false,"context_lines":[{"line_number":804,"context_line":"                                    u\u0027fixed\u0027))"},{"line_number":805,"context_line":"            port_fips \u003d floating_ips.get(port.id)"},{"line_number":806,"context_line":"            if port_fips is not None:"},{"line_number":807,"context_line":"                for fip in port_fips:"},{"line_number":808,"context_line":"                    addresses[network_name].append("},{"line_number":809,"context_line":"                        _format_address(port.mac_address,"},{"line_number":810,"context_line":"                                        fip.floating_ip_address,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2Bcdg%3D","line":807,"in_reply_to":"AAAAUH%2F%2Bke0%3D","updated":"2014-01-26 09:45:51.000000000","message":"No no, being pedantic is part of being a programmer :)","commit_id":"e4898139fcc56abba4a0df51771c1a9956101532"}],"openstack_dashboard/dashboards/admin/instances/tests.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"23c53a2d3a67bc1f73d281eed546fb9c6455916d","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                             all_tenants\u003dTrue, search_opts\u003dsearch_opts) \\"},{"line_number":49,"context_line":"                                .AndReturn([servers, False])"},{"line_number":50,"context_line":"        api.network.servers_update_networking(IsA(http.HttpRequest),"},{"line_number":51,"context_line":"                                              IgnoreArg())"},{"line_number":52,"context_line":"        api.nova.flavor_list(IsA(http.HttpRequest)).AndReturn(flavors)"},{"line_number":53,"context_line":"        self.mox.ReplayAll()"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2F9A4%3D","line":51,"updated":"2014-01-06 09:24:18.000000000","message":"It is better to avoid using IgnoreArg(). Can\u0027t we check the argument more explicitly?","commit_id":"cd34d989029fa8be1c6ef5d2d1f96523daa53ec2"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"daa0328d94577c385bf8cd5b38ca9baa5cda9181","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                             all_tenants\u003dTrue, search_opts\u003dsearch_opts) \\"},{"line_number":49,"context_line":"                                .AndReturn([servers, False])"},{"line_number":50,"context_line":"        api.network.servers_update_networking(IsA(http.HttpRequest),"},{"line_number":51,"context_line":"                                              IgnoreArg())"},{"line_number":52,"context_line":"        api.nova.flavor_list(IsA(http.HttpRequest)).AndReturn(flavors)"},{"line_number":53,"context_line":"        self.mox.ReplayAll()"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Fr9I%3D","line":51,"in_reply_to":"AAAAUH%2F%2F9A4%3D","updated":"2014-01-09 18:24:37.000000000","message":"Done","commit_id":"cd34d989029fa8be1c6ef5d2d1f96523daa53ec2"}],"openstack_dashboard/dashboards/admin/instances/views.py":[{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"108260dd0a7f4b3ba10da69b0d7abff8683724c8","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            exceptions.handle(self.request,"},{"line_number":81,"context_line":"                              _(\u0027Unable to retrieve instance list.\u0027))"},{"line_number":82,"context_line":"        if instances:"},{"line_number":83,"context_line":"            api.network.servers_update_networking(self.request, instances)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"            # Gather our flavors to correlate against IDs"},{"line_number":86,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAT3%2F%2Fvu0%3D","line":83,"updated":"2014-01-02 14:19:25.000000000","message":"Catch exception here","commit_id":"cd34d989029fa8be1c6ef5d2d1f96523daa53ec2"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"daa0328d94577c385bf8cd5b38ca9baa5cda9181","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            exceptions.handle(self.request,"},{"line_number":81,"context_line":"                              _(\u0027Unable to retrieve instance list.\u0027))"},{"line_number":82,"context_line":"        if instances:"},{"line_number":83,"context_line":"            api.network.servers_update_networking(self.request, instances)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"            # Gather our flavors to correlate against IDs"},{"line_number":86,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FxEo%3D","line":83,"in_reply_to":"AAAAT3%2F%2Fvu0%3D","updated":"2014-01-09 18:24:37.000000000","message":"Done","commit_id":"cd34d989029fa8be1c6ef5d2d1f96523daa53ec2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3ad0b3720be57becdb08666f26b52ecd86416831","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            except Exception:"},{"line_number":86,"context_line":"                exceptions.handle("},{"line_number":87,"context_line":"                    self.request,"},{"line_number":88,"context_line":"                    message\u003d_(\u0027Unable to retrieve IP addresses from Neutron\u0027),"},{"line_number":89,"context_line":"                    ignore\u003dTrue)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"            # Gather our flavors to correlate against IDs"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2BkZs%3D","line":88,"updated":"2014-01-24 10:08:59.000000000","message":"It is better to be terminated with a period.","commit_id":"e4898139fcc56abba4a0df51771c1a9956101532"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"206512a98c71d34a924d9a5755550fe88bc06001","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            except Exception:"},{"line_number":86,"context_line":"                exceptions.handle("},{"line_number":87,"context_line":"                    self.request,"},{"line_number":88,"context_line":"                    message\u003d_(\u0027Unable to retrieve IP addresses from Neutron\u0027),"},{"line_number":89,"context_line":"                    ignore\u003dTrue)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"            # Gather our flavors to correlate against IDs"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2BcZw%3D","line":88,"in_reply_to":"AAAAUH%2F%2BkZs%3D","updated":"2014-01-26 09:45:51.000000000","message":"Fixed in all error messages introduced by this patch.","commit_id":"e4898139fcc56abba4a0df51771c1a9956101532"}],"openstack_dashboard/dashboards/project/instances/views.py":[{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"108260dd0a7f4b3ba10da69b0d7abff8683724c8","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                              _(\u0027Unable to retrieve instances.\u0027))"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        if instances:"},{"line_number":72,"context_line":"            api.network.servers_update_networking(self.request, instances)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"            # Gather our flavors and images and correlate our instances to them"},{"line_number":75,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAT3%2F%2Fvus%3D","line":72,"updated":"2014-01-02 14:19:25.000000000","message":"Catch exception here","commit_id":"cd34d989029fa8be1c6ef5d2d1f96523daa53ec2"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"daa0328d94577c385bf8cd5b38ca9baa5cda9181","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                              _(\u0027Unable to retrieve instances.\u0027))"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        if instances:"},{"line_number":72,"context_line":"            api.network.servers_update_networking(self.request, instances)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"            # Gather our flavors and images and correlate our instances to them"},{"line_number":75,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FxEc%3D","line":72,"in_reply_to":"AAAAT3%2F%2Fvus%3D","updated":"2014-01-09 18:24:37.000000000","message":"Done","commit_id":"cd34d989029fa8be1c6ef5d2d1f96523daa53ec2"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"108260dd0a7f4b3ba10da69b0d7abff8683724c8","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        try:"},{"line_number":223,"context_line":"            instance_id \u003d self.kwargs[\u0027instance_id\u0027]"},{"line_number":224,"context_line":"            instance \u003d api.nova.server_get(self.request, instance_id)"},{"line_number":225,"context_line":"            api.network.servers_update_networking(self.request, [instance])"},{"line_number":226,"context_line":"            instance.volumes \u003d api.nova.instance_volumes_list(self.request,"},{"line_number":227,"context_line":"                                                              instance_id)"},{"line_number":228,"context_line":"            # Sort by device name"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAT3%2F%2Fvtw%3D","line":225,"updated":"2014-01-02 14:19:25.000000000","message":"Putting it in different exception block might be a good idea. So it still shows basic info even when there is neutron error.","commit_id":"cd34d989029fa8be1c6ef5d2d1f96523daa53ec2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"23c53a2d3a67bc1f73d281eed546fb9c6455916d","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        try:"},{"line_number":223,"context_line":"            instance_id \u003d self.kwargs[\u0027instance_id\u0027]"},{"line_number":224,"context_line":"            instance \u003d api.nova.server_get(self.request, instance_id)"},{"line_number":225,"context_line":"            api.network.servers_update_networking(self.request, [instance])"},{"line_number":226,"context_line":"            instance.volumes \u003d api.nova.instance_volumes_list(self.request,"},{"line_number":227,"context_line":"                                                              instance_id)"},{"line_number":228,"context_line":"            # Sort by device name"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2F9Cw%3D","line":225,"in_reply_to":"AAAAT3%2F%2Fvtw%3D","updated":"2014-01-06 09:24:18.000000000","message":"Agree. Even when neutron API call fails, we already have almost all information.","commit_id":"cd34d989029fa8be1c6ef5d2d1f96523daa53ec2"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"daa0328d94577c385bf8cd5b38ca9baa5cda9181","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        try:"},{"line_number":223,"context_line":"            instance_id \u003d self.kwargs[\u0027instance_id\u0027]"},{"line_number":224,"context_line":"            instance \u003d api.nova.server_get(self.request, instance_id)"},{"line_number":225,"context_line":"            api.network.servers_update_networking(self.request, [instance])"},{"line_number":226,"context_line":"            instance.volumes \u003d api.nova.instance_volumes_list(self.request,"},{"line_number":227,"context_line":"                                                              instance_id)"},{"line_number":228,"context_line":"            # Sort by device name"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FxEU%3D","line":225,"in_reply_to":"AAAAT3%2F%2Fvtw%3D","updated":"2014-01-09 18:24:37.000000000","message":"Done","commit_id":"cd34d989029fa8be1c6ef5d2d1f96523daa53ec2"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"daa0328d94577c385bf8cd5b38ca9baa5cda9181","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        try:"},{"line_number":223,"context_line":"            instance_id \u003d self.kwargs[\u0027instance_id\u0027]"},{"line_number":224,"context_line":"            instance \u003d api.nova.server_get(self.request, instance_id)"},{"line_number":225,"context_line":"            api.network.servers_update_networking(self.request, [instance])"},{"line_number":226,"context_line":"            instance.volumes \u003d api.nova.instance_volumes_list(self.request,"},{"line_number":227,"context_line":"                                                              instance_id)"},{"line_number":228,"context_line":"            # Sort by device name"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FxEQ%3D","line":225,"in_reply_to":"AAAAUH%2F%2F9Cw%3D","updated":"2014-01-09 18:24:37.000000000","message":"Done","commit_id":"cd34d989029fa8be1c6ef5d2d1f96523daa53ec2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3ad0b3720be57becdb08666f26b52ecd86416831","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            except Exception:"},{"line_number":75,"context_line":"                exceptions.handle("},{"line_number":76,"context_line":"                    self.request,"},{"line_number":77,"context_line":"                    message\u003d_(\u0027Unable to retrieve IP addresses from Neutron\u0027),"},{"line_number":78,"context_line":"                    ignore\u003dTrue)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"            # Gather our flavors and images and correlate our instances to them"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2BkZY%3D","line":77,"updated":"2014-01-24 10:08:59.000000000","message":"It is better to be terminated with a period.","commit_id":"e4898139fcc56abba4a0df51771c1a9956101532"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"206512a98c71d34a924d9a5755550fe88bc06001","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            except Exception:"},{"line_number":75,"context_line":"                exceptions.handle("},{"line_number":76,"context_line":"                    self.request,"},{"line_number":77,"context_line":"                    message\u003d_(\u0027Unable to retrieve IP addresses from Neutron\u0027),"},{"line_number":78,"context_line":"                    ignore\u003dTrue)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"            # Gather our flavors and images and correlate our instances to them"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2BcZo%3D","line":77,"in_reply_to":"AAAAUH%2F%2BkZY%3D","updated":"2014-01-26 09:45:51.000000000","message":"Done","commit_id":"e4898139fcc56abba4a0df51771c1a9956101532"}]}
