)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"17ff7be6b3554aa4c89087f15317bebd3b156ec2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"a90e9819_a5994b7c","updated":"2025-05-21 18:09:48.000000000","message":"@jjasek@redhat.com hello, please close this MR.","commit_id":"d6f8364d8e47c232e886d99754ea64b8c5bf6db3"}],"openstack_dashboard/static/app/core/images/actions/delete-image.service.spec.js":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0d59388af8c8e1cb711beaa617425a3d42b35ba3","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        expect(deleteModalService.open).not.toHaveBeenCalled();"},{"line_number":187,"context_line":"      }"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"      function testGlance() {"},{"line_number":190,"context_line":"        spyOn(glanceAPI, \u0027deleteImage\u0027);"},{"line_number":191,"context_line":"        var imageCount \u003d 1;"},{"line_number":192,"context_line":"        var images \u003d generateImage(imageCount);"}],"source_content_type":"text/javascript","patch_set":21,"id":"9f560f44_b285640a","line":189,"range":{"start_line":189,"start_character":15,"end_line":189,"end_character":25},"updated":"2020-09-14 22:03:13.000000000","message":"See my comment at L.203.","commit_id":"c2c1284a9c5f622a31a6fc4d8184052db1b12475"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"0817c4e150591f4c578e1b5e6bb7932d2cdfe658","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        expect(deleteModalService.open).not.toHaveBeenCalled();"},{"line_number":187,"context_line":"      }"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"      function testGlance() {"},{"line_number":190,"context_line":"        spyOn(glanceAPI, \u0027deleteImage\u0027);"},{"line_number":191,"context_line":"        var imageCount \u003d 1;"},{"line_number":192,"context_line":"        var images \u003d generateImage(imageCount);"}],"source_content_type":"text/javascript","patch_set":21,"id":"9f560f44_98c52c91","line":189,"range":{"start_line":189,"start_character":15,"end_line":189,"end_character":25},"in_reply_to":"9f560f44_18847c5d","updated":"2020-09-24 11:06:01.000000000","message":"sorry I didn\u0027t understand this comment completely what you want? You want me to update this test name as well and what it should be after the update:(","commit_id":"c2c1284a9c5f622a31a6fc4d8184052db1b12475"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b5e32127d309e3daa8d92f2b717e55ec7cf7b9a1","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        expect(deleteModalService.open).not.toHaveBeenCalled();"},{"line_number":187,"context_line":"      }"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"      function testGlance() {"},{"line_number":190,"context_line":"        spyOn(glanceAPI, \u0027deleteImage\u0027);"},{"line_number":191,"context_line":"        var imageCount \u003d 1;"},{"line_number":192,"context_line":"        var images \u003d generateImage(imageCount);"}],"source_content_type":"text/javascript","patch_set":21,"id":"9f560f44_18847c5d","line":189,"range":{"start_line":189,"start_character":15,"end_line":189,"end_character":25},"in_reply_to":"9f560f44_b285640a","updated":"2020-09-24 10:59:11.000000000","message":"This is not addressed. This is a counterpart of the test added, so I think it makes sense to update it.","commit_id":"c2c1284a9c5f622a31a6fc4d8184052db1b12475"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0d59388af8c8e1cb711beaa617425a3d42b35ba3","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        var contextArg \u003d deleteModalService.open.calls.argsFor(0)[2];"},{"line_number":198,"context_line":"        var deleteFunction \u003d contextArg.deleteEntity;"},{"line_number":199,"context_line":"        deleteFunction(image.id);"},{"line_number":200,"context_line":"        expect(glanceAPI.deleteImage).toHaveBeenCalledWith(image.id, true);"},{"line_number":201,"context_line":"      }"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"      function testGlanceResult() {"}],"source_content_type":"text/javascript","patch_set":21,"id":"9f560f44_728bcc1d","line":200,"updated":"2020-09-14 22:03:13.000000000","message":"Is it better to check the redirected path is /project/images/ as you do at L.218 below (for the admin page).","commit_id":"c2c1284a9c5f622a31a6fc4d8184052db1b12475"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"18a5fc9bc40eaf6f687a0c5a9ed43038c7538964","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        var contextArg \u003d deleteModalService.open.calls.argsFor(0)[2];"},{"line_number":198,"context_line":"        var deleteFunction \u003d contextArg.deleteEntity;"},{"line_number":199,"context_line":"        deleteFunction(image.id);"},{"line_number":200,"context_line":"        expect(glanceAPI.deleteImage).toHaveBeenCalledWith(image.id, true);"},{"line_number":201,"context_line":"      }"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"      function testGlanceResult() {"}],"source_content_type":"text/javascript","patch_set":21,"id":"9f560f44_83ae66e4","line":200,"in_reply_to":"9f560f44_728bcc1d","updated":"2020-09-24 08:29:09.000000000","message":"Done.","commit_id":"c2c1284a9c5f622a31a6fc4d8184052db1b12475"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0d59388af8c8e1cb711beaa617425a3d42b35ba3","unresolved":false,"context_lines":[{"line_number":200,"context_line":"        expect(glanceAPI.deleteImage).toHaveBeenCalledWith(image.id, true);"},{"line_number":201,"context_line":"      }"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"      function testGlanceResult() {"},{"line_number":204,"context_line":"        $location.path(\"ngdetails/OS::Glance::Image/1?nav\u003d/admin/images/\");"},{"line_number":205,"context_line":"        var imageCount \u003d 1;"},{"line_number":206,"context_line":"        var images \u003d generateImage(imageCount);"}],"source_content_type":"text/javascript","patch_set":21,"id":"9f560f44_32983474","line":203,"range":{"start_line":203,"start_character":15,"end_line":203,"end_character":31},"updated":"2020-09-14 22:03:13.000000000","message":"The test name sounds odd. This test checks the path redirected after deleting an image. I guess you just borrowed the code from testGlance above, but it is a good chance to update them.","commit_id":"c2c1284a9c5f622a31a6fc4d8184052db1b12475"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"18a5fc9bc40eaf6f687a0c5a9ed43038c7538964","unresolved":false,"context_lines":[{"line_number":200,"context_line":"        expect(glanceAPI.deleteImage).toHaveBeenCalledWith(image.id, true);"},{"line_number":201,"context_line":"      }"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"      function testGlanceResult() {"},{"line_number":204,"context_line":"        $location.path(\"ngdetails/OS::Glance::Image/1?nav\u003d/admin/images/\");"},{"line_number":205,"context_line":"        var imageCount \u003d 1;"},{"line_number":206,"context_line":"        var images \u003d generateImage(imageCount);"}],"source_content_type":"text/javascript","patch_set":21,"id":"9f560f44_03e9b618","line":203,"range":{"start_line":203,"start_character":15,"end_line":203,"end_character":31},"in_reply_to":"9f560f44_32983474","updated":"2020-09-24 08:29:09.000000000","message":"Done.","commit_id":"c2c1284a9c5f622a31a6fc4d8184052db1b12475"}]}