)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"80e72e359bf824134a7de1a27a355218b83fa816","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     pengyuesheng \u003cpengyuesheng@gohighsec.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-04-02 15:31:01 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Input limit on key name"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"depend-on:https://github.com/openstack/cinder/blob/master/cinder/api/validation/parameter_types.py#L150"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_c46f77fa","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":23},"updated":"2019-04-02 09:41:13.000000000","message":"Implementation is not as per bug and commit message, IMO change LP bug description as existing implementation.","commit_id":"931aaf61325fc0ae29276fab31c767a08c79127d"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"7689eb25ffb6b92f11abe1a90701dbd9db2e85e0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     pengyuesheng \u003cpengyuesheng@gohighsec.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-04-02 15:31:01 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Input limit on key name"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"depend-on:https://github.com/openstack/cinder/blob/master/cinder/api/validation/parameter_types.py#L150"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_6ec77966","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":23},"in_reply_to":"5fc1f717_c46f77fa","updated":"2019-04-02 13:58:31.000000000","message":"In addition to Vishal\u0027s comment, could you explain where you changed (like qos_spec form)? Your commit messages always explain how you change but do not mention where is changed, so it is hard to find where is changed from commit messages (i.e., git log).","commit_id":"931aaf61325fc0ae29276fab31c767a08c79127d"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"80e72e359bf824134a7de1a27a355218b83fa816","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Input limit on key name"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"depend-on:https://github.com/openstack/cinder/blob/master/cinder/api/validation/parameter_types.py#L150"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I295541ab3adb16b28ffe69cae1cfb48a3daf7d31"},{"line_number":12,"context_line":"Closes-Bug: #1822734"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_3f452644","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":103},"updated":"2019-04-02 09:41:13.000000000","message":"The format of this reference is wrong,\nDepends-On is a special tag used for cross-project dependencies.\nYou can rewrite it as :\n\nThis patch implements the regex validation for specs in qos_specs as implemented in cinder[1].\n\n[1] https://github.com/openstack/cinder/blob/master/cinder/api/validation/parameter_types.py#L150","commit_id":"931aaf61325fc0ae29276fab31c767a08c79127d"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"05d8e6adaef64e7e15d201079b38dd7f155a7cfc","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     pengyuesheng \u003cpengyuesheng@gohighsec.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-04-03 14:01:32 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Check if the key meets the specifications"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In create qos spec form under the volume type panel,"},{"line_number":10,"context_line":"if the key does not match the regex,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"bfb3d3c7_09324211","line":7,"range":{"start_line":7,"start_character":27,"end_line":7,"end_character":41},"updated":"2019-05-23 08:38:42.000000000","message":"-\u003e cinder API validation","commit_id":"87b34ef73e30effe47f27706579aae9a6ef8e2db"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"05d8e6adaef64e7e15d201079b38dd7f155a7cfc","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In create qos spec form under the volume type panel,"},{"line_number":10,"context_line":"if the key does not match the regex,"},{"line_number":11,"context_line":"failed to create qos spec"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch implements the regex validation for specs in qos_specs as"},{"line_number":14,"context_line":"implemented in cinder[1]."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"bfb3d3c7_a97216e2","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":25},"updated":"2019-05-23 08:38:42.000000000","message":"The subject is missing.... but the author seems not to care the grammar so much.","commit_id":"87b34ef73e30effe47f27706579aae9a6ef8e2db"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"05d8e6adaef64e7e15d201079b38dd7f155a7cfc","unresolved":false,"context_lines":[{"line_number":10,"context_line":"if the key does not match the regex,"},{"line_number":11,"context_line":"failed to create qos spec"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch implements the regex validation for specs in qos_specs as"},{"line_number":14,"context_line":"implemented in cinder[1]."},{"line_number":15,"context_line":"[1] https://github.com/openstack/cinder/blob/master/cinder/api/validation/parameter_types.py#L150"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"bfb3d3c7_094d6299","line":13,"range":{"start_line":13,"start_character":47,"end_line":13,"end_character":52},"updated":"2019-05-23 08:38:42.000000000","message":"-\u003e the spec","commit_id":"87b34ef73e30effe47f27706579aae9a6ef8e2db"}],"openstack_dashboard/dashboards/admin/volume_types/qos_specs/forms.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"7689eb25ffb6b92f11abe1a90701dbd9db2e85e0","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"KEY_NAME_REGEX \u003d re.compile(r\"^[a-zA-Z0-9-_:. /]+$\", re.UNICODE)"},{"line_number":26,"context_line":"KEY_ERROR_MESSAGES \u003d {"},{"line_number":27,"context_line":"    \u0027invalid\u0027: _(\"does not match the regexes: \u0027^[a-zA-Z0-9-_:. /]\u0027\")}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class CreateKeyValuePair(forms.SelfHandlingForm):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_4ea4fdb9","line":27,"range":{"start_line":27,"start_character":17,"end_line":27,"end_character":67},"updated":"2019-04-02 13:58:31.000000000","message":"The message should be a complete sentence. At least the subject must exist.","commit_id":"931aaf61325fc0ae29276fab31c767a08c79127d"}]}