)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"845a792114b1ccbf41ccc6143dc55cf44bd06906","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     pengyuesheng \u003cpengyuesheng@gohighsec.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-04-03 10:05:01 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Judge if data[\u0027key\u0027] exists in Create Extra Spec Form under Volume Type Panel"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I5ecdbb37953e95b302a254748cfc2a6a615c7d4b"},{"line_number":10,"context_line":"Closes-Bug: #1822924"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_59b03bde","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":77},"updated":"2019-04-03 05:12:04.000000000","message":"Please, provide a commit message that follows OpenStack guidelines [1].\n\n[1] https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"c08748dfc610a0e49b93ddbad1c8532bf1aa00f9"},{"author":{"_account_id":27822,"name":"pengyuesheng","email":"pengyuesheng@gohighsec.com","username":"pengyuesheng"},"change_message_id":"6724ac92349c44617d3e2a11d5d4371bf2aee671","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     pengyuesheng \u003cpengyuesheng@gohighsec.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-04-03 10:05:01 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Judge if data[\u0027key\u0027] exists in Create Extra Spec Form under Volume Type Panel"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I5ecdbb37953e95b302a254748cfc2a6a615c7d4b"},{"line_number":10,"context_line":"Closes-Bug: #1822924"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_94742a9e","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":77},"in_reply_to":"5fc1f717_59b03bde","updated":"2019-04-03 06:25:42.000000000","message":"Done","commit_id":"c08748dfc610a0e49b93ddbad1c8532bf1aa00f9"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"be2a7af36c886ad1bdbfdbab9fb2baac48f49821","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     pengyuesheng \u003cpengyuesheng@gohighsec.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-04-03 13:51:18 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Judge if data[\u0027key\u0027] exists"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In Create Extra Spec Form under Volume Type Panel,"},{"line_number":10,"context_line":"in the clean method, need to determine whether"},{"line_number":11,"context_line":"data[\u0027key\u0027] exists, because data[\u0027key\u0027] does"},{"line_number":12,"context_line":"not exist if the key does not match to the regex"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I5ecdbb37953e95b302a254748cfc2a6a615c7d4b"},{"line_number":15,"context_line":"Closes-Bug: #1822924"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5fc1f717_873cf5e1","line":12,"range":{"start_line":7,"start_character":0,"end_line":12,"end_character":48},"updated":"2019-04-03 12:59:26.000000000","message":"Implementation is not as per bug and commit message, IMO change LP bug description.","commit_id":"1d0d41701d984d2b6decdb9a200782c4a699ba8b"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"ae29eebc43b3ed239725c5d31c03005f9f9a49b4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     pengyuesheng \u003cpengyuesheng@gohighsec.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-04-04 09:26:35 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Judge if data[\u0027key\u0027] exists on Create Extra Spec Form"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In Create Extra Spec Form under Volume Type Panel,"},{"line_number":10,"context_line":"when an extra spec already exists,"},{"line_number":11,"context_line":"create an extra spec with the name \"#^\u0026*\" will report an error."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This bug is due to the fact that data[\"key\"] does not exist,"},{"line_number":14,"context_line":"but uses it."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I5ecdbb37953e95b302a254748cfc2a6a615c7d4b"},{"line_number":17,"context_line":"Closes-Bug: #1822924"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5fc1f717_88f8667c","line":14,"range":{"start_line":7,"start_character":0,"end_line":14,"end_character":12},"updated":"2019-04-04 14:21:00.000000000","message":"Commit message can be improved.","commit_id":"b3c0d9336825c07861a277c1d411396e6a6de2c4"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"a4974aa980b4817082e6e4a0844afffb62068988","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     pengyuesheng \u003cpengyuesheng@gohighsec.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-04-04 09:26:35 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Judge if data[\u0027key\u0027] exists on Create Extra Spec Form"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In Create Extra Spec Form under Volume Type Panel,"},{"line_number":10,"context_line":"when an extra spec already exists,"},{"line_number":11,"context_line":"create an extra spec with the name \"#^\u0026*\" will report an error."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This bug is due to the fact that data[\"key\"] does not exist,"},{"line_number":14,"context_line":"but uses it."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I5ecdbb37953e95b302a254748cfc2a6a615c7d4b"},{"line_number":17,"context_line":"Closes-Bug: #1822924"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5fc1f717_e80faa85","line":14,"range":{"start_line":7,"start_character":0,"end_line":14,"end_character":12},"in_reply_to":"5fc1f717_88f8667c","updated":"2019-04-04 14:22:59.000000000","message":"Done.","commit_id":"b3c0d9336825c07861a277c1d411396e6a6de2c4"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"015ade05ff2b102548f44cf4b9f5eb8ce360b18b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Correct error messages of Create Extra Spec Form under Volume Type Panel"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When there is more than one Extra Specs in Volume Type Extra "},{"line_number":10,"context_line":"Specs, then create an Extra spec with the Key name \"#^\u0026*\", the "},{"line_number":11,"context_line":"form prompts an Wrong error. This patch correcting the error message."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5fc1f717_26c64318","line":9,"updated":"2019-04-05 11:09:59.000000000","message":"Remove the trailing space","commit_id":"692064fbd82ad2f40bec22752623ab8904e8334a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"015ade05ff2b102548f44cf4b9f5eb8ce360b18b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Correct error messages of Create Extra Spec Form under Volume Type Panel"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When there is more than one Extra Specs in Volume Type Extra "},{"line_number":10,"context_line":"Specs, then create an Extra spec with the Key name \"#^\u0026*\", the "},{"line_number":11,"context_line":"form prompts an Wrong error. This patch correcting the error message."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I5ecdbb37953e95b302a254748cfc2a6a615c7d4b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5fc1f717_46c90f23","line":10,"updated":"2019-04-05 11:09:59.000000000","message":"ditto","commit_id":"692064fbd82ad2f40bec22752623ab8904e8334a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"015ade05ff2b102548f44cf4b9f5eb8ce360b18b","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When there is more than one Extra Specs in Volume Type Extra "},{"line_number":10,"context_line":"Specs, then create an Extra spec with the Key name \"#^\u0026*\", the "},{"line_number":11,"context_line":"form prompts an Wrong error. This patch correcting the error message."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I5ecdbb37953e95b302a254748cfc2a6a615c7d4b"},{"line_number":14,"context_line":"Closes-Bug: #1822924"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5fc1f717_06d307d7","line":11,"range":{"start_line":11,"start_character":40,"end_line":11,"end_character":51},"updated":"2019-04-05 11:09:59.000000000","message":"-\u003e corrects","commit_id":"692064fbd82ad2f40bec22752623ab8904e8334a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"015ade05ff2b102548f44cf4b9f5eb8ce360b18b","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When there is more than one Extra Specs in Volume Type Extra "},{"line_number":10,"context_line":"Specs, then create an Extra spec with the Key name \"#^\u0026*\", the "},{"line_number":11,"context_line":"form prompts an Wrong error. This patch correcting the error message."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I5ecdbb37953e95b302a254748cfc2a6a615c7d4b"},{"line_number":14,"context_line":"Closes-Bug: #1822924"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5fc1f717_86de17d8","line":11,"range":{"start_line":11,"start_character":15,"end_line":11,"end_character":21},"updated":"2019-04-05 11:09:59.000000000","message":"No need to capitalize it: an Wrong -\u003e a wrong error message","commit_id":"692064fbd82ad2f40bec22752623ab8904e8334a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"fd7a3d547bc2504e128e8c282a89254ca5be787d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Correct error messages of Create Extra Spec Form under Volume Type Panel"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When there is more than one Extra Specs in Volume Type Extra"},{"line_number":10,"context_line":"Specs, then create an Extra spec with the Key name \"#^\u0026*\", the"},{"line_number":11,"context_line":"form prompts a wrong error message. This patch corrects the error message."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I5ecdbb37953e95b302a254748cfc2a6a615c7d4b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5fc1f717_804812b3","line":10,"range":{"start_line":10,"start_character":51,"end_line":10,"end_character":57},"updated":"2019-04-08 06:01:01.000000000","message":"This example does not describe what is the point. Let me update the commit messge.","commit_id":"7dba5d4e138df6d1e7171a18147e06bfff7915aa"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"26f5bdb3dc11f161fda15cf35935e5ea22b95365","unresolved":false,"context_lines":[{"line_number":11,"context_line":"the form prompts a wrong error message."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Add a validation message when a user try to \u0027Create\u0027"},{"line_number":14,"context_line":"a qos spec with an existing key name."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This patch corrects the error message and add a validation message."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"3fce034c_2121b4a0","line":14,"updated":"2019-04-11 02:49:26.000000000","message":"according to https://bugs.launchpad.net/bugs/1822724, you are fixing another bug. Closes-Bug should be added.\n\n(Note that fixing two bugs in a single patch is not recommended.)","commit_id":"7f669c0adc45e6ef2a40ed90e2f57eb83e9d5787"}],"openstack_dashboard/dashboards/admin/volume_types/extras/forms.py":[{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"be2a7af36c886ad1bdbfdbab9fb2baac48f49821","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        extra_list \u003d api.cinder.volume_type_extra_get(self.request,"},{"line_number":41,"context_line":"                                                      type_id)"},{"line_number":42,"context_line":"        for extra in extra_list:"},{"line_number":43,"context_line":"            if data.get(\"key\") and extra.key.lower() \u003d\u003d data[\u0027key\u0027].lower():"},{"line_number":44,"context_line":"                error_msg \u003d _(\u0027Key with name \"%s\" already exists. Use Edit to \u0027"},{"line_number":45,"context_line":"                              \u0027update the value, else create key with \u0027"},{"line_number":46,"context_line":"                              \u0027different name.\u0027) % data[\u0027key\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_a20a3f1d","line":43,"range":{"start_line":43,"start_character":15,"end_line":43,"end_character":35},"updated":"2019-04-03 12:59:26.000000000","message":"why we need this condition?\nCould you please elaborate when this condition is going to use.","commit_id":"1d0d41701d984d2b6decdb9a200782c4a699ba8b"},{"author":{"_account_id":27822,"name":"pengyuesheng","email":"pengyuesheng@gohighsec.com","username":"pengyuesheng"},"change_message_id":"6be840a863cdf144dcfe49c095fa601d0d500df7","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        extra_list \u003d api.cinder.volume_type_extra_get(self.request,"},{"line_number":41,"context_line":"                                                      type_id)"},{"line_number":42,"context_line":"        for extra in extra_list:"},{"line_number":43,"context_line":"            if data.get(\"key\") and extra.key.lower() \u003d\u003d data[\u0027key\u0027].lower():"},{"line_number":44,"context_line":"                error_msg \u003d _(\u0027Key with name \"%s\" already exists. Use Edit to \u0027"},{"line_number":45,"context_line":"                              \u0027update the value, else create key with \u0027"},{"line_number":46,"context_line":"                              \u0027different name.\u0027) % data[\u0027key\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_15ca6145","line":43,"range":{"start_line":43,"start_character":15,"end_line":43,"end_character":35},"in_reply_to":"5fc1f717_a20a3f1d","updated":"2019-04-04 01:35:32.000000000","message":"When the key is entered as \"##$%\", RegexField will make an error, and there is no key in data. If data[\"key\"] is used directly, an error will be reported.","commit_id":"1d0d41701d984d2b6decdb9a200782c4a699ba8b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"015ade05ff2b102548f44cf4b9f5eb8ce360b18b","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        extra_list \u003d api.cinder.volume_type_extra_get(self.request,"},{"line_number":41,"context_line":"                                                      type_id)"},{"line_number":42,"context_line":"        for extra in extra_list:"},{"line_number":43,"context_line":"            if data.get(\"key\") and extra.key.lower() \u003d\u003d data[\u0027key\u0027].lower():"},{"line_number":44,"context_line":"                error_msg \u003d _(\u0027Key with name \"%s\" already exists. Use Edit to \u0027"},{"line_number":45,"context_line":"                              \u0027update the value, else create key with \u0027"},{"line_number":46,"context_line":"                              \u0027different name.\u0027) % data[\u0027key\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_cf88a223","line":43,"updated":"2019-04-05 11:09:59.000000000","message":"You said \"#^\u0026*\" is provided as \"key\". In this case, \"key\" is not included in \"data\" because it does not satisfy the regex at L.33. \n\nThus, there is no need of \"for\" loop.\n\nPlease move the check for \"key\" existence before the \"for\" loop.\n\nIn addition,\n\n \"key\" in data\n\nis better than\n\n data.get(\u0027key\u0027)","commit_id":"692064fbd82ad2f40bec22752623ab8904e8334a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"dbbc8d12187015db1236a4c6202c68ee58c1cc97","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                if extra.key.lower() \u003d\u003d data[\u0027key\u0027].lower():"},{"line_number":45,"context_line":"                    error_msg \u003d _(\u0027Key with name \"%s\" already exists. Use \u0027"},{"line_number":46,"context_line":"                                  \u0027Edit to update the value, else create key \u0027"},{"line_number":47,"context_line":"                                  \u0027with different name.\u0027) % data[\u0027key\u0027]"},{"line_number":48,"context_line":"                    raise forms.ValidationError(error_msg)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        return data"}],"source_content_type":"text/x-python","patch_set":6,"id":"5fc1f717_fe55f2c2","line":47,"updated":"2019-04-08 11:20:27.000000000","message":"There is much room to improve this message including incorrect grammar, but this is another topic. I will improve it later.","commit_id":"506c6e6c8b8334831568f0ca6958af6465f56b95"}],"openstack_dashboard/dashboards/admin/volume_types/qos_specs/forms.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"eef680fe6e66c8a9ad1e0acd84c18e10fd5071fe","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        data \u003d super(CreateKeyValuePair, self).clean()"},{"line_number":30,"context_line":"        qos_spec_id \u003d self.initial[\u0027qos_spec_id\u0027]"},{"line_number":31,"context_line":"        qos_list \u003d api.cinder.qos_spec_get_keys(self.request, qos_spec_id)"},{"line_number":32,"context_line":"        if \"key\" in data:"},{"line_number":33,"context_line":"            for qos in qos_list:"},{"line_number":34,"context_line":"                if qos.key.lower() \u003d\u003d data[\u0027key\u0027].lower():"},{"line_number":35,"context_line":"                    error_msg \u003d _(\u0027Key with name \"%s\" already exists. Use \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"5fc1f717_17450eb4","line":32,"range":{"start_line":32,"start_character":8,"end_line":32,"end_character":25},"updated":"2019-04-10 09:01:39.000000000","message":"Why do you need this change in this form?\n\"key\" is CharField, so I think it always exists.","commit_id":"6fd152cd60ab94a8e6ce28d1186f881b292b588e"}]}