)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"58052ae6df1537e0ac8b939e7ca656a957b414e5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support to modal.js for file attachments in form response"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The none modal forms handle this fine, but the ajax wrapping in modal.js"},{"line_number":10,"context_line":"doesn\u0027t handle this properly and just appends the file data to the page."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This will correctly process the file, and download it before closing the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"dfbec78f_55f9a24a","line":9,"range":{"start_line":9,"start_character":4,"end_line":9,"end_character":14},"updated":"2019-05-10 05:23:23.000000000","message":"nit: perhaps \"non-modal\" is better.","commit_id":"678bcd0711943ee5cd45a88415eaa94ac3d33104"},{"author":{"_account_id":10420,"name":"Adrian Turjak","email":"devs+openstack@uncaught-exceptions.com","username":"adriant"},"change_message_id":"e5f92bb6938036ef5f98808cf4eee8816e7d6525","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support to modal.js for file attachments in form response"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The none modal forms handle this fine, but the ajax wrapping in modal.js"},{"line_number":10,"context_line":"doesn\u0027t handle this properly and just appends the file data to the page."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This will correctly process the file, and download it before closing the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"dfbec78f_a13d20c5","line":9,"range":{"start_line":9,"start_character":4,"end_line":9,"end_character":14},"in_reply_to":"dfbec78f_55f9a24a","updated":"2019-05-12 23:00:50.000000000","message":"blast, yes, missed that typo","commit_id":"678bcd0711943ee5cd45a88415eaa94ac3d33104"}],"horizon/static/horizon/js/horizon.modals.js":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"58052ae6df1537e0ac8b939e7ca656a957b414e5","unresolved":false,"context_lines":[{"line_number":340,"context_line":"        modal_attachment_link.click();"},{"line_number":341,"context_line":"        modal_attachment_link.remove();"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"        if (redirect_header){"},{"line_number":344,"context_line":"          location.href \u003d redirect_header;"},{"line_number":345,"context_line":"        }"},{"line_number":346,"context_line":"      } else if (redirect_header) {"}],"source_content_type":"text/javascript","patch_set":5,"id":"dfbec78f_b5b81e76","line":343,"range":{"start_line":343,"start_character":28,"end_line":343,"end_character":29},"updated":"2019-05-10 05:23:23.000000000","message":"nit: space before { (for consistency)","commit_id":"678bcd0711943ee5cd45a88415eaa94ac3d33104"},{"author":{"_account_id":10420,"name":"Adrian Turjak","email":"devs+openstack@uncaught-exceptions.com","username":"adriant"},"change_message_id":"e5f92bb6938036ef5f98808cf4eee8816e7d6525","unresolved":false,"context_lines":[{"line_number":340,"context_line":"        modal_attachment_link.click();"},{"line_number":341,"context_line":"        modal_attachment_link.remove();"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"        if (redirect_header){"},{"line_number":344,"context_line":"          location.href \u003d redirect_header;"},{"line_number":345,"context_line":"        }"},{"line_number":346,"context_line":"      } else if (redirect_header) {"}],"source_content_type":"text/javascript","patch_set":5,"id":"dfbec78f_c13a94ca","line":343,"range":{"start_line":343,"start_character":28,"end_line":343,"end_character":29},"in_reply_to":"dfbec78f_b5b81e76","updated":"2019-05-12 23:00:50.000000000","message":"Done","commit_id":"678bcd0711943ee5cd45a88415eaa94ac3d33104"}]}