)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27838,"name":"Vadym Markov","email":"vmarkov@mirantis.com","username":"vmarkov"},"change_message_id":"dd81d4990573a49720e45eb8a958109f5abd48a5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     pengyuesheng \u003cpengyuesheng@gohighsec.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-04-11 11:22:56 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"In admin panel subnet page subnet_free_ips is less than 0, returns 0"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I3f1441bf5e4eb3017024db2865adf3296127793e"},{"line_number":10,"context_line":"Closes-Bug: #1823149"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fce034c_e773677f","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":68},"updated":"2019-04-16 13:26:26.000000000","message":"Please expand commit message, it is too unclear","commit_id":"c9187a725538d8ee9fd1ad40aef1abcce0fb36d1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"30ca8a8a76d905e1d6fd63bd0593b6e41d5cd6ec","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Create 5 ports in advance,"},{"line_number":10,"context_line":"Then edit the subnet and set the range of the"},{"line_number":11,"context_line":"allocation_pools value to 10.10.10.3-10.10.10.4,"},{"line_number":12,"context_line":"We will find that the available ip becomes negative"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I3f1441bf5e4eb3017024db2865adf3296127793e"},{"line_number":15,"context_line":"Closes-Bug: #1823149"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3fce034c_46cc9d69","line":12,"updated":"2019-04-17 18:16:37.000000000","message":"Personally I would like to sse more generalized description in the commit message to describe what actually happens and how the problem solves. This is what I usually feel when reading your commit message. You are sending a lot of fixes so it would be really nice if commit messages are improved.","commit_id":"f75756f0c95e6874efe1f8fde85f220fe7b11502"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"7fee4709564d35b64bfe481bf9968f2576240482","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In subnet page under admin panel,"},{"line_number":10,"context_line":"Subnet_free_ips is negative if the subnet\u0027s allocation_pools"},{"line_number":11,"context_line":"range is less than the existing ip of the subnet."},{"line_number":12,"context_line":"This patch is When subnet_free_ips is negative, the value becomes 0."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I3f1441bf5e4eb3017024db2865adf3296127793e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3fce034c_e686df13","line":11,"range":{"start_line":11,"start_character":22,"end_line":11,"end_character":34},"updated":"2019-04-18 05:26:37.000000000","message":"-\u003e used IPs\n\n\"existing\" is super confusing as it can be interpreted as both \"used\" and \"free\".","commit_id":"fad3518fec4ae7547233d288f80e7019eec0882a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"7fee4709564d35b64bfe481bf9968f2576240482","unresolved":false,"context_lines":[{"line_number":9,"context_line":"In subnet page under admin panel,"},{"line_number":10,"context_line":"Subnet_free_ips is negative if the subnet\u0027s allocation_pools"},{"line_number":11,"context_line":"range is less than the existing ip of the subnet."},{"line_number":12,"context_line":"This patch is When subnet_free_ips is negative, the value becomes 0."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I3f1441bf5e4eb3017024db2865adf3296127793e"},{"line_number":15,"context_line":"Closes-Bug: #1823149"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3fce034c_c6af237b","line":12,"updated":"2019-04-18 05:26:37.000000000","message":"-\u003e \"... adjusts subnet_free_ips to 0 when it is negative\"?","commit_id":"fad3518fec4ae7547233d288f80e7019eec0882a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d4ab10ff26b04f751f22439d2d072878d0e18b80","unresolved":false,"context_lines":[{"line_number":9,"context_line":"In subnet page under admin panel,"},{"line_number":10,"context_line":"Subnet_free_ips is negative if the subnet\u0027s allocation_pools"},{"line_number":11,"context_line":"range is less than the used IPs of the subnet."},{"line_number":12,"context_line":"This patch is adjusts subnet_free_ips to 0 when it is negative."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I3f1441bf5e4eb3017024db2865adf3296127793e"},{"line_number":15,"context_line":"Closes-Bug: #1823149"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3fce034c_54a8a08a","line":12,"range":{"start_line":12,"start_character":11,"end_line":12,"end_character":13},"updated":"2019-04-19 07:40:28.000000000","message":"unnecessary. Double verbs :-(","commit_id":"789339036017d922a098d11837d9f18ed006c439"}],"openstack_dashboard/dashboards/admin/networks/subnets/tables.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d74865dfd0d5f40d5b21f99b6a0fd77a609c651b","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        if subnet_availability \u003e 10000:"},{"line_number":82,"context_line":"            return \"\u003e10000\""},{"line_number":83,"context_line":"        elif subnet_availability \u003c 0:"},{"line_number":84,"context_line":"            return \"0\""},{"line_number":85,"context_line":"        else:"},{"line_number":86,"context_line":"            return str(subnet_availability)"},{"line_number":87,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fce034c_26130a69","line":84,"updated":"2019-04-11 02:42:44.000000000","message":"It looks better to handle this at L.160. This function should handle only visibility, but  negative value is not a visibility issue. It is a bug on calculation and the calculation is done in _add_subnet_availability()\n\nIn addition, this is worth having unit test coverage.","commit_id":"f6d92895333678c83ece59a70ff0110618e82135"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"30ca8a8a76d905e1d6fd63bd0593b6e41d5cd6ec","unresolved":false,"context_lines":[{"line_number":156,"context_line":"                subnet_used_ips \u003d subnet_usage.get(\"used_ips\")"},{"line_number":157,"context_line":"                subnet_total_ips \u003d subnet_usage.get(\"total_ips\")"},{"line_number":158,"context_line":"                subnet_free_ips \u003d subnet_total_ips - subnet_used_ips"},{"line_number":159,"context_line":"                subnet_free_ips \u003d subnet_free_ips if subnet_free_ips \u003e 0 else 0"},{"line_number":160,"context_line":"                for item in subnets_dict:"},{"line_number":161,"context_line":"                    id \u003d item.get(\"id\")"},{"line_number":162,"context_line":"                    if id \u003d\u003d subnet_id:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fce034c_e68d8931","line":159,"updated":"2019-04-17 18:16:37.000000000","message":"super nit: the logic is correct but using if-clause highlights what we would like to do more.\n\n  if subnet_free_ips \u003c 0:\n       subnet_free_ips \u003d 0","commit_id":"f75756f0c95e6874efe1f8fde85f220fe7b11502"}]}