)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"5afa35eced6d52858231ed5e95baa4367ca61ef3","unresolved":false,"context_lines":[{"line_number":9,"context_line":"On instance panel，if the volume is the root device volume,"},{"line_number":10,"context_line":"the detached volume will fail,"},{"line_number":11,"context_line":"the root device volume cannot be Detach."},{"line_number":12,"context_line":"This patch hide the root device volume."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Iab6be5ed94d794ff5ef6a201671165aaba89f3ec"},{"line_number":15,"context_line":"Closes-Bug: #1824076"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3fce034c_49515836","line":12,"updated":"2019-04-14 16:15:28.000000000","message":"The commit message is different from what you actually change. The message is incorrect.","commit_id":"27d4aebd60cc46470bd952535ec004ee6c05376c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e1f51196774398eff4ce0d42bc9e1792c2912741","unresolved":false,"context_lines":[{"line_number":9,"context_line":"On instance panel，if the volume is the root device volume,"},{"line_number":10,"context_line":"the detached volume will fail,"},{"line_number":11,"context_line":"but the error message does not explain the cause of the error."},{"line_number":12,"context_line":"This patch corrects the error message."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Co-Authored-By: Vishal Manchanda \u003cmanchandavishal143@gmail.com\u003e"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"7faddb67_b26a12ea","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":38},"updated":"2019-08-05 01:28:12.000000000","message":"Precisely speaking, this sentence is no longer correct, but I am okay.","commit_id":"26c5c8c34392124a5c81859ef0acfffd371e6743"}],"openstack_dashboard/dashboards/project/instances/forms.py":[{"author":{"_account_id":27838,"name":"Vadym Markov","email":"vmarkov@mirantis.com","username":"vmarkov"},"change_message_id":"c651b99f52e6d64b6b17270455c7f28933acc96a","unresolved":false,"context_lines":[{"line_number":293,"context_line":"                        \u0027%(inst)s.\u0027) % {\"vol\": volume,"},{"line_number":294,"context_line":"                                        \"inst\": instance_id}"},{"line_number":295,"context_line":"            messages.info(request, message)"},{"line_number":296,"context_line":"        except nova_exceptions.BadRequest as exc:"},{"line_number":297,"context_line":"            exceptions.handle(request, exc)"},{"line_number":298,"context_line":"        except Exception:"},{"line_number":299,"context_line":"            redirect \u003d reverse(\u0027horizon:project:instances:index\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fce034c_84dc1a75","line":296,"range":{"start_line":296,"start_character":31,"end_line":296,"end_character":41},"updated":"2019-04-12 12:35:00.000000000","message":"We need to notify user about failed operation","commit_id":"27d4aebd60cc46470bd952535ec004ee6c05376c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"5afa35eced6d52858231ed5e95baa4367ca61ef3","unresolved":false,"context_lines":[{"line_number":298,"context_line":"        except Exception:"},{"line_number":299,"context_line":"            redirect \u003d reverse(\u0027horizon:project:instances:index\u0027)"},{"line_number":300,"context_line":"            exceptions.handle(request,"},{"line_number":301,"context_line":"                              _(\"Unable to detach volume.\"),"},{"line_number":302,"context_line":"                              redirect\u003dredirect)"},{"line_number":303,"context_line":"        return True"},{"line_number":304,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3fce034c_294c0c9d","line":301,"updated":"2019-04-14 16:15:28.000000000","message":"How about adding the detail exception message to the message here? This is same as what you do.","commit_id":"27d4aebd60cc46470bd952535ec004ee6c05376c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"5a5320b548d7152e07504d8f98376b40b9c8a68f","unresolved":false,"context_lines":[{"line_number":294,"context_line":"                                        \"inst\": instance_id}"},{"line_number":295,"context_line":"            messages.info(request, message)"},{"line_number":296,"context_line":"        except nova_exceptions.BadRequest as exc:"},{"line_number":297,"context_line":"            exceptions.handle(request, exc)"},{"line_number":298,"context_line":"        except Exception:"},{"line_number":299,"context_line":"            redirect \u003d reverse(\u0027horizon:project:instances:index\u0027)"},{"line_number":300,"context_line":"            exceptions.handle(request,"}],"source_content_type":"text/x-python","patch_set":8,"id":"bfb3d3c7_21a73952","line":297,"updated":"2019-05-22 03:11:08.000000000","message":"Does it mean a message in the response from nova will be shown directly? I still prefer to have \"Unable to detach volume\". More detail can be appended.","commit_id":"0b891552eb59e49d6ec7410f7eb4a237ef7ca4b2"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"7f8b896f92a06245b85e00ed8aba3c9ea0b50a60","unresolved":false,"context_lines":[{"line_number":294,"context_line":"                                        \"inst\": instance_id}"},{"line_number":295,"context_line":"            messages.info(request, message)"},{"line_number":296,"context_line":"        except nova_exceptions.BadRequest as exc:"},{"line_number":297,"context_line":"            exceptions.handle(request, exc)"},{"line_number":298,"context_line":"        except Exception:"},{"line_number":299,"context_line":"            redirect \u003d reverse(\u0027horizon:project:instances:index\u0027)"},{"line_number":300,"context_line":"            exceptions.handle(request,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7faddb67_b853136b","line":297,"in_reply_to":"bfb3d3c7_21a73952","updated":"2019-07-31 07:21:06.000000000","message":"Done in the updated patch set.","commit_id":"0b891552eb59e49d6ec7410f7eb4a237ef7ca4b2"},{"author":{"_account_id":27822,"name":"pengyuesheng","email":"pengyuesheng@gohighsec.com","username":"pengyuesheng"},"change_message_id":"bd2e6bd95cf176c744543909b7204efd6e65a2bd","unresolved":false,"context_lines":[{"line_number":292,"context_line":"                        \u0027%(inst)s.\u0027) % {\"vol\": volume,"},{"line_number":293,"context_line":"                                        \"inst\": instance_id}"},{"line_number":294,"context_line":"            messages.info(request, message)"},{"line_number":295,"context_line":"        except nova_exceptions.BadRequest as exc:"},{"line_number":296,"context_line":"            exceptions.handle(request, exc)"},{"line_number":297,"context_line":"        except Exception as ex:"},{"line_number":298,"context_line":"            redirect \u003d reverse(\u0027horizon:project:instances:index\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"7faddb67_d3535015","line":295,"range":{"start_line":295,"start_character":15,"end_line":295,"end_character":30},"updated":"2019-07-31 07:43:53.000000000","message":"The nova_exceptions module should be imported","commit_id":"ab315040776ff0d44281d2b71e26578d0fc0e3b4"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"90d7a9524beb6fdb11505b5c8b89edfe94b25dda","unresolved":false,"context_lines":[{"line_number":292,"context_line":"                        \u0027%(inst)s.\u0027) % {\"vol\": volume,"},{"line_number":293,"context_line":"                                        \"inst\": instance_id}"},{"line_number":294,"context_line":"            messages.info(request, message)"},{"line_number":295,"context_line":"        except nova_exceptions.BadRequest as exc:"},{"line_number":296,"context_line":"            exceptions.handle(request, exc)"},{"line_number":297,"context_line":"        except Exception as ex:"},{"line_number":298,"context_line":"            redirect \u003d reverse(\u0027horizon:project:instances:index\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"7faddb67_f35d2c79","line":295,"range":{"start_line":295,"start_character":15,"end_line":295,"end_character":30},"in_reply_to":"7faddb67_d3535015","updated":"2019-07-31 08:26:20.000000000","message":"there is no need to import this. Could you check updated patch set?","commit_id":"ab315040776ff0d44281d2b71e26578d0fc0e3b4"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"9c3da0ebfa3a1c1722981ac8b24a7fb9b1be339a","unresolved":false,"context_lines":[{"line_number":292,"context_line":"                        \u0027%(inst)s.\u0027) % {\"vol\": volume,"},{"line_number":293,"context_line":"                                        \"inst\": instance_id}"},{"line_number":294,"context_line":"            messages.info(request, message)"},{"line_number":295,"context_line":"        except nova_exceptions.BadRequest as exc:"},{"line_number":296,"context_line":"            exceptions.handle(request, exc)"},{"line_number":297,"context_line":"        except Exception as ex:"},{"line_number":298,"context_line":"            redirect \u003d reverse(\u0027horizon:project:instances:index\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"7faddb67_b37494d0","line":295,"range":{"start_line":295,"start_character":15,"end_line":295,"end_character":30},"in_reply_to":"7faddb67_d39b5014","updated":"2019-07-31 08:35:03.000000000","message":"no problem","commit_id":"ab315040776ff0d44281d2b71e26578d0fc0e3b4"},{"author":{"_account_id":27822,"name":"pengyuesheng","email":"pengyuesheng@gohighsec.com","username":"pengyuesheng"},"change_message_id":"e13d588619056744574ca1052303579f73961e59","unresolved":false,"context_lines":[{"line_number":292,"context_line":"                        \u0027%(inst)s.\u0027) % {\"vol\": volume,"},{"line_number":293,"context_line":"                                        \"inst\": instance_id}"},{"line_number":294,"context_line":"            messages.info(request, message)"},{"line_number":295,"context_line":"        except nova_exceptions.BadRequest as exc:"},{"line_number":296,"context_line":"            exceptions.handle(request, exc)"},{"line_number":297,"context_line":"        except Exception as ex:"},{"line_number":298,"context_line":"            redirect \u003d reverse(\u0027horizon:project:instances:index\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"7faddb67_d39b5014","line":295,"range":{"start_line":295,"start_character":15,"end_line":295,"end_character":30},"in_reply_to":"7faddb67_f35d2c79","updated":"2019-07-31 08:30:30.000000000","message":"my bad","commit_id":"ab315040776ff0d44281d2b71e26578d0fc0e3b4"}]}
