)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":37632,"name":"Dmitriy Chubinidze","email":"dcu995@gmail.com","username":"chubinidzedr"},"change_message_id":"cd127af20f1c2e62b9547d5cb083f4ddd5a1aba6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"c45ccfd8_fc439fd6","updated":"2025-05-23 16:37:55.000000000","message":"@jjasek@redhat.com I suppose we can abandon this change.","commit_id":"367193ef327e4e5783945a0327e528a07a17387d"}],"openstack_dashboard/dashboards/identity/users/tables.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"91ea5998bcb2fec96905f86b315238f5a1e1dddb","unresolved":false,"context_lines":[{"line_number":166,"context_line":"                          (\"id\", _(\"User ID \u003d\"), True),"},{"line_number":167,"context_line":"                          (\"enabled\", _(\"Enabled \u003d\"), True, _(\u0027e.g. Yes/No\u0027)))"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    def allowed(self, request, datum):"},{"line_number":170,"context_line":"        if not policy.check(((\"identity\", \"identity:list_users\"),),"},{"line_number":171,"context_line":"                            request):"},{"line_number":172,"context_line":"            self.filter_type \u003d \"query\""}],"source_content_type":"text/x-python","patch_set":3,"id":"bfb3d3c7_c3959088","line":169,"updated":"2019-05-29 10:29:31.000000000","message":"Please, add unit tests for this.","commit_id":"50a3348e0b11541102dd86f4bc74143c1a556a2c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"da18ed22417b7e66b42c279100bd9557c2fdb2a6","unresolved":false,"context_lines":[{"line_number":166,"context_line":"                          (\"id\", _(\"User ID \u003d\"), True),"},{"line_number":167,"context_line":"                          (\"enabled\", _(\"Enabled \u003d\"), True, _(\u0027e.g. Yes/No\u0027)))"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    def allowed(self, request, datum):"},{"line_number":170,"context_line":"        if not policy.check(((\"identity\", \"identity:list_users\"),),"},{"line_number":171,"context_line":"                            request):"},{"line_number":172,"context_line":"            self.filter_type \u003d \"query\""}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_11c0d929","line":169,"in_reply_to":"bfb3d3c7_c3959088","updated":"2019-06-12 07:33:40.000000000","message":"This is not addressed yet in PS4.","commit_id":"50a3348e0b11541102dd86f4bc74143c1a556a2c"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"91ea5998bcb2fec96905f86b315238f5a1e1dddb","unresolved":false,"context_lines":[{"line_number":167,"context_line":"                          (\"enabled\", _(\"Enabled \u003d\"), True, _(\u0027e.g. Yes/No\u0027)))"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    def allowed(self, request, datum):"},{"line_number":170,"context_line":"        if not policy.check(((\"identity\", \"identity:list_users\"),),"},{"line_number":171,"context_line":"                            request):"},{"line_number":172,"context_line":"            self.filter_type \u003d \"query\""},{"line_number":173,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"bfb3d3c7_23ecac28","line":170,"updated":"2019-05-29 10:29:31.000000000","message":"It would be good to have some comment in the code why do we need this fall fallback","commit_id":"50a3348e0b11541102dd86f4bc74143c1a556a2c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"da18ed22417b7e66b42c279100bd9557c2fdb2a6","unresolved":false,"context_lines":[{"line_number":167,"context_line":"                          (\"enabled\", _(\"Enabled \u003d\"), True, _(\u0027e.g. Yes/No\u0027)))"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    def allowed(self, request, datum):"},{"line_number":170,"context_line":"        # adjust filter_type to query when the user"},{"line_number":171,"context_line":"        # does not have the list_users permission"},{"line_number":172,"context_line":"        if not policy.check(((\"identity\", \"identity:list_users\"),),"},{"line_number":173,"context_line":"                            request):"},{"line_number":174,"context_line":"            self.filter_type \u003d \"query\""}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_911049aa","line":171,"range":{"start_line":170,"start_character":8,"end_line":171,"end_character":49},"updated":"2019-06-12 07:33:40.000000000","message":"This comment is not easy to understand to me.\n\n When a user has no permission for list_users, we cannot use \n server-side filtering, so we fallback to client-side filtering (\u0027query\u0027).","commit_id":"ad81904d8783c8c441c11718981ac8af0ec6afff"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"da18ed22417b7e66b42c279100bd9557c2fdb2a6","unresolved":false,"context_lines":[{"line_number":173,"context_line":"                            request):"},{"line_number":174,"context_line":"            self.filter_type \u003d \"query\""},{"line_number":175,"context_line":"        else:"},{"line_number":176,"context_line":"            self.filter_type \u003d \"server\""},{"line_number":177,"context_line":"        return True"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_31407da5","line":176,"range":{"start_line":176,"start_character":12,"end_line":176,"end_character":39},"updated":"2019-06-12 07:33:40.000000000","message":"(While we are dropping keystone v2 support) this potentially overrides filter_type for keystone v2 (See L.161-162).\nI think we should fallback filter_type to \u0027query\u0027 when filter_type is \u0027server\u0027 and a user has no permission for list_users.","commit_id":"ad81904d8783c8c441c11718981ac8af0ec6afff"}]}