)]}'
{"openstack_dashboard/dashboards/project/instances/views.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3b81516435d765308eb10a4d59a8ad1706f3dad2","unresolved":false,"context_lines":[{"line_number":184,"context_line":"                        boot_volume \u003d volume_dict[instance_volumes[0][\u0027id\u0027]]"},{"line_number":185,"context_line":"                        if hasattr(boot_volume, \"volume_image_metadata\") and \\"},{"line_number":186,"context_line":"                            boot_volume.volume_image_metadata[\u0027image_id\u0027] in \\"},{"line_number":187,"context_line":"                                image_dict:"},{"line_number":188,"context_line":"                            instance.image \u003d image_dict["},{"line_number":189,"context_line":"                                boot_volume.volume_image_metadata[\u0027image_id\u0027]"},{"line_number":190,"context_line":"                            ]"}],"source_content_type":"text/x-python","patch_set":3,"id":"ffb9cba7_a773d915","line":187,"updated":"2019-04-30 20:08:05.000000000","message":"Could you use parentheses to wrap lines? It is the convention used in all OpenStack projects. In addition, could you consider assigning boot_volume.volume_image_metadata[\u0027image_id\u0027] to a variable?\n\n  if hasattr(boot_volume, \u0027volume_image_metadata\u0027:\n    image_id \u003d boot_volume.volume_image_metadata[\u0027image_id\u0027]\n    if image_id in image_dict:\n      instance.image \u003d image_dict[image_id]","commit_id":"e40fdb1b7eb780e6b1dbfc696260fa8cdeae3baf"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"fc0b2c0ded6a4dd086461a36f74cd26899a8b0ea","unresolved":false,"context_lines":[{"line_number":184,"context_line":"                        boot_volume \u003d volume_dict[instance_volumes[0][\u0027id\u0027]]"},{"line_number":185,"context_line":"                        if hasattr(boot_volume, \"volume_image_metadata\") and \\"},{"line_number":186,"context_line":"                            boot_volume.volume_image_metadata[\u0027image_id\u0027] in \\"},{"line_number":187,"context_line":"                                image_dict:"},{"line_number":188,"context_line":"                            instance.image \u003d image_dict["},{"line_number":189,"context_line":"                                boot_volume.volume_image_metadata[\u0027image_id\u0027]"},{"line_number":190,"context_line":"                            ]"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfbec78f_7888cd70","line":187,"in_reply_to":"ffb9cba7_737b607a","updated":"2019-05-02 19:40:05.000000000","message":"Okay, that\u0027s the other thing. Let me refactor the code later. We already have too many indent level.....","commit_id":"e40fdb1b7eb780e6b1dbfc696260fa8cdeae3baf"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"82982ad03d8fb1781fe7fc3f372d5f075e8bf776","unresolved":false,"context_lines":[{"line_number":184,"context_line":"                        boot_volume \u003d volume_dict[instance_volumes[0][\u0027id\u0027]]"},{"line_number":185,"context_line":"                        if hasattr(boot_volume, \"volume_image_metadata\") and \\"},{"line_number":186,"context_line":"                            boot_volume.volume_image_metadata[\u0027image_id\u0027] in \\"},{"line_number":187,"context_line":"                                image_dict:"},{"line_number":188,"context_line":"                            instance.image \u003d image_dict["},{"line_number":189,"context_line":"                                boot_volume.volume_image_metadata[\u0027image_id\u0027]"},{"line_number":190,"context_line":"                            ]"}],"source_content_type":"text/x-python","patch_set":3,"id":"ffb9cba7_58d99bf0","line":187,"in_reply_to":"ffb9cba7_a773d915","updated":"2019-05-01 09:06:06.000000000","message":"Oh, didn\u0027t know that, just saw lots of wraps with \"\\\" inside project, so decided that it\u0027s ok to use that method (like https://opendev.org/openstack/horizon/src/branch/master/openstack_dashboard/api/base.py#L358). Probably it\u0027s some historic thing.\n\nWas trying to use one \"if\" as a part of \"fight\" with this function complexity...","commit_id":"e40fdb1b7eb780e6b1dbfc696260fa8cdeae3baf"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"26e94a0f187992208d8908d88138d156a9051025","unresolved":false,"context_lines":[{"line_number":184,"context_line":"                        boot_volume \u003d volume_dict[instance_volumes[0][\u0027id\u0027]]"},{"line_number":185,"context_line":"                        if hasattr(boot_volume, \"volume_image_metadata\") and \\"},{"line_number":186,"context_line":"                            boot_volume.volume_image_metadata[\u0027image_id\u0027] in \\"},{"line_number":187,"context_line":"                                image_dict:"},{"line_number":188,"context_line":"                            instance.image \u003d image_dict["},{"line_number":189,"context_line":"                                boot_volume.volume_image_metadata[\u0027image_id\u0027]"},{"line_number":190,"context_line":"                            ]"}],"source_content_type":"text/x-python","patch_set":3,"id":"ffb9cba7_737b607a","line":187,"in_reply_to":"ffb9cba7_a773d915","updated":"2019-05-01 10:41:46.000000000","message":"Unfortunately unable to split into 2 \"if\", as pep complains on \"Too many nested blocks (6/5)\"","commit_id":"e40fdb1b7eb780e6b1dbfc696260fa8cdeae3baf"}]}