)]}'
{"openstack_dashboard/dashboards/admin/networks/forms.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"f0fc076b29ef0736e2ef3d37f6b290b977137890","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                                     initial\u003dTrue,"},{"line_number":123,"context_line":"                                     required\u003dFalse,"},{"line_number":124,"context_line":"                                     help_text\u003d_(\"The state to start \""},{"line_number":125,"context_line":"                                                 \"the network in.\"))"},{"line_number":126,"context_line":"    shared \u003d forms.BooleanField(label\u003d_(\"Shared\"),"},{"line_number":127,"context_line":"                                initial\u003dFalse, required\u003dFalse)"},{"line_number":128,"context_line":"    external \u003d forms.BooleanField(label\u003d_(\"External Network\"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfbec78f_ce946eeb","line":125,"updated":"2019-05-05 18:00:27.000000000","message":"Could you wrap lines like L.144? You can avoid wrapping line in help_text and it is easier to read.","commit_id":"f9bc221f00b30442968abd4cf3088e9db07c0609"},{"author":{"_account_id":27979,"name":"steven","email":"gaoyl@rc.inesa.com","username":"stevenGao"},"change_message_id":"4d3fa40a9fabdf7580376996b0ac121a77d1a73e","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                                     initial\u003dTrue,"},{"line_number":123,"context_line":"                                     required\u003dFalse,"},{"line_number":124,"context_line":"                                     help_text\u003d_(\"The state to start \""},{"line_number":125,"context_line":"                                                 \"the network in.\"))"},{"line_number":126,"context_line":"    shared \u003d forms.BooleanField(label\u003d_(\"Shared\"),"},{"line_number":127,"context_line":"                                initial\u003dFalse, required\u003dFalse)"},{"line_number":128,"context_line":"    external \u003d forms.BooleanField(label\u003d_(\"External Network\"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfbec78f_2460cbce","line":125,"in_reply_to":"dfbec78f_ce946eeb","updated":"2019-05-06 02:27:08.000000000","message":"That is a good suggestion :)","commit_id":"f9bc221f00b30442968abd4cf3088e9db07c0609"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9695e025d5c7423179591e4e44639c489525b360","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        label\u003d_(\"Enable Admin State\"),"},{"line_number":123,"context_line":"        initial\u003dTrue,"},{"line_number":124,"context_line":"        required\u003dFalse,"},{"line_number":125,"context_line":"        help_text\u003d_(\"The state to start the network in.\"))"},{"line_number":126,"context_line":"    shared \u003d forms.BooleanField(label\u003d_(\"Shared\"),"},{"line_number":127,"context_line":"                                initial\u003dFalse, required\u003dFalse)"},{"line_number":128,"context_line":"    external \u003d forms.BooleanField(label\u003d_(\"External Network\"),"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfbec78f_df24f5c8","line":125,"updated":"2019-05-08 09:16:11.000000000","message":"It is better to explain what \"Admin State\" means rather than what happens when a network is created. In addition, I would like to see the help text which can be used to update_network too.","commit_id":"7cd5317bf434281a081e67526eb4fd4dd9657e91"},{"author":{"_account_id":27979,"name":"steven","email":"gaoyl@rc.inesa.com","username":"stevenGao"},"change_message_id":"4a632f56d2e7ac7554306e3c4eda2463c10955ad","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        label\u003d_(\"Enable Admin State\"),"},{"line_number":123,"context_line":"        initial\u003dTrue,"},{"line_number":124,"context_line":"        required\u003dFalse,"},{"line_number":125,"context_line":"        help_text\u003d_(\"The state to start the network in.\"))"},{"line_number":126,"context_line":"    shared \u003d forms.BooleanField(label\u003d_(\"Shared\"),"},{"line_number":127,"context_line":"                                initial\u003dFalse, required\u003dFalse)"},{"line_number":128,"context_line":"    external \u003d forms.BooleanField(label\u003d_(\"External Network\"),"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfbec78f_c1261416","line":125,"in_reply_to":"dfbec78f_0d3ea3d9","updated":"2019-05-13 02:15:43.000000000","message":"I see. \"Admin\" really confuse me a lot. \nAnd when I\u0027m talking about the word \"functional\", it also means whether the network is enabled. Maybe I used the wrong word but I think we have the same understanding of this checkbox.\n\nSo, I suggest to change the help text to \"enable the network\" which may be easy to understand.","commit_id":"7cd5317bf434281a081e67526eb4fd4dd9657e91"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"34a6cdbc5dafc736e258312f117049d32667dc16","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        label\u003d_(\"Enable Admin State\"),"},{"line_number":123,"context_line":"        initial\u003dTrue,"},{"line_number":124,"context_line":"        required\u003dFalse,"},{"line_number":125,"context_line":"        help_text\u003d_(\"The state to start the network in.\"))"},{"line_number":126,"context_line":"    shared \u003d forms.BooleanField(label\u003d_(\"Shared\"),"},{"line_number":127,"context_line":"                                initial\u003dFalse, required\u003dFalse)"},{"line_number":128,"context_line":"    external \u003d forms.BooleanField(label\u003d_(\"External Network\"),"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfbec78f_0d3ea3d9","line":125,"in_reply_to":"dfbec78f_92bf47cf","updated":"2019-05-12 09:29:19.000000000","message":"What confuses you? is \"Admin\" confusing?\n\nFor example, \"administrative state\" is used in Cisco router \"show interface\" and it means whether a network operator enables the port. It does not mean that the port is actually functional. The port can be broken by failure or other network problem.\n\nIf we go to the route to rephrase it, \"Enable/Disable network\" would be better. OSC uses the following options.\n\n  --enable              Enable network (default)\n  --disable             Disable network\n\nIf we keep \"Enable Admin State\", one idea from me is:\n\n  Checking this means the network is enabled from administrative perspective.","commit_id":"7cd5317bf434281a081e67526eb4fd4dd9657e91"},{"author":{"_account_id":27979,"name":"steven","email":"gaoyl@rc.inesa.com","username":"stevenGao"},"change_message_id":"54d8d1807d668891ef84aa5fbe1e8437fa668b82","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        label\u003d_(\"Enable Admin State\"),"},{"line_number":123,"context_line":"        initial\u003dTrue,"},{"line_number":124,"context_line":"        required\u003dFalse,"},{"line_number":125,"context_line":"        help_text\u003d_(\"The state to start the network in.\"))"},{"line_number":126,"context_line":"    shared \u003d forms.BooleanField(label\u003d_(\"Shared\"),"},{"line_number":127,"context_line":"                                initial\u003dFalse, required\u003dFalse)"},{"line_number":128,"context_line":"    external \u003d forms.BooleanField(label\u003d_(\"External Network\"),"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfbec78f_92bf47cf","line":125,"in_reply_to":"dfbec78f_df24f5c8","updated":"2019-05-09 01:31:21.000000000","message":"Help text has now been used to update_network.\n\nAnd for what \"Admin State\" means seems to be very confusing. In my understanding, this means wheather to make the network functional. Maybe it\u0027s better to change the word \"Admin State\" rather than just give an explaination.\n\nSo I just complete the missing part of help text wherever \"Admin State\" shows up.","commit_id":"7cd5317bf434281a081e67526eb4fd4dd9657e91"}],"openstack_dashboard/dashboards/project/networks/ports/workflows.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"f0fc076b29ef0736e2ef3d37f6b290b977137890","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                                     initial\u003dTrue,"},{"line_number":63,"context_line":"                                     required\u003dFalse,"},{"line_number":64,"context_line":"                                     help_text\u003d_(\"The state to start \""},{"line_number":65,"context_line":"                                                 \"the network in.\"))"},{"line_number":66,"context_line":"    device_id \u003d forms.CharField(max_length\u003d100, label\u003d_(\"Device ID\"),"},{"line_number":67,"context_line":"                                help_text\u003d_(\"Device ID attached to the port\"),"},{"line_number":68,"context_line":"                                required\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfbec78f_aea33a4f","line":65,"updated":"2019-05-05 18:00:27.000000000","message":"ditto","commit_id":"f9bc221f00b30442968abd4cf3088e9db07c0609"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"f0fc076b29ef0736e2ef3d37f6b290b977137890","unresolved":false,"context_lines":[{"line_number":309,"context_line":"    admin_state \u003d forms.BooleanField(label\u003d_(\"Enable Admin State\"),"},{"line_number":310,"context_line":"                                     required\u003dFalse,"},{"line_number":311,"context_line":"                                     help_text\u003d_(\"The state to start \""},{"line_number":312,"context_line":"                                                 \"the network in.\"))"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    def __init__(self, request, *args, **kwargs):"},{"line_number":315,"context_line":"        super(UpdatePortInfoAction, self).__init__(request, *args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfbec78f_6e8542ad","line":312,"updated":"2019-05-05 18:00:27.000000000","message":"ditto","commit_id":"f9bc221f00b30442968abd4cf3088e9db07c0609"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"34a6cdbc5dafc736e258312f117049d32667dc16","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        label\u003d_(\"Enable Admin State\"),"},{"line_number":63,"context_line":"        initial\u003dTrue,"},{"line_number":64,"context_line":"        required\u003dFalse,"},{"line_number":65,"context_line":"        help_text\u003d_(\"The state to start the network in.\"))"},{"line_number":66,"context_line":"    device_id \u003d forms.CharField(max_length\u003d100, label\u003d_(\"Device ID\"),"},{"line_number":67,"context_line":"                                help_text\u003d_(\"Device ID attached to the port\"),"},{"line_number":68,"context_line":"                                required\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfbec78f_2d1cc776","line":65,"range":{"start_line":65,"start_character":44,"end_line":65,"end_character":51},"updated":"2019-05-12 09:29:19.000000000","message":"port?\n\neven after it is changed to \"port\", I still cannot understand what \"to start the port in\"......","commit_id":"8557c04ffb915d3e177cc98107938ba970d4b477"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b296d330ba1b4babd35bc6ee4e4f34bc213bf07e","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        label\u003d_(\"Enable Admin State\"),"},{"line_number":63,"context_line":"        initial\u003dTrue,"},{"line_number":64,"context_line":"        required\u003dFalse,"},{"line_number":65,"context_line":"        help_text\u003d_(\"The state to enable the port.\"))"},{"line_number":66,"context_line":"    device_id \u003d forms.CharField(max_length\u003d100, label\u003d_(\"Device ID\"),"},{"line_number":67,"context_line":"                                help_text\u003d_(\"Device ID attached to the port\"),"},{"line_number":68,"context_line":"                                required\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":5,"id":"bfb3d3c7_5cc1f27f","line":65,"updated":"2019-05-22 04:01:42.000000000","message":"How about \"If checked, the port will be enabled\" ?\nI think \"The state to enable ...\" is still unclear a bit.","commit_id":"9141dfc403cefe5d5b19cd5c0850b47e55188fcb"}],"openstack_dashboard/dashboards/project/routers/forms.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"f0fc076b29ef0736e2ef3d37f6b290b977137890","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                                        initial\u003dTrue,"},{"line_number":39,"context_line":"                                        required\u003dFalse,"},{"line_number":40,"context_line":"                                        help_text\u003d_(\"The state to start \""},{"line_number":41,"context_line":"                                                    \"the network in.\"))"},{"line_number":42,"context_line":"    external_network \u003d forms.ThemableChoiceField(label\u003d_(\"External Network\"),"},{"line_number":43,"context_line":"                                                 required\u003dFalse)"},{"line_number":44,"context_line":"    enable_snat \u003d forms.BooleanField(label\u003d_(\"Enable SNAT\"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfbec78f_2e8f4acd","line":41,"updated":"2019-05-05 18:00:27.000000000","message":"ditto","commit_id":"f9bc221f00b30442968abd4cf3088e9db07c0609"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"f0fc076b29ef0736e2ef3d37f6b290b977137890","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    admin_state \u003d forms.BooleanField(label\u003d_(\"Enable Admin State\"),"},{"line_number":159,"context_line":"                                     required\u003dFalse,"},{"line_number":160,"context_line":"                                     help_text\u003d_(\"The state to start \""},{"line_number":161,"context_line":"                                                 \"the network in.\"))"},{"line_number":162,"context_line":"    mode \u003d forms.ThemableChoiceField(label\u003d_(\"Router Type\"))"},{"line_number":163,"context_line":"    ha \u003d forms.BooleanField(label\u003d_(\"High Availability Mode\"), required\u003dFalse)"},{"line_number":164,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dfbec78f_eec292e9","line":161,"updated":"2019-05-05 18:00:27.000000000","message":"ditto","commit_id":"f9bc221f00b30442968abd4cf3088e9db07c0609"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"34a6cdbc5dafc736e258312f117049d32667dc16","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        label\u003d_(\"Enable Admin State\"),"},{"line_number":39,"context_line":"        initial\u003dTrue,"},{"line_number":40,"context_line":"        required\u003dFalse,"},{"line_number":41,"context_line":"        help_text\u003d_(\"The state to start the network in.\"))"},{"line_number":42,"context_line":"    external_network \u003d forms.ThemableChoiceField(label\u003d_(\"External Network\"),"},{"line_number":43,"context_line":"                                                 required\u003dFalse)"},{"line_number":44,"context_line":"    enable_snat \u003d forms.BooleanField(label\u003d_(\"Enable SNAT\"),"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfbec78f_8d29339c","line":41,"range":{"start_line":41,"start_character":44,"end_line":41,"end_character":51},"updated":"2019-05-12 09:29:19.000000000","message":"router?","commit_id":"8557c04ffb915d3e177cc98107938ba970d4b477"}]}