)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e8f5d12371d848f50da10363158abc80186d7428","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     pengyuesheng \u003cpengyuesheng@gohighsec.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-05-08 17:16:57 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Snapshot Name is optional parameter on create snapshot form"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I32aed4f1e27ce53ab9303f470b50145c9715c4ce"},{"line_number":10,"context_line":"Closes-Bug: #1828195"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dfbec78f_455d94e7","line":7,"range":{"start_line":7,"start_character":39,"end_line":7,"end_character":45},"updated":"2019-05-08 11:37:50.000000000","message":"Your change is not limited to \"create snapshot form\".","commit_id":"240d6b01071dc4d6fdbbba71d0453005741fe549"}],"openstack_dashboard/dashboards/project/snapshots/forms.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e8f5d12371d848f50da10363158abc80186d7428","unresolved":false,"context_lines":[{"line_number":37,"context_line":"                                                     data[\u0027name\u0027],"},{"line_number":38,"context_line":"                                                     data[\u0027description\u0027])"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"            name \u003d snapshot[\"snapshot\"][\"name\"] or snapshot[\"snapshot\"][\"id\"]"},{"line_number":41,"context_line":"            message \u003d _(\u0027Updating volume snapshot \"%s\"\u0027) % name"},{"line_number":42,"context_line":"            messages.info(request, message)"},{"line_number":43,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfbec78f_85638cb1","line":40,"range":{"start_line":40,"start_character":11,"end_line":40,"end_character":16},"updated":"2019-05-08 11:37:50.000000000","message":"The variable name is confusing because it can be name or ID.","commit_id":"240d6b01071dc4d6fdbbba71d0453005741fe549"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2f9e32f313c8c3df06caff363a7a77024e32ed17","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                                                     data[\u0027description\u0027])"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"            name_or_id \u003d \\"},{"line_number":41,"context_line":"                snapshot[\"snapshot\"][\"name\"] or snapshot[\"snapshot\"][\"id\"]"},{"line_number":42,"context_line":"            message \u003d _(\u0027Updating volume snapshot \"%s\"\u0027) % name_or_id"},{"line_number":43,"context_line":"            messages.info(request, message)"},{"line_number":44,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfbec78f_12ffd734","line":41,"updated":"2019-05-09 02:14:57.000000000","message":"Could you avoid using a backslash as much as possib le?\n\n\n name_or_id \u003d (snapshot[\"snapshot\"][\"name\"] or\n               snapshot[\"snapshot\"][\"id\"])","commit_id":"2d718d06dd3df83fb61a5c53cce27ece58502bed"}],"openstack_dashboard/dashboards/project/volumes/forms.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e8f5d12371d848f50da10363158abc80186d7428","unresolved":false,"context_lines":[{"line_number":569,"context_line":"                                                     data[\u0027description\u0027],"},{"line_number":570,"context_line":"                                                     force\u003dforce)"},{"line_number":571,"context_line":""},{"line_number":572,"context_line":"            messages.info(request, message % snapshot.name)"},{"line_number":573,"context_line":"            return snapshot"},{"line_number":574,"context_line":"        except Exception as e:"},{"line_number":575,"context_line":"            redirect \u003d reverse(\"horizon:project:volumes:index\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfbec78f_e54a8825","line":572,"range":{"start_line":572,"start_character":45,"end_line":572,"end_character":59},"updated":"2019-05-08 11:37:50.000000000","message":"why does snapshot.name work?","commit_id":"240d6b01071dc4d6fdbbba71d0453005741fe549"},{"author":{"_account_id":27822,"name":"pengyuesheng","email":"pengyuesheng@gohighsec.com","username":"pengyuesheng"},"change_message_id":"b013fdd4150680504d7560d7285c8bc07003a2d1","unresolved":false,"context_lines":[{"line_number":569,"context_line":"                                                     data[\u0027description\u0027],"},{"line_number":570,"context_line":"                                                     force\u003dforce)"},{"line_number":571,"context_line":""},{"line_number":572,"context_line":"            messages.info(request, message % snapshot.name)"},{"line_number":573,"context_line":"            return snapshot"},{"line_number":574,"context_line":"        except Exception as e:"},{"line_number":575,"context_line":"            redirect \u003d reverse(\"horizon:project:volumes:index\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfbec78f_52878f10","line":572,"range":{"start_line":572,"start_character":45,"end_line":572,"end_character":59},"in_reply_to":"dfbec78f_e54a8825","updated":"2019-05-09 01:34:47.000000000","message":"snapshot.name can be name or ID.the method of name is define by [1]\n[1]https://github.com/openstack/horizon/blob/master/openstack_dashboard/api/cinder.py#L71-L77","commit_id":"240d6b01071dc4d6fdbbba71d0453005741fe549"}]}
