)]}'
{"id":"openstack%2Fhorizon~659513","triplet_id":"openstack%2Fhorizon~master~Iaf28306df7e1d77ee64501adee07a932c72c560c","project":"openstack/horizon","branch":"master","topic":"bug/1818659","attention_set":{},"removed_from_attention_set":{"27738":{"account":{"_account_id":27738,"name":"mashuting","email":"shutingm@vmware.com","username":"mashuting"},"last_update":"2025-05-21 16:10:44.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"Iaf28306df7e1d77ee64501adee07a932c72c560c","subject":"Handle 403 response when update image attribute","status":"ABANDONED","created":"2019-05-16 09:50:29.000000000","updated":"2025-05-21 16:10:44.000000000","total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"c7787cb201841340f0d1b4ecd930b057be1b03e4","_number":659513,"virtual_id_number":659513,"owner":{"_account_id":27738,"name":"mashuting","email":"shutingm@vmware.com","username":"mashuting"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":1,"date":"2019-05-16 10:50:10.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},{"_account_id":27822,"name":"pengyuesheng","email":"pengyuesheng@gohighsec.com","username":"pengyuesheng"},{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"date":"2019-05-17 02:58:13.000000000","_account_id":27738,"name":"mashuting","email":"shutingm@vmware.com","username":"mashuting"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":-1,"date":"2025-05-20 16:28:58.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},{"value":-1,"date":"2019-05-17 01:37:44.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":27822,"name":"pengyuesheng","email":"pengyuesheng@gohighsec.com","username":"pengyuesheng"},{"value":-1,"date":"2019-05-29 10:06:24.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":27738,"name":"mashuting","email":"shutingm@vmware.com","username":"mashuting"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},{"_account_id":27822,"name":"pengyuesheng","email":"pengyuesheng@gohighsec.com","username":"pengyuesheng"},{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"date":"2019-05-16 09:51:45.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":27738,"name":"mashuting","email":"shutingm@vmware.com","username":"mashuting"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},{"_account_id":27822,"name":"pengyuesheng","email":"pengyuesheng@gohighsec.com","username":"pengyuesheng"},{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"_account_id":27738,"name":"mashuting","email":"shutingm@vmware.com","username":"mashuting"}],"values":{"-1":"Release Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"}],"REVIEWER":[{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":27738,"name":"mashuting","email":"shutingm@vmware.com","username":"mashuting"},{"_account_id":27822,"name":"pengyuesheng","email":"pengyuesheng@gohighsec.com","username":"pengyuesheng"},{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-05-16 09:51:45.000000000","updated_by":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"reviewer":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"state":"REVIEWER"},{"updated":"2019-05-16 10:50:10.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-05-17 01:37:44.000000000","updated_by":{"_account_id":27822,"name":"pengyuesheng","email":"pengyuesheng@gohighsec.com","username":"pengyuesheng"},"reviewer":{"_account_id":27822,"name":"pengyuesheng","email":"pengyuesheng@gohighsec.com","username":"pengyuesheng"},"state":"REVIEWER"},{"updated":"2019-05-29 10:06:24.000000000","updated_by":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"reviewer":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"state":"REVIEWER"},{"updated":"2025-05-20 16:28:58.000000000","updated_by":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"reviewer":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"state":"CC"},{"updated":"2025-05-20 16:28:58.000000000","updated_by":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"reviewer":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"state":"REVIEWER"}],"messages":[{"id":"b181b1137fa60fc3ce0c90a6b02588fb5181c25b","author":{"_account_id":27738,"name":"mashuting","email":"shutingm@vmware.com","username":"mashuting"},"date":"2019-05-16 09:50:29.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"14c5603480e07f036303b9ccacc85fef690fc0eb","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-16 10:50:10.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- nodejs10-npm-run-lint http://logs.openstack.org/13/659513/1/check/nodejs10-npm-run-lint/05bdb27/ : SUCCESS in 5m 53s\n- nodejs10-npm-run-test http://logs.openstack.org/13/659513/1/check/nodejs10-npm-run-test/8cc6e17/ : SUCCESS in 5m 50s\n- openstack-tox-lower-constraints http://logs.openstack.org/13/659513/1/check/openstack-tox-lower-constraints/45521f6/ : SUCCESS in 8m 33s\n- openstack-tox-pep8 http://logs.openstack.org/13/659513/1/check/openstack-tox-pep8/ead8c61/ : SUCCESS in 4m 56s\n- openstack-tox-py27 http://logs.openstack.org/13/659513/1/check/openstack-tox-py27/d0749ac/ : SUCCESS in 11m 32s\n- openstack-tox-py36 http://logs.openstack.org/13/659513/1/check/openstack-tox-py36/39a2cc1/ : SUCCESS in 7m 27s\n- openstack-tox-py37 http://logs.openstack.org/13/659513/1/check/openstack-tox-py37/20ba48e/ : SUCCESS in 9m 03s\n- openstack-tox-docs http://logs.openstack.org/13/659513/1/check/openstack-tox-docs/2449a7e/html/ : SUCCESS in 3m 44s\n- horizon-openstack-tox-python3-django111 http://logs.openstack.org/13/659513/1/check/horizon-openstack-tox-python3-django111/8bd7b44/ : SUCCESS in 9m 25s\n- horizon-selenium-headless http://logs.openstack.org/13/659513/1/check/horizon-selenium-headless/cabaf54/ : SUCCESS in 5m 20s\n- horizon-integration-tests http://logs.openstack.org/13/659513/1/check/horizon-integration-tests/934043b/ : SUCCESS in 53m 46s\n- horizon-dsvm-tempest-plugin http://logs.openstack.org/13/659513/1/check/horizon-dsvm-tempest-plugin/9eb5e40/ : SUCCESS in 33m 08s\n- horizon-dsvm-tempest-plugin-py27 http://logs.openstack.org/13/659513/1/check/horizon-dsvm-tempest-plugin-py27/708189c/ : SUCCESS in 32m 27s\n- horizon-tox-bandit-baseline http://logs.openstack.org/13/659513/1/check/horizon-tox-bandit-baseline/e2c365b/ : SUCCESS in 3m 44s","accounts_in_message":[],"_revision_number":1},{"id":"13df62e2e860f95d8698ff649289f5f342fc2bf9","author":{"_account_id":27822,"name":"pengyuesheng","email":"pengyuesheng@gohighsec.com","username":"pengyuesheng"},"date":"2019-05-17 01:37:44.000000000","message":"Patch Set 1: Code-Review-1\n\nI think that modifying the status code is not a good way to deal with it. Is there any other way of handling it?","accounts_in_message":[],"_revision_number":1},{"id":"7efd240ce294bd16533f298d640977d235c9ab3b","author":{"_account_id":27738,"name":"mashuting","email":"shutingm@vmware.com","username":"mashuting"},"date":"2019-05-17 02:58:13.000000000","message":"Patch Set 1:\n\n\u003e I think that modifying the status code is not a good way to deal\n \u003e with it. Is there any other way of handling it?\n\nI thought of three ways:\n1. Change the response type from glanceclent, replace 403 fobidden to another;\n2. Start from angularjs part to fix, remove the handling of HTTP 403 from factory function \u0027horizon.framework.redirect\u0027;\n3.Fix from the middle of 1 and 2, like in this patch.","accounts_in_message":[],"_revision_number":1},{"id":"98847546ca6505f0923684c4f9bbff3e6cac24d8","author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"date":"2019-05-29 10:06:24.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)\n\nI prefer to go this way:\n\u003e\u003e 2. Start from angularjs part to fix, remove the handling of HTTP 403 from factory function \u0027horizon.framework.redirect\u0027;\n\nBut for now, we need to add at least some TODOs in the code to not forget why we did this patch in a such way.","accounts_in_message":[],"_revision_number":1},{"id":"7691e25e9037a0ea60ce04456a0e91b4698d2f17","author":{"_account_id":27822,"name":"pengyuesheng","email":"pengyuesheng@gohighsec.com","username":"pengyuesheng"},"date":"2019-05-31 06:25:36.000000000","message":"Patch Set 1:\n\n\u003e \u003e I think that modifying the status code is not a good way to deal\n \u003e \u003e with it. Is there any other way of handling it?\n \u003e \n \u003e I thought of three ways:\n \u003e 1. Change the response type from glanceclent, replace 403 fobidden\n \u003e to another;\n \u003e 2. Start from angularjs part to fix, remove the handling of HTTP\n \u003e 403 from factory function \u0027horizon.framework.redirect\u0027;\n \u003e 3.Fix from the middle of 1 and 2, like in this patch.\n\nIs it possible to throw only errors in the factory function \u0027horizon.framework.redirect\u0027 without jumping","accounts_in_message":[],"_revision_number":1},{"id":"cf72bdcdac3aa4cf678ea8f037080f71f040c7f7","author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"date":"2025-05-20 16:28:58.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"c7787cb201841340f0d1b4ecd930b057be1b03e4","tag":"autogenerated:gerrit:abandon","author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"date":"2025-05-21 16:10:44.000000000","message":"Abandoned\n\nPatch without activity for multiple years.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"36bbddf6e42f8d0fb11d3ed7cc4a5bd94127aa3a","revisions":{"36bbddf6e42f8d0fb11d3ed7cc4a5bd94127aa3a":{"kind":"REWORK","_number":1,"created":"2019-05-16 09:50:29.000000000","uploader":{"_account_id":27738,"name":"mashuting","email":"shutingm@vmware.com","username":"mashuting"},"ref":"refs/changes/13/659513/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/horizon","ref":"refs/changes/13/659513/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/horizon refs/changes/13/659513/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/horizon refs/changes/13/659513/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/horizon refs/changes/13/659513/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/horizon refs/changes/13/659513/1"}}},"commit":{"parents":[{"commit":"7db6b00d3ae27670cbba0e12cdb564a38798727a","subject":"Merge \"[trivial] use systemctl for service management in Ubuntu\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/horizon/commit/7db6b00d3ae27670cbba0e12cdb564a38798727a"}]}],"author":{"name":"shutingm","email":"shutingm@vmware.com","date":"2019-05-16 09:25:52.000000000","tz":480},"committer":{"name":"shutingm","email":"shutingm@vmware.com","date":"2019-05-16 09:48:45.000000000","tz":480},"subject":"Handle 403 response when update image attribute","message":"Handle 403 response when update image attribute\n\nThe part of angularjs code catch an HTTP 403 response and redirect\nto logout, convert it to 404 response.\n\nChange-Id: Iaf28306df7e1d77ee64501adee07a932c72c560c\nCloses-Bug: #1818659\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/horizon/commit/36bbddf6e42f8d0fb11d3ed7cc4a5bd94127aa3a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/horizon/commit/36bbddf6e42f8d0fb11d3ed7cc4a5bd94127aa3a"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review priority","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"-label:Review-Priority\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":[],"failing_atoms":["label:Review-Priority\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}