)]}'
{"openstack_dashboard/api/lbaas.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"64073b1c2802741e2809894e241eb618b1290d74","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from __future__ import absolute_import"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from django.utils.datastructures import SortedDict  # noqa"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from openstack_dashboard.api import neutron"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FaJ0%3D","line":19,"updated":"2014-01-14 02:14:41.000000000","message":"\"noqa\" is not needed here. See import_exceptions in tox.ini.","commit_id":"afce607f2a07572457df82472d440777fb3dc99d"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"e9da670feaadff437bfc34326a39a6503283112c","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from __future__ import absolute_import"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from django.utils.datastructures import SortedDict  # noqa"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from openstack_dashboard.api import neutron"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FQh0%3D","line":19,"in_reply_to":"AAAAUH%2F%2FaJ0%3D","updated":"2014-01-15 20:01:16.000000000","message":"Thanks! Done.","commit_id":"afce607f2a07572457df82472d440777fb3dc99d"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"64073b1c2802741e2809894e241eb618b1290d74","unresolved":false,"context_lines":[{"line_number":38,"context_line":"            apiresource[\u0027provider\u0027] \u003d None"},{"line_number":39,"context_line":"        super(Pool, self).__init__(apiresource)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def get_dict(self):"},{"line_number":42,"context_line":"        pool_dict \u003d self._apidict"},{"line_number":43,"context_line":"        pool_dict[\u0027pool_id\u0027] \u003d pool_dict[\u0027id\u0027]"},{"line_number":44,"context_line":"        return pool_dict"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FaJQ%3D","line":41,"updated":"2014-01-14 02:14:41.000000000","message":"It seems get_dict is not used.","commit_id":"afce607f2a07572457df82472d440777fb3dc99d"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"e9da670feaadff437bfc34326a39a6503283112c","unresolved":false,"context_lines":[{"line_number":38,"context_line":"            apiresource[\u0027provider\u0027] \u003d None"},{"line_number":39,"context_line":"        super(Pool, self).__init__(apiresource)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def get_dict(self):"},{"line_number":42,"context_line":"        pool_dict \u003d self._apidict"},{"line_number":43,"context_line":"        pool_dict[\u0027pool_id\u0027] \u003d pool_dict[\u0027id\u0027]"},{"line_number":44,"context_line":"        return pool_dict"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FQg8%3D","line":41,"in_reply_to":"AAAAUH%2F%2FaJQ%3D","updated":"2014-01-15 20:01:16.000000000","message":"Removed here and below.","commit_id":"afce607f2a07572457df82472d440777fb3dc99d"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"64073b1c2802741e2809894e241eb618b1290d74","unresolved":false,"context_lines":[{"line_number":163,"context_line":"                except Exception:"},{"line_number":164,"context_line":"                    p[\u0027vip_name\u0027] \u003d p[\u0027vip_id\u0027]"},{"line_number":165,"context_line":"            else:"},{"line_number":166,"context_line":"                p[\u0027vip_name\u0027] \u003d None"},{"line_number":167,"context_line":"    return [Pool(p) for p in pools]"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FaI8%3D","line":166,"updated":"2014-01-14 02:14:41.000000000","message":"It would be nice if L.160-166 and L.180-186 share the logic.","commit_id":"afce607f2a07572457df82472d440777fb3dc99d"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"e9da670feaadff437bfc34326a39a6503283112c","unresolved":false,"context_lines":[{"line_number":163,"context_line":"                except Exception:"},{"line_number":164,"context_line":"                    p[\u0027vip_name\u0027] \u003d p[\u0027vip_id\u0027]"},{"line_number":165,"context_line":"            else:"},{"line_number":166,"context_line":"                p[\u0027vip_name\u0027] \u003d None"},{"line_number":167,"context_line":"    return [Pool(p) for p in pools]"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FQc8%3D","line":166,"in_reply_to":"AAAAUH%2F%2FaI8%3D","updated":"2014-01-15 20:01:16.000000000","message":"Good idea. I will add a separate method for it.","commit_id":"afce607f2a07572457df82472d440777fb3dc99d"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"56d65b86285f7aa3ffd9163f196a65eb1a33d3ff","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    \"\"\"Wrapper for neutron load balancer member.\"\"\""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def __init__(self, apiresource):"},{"line_number":46,"context_line":"        super(Member, self).__init__(apiresource)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"class PoolStats(neutron.NeutronAPIDictWrapper):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2BkPs%3D","line":46,"updated":"2014-01-24 10:36:44.000000000","message":"There is no longer a need to override.\n\n  class Member(neutron.NeutronAPIDictWrapper):\n      \"\"\"Wrapper for neutron load balancer member.\"\"\"\n      pass","commit_id":"5391659fdfd0d86165ed743255d0d167c992375e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"f6a2401c0c7e217c1efb1513a987891093ccc4b9","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    \"\"\"Wrapper for neutron load balancer member.\"\"\""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def __init__(self, apiresource):"},{"line_number":46,"context_line":"        super(Member, self).__init__(apiresource)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"class PoolStats(neutron.NeutronAPIDictWrapper):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2BStc%3D","line":46,"in_reply_to":"AAAAUH%2F%2BZEk%3D","updated":"2014-01-28 10:41:53.000000000","message":"Both is okay to me.\n\nI think a merit of removing them is that we don\u0027t need to change a method signature even if a corresponding method in a parent class is changed. It makes it easy to maintain.\n\nIn this case, APIDictWrapper is stable and it is unlikely to change its signature. Thus I think both is okay.","commit_id":"5391659fdfd0d86165ed743255d0d167c992375e"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"87e410cb9954d287dde23d578198a3be1b0881bc","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    \"\"\"Wrapper for neutron load balancer member.\"\"\""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def __init__(self, apiresource):"},{"line_number":46,"context_line":"        super(Member, self).__init__(apiresource)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"class PoolStats(neutron.NeutronAPIDictWrapper):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2BZEk%3D","line":46,"in_reply_to":"AAAAUH%2F%2BkPs%3D","updated":"2014-01-27 14:54:00.000000000","message":"I agree, it is not needed here. However IMO for proper hierarchy resolution it is safer to keep it. What do you think?","commit_id":"5391659fdfd0d86165ed743255d0d167c992375e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"56d65b86285f7aa3ffd9163f196a65eb1a33d3ff","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    \"\"\"Wrapper for neutron load balancer pool stats.\"\"\""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def __init__(self, apiresource):"},{"line_number":53,"context_line":"        super(PoolStats, self).__init__(apiresource)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"class PoolMonitor(neutron.NeutronAPIDictWrapper):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2BkPY%3D","line":53,"updated":"2014-01-24 10:36:44.000000000","message":"Ditto","commit_id":"5391659fdfd0d86165ed743255d0d167c992375e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"56d65b86285f7aa3ffd9163f196a65eb1a33d3ff","unresolved":false,"context_lines":[{"line_number":56,"context_line":"class PoolMonitor(neutron.NeutronAPIDictWrapper):"},{"line_number":57,"context_line":"    \"\"\"Wrapper for neutron load balancer pool health monitor.\"\"\""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def __init__(self, apiresource):"},{"line_number":60,"context_line":"        super(PoolMonitor, self).__init__(apiresource)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2BkPU%3D","line":59,"updated":"2014-01-24 10:36:44.000000000","message":"Ditto","commit_id":"5391659fdfd0d86165ed743255d0d167c992375e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"56d65b86285f7aa3ffd9163f196a65eb1a33d3ff","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"def _get_vip_name(request, pool, vip_dict):"},{"line_number":136,"context_line":"    if pool[\u0027vip_id\u0027] is not None:"},{"line_number":137,"context_line":"        try:"},{"line_number":138,"context_line":"            if vip_dict:"},{"line_number":139,"context_line":"                return vip_dict.get(pool[\u0027vip_id\u0027]).name"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2BkWg%3D","line":136,"updated":"2014-01-24 10:36:44.000000000","message":"Just a question. Isn\u0027t \"if pool[\u0027vip_id\u0027]\" sufficient?","commit_id":"5391659fdfd0d86165ed743255d0d167c992375e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"f6a2401c0c7e217c1efb1513a987891093ccc4b9","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"def _get_vip_name(request, pool, vip_dict):"},{"line_number":136,"context_line":"    if pool[\u0027vip_id\u0027] is not None:"},{"line_number":137,"context_line":"        try:"},{"line_number":138,"context_line":"            if vip_dict:"},{"line_number":139,"context_line":"                return vip_dict.get(pool[\u0027vip_id\u0027]).name"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2BSvE%3D","line":136,"in_reply_to":"AAAAUH%2F%2BY04%3D","updated":"2014-01-28 10:41:53.000000000","message":"No problem. I just thought do we need to check it is None strictly? and wondered there is a case where vip_id is \u0027\u0027 (an empty string). After checking the API spec, vip_id is never \u0027\u0027.","commit_id":"5391659fdfd0d86165ed743255d0d167c992375e"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"87e410cb9954d287dde23d578198a3be1b0881bc","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"def _get_vip_name(request, pool, vip_dict):"},{"line_number":136,"context_line":"    if pool[\u0027vip_id\u0027] is not None:"},{"line_number":137,"context_line":"        try:"},{"line_number":138,"context_line":"            if vip_dict:"},{"line_number":139,"context_line":"                return vip_dict.get(pool[\u0027vip_id\u0027]).name"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2BY04%3D","line":136,"in_reply_to":"AAAAUH%2F%2BkWg%3D","updated":"2014-01-27 14:54:00.000000000","message":"If there is no VIP in a pool, the pool has an attribute \u0027vip_id\u0027 anyway, and pool[\u0027vip_id\u0027] is None. According to PEP8, comparison to None should be done with \u0027is\u0027 or \u0027is not\u0027. Also it is a tiny bit faster and IMO much more readable.","commit_id":"5391659fdfd0d86165ed743255d0d167c992375e"}],"openstack_dashboard/api/vpn.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"56d65b86285f7aa3ffd9163f196a65eb1a33d3ff","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    \"\"\"Wrapper for neutron VPN IKEPolicy.\"\"\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def __init__(self, apiresource):"},{"line_number":35,"context_line":"        super(IKEPolicy, self).__init__(apiresource)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"class IPSecPolicy(neutron.NeutronAPIDictWrapper):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2BkQU%3D","line":35,"updated":"2014-01-24 10:36:44.000000000","message":"__init__ method is no longer needed :-)\n\n  class IKEPolicy(neutron.NeutronAPIDictWrapper):\n      \"\"\"Wrapper for neutron VPN IKEPolicy.\"\"\"\n      pass","commit_id":"5391659fdfd0d86165ed743255d0d167c992375e"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"87e410cb9954d287dde23d578198a3be1b0881bc","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    \"\"\"Wrapper for neutron VPN IKEPolicy.\"\"\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def __init__(self, apiresource):"},{"line_number":35,"context_line":"        super(IKEPolicy, self).__init__(apiresource)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"class IPSecPolicy(neutron.NeutronAPIDictWrapper):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2BZCA%3D","line":35,"in_reply_to":"AAAAUH%2F%2BkQU%3D","updated":"2014-01-27 14:54:00.000000000","message":"Same thought as in lbaas.py","commit_id":"5391659fdfd0d86165ed743255d0d167c992375e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"56d65b86285f7aa3ffd9163f196a65eb1a33d3ff","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    \"\"\"Wrapper for neutron VPN IPSecPolicy.\"\"\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def __init__(self, apiresource):"},{"line_number":43,"context_line":"        super(IPSecPolicy, self).__init__(apiresource)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"class IPSecSiteConnection(neutron.NeutronAPIDictWrapper):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2BkQE%3D","line":43,"updated":"2014-01-24 10:36:44.000000000","message":"Ditto","commit_id":"5391659fdfd0d86165ed743255d0d167c992375e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"56d65b86285f7aa3ffd9163f196a65eb1a33d3ff","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    \"\"\"Wrapper for neutron IPSecSiteConnection.\"\"\""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def __init__(self, apiresource):"},{"line_number":51,"context_line":"        super(IPSecSiteConnection, self).__init__(apiresource)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"class VPNService(neutron.NeutronAPIDictWrapper):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2BkP8%3D","line":51,"updated":"2014-01-24 10:36:44.000000000","message":"Ditto","commit_id":"5391659fdfd0d86165ed743255d0d167c992375e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"56d65b86285f7aa3ffd9163f196a65eb1a33d3ff","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    \"\"\"Wrapper for neutron VPNService.\"\"\""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def __init__(self, apiresource):"},{"line_number":59,"context_line":"        super(VPNService, self).__init__(apiresource)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"def vpnservice_create(request, **kwargs):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2BkP4%3D","line":59,"updated":"2014-01-24 10:36:44.000000000","message":"Ditto","commit_id":"5391659fdfd0d86165ed743255d0d167c992375e"}],"openstack_dashboard/dashboards/project/loadbalancers/tabs.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"64073b1c2802741e2809894e241eb618b1290d74","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            exceptions.handle(self.tab_group.request,"},{"line_number":42,"context_line":"                              _(\u0027Unable to retrieve pools list.\u0027))"},{"line_number":43,"context_line":"        for p in pools:"},{"line_number":44,"context_line":"            p.set_id_as_name_if_empty()"},{"line_number":45,"context_line":"        return pools"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FaJc%3D","line":44,"updated":"2014-01-14 02:14:41.000000000","message":"Or you can use \"name_or_id\" property.","commit_id":"afce607f2a07572457df82472d440777fb3dc99d"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"e9da670feaadff437bfc34326a39a6503283112c","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            exceptions.handle(self.tab_group.request,"},{"line_number":42,"context_line":"                              _(\u0027Unable to retrieve pools list.\u0027))"},{"line_number":43,"context_line":"        for p in pools:"},{"line_number":44,"context_line":"            p.set_id_as_name_if_empty()"},{"line_number":45,"context_line":"        return pools"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FQdc%3D","line":44,"in_reply_to":"AAAAUH%2F%2FaJc%3D","updated":"2014-01-15 20:01:16.000000000","message":"What do you think about L.43-44? Aren\u0027t they redundant at all?","commit_id":"afce607f2a07572457df82472d440777fb3dc99d"}],"openstack_dashboard/dashboards/project/vpn/tabs.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"56d65b86285f7aa3ffd9163f196a65eb1a33d3ff","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        setattr(base_obj, resource, obj)"},{"line_number":46,"context_line":"    except Exception:"},{"line_number":47,"context_line":"        fake_dict \u003d {\u0027id\u0027: obj_id, \u0027name\u0027: \u0027\u0027}"},{"line_number":48,"context_line":"        setattr(base_obj, resource,"},{"line_number":49,"context_line":"                api.neutron.NeutronAPIDictWrapper(fake_dict))"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2BkTo%3D","line":48,"updated":"2014-01-24 10:36:44.000000000","message":"Generally speaking this method is no longer needed because for example vpnservice_get expands subnet and router now. Thus L.43-45 is duplicated.\n\nOne big difference is that this method does exception handling and ensure a fake object with \"id\" and \"name\" when an exception is raised.\n\"id\" and \"name\" is referred to in vpn templates (xxx.name_or_id).\n\nI start to think the exception handling at L.47-49 to get_context_data in each class, but it is not small change and it can be done in a separate patch. I can work on refactor based on your work.\n\nThought?","commit_id":"5391659fdfd0d86165ed743255d0d167c992375e"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"87e410cb9954d287dde23d578198a3be1b0881bc","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        setattr(base_obj, resource, obj)"},{"line_number":46,"context_line":"    except Exception:"},{"line_number":47,"context_line":"        fake_dict \u003d {\u0027id\u0027: obj_id, \u0027name\u0027: \u0027\u0027}"},{"line_number":48,"context_line":"        setattr(base_obj, resource,"},{"line_number":49,"context_line":"                api.neutron.NeutronAPIDictWrapper(fake_dict))"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2BYUo%3D","line":48,"in_reply_to":"AAAAUH%2F%2BkTo%3D","updated":"2014-01-27 14:54:00.000000000","message":"Well, this requires some more thought. I like the idea of moving exception handling to get_context_data. It would be a nice simplification, but I\u0027m not sure about readability. Anyway, this change is definitely for another patch set.","commit_id":"5391659fdfd0d86165ed743255d0d167c992375e"}]}
