)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"57fba4cb2a8be3b322df08ee913dc0be690ed3d2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add use_required_attribute \u003d False in some form"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When an element is required and hidden,"},{"line_number":10,"context_line":"the browser will report an error when submitting the form."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Here is the code location where Django adds the required attribute to the element:"},{"line_number":13,"context_line":"https://github.com/django/django/blob/master/django/forms/boundfield.py#L221-L222"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bfb3d3c7_8f90324c","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":58},"updated":"2019-05-28 12:04:46.000000000","message":"I checked the first two files you touched, but I cannot understand why use_required_attribute is needed. Is this description correct?","commit_id":"d11c15c4e21a464783cbc1126401bf69c15006a9"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"4e1ae9af28508d5953e75c87af2857e5da181bc1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ede3b7de_19e4810d","updated":"2025-05-22 07:52:25.000000000","message":"@jjasek@redhat.com hello, please close this MR.","commit_id":"d11c15c4e21a464783cbc1126401bf69c15006a9"}],"openstack_dashboard/dashboards/admin/networks/agents/forms.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"57fba4cb2a8be3b322df08ee913dc0be690ed3d2","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class AddDHCPAgent(forms.SelfHandlingForm):"},{"line_number":26,"context_line":"    use_required_attribute \u003d False"},{"line_number":27,"context_line":"    network_id \u003d forms.CharField(widget\u003dforms.HiddenInput())"},{"line_number":28,"context_line":"    network_name \u003d forms.CharField(label\u003d_(\"Network Name\"),"},{"line_number":29,"context_line":"                                   widget\u003dforms.TextInput("}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_4fad5a99","line":26,"updated":"2019-05-28 12:04:46.000000000","message":"I cannot understand why this form needs this.\nThere is a hidden input but the field always exists.\nIn addition, there is no conditional field.","commit_id":"d11c15c4e21a464783cbc1126401bf69c15006a9"},{"author":{"_account_id":27822,"name":"pengyuesheng","email":"pengyuesheng@gohighsec.com","username":"pengyuesheng"},"change_message_id":"170694fc5a93c4ea83a39248cc2611b04dfc4a12","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class AddDHCPAgent(forms.SelfHandlingForm):"},{"line_number":26,"context_line":"    use_required_attribute \u003d False"},{"line_number":27,"context_line":"    network_id \u003d forms.CharField(widget\u003dforms.HiddenInput())"},{"line_number":28,"context_line":"    network_name \u003d forms.CharField(label\u003d_(\"Network Name\"),"},{"line_number":29,"context_line":"                                   widget\u003dforms.TextInput("}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_4372077d","line":26,"in_reply_to":"bfb3d3c7_4fad5a99","updated":"2019-05-29 01:21:59.000000000","message":"When we click the submit button directly, the page doesn\u0027t react and the browser throws an error.So I joined use_required_attribute","commit_id":"d11c15c4e21a464783cbc1126401bf69c15006a9"}],"openstack_dashboard/dashboards/admin/rbac_policies/forms.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"57fba4cb2a8be3b322df08ee913dc0be690ed3d2","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"class CreatePolicyForm(forms.SelfHandlingForm):"},{"line_number":53,"context_line":"    use_required_attribute \u003d False"},{"line_number":54,"context_line":"    target_tenant \u003d forms.ThemableChoiceField(label\u003d_(\"Target Project\"))"},{"line_number":55,"context_line":"    action_object_type \u003d forms.ThemableChoiceField("},{"line_number":56,"context_line":"        label\u003d_(\"Action and Object Type\"),"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_af9bb670","line":53,"updated":"2019-05-28 12:04:46.000000000","message":"Could you explain why this is required?\nAll conditional fields are marked as \"required\u003dFalse\".","commit_id":"d11c15c4e21a464783cbc1126401bf69c15006a9"},{"author":{"_account_id":27822,"name":"pengyuesheng","email":"pengyuesheng@gohighsec.com","username":"pengyuesheng"},"change_message_id":"170694fc5a93c4ea83a39248cc2611b04dfc4a12","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"class CreatePolicyForm(forms.SelfHandlingForm):"},{"line_number":53,"context_line":"    use_required_attribute \u003d False"},{"line_number":54,"context_line":"    target_tenant \u003d forms.ThemableChoiceField(label\u003d_(\"Target Project\"))"},{"line_number":55,"context_line":"    action_object_type \u003d forms.ThemableChoiceField("},{"line_number":56,"context_line":"        label\u003d_(\"Action and Object Type\"),"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_832a3f29","line":53,"in_reply_to":"bfb3d3c7_af9bb670","updated":"2019-05-29 01:21:59.000000000","message":"When we click the submit button directly, the page doesn\u0027t react and the browser throws an error. Django will check if the field is empty, so I joined use_required_attribute \u003d False","commit_id":"d11c15c4e21a464783cbc1126401bf69c15006a9"}]}