)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"0d052b3de5d62ed78e6a902f35bde9941df35af0","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Heat Stack update view/form"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"blueprint:"},{"line_number":10,"context_line":"https://blueprints.launchpad.net/horizon/+spec/heat-stack-update"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I2854e9e4bb578be5187ef962808b93f11ac6b1f1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"AAAAUH%2F%2BsTs%3D","line":10,"updated":"2014-01-23 05:32:38.000000000","message":"Please reference the bp like?\"Implements: blueprint heat-stack-update\"","commit_id":"4ce782efb55fa7a3f29f9919b3f5f0d346606495"}],"openstack_dashboard/api/heat.py":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"0d6b93c3ebd95227f8461262c3daedc81e0d7cc8","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    return heatclient(request, password).stacks.create(**kwargs)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"def stack_update(request, stack_id, password\u003dNone, **kwargs):"},{"line_number":76,"context_line":"    return heatclient(request).stacks.update(stack_id, **kwargs)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAVX%2F%2FtmU%3D","line":75,"updated":"2014-02-28 21:07:02.000000000","message":"the password parameter is not used in the update call. Is this used to ignore the password parameter when making the update call?\n\nIf yes, I think it would be better to explicitly pop the password from kwargs rather than this approach.","commit_id":"77ee1d3b2413748f9aa1c7a969e98a1b6f2476ff"}],"openstack_dashboard/dashboards/project/stacks/forms.py":[{"author":{"_account_id":7386,"name":"Tzu-Mainn Chen","email":"tzumainn@redhat.com","username":"tzumainn"},"change_message_id":"c8c68aa498f97ffabccb99c33f957c1faae9812c","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        # request so that we can chain it as an input to the next view..."},{"line_number":179,"context_line":"        # but hey, it totally works."},{"line_number":180,"context_line":"        request.method \u003d \u0027GET\u0027"},{"line_number":181,"context_line":"        return self.next_view.as_view()(request, **kwargs)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"class CreateStackForm(forms.SelfHandlingForm):"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUH%2F%2Bs98%3D","line":181,"updated":"2014-01-23 01:12:45.000000000","message":"This seems pretty similar to the TemplateForm handle method; is it possible to change this to somehow super that and add in the stack_id parameter?  I\u0027m not sure.","commit_id":"4ce782efb55fa7a3f29f9919b3f5f0d346606495"},{"author":{"_account_id":7386,"name":"Tzu-Mainn Chen","email":"tzumainn@redhat.com","username":"tzumainn"},"change_message_id":"c8c68aa498f97ffabccb99c33f957c1faae9812c","unresolved":false,"context_lines":[{"line_number":326,"context_line":"            fields[\u0027template\u0027] \u003d data.get(\u0027template_data\u0027)"},{"line_number":327,"context_line":"        elif data.get(\u0027template_url\u0027):"},{"line_number":328,"context_line":"            fields[\u0027template_url\u0027] \u003d data.get(\u0027template_url\u0027)"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"        try:"},{"line_number":331,"context_line":"            api.heat.stack_update(self.request, stack_id, **fields)"},{"line_number":332,"context_line":"            messages.success(request, _(\"Stack update started.\"))"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUH%2F%2Bs%2BE%3D","line":329,"updated":"2014-01-23 01:12:45.000000000","message":"Would it be possible to put these lines dealing with the fields parameter - 312 - 329 - in a separate method in CreateStackForm - and use something like:\n\nfields \u003d self._get_fields(data)\n\n. . . in both the Create and Edit handle methods?  It seems like that would cut out a lot of code duplication.","commit_id":"4ce782efb55fa7a3f29f9919b3f5f0d346606495"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"0d052b3de5d62ed78e6a902f35bde9941df35af0","unresolved":false,"context_lines":[{"line_number":326,"context_line":"            fields[\u0027template\u0027] \u003d data.get(\u0027template_data\u0027)"},{"line_number":327,"context_line":"        elif data.get(\u0027template_url\u0027):"},{"line_number":328,"context_line":"            fields[\u0027template_url\u0027] \u003d data.get(\u0027template_url\u0027)"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"        try:"},{"line_number":331,"context_line":"            api.heat.stack_update(self.request, stack_id, **fields)"},{"line_number":332,"context_line":"            messages.success(request, _(\"Stack update started.\"))"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUH%2F%2BsSE%3D","line":329,"in_reply_to":"AAAAUH%2F%2Bs%2BE%3D","updated":"2014-01-23 05:32:38.000000000","message":"+1","commit_id":"4ce782efb55fa7a3f29f9919b3f5f0d346606495"}],"openstack_dashboard/dashboards/project/stacks/tests.py":[{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"0d052b3de5d62ed78e6a902f35bde9941df35af0","unresolved":false,"context_lines":[{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        self.mox.ReplayAll()"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        url \u003d reverse(\u0027horizon:project:stacks:change_template\u0027)"},{"line_number":178,"context_line":"        res \u003d self.client.get(url)"},{"line_number":179,"context_line":"        self.assertTemplateUsed(res, \u0027project/stacks/select_template.html\u0027)"},{"line_number":180,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUH%2F%2BsNg%3D","line":177,"updated":"2014-01-23 05:32:38.000000000","message":"miss args\u003d[stack.id].","commit_id":"4ce782efb55fa7a3f29f9919b3f5f0d346606495"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"0d052b3de5d62ed78e6a902f35bde9941df35af0","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        res \u003d self.client.post(url, form_data)"},{"line_number":185,"context_line":"        self.assertTemplateUsed(res, \u0027project/stacks/update.html\u0027)"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        url \u003d reverse(\u0027horizon:project:stacks:edit_template\u0027)"},{"line_number":188,"context_line":"        form_data \u003d {\u0027template_source\u0027: \u0027raw\u0027,"},{"line_number":189,"context_line":"                     \u0027template_data\u0027: template.data,"},{"line_number":190,"context_line":"                     \u0027password\u0027: \u0027password\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUH%2F%2BsNY%3D","line":187,"updated":"2014-01-23 05:32:38.000000000","message":"ditto","commit_id":"4ce782efb55fa7a3f29f9919b3f5f0d346606495"}],"openstack_dashboard/dashboards/project/stacks/urls.py":[{"author":{"_account_id":7386,"name":"Tzu-Mainn Chen","email":"tzumainn@redhat.com","username":"tzumainn"},"change_message_id":"0bae1221da283f27088baf6b30414dcd4c0b25bd","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    url(r\u0027^(?P\u003cstack_id\u003e[^/]+)/change_template$\u0027,"},{"line_number":30,"context_line":"        views.ChangeTemplateView.as_view(), name\u003d\u0027change_template\u0027),"},{"line_number":31,"context_line":"    url(r\u0027^(?P\u003cstack_id\u003e[^/]+)/edit_template$\u0027,"},{"line_number":32,"context_line":"        views.EditStackView.as_view(), name\u003d\u0027edit_template\u0027),"},{"line_number":33,"context_line":"    url(r\u0027^stack/(?P\u003cstack_id\u003e[^/]+)/(?P\u003cresource_name\u003e[^/]+)/$\u0027,"},{"line_number":34,"context_line":"        views.ResourceView.as_view(), name\u003d\u0027resource\u0027),"},{"line_number":35,"context_line":"    url(r\u0027^get_d3_data/(?P\u003cstack_id\u003e[^/]+)/$\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAUH%2F%2BJEw%3D","line":32,"updated":"2014-01-29 19:13:11.000000000","message":"should this url be consistent?  edit_template vs edit_stack?","commit_id":"7f0cd5b9f286d1e76888d8168c27e71f7b3e68ef"}],"openstack_dashboard/dashboards/project/stacks/views.py":[{"author":{"_account_id":7386,"name":"Tzu-Mainn Chen","email":"tzumainn@redhat.com","username":"tzumainn"},"change_message_id":"0bae1221da283f27088baf6b30414dcd4c0b25bd","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        try:"},{"line_number":84,"context_line":"            stack \u003d {}"},{"line_number":85,"context_line":"            stack \u003d api.heat.stack_get(self.request, stack_id)"},{"line_number":86,"context_line":"            self._stack \u003d stack"},{"line_number":87,"context_line":"        except Exception:"},{"line_number":88,"context_line":"            msg \u003d _(\"Unable to retrieve stack.\")"},{"line_number":89,"context_line":"            redirect \u003d reverse(\u0027horizon:project:stacks:index\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAUH%2F%2BJDg%3D","line":86,"updated":"2014-01-29 19:13:11.000000000","message":"can the above three lines just be simplified to:\n\nself._stack \u003d api.heat.stack_get(self.request, stack_id)\n\n?","commit_id":"7f0cd5b9f286d1e76888d8168c27e71f7b3e68ef"},{"author":{"_account_id":7386,"name":"Tzu-Mainn Chen","email":"tzumainn@redhat.com","username":"tzumainn"},"change_message_id":"0bae1221da283f27088baf6b30414dcd4c0b25bd","unresolved":false,"context_lines":[{"line_number":160,"context_line":"            stack[\u0027stack\u0027] \u003d api.heat.stack_get(self.request, stack_id)"},{"line_number":161,"context_line":"            stack[\u0027template\u0027] \u003d api.heat.template_get(self.request, stack_id)"},{"line_number":162,"context_line":"            self._stack \u003d stack"},{"line_number":163,"context_line":"        except Exception:"},{"line_number":164,"context_line":"            msg \u003d _(\"Unable to retrieve stack.\")"},{"line_number":165,"context_line":"            redirect \u003d reverse(\u0027horizon:project:stacks:index\u0027)"},{"line_number":166,"context_line":"            exceptions.handle(self.request, msg, redirect\u003dredirect)"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAUH%2F%2BJDE%3D","line":163,"updated":"2014-01-29 19:13:11.000000000","message":"same comment as above","commit_id":"7f0cd5b9f286d1e76888d8168c27e71f7b3e68ef"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"0d6b93c3ebd95227f8461262c3daedc81e0d7cc8","unresolved":false,"context_lines":[{"line_number":141,"context_line":""},{"line_number":142,"context_line":"        return initial"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def get_form_kwargs(self):"},{"line_number":145,"context_line":"        kwargs \u003d super(EditStackView, self).get_form_kwargs()"},{"line_number":146,"context_line":"        return kwargs"},{"line_number":147,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAVX%2F%2Ftbc%3D","line":144,"updated":"2014-02-28 21:07:02.000000000","message":"Can we remove this, it doesn\u0027t really do anything here.","commit_id":"77ee1d3b2413748f9aa1c7a969e98a1b6f2476ff"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"48bb6ccea35930196971181c081fe0e52eb44e1e","unresolved":false,"context_lines":[{"line_number":141,"context_line":""},{"line_number":142,"context_line":"        return initial"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def get_form_kwargs(self):"},{"line_number":145,"context_line":"        kwargs \u003d super(EditStackView, self).get_form_kwargs()"},{"line_number":146,"context_line":"        return kwargs"},{"line_number":147,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAVX%2F%2FsCw%3D","line":144,"in_reply_to":"AAAAVX%2F%2Ftbc%3D","updated":"2014-03-01 01:43:46.000000000","message":"+1 on removing this.","commit_id":"77ee1d3b2413748f9aa1c7a969e98a1b6f2476ff"}]}
