)]}'
{"openstack_dashboard/management/commands/horizon.wsgi.template":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2a0c9c73f46b802e8d3191fee9572f8d58b13ba9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7faddb67_88e5703a","updated":"2019-07-17 12:18:51.000000000","message":"Why do you need noqa and pylint disable?\nWho complains it? OpenStack CI does not complain it.\nWe need more information on maintenance.","commit_id":"5e817478ced084d09cb7bcb6b0346a7d9a80be7f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6c337e5430720deddb79f07f71153fca72784574","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7faddb67_2b86e814","in_reply_to":"7faddb67_1ed3fad6","updated":"2019-07-31 12:55:22.000000000","message":"Okay, we already have local_settings.py in the ignored list.\nIdeally we should avoid generating files under the repo....","commit_id":"5e817478ced084d09cb7bcb6b0346a7d9a80be7f"},{"author":{"_account_id":8674,"name":"Yves-Gwenael Bourhis","email":"ygbourhis@gmail.com","username":"yves"},"change_message_id":"ede7fe5b59ba21a5458706d07c0361bfbdb1fba8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7faddb67_1ed3fad6","in_reply_to":"7faddb67_88e5703a","updated":"2019-07-17 14:05:54.000000000","message":"\u003e Why do you need noqa and pylint disable?\n \u003e Who complains it? OpenStack CI does not complain it.\n \u003e We need more information on maintenance.\n\nIf you generate this file , it is git ignored, but the pep8 checks complain about it.\nI agree it could be better to tell tox.ini to ignore this file \"if it exists\".","commit_id":"5e817478ced084d09cb7bcb6b0346a7d9a80be7f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e6560119b7ba2463f2b24d873800c1bab0be30c9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!{{ PYTHON_EXEC }}"},{"line_number":2,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":3,"context_line":"# not use this file except in compliance with the License. You may obtain"},{"line_number":4,"context_line":"# a copy of the License at"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"7faddb67_ccb7f5f4","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":19},"updated":"2019-07-17 18:13:52.000000000","message":"Do we really need this line?\n\nIn case of devstack (with apache mod_wsgi), we are using [1] and [1] does not contain this line.\n\n(There are several differences between this and [1], but I haven\u0027t checked what they mean.)\n\n[1] https://opendev.org/openstack/horizon/src/branch/master/openstack_dashboard/wsgi.py","commit_id":"66144165ff39b8b7b5257e141c51a081d498963f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6c337e5430720deddb79f07f71153fca72784574","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!{{ PYTHON_EXEC }}"},{"line_number":2,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":3,"context_line":"# not use this file except in compliance with the License. You may obtain"},{"line_number":4,"context_line":"# a copy of the License at"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"7faddb67_0e253a5c","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":19},"in_reply_to":"7faddb67_cae883b4","updated":"2019-07-31 12:55:22.000000000","message":"Thanks for sharing your detail thought. Your thought on the wsgi template makes sense to me.\n\nOn the other hand, I am not sure the django application project should be responsible for sample configurations of all WSGI web servers. We are not necessarily familiar with all web servers, so such configuration samples can be out of date easily.","commit_id":"66144165ff39b8b7b5257e141c51a081d498963f"},{"author":{"_account_id":8674,"name":"Yves-Gwenael Bourhis","email":"ygbourhis@gmail.com","username":"yves"},"change_message_id":"c39b1235374aa9c01df15469815ccfc481bc16e7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!{{ PYTHON_EXEC }}"},{"line_number":2,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":3,"context_line":"# not use this file except in compliance with the License. You may obtain"},{"line_number":4,"context_line":"# a copy of the License at"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"7faddb67_cae883b4","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":19},"in_reply_to":"7faddb67_ccb7f5f4","updated":"2019-07-30 13:27:52.000000000","message":"Apache and nginx simply ignore it, uwsgi I don\u0027t know.\n\nIn fact, this wsgi file is a pure python script which can be executed directly from the command line by any process.\n\nWith the shebang we make it fully universal for any kind of web servers, even exotic ones.\n\nThis wgsi file is intended for all web servers and not only apache.\n\nIn fact, the make_web_conf command should add support for --nginx, --uwsgi, etc (and grow).\n\nThe reason we have the shebang is to insure this script is universal whatever web server uses it.\nIt can only help but can\u0027t harm.\nIt also helps any one reading it to know which python executable is used and can greatly help when debugging on a server with multiple python versions (I\u0027ve seen some...).","commit_id":"66144165ff39b8b7b5257e141c51a081d498963f"}],"openstack_dashboard/management/commands/make_web_conf.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2a0c9c73f46b802e8d3191fee9572f8d58b13ba9","unresolved":false,"context_lines":[{"line_number":36,"context_line":"PROJECT_PATH \u003d os.path.realpath(os.path.join(CURDIR, \u0027../..\u0027))"},{"line_number":37,"context_line":"STATIC_PATH \u003d os.path.realpath(os.path.join(PROJECT_PATH, \u0027../static\u0027))"},{"line_number":38,"context_line":"# Use STATIC_ROOT from settings if exists and is not None:"},{"line_number":39,"context_line":"STATIC_PATH \u003d getattr(settings, \u0027STATIC_ROOT\u0027, STATIC_PATH) or STATIC_PATH"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"# Known apache regular expression to retrieve it\u0027s version"},{"line_number":42,"context_line":"APACHE_VERSION_REG \u003d r\u0027Apache/(?P\u003cversion\u003e[\\d.]*)\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_a8b94c15","line":39,"range":{"start_line":39,"start_character":14,"end_line":39,"end_character":21},"updated":"2019-07-17 12:18:51.000000000","message":"Is there a case where STATIC_ROOT is not defined?\nDjango document says the default value is None.\nhttps://docs.djangoproject.com/en/2.2/ref/settings/#static-root\n\nEven if there is a case where STATIC_ROOT is not defined, the default value is None, so\n\n  getattr(settings, \u0027STATIC_ROOT\u0027, None)\n\nis better. getattr default value should match the default value.","commit_id":"5e817478ced084d09cb7bcb6b0346a7d9a80be7f"},{"author":{"_account_id":8674,"name":"Yves-Gwenael Bourhis","email":"ygbourhis@gmail.com","username":"yves"},"change_message_id":"ede7fe5b59ba21a5458706d07c0361bfbdb1fba8","unresolved":false,"context_lines":[{"line_number":36,"context_line":"PROJECT_PATH \u003d os.path.realpath(os.path.join(CURDIR, \u0027../..\u0027))"},{"line_number":37,"context_line":"STATIC_PATH \u003d os.path.realpath(os.path.join(PROJECT_PATH, \u0027../static\u0027))"},{"line_number":38,"context_line":"# Use STATIC_ROOT from settings if exists and is not None:"},{"line_number":39,"context_line":"STATIC_PATH \u003d getattr(settings, \u0027STATIC_ROOT\u0027, STATIC_PATH) or STATIC_PATH"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"# Known apache regular expression to retrieve it\u0027s version"},{"line_number":42,"context_line":"APACHE_VERSION_REG \u003d r\u0027Apache/(?P\u003cversion\u003e[\\d.]*)\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_ded802f0","line":39,"range":{"start_line":39,"start_character":14,"end_line":39,"end_character":21},"in_reply_to":"7faddb67_a8b94c15","updated":"2019-07-17 14:05:54.000000000","message":"Well yes:\nhttps://github.com/openstack/horizon/blob/master/openstack_dashboard/settings.py#L64\n\nAnd no:\nhttps://github.com/openstack/horizon/blob/master/openstack_dashboard/settings.py#L412\n\nIt seems always defined","commit_id":"5e817478ced084d09cb7bcb6b0346a7d9a80be7f"}]}