)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ecf3f7e9b385b7cb65b8970c3c6889fced408759","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     manchandavishal \u003cmanchandavishal143@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-08-27 10:42:36 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Refactor-error-messages for project panel"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Error messages can come from different projects(cinder, keystone,"},{"line_number":10,"context_line":"nova, etc.),but we are currently catching all the exceptions and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7faddb67_58c4aa41","line":7,"range":{"start_line":7,"start_character":36,"end_line":7,"end_character":41},"updated":"2019-08-27 11:06:19.000000000","message":"In the horizon terminology this is called as \"dashboard\".","commit_id":"5544357e7c872aa6d7296a7da71e1da153ef8190"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"5f2a66612745d55c1ad8d69fcef6b3729dddf4fa","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     manchandavishal \u003cmanchandavishal143@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-08-27 10:42:36 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Refactor-error-messages for project panel"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Error messages can come from different projects(cinder, keystone,"},{"line_number":10,"context_line":"nova, etc.),but we are currently catching all the exceptions and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7faddb67_0be9fae1","line":7,"range":{"start_line":7,"start_character":36,"end_line":7,"end_character":41},"in_reply_to":"7faddb67_58c4aa41","updated":"2019-08-27 11:56:06.000000000","message":"oK, will update it in next PS.\nThanks","commit_id":"5544357e7c872aa6d7296a7da71e1da153ef8190"}],"horizon/messages.py":[{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"0a7569dc25984079f42d0bb009f3d4e8b4144df9","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"def add_message(request, level, message, extra_tags\u003d\u0027\u0027, fail_silently\u003dFalse,"},{"line_number":40,"context_line":"                is_detail\u003d\u0027\u0027):"},{"line_number":41,"context_line":"    \"\"\"Attempts to add a message to the request using the \u0027messages\u0027 app.\"\"\""},{"line_number":42,"context_line":"    if not horizon_message_already_queued(request, message):"},{"line_number":43,"context_line":"        if request.is_ajax():"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_6bd27500","line":40,"updated":"2020-02-12 14:31:20.000000000","message":"Traditionally variables starting with \"is_\" are boolean variables that talk about the object itself. In this case, it would make more sense to have \"has_details\" if it\u0027s a boolean function, or just \"details\" for the content of the detailed information.","commit_id":"b2bc71f8940f6ad5820a7ff451acd07a2e08c799"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"7581cb4b776e3b97a2235ee8fa2ac072f8b3dbd7","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"def add_message(request, level, message, extra_tags\u003d\u0027\u0027, fail_silently\u003dFalse,"},{"line_number":40,"context_line":"                is_detail\u003d\u0027\u0027):"},{"line_number":41,"context_line":"    \"\"\"Attempts to add a message to the request using the \u0027messages\u0027 app.\"\"\""},{"line_number":42,"context_line":"    if not horizon_message_already_queued(request, message):"},{"line_number":43,"context_line":"        if request.is_ajax():"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_43d99d25","line":40,"in_reply_to":"3fa7e38b_6bd27500","updated":"2020-02-12 16:24:38.000000000","message":"Please just use \"details\". Also, please change all \"detail\" to \"details\".","commit_id":"b2bc71f8940f6ad5820a7ff451acd07a2e08c799"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"5a4897d51f476ee9210274beebe1769f5a527dad","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"def add_message(request, level, message, extra_tags\u003d\u0027\u0027, fail_silently\u003dFalse,"},{"line_number":40,"context_line":"                is_detail\u003d\u0027\u0027):"},{"line_number":41,"context_line":"    \"\"\"Attempts to add a message to the request using the \u0027messages\u0027 app.\"\"\""},{"line_number":42,"context_line":"    if not horizon_message_already_queued(request, message):"},{"line_number":43,"context_line":"        if request.is_ajax():"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_36b860e6","line":40,"in_reply_to":"3fa7e38b_6bd27500","updated":"2020-02-12 14:58:54.000000000","message":"ok, I will use \"has_details\".\nThanks","commit_id":"b2bc71f8940f6ad5820a7ff451acd07a2e08c799"}],"horizon/templates/horizon/client_side/_alert_message.html":[{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"0a7569dc25984079f42d0bb009f3d4e8b4144df9","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    [[/safe]]"},{"line_number":16,"context_line":"    [[^safe]]"},{"line_number":17,"context_line":"      [[message]]"},{"line_number":18,"context_line":"      \u003ca href\u003d\"#demo\"  data-toggle\u003d\"collapse\" data-target\u003d\"#demo\"\u003eDetail\u003c/a\u003e"},{"line_number":19,"context_line":"      \u003cdiv id\u003d\"demo\" class\u003d\"collapse\"\u003e"},{"line_number":20,"context_line":"      [[detail]]"},{"line_number":21,"context_line":"      \u003c/div\u003e"}],"source_content_type":"text/html","patch_set":5,"id":"3fa7e38b_cb7fe9b9","line":18,"updated":"2020-02-12 14:31:20.000000000","message":"This should read \"Details\". \"Detail\" would be a single fact.","commit_id":"b2bc71f8940f6ad5820a7ff451acd07a2e08c799"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"5a4897d51f476ee9210274beebe1769f5a527dad","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    [[/safe]]"},{"line_number":16,"context_line":"    [[^safe]]"},{"line_number":17,"context_line":"      [[message]]"},{"line_number":18,"context_line":"      \u003ca href\u003d\"#demo\"  data-toggle\u003d\"collapse\" data-target\u003d\"#demo\"\u003eDetail\u003c/a\u003e"},{"line_number":19,"context_line":"      \u003cdiv id\u003d\"demo\" class\u003d\"collapse\"\u003e"},{"line_number":20,"context_line":"      [[detail]]"},{"line_number":21,"context_line":"      \u003c/div\u003e"}],"source_content_type":"text/html","patch_set":5,"id":"3fa7e38b_36862018","line":18,"in_reply_to":"3fa7e38b_cb7fe9b9","updated":"2020-02-12 14:58:54.000000000","message":"ok will update it in next PS.\nthanks.","commit_id":"b2bc71f8940f6ad5820a7ff451acd07a2e08c799"}],"openstack_dashboard/dashboards/project/floating_ips/views.py":[{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"0a7569dc25984079f42d0bb009f3d4e8b4144df9","unresolved":false,"context_lines":[{"line_number":129,"context_line":"            except Exception as ex:"},{"line_number":130,"context_line":"                exceptions.handle(self.request,"},{"line_number":131,"context_line":"                                  _(\u0027Unable to retrieve instance list: %s\u0027)"},{"line_number":132,"context_line":"                                  % ex)"},{"line_number":133,"context_line":"            instances_dict \u003d dict((obj.id, obj.name) for obj in instances)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        for ip in floating_ips:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_8bfa510f","line":132,"updated":"2020-02-12 14:31:20.000000000","message":"This is still the old approach?","commit_id":"b2bc71f8940f6ad5820a7ff451acd07a2e08c799"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"5a4897d51f476ee9210274beebe1769f5a527dad","unresolved":false,"context_lines":[{"line_number":129,"context_line":"            except Exception as ex:"},{"line_number":130,"context_line":"                exceptions.handle(self.request,"},{"line_number":131,"context_line":"                                  _(\u0027Unable to retrieve instance list: %s\u0027)"},{"line_number":132,"context_line":"                                  % ex)"},{"line_number":133,"context_line":"            instances_dict \u003d dict((obj.id, obj.name) for obj in instances)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        for ip in floating_ips:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_76a498a4","line":132,"in_reply_to":"3fa7e38b_8bfa510f","updated":"2020-02-12 14:58:54.000000000","message":"yeah, there are many places which I forgeot to update.\nI am going to change all in the next ps.","commit_id":"b2bc71f8940f6ad5820a7ff451acd07a2e08c799"}],"openstack_dashboard/dashboards/project/instances/forms.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"800b337f3cb28c6b10e2892230d787b819afc463","unresolved":false,"context_lines":[{"line_number":292,"context_line":"        except Exception:"},{"line_number":293,"context_line":"            redirect \u003d reverse(\u0027horizon:project:instances:index\u0027)"},{"line_number":294,"context_line":"            exceptions.handle("},{"line_number":295,"context_line":"                request, _(\"Unable to detach volume: %s\"),"},{"line_number":296,"context_line":"                redirect\u003dredirect)"},{"line_number":297,"context_line":"        return True"},{"line_number":298,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_3e5d51e9","line":295,"range":{"start_line":295,"start_character":53,"end_line":295,"end_character":55},"updated":"2020-08-18 18:49:55.000000000","message":"unnecessary","commit_id":"9ac47c2fc531bde75a85d4884ab70bd8d6536d11"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"478899c9b3c05fb819b944498a66e33223568a6f","unresolved":false,"context_lines":[{"line_number":292,"context_line":"        except Exception:"},{"line_number":293,"context_line":"            redirect \u003d reverse(\u0027horizon:project:instances:index\u0027)"},{"line_number":294,"context_line":"            exceptions.handle("},{"line_number":295,"context_line":"                request, _(\"Unable to detach volume: %s\"),"},{"line_number":296,"context_line":"                redirect\u003dredirect)"},{"line_number":297,"context_line":"        return True"},{"line_number":298,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_b5b17c92","line":295,"range":{"start_line":295,"start_character":53,"end_line":295,"end_character":55},"in_reply_to":"9f560f44_3e5d51e9","updated":"2020-08-19 03:49:11.000000000","message":"Done.","commit_id":"9ac47c2fc531bde75a85d4884ab70bd8d6536d11"}],"openstack_dashboard/dashboards/project/instances/workflows/update_instance.py":[{"author":{"_account_id":27822,"name":"pengyuesheng","email":"pengyuesheng@gohighsec.com","username":"pengyuesheng"},"change_message_id":"7f9f8f226897a724fb271a134fff97e97db8627e","unresolved":false,"context_lines":[{"line_number":47,"context_line":"            api.neutron.server_update_security_groups(request, instance_id,"},{"line_number":48,"context_line":"                                                      wanted_groups)"},{"line_number":49,"context_line":"        except Exception as e:"},{"line_number":50,"context_line":"            exceptions.handle(request, str(e))"},{"line_number":51,"context_line":"            return False"},{"line_number":52,"context_line":"        return True"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_5c3abbcc","side":"PARENT","line":50,"range":{"start_line":50,"start_character":38,"end_line":50,"end_character":45},"updated":"2020-09-04 09:06:13.000000000","message":"I think it should be replaced with some specific error message","commit_id":"5081359295e5311ca725e80efa0bc4b2ec811a0e"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"8b3505b5205fc9d7a8d3fc470cabea98d3a1fcf7","unresolved":false,"context_lines":[{"line_number":47,"context_line":"            api.neutron.server_update_security_groups(request, instance_id,"},{"line_number":48,"context_line":"                                                      wanted_groups)"},{"line_number":49,"context_line":"        except Exception as e:"},{"line_number":50,"context_line":"            exceptions.handle(request, str(e))"},{"line_number":51,"context_line":"            return False"},{"line_number":52,"context_line":"        return True"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_3cfd473b","side":"PARENT","line":50,"range":{"start_line":50,"start_character":38,"end_line":50,"end_character":45},"in_reply_to":"9f560f44_5c3abbcc","updated":"2020-09-04 09:56:36.000000000","message":"Good Catch.\nSpecific error message will be raised from api but it\u0027s good to add some message here otherwise it looks wired.","commit_id":"5081359295e5311ca725e80efa0bc4b2ec811a0e"}],"openstack_dashboard/dashboards/project/networks/subnets/workflows.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"800b337f3cb28c6b10e2892230d787b819afc463","unresolved":false,"context_lines":[{"line_number":221,"context_line":"            LOG.debug(\u0027Subnet \"%s\" was successfully updated.\u0027, data[\u0027cidr\u0027])"},{"line_number":222,"context_line":"            return subnet"},{"line_number":223,"context_line":"        except Exception:"},{"line_number":224,"context_line":"            msg \u003d (_(\u0027Failed to update subnet \"%(sub)s\".\u0027) %"},{"line_number":225,"context_line":"                   {\"sub\": data[\u0027cidr\u0027]})"},{"line_number":226,"context_line":"            redirect \u003d reverse(self.failure_url, args\u003d(network_id,))"},{"line_number":227,"context_line":"            exceptions.handle(request, msg, redirect\u003dredirect)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_1e05edc2","line":224,"range":{"start_line":224,"start_character":47,"end_line":224,"end_character":54},"updated":"2020-08-18 18:49:55.000000000","message":"When we have only one substitution, our convention uses %s instead of %(sub)s.","commit_id":"9ac47c2fc531bde75a85d4884ab70bd8d6536d11"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"478899c9b3c05fb819b944498a66e33223568a6f","unresolved":false,"context_lines":[{"line_number":221,"context_line":"            LOG.debug(\u0027Subnet \"%s\" was successfully updated.\u0027, data[\u0027cidr\u0027])"},{"line_number":222,"context_line":"            return subnet"},{"line_number":223,"context_line":"        except Exception:"},{"line_number":224,"context_line":"            msg \u003d (_(\u0027Failed to update subnet \"%(sub)s\".\u0027) %"},{"line_number":225,"context_line":"                   {\"sub\": data[\u0027cidr\u0027]})"},{"line_number":226,"context_line":"            redirect \u003d reverse(self.failure_url, args\u003d(network_id,))"},{"line_number":227,"context_line":"            exceptions.handle(request, msg, redirect\u003dredirect)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_95ac3836","line":224,"range":{"start_line":224,"start_character":47,"end_line":224,"end_character":54},"in_reply_to":"9f560f44_1e05edc2","updated":"2020-08-19 03:49:11.000000000","message":"removed.","commit_id":"9ac47c2fc531bde75a85d4884ab70bd8d6536d11"}],"openstack_dashboard/dashboards/project/networks/workflows.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"800b337f3cb28c6b10e2892230d787b819afc463","unresolved":false,"context_lines":[{"line_number":495,"context_line":"            return network"},{"line_number":496,"context_line":"        except Exception as e:"},{"line_number":497,"context_line":"            LOG.info(\u0027Failed to create network: %s\u0027, e)"},{"line_number":498,"context_line":"            msg \u003d (_(\u0027Failed to create network \"%(network)s\".\u0027) %"},{"line_number":499,"context_line":"                   {\"network\": data[\u0027net_name\u0027]})"},{"line_number":500,"context_line":"            redirect \u003d self.get_failure_url()"},{"line_number":501,"context_line":"            exceptions.handle(request, msg, redirect\u003dredirect)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_5e0f65e0","line":498,"range":{"start_line":498,"start_character":48,"end_line":498,"end_character":59},"updated":"2020-08-18 18:49:55.000000000","message":"When we have only one substitution, our convention uses %s instead of %(network)s.","commit_id":"9ac47c2fc531bde75a85d4884ab70bd8d6536d11"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"478899c9b3c05fb819b944498a66e33223568a6f","unresolved":false,"context_lines":[{"line_number":495,"context_line":"            return network"},{"line_number":496,"context_line":"        except Exception as e:"},{"line_number":497,"context_line":"            LOG.info(\u0027Failed to create network: %s\u0027, e)"},{"line_number":498,"context_line":"            msg \u003d (_(\u0027Failed to create network \"%(network)s\".\u0027) %"},{"line_number":499,"context_line":"                   {\"network\": data[\u0027net_name\u0027]})"},{"line_number":500,"context_line":"            redirect \u003d self.get_failure_url()"},{"line_number":501,"context_line":"            exceptions.handle(request, msg, redirect\u003dredirect)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_f5abf419","line":498,"range":{"start_line":498,"start_character":48,"end_line":498,"end_character":59},"in_reply_to":"9f560f44_5e0f65e0","updated":"2020-08-19 03:49:11.000000000","message":"removed.","commit_id":"9ac47c2fc531bde75a85d4884ab70bd8d6536d11"}],"openstack_dashboard/dashboards/project/security_groups/forms.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"800b337f3cb28c6b10e2892230d787b819afc463","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        except Exception:"},{"line_number":70,"context_line":"            redirect \u003d reverse(\"horizon:project:security_groups:index\")"},{"line_number":71,"context_line":"            error_msg \u003d self.error_message"},{"line_number":72,"context_line":"            exceptions.handle(request, error_msg, redirect\u003dredirect)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"class CreateGroup(GroupBase):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_fe30f9a0","line":72,"range":{"start_line":72,"start_character":39,"end_line":72,"end_character":48},"updated":"2020-08-18 18:49:55.000000000","message":"We can now use self.error_message directly here.","commit_id":"9ac47c2fc531bde75a85d4884ab70bd8d6536d11"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"478899c9b3c05fb819b944498a66e33223568a6f","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        except Exception:"},{"line_number":70,"context_line":"            redirect \u003d reverse(\"horizon:project:security_groups:index\")"},{"line_number":71,"context_line":"            error_msg \u003d self.error_message"},{"line_number":72,"context_line":"            exceptions.handle(request, error_msg, redirect\u003dredirect)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"class CreateGroup(GroupBase):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_1566682a","line":72,"range":{"start_line":72,"start_character":39,"end_line":72,"end_character":48},"in_reply_to":"9f560f44_fe30f9a0","updated":"2020-08-19 03:49:11.000000000","message":"Done.","commit_id":"9ac47c2fc531bde75a85d4884ab70bd8d6536d11"}]}