)]}'
{"horizon/tables/base.py":[{"author":{"_account_id":6966,"name":"Jeffrey J. Walls","email":"jeff.walls@hpe.com","username":"ftcjeff"},"change_message_id":"464656ca179c2f0f7a43c8904ab98ecbaed8f596","unresolved":false,"context_lines":[{"line_number":1226,"context_line":"            bound_actions.append(bound_action)"},{"line_number":1227,"context_line":"        return bound_actions"},{"line_number":1228,"context_line":""},{"line_number":1229,"context_line":"    def enable_multiselect_column(self, enable\u003dTrue):"},{"line_number":1230,"context_line":"        \"\"\"hide checkbox column if no current table action is allowed.\"\"\""},{"line_number":1231,"context_line":"        if self.multi_select:"},{"line_number":1232,"context_line":"            select_column \u003d self.columns.values()[0]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F991I%3D","line":1229,"updated":"2014-01-31 15:42:37.000000000","message":"I find it awkward to have a method called enable_* and then there\u0027s the possibility that the method actually *disables* things.  Would you be open to renaming it?","commit_id":"605a8bbf41b0674b6f396e906bb0b18daf42090c"},{"author":{"_account_id":9275,"name":"Leandro Ignacio Costantino","email":"leandro.i.costantino@intel.com","username":"lcostantino"},"change_message_id":"2fef143a5f43f677dd7e58366eb0b24bae537daa","unresolved":false,"context_lines":[{"line_number":1226,"context_line":"            bound_actions.append(bound_action)"},{"line_number":1227,"context_line":"        return bound_actions"},{"line_number":1228,"context_line":""},{"line_number":1229,"context_line":"    def enable_multiselect_column(self, enable\u003dTrue):"},{"line_number":1230,"context_line":"        \"\"\"hide checkbox column if no current table action is allowed.\"\"\""},{"line_number":1231,"context_line":"        if self.multi_select:"},{"line_number":1232,"context_line":"            select_column \u003d self.columns.values()[0]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F99sE%3D","line":1229,"in_reply_to":"AAAAUH%2F991I%3D","updated":"2014-01-31 16:05:03.000000000","message":"Sure, what\u0027s your suggestion?","commit_id":"605a8bbf41b0674b6f396e906bb0b18daf42090c"},{"author":{"_account_id":9275,"name":"Leandro Ignacio Costantino","email":"leandro.i.costantino@intel.com","username":"lcostantino"},"change_message_id":"e55896d265c96d501e7fcc2ae6352922e0d4dc81","unresolved":false,"context_lines":[{"line_number":1226,"context_line":"            bound_actions.append(bound_action)"},{"line_number":1227,"context_line":"        return bound_actions"},{"line_number":1228,"context_line":""},{"line_number":1229,"context_line":"    def enable_multiselect_column(self, enable\u003dTrue):"},{"line_number":1230,"context_line":"        \"\"\"hide checkbox column if no current table action is allowed.\"\"\""},{"line_number":1231,"context_line":"        if self.multi_select:"},{"line_number":1232,"context_line":"            select_column \u003d self.columns.values()[0]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F99kA%3D","line":1229,"in_reply_to":"AAAAUH%2F99pA%3D","updated":"2014-01-31 16:24:31.000000000","message":"Thanks for the input Jeff.\nI\u0027ll switch to that, but instead of enable\u003dTrue it will be visible\u003dTrue.","commit_id":"605a8bbf41b0674b6f396e906bb0b18daf42090c"},{"author":{"_account_id":6966,"name":"Jeffrey J. Walls","email":"jeff.walls@hpe.com","username":"ftcjeff"},"change_message_id":"2cad4f9103105af5cb49ec20ed5599167e741c98","unresolved":false,"context_lines":[{"line_number":1226,"context_line":"            bound_actions.append(bound_action)"},{"line_number":1227,"context_line":"        return bound_actions"},{"line_number":1228,"context_line":""},{"line_number":1229,"context_line":"    def enable_multiselect_column(self, enable\u003dTrue):"},{"line_number":1230,"context_line":"        \"\"\"hide checkbox column if no current table action is allowed.\"\"\""},{"line_number":1231,"context_line":"        if self.multi_select:"},{"line_number":1232,"context_line":"            select_column \u003d self.columns.values()[0]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F99pA%3D","line":1229,"in_reply_to":"AAAAUH%2F99sE%3D","updated":"2014-01-31 16:10:33.000000000","message":"I knew you\u0027d ask that :-)  My names tend to be pep-8 disasters because they\u0027re so long...  How about:  set_multiselect_column_visibility?  or something along those lines?","commit_id":"605a8bbf41b0674b6f396e906bb0b18daf42090c"},{"author":{"_account_id":9317,"name":"Ana Krivokapic","email":"akrivoka@redhat.com","username":"akrivoka"},"change_message_id":"c6bdd394420459ea663250ac843ac689b0a19c12","unresolved":false,"context_lines":[{"line_number":1228,"context_line":""},{"line_number":1229,"context_line":"    def set_multiselect_column_visibility(self, visible\u003dTrue):"},{"line_number":1230,"context_line":"        \"\"\"hide checkbox column if no current table action is allowed.\"\"\""},{"line_number":1231,"context_line":"        if self.multi_select:"},{"line_number":1232,"context_line":"            select_column \u003d self.columns.values()[0]"},{"line_number":1233,"context_line":"            #to avoid creating a new list with compre list,"},{"line_number":1234,"context_line":"            #try to find the value"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2B5BM%3D","line":1231,"updated":"2014-03-11 14:28:46.000000000","message":"You can avoid having to indent this whole block of code, by doing:\n\n if not self.multi_select:\n     return\n\n # main block of code goes here","commit_id":"d63ed74b3627e0003135c835d2fa09d54363a28a"},{"author":{"_account_id":9317,"name":"Ana Krivokapic","email":"akrivoka@redhat.com","username":"akrivoka"},"change_message_id":"c6bdd394420459ea663250ac843ac689b0a19c12","unresolved":false,"context_lines":[{"line_number":1231,"context_line":"        if self.multi_select:"},{"line_number":1232,"context_line":"            select_column \u003d self.columns.values()[0]"},{"line_number":1233,"context_line":"            #to avoid creating a new list with compre list,"},{"line_number":1234,"context_line":"            #try to find the value"},{"line_number":1235,"context_line":"            hidden_found \u003d \u0027hidden\u0027 in select_column.classes"},{"line_number":1236,"context_line":"            if hidden_found and visible:"},{"line_number":1237,"context_line":"                select_column.classes.remove(\u0027hidden\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2B5Ag%3D","line":1234,"updated":"2014-03-11 14:28:46.000000000","message":"Please try to use the whole sentences in comments; avoid partial sentences, abbreviations, etc. It really helps having a clear and understandable comment, especially if you happen to have to read it in the future. :)","commit_id":"d63ed74b3627e0003135c835d2fa09d54363a28a"},{"author":{"_account_id":9317,"name":"Ana Krivokapic","email":"akrivoka@redhat.com","username":"akrivoka"},"change_message_id":"c6bdd394420459ea663250ac843ac689b0a19c12","unresolved":false,"context_lines":[{"line_number":1235,"context_line":"            hidden_found \u003d \u0027hidden\u0027 in select_column.classes"},{"line_number":1236,"context_line":"            if hidden_found and visible:"},{"line_number":1237,"context_line":"                select_column.classes.remove(\u0027hidden\u0027)"},{"line_number":1238,"context_line":"            if not hidden_found and not visible:"},{"line_number":1239,"context_line":"                select_column.classes.append(\u0027hidden\u0027)"},{"line_number":1240,"context_line":""},{"line_number":1241,"context_line":"    def render_table_actions(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2B4%2F0%3D","line":1238,"updated":"2014-03-11 14:28:46.000000000","message":"Use `elif` here.","commit_id":"d63ed74b3627e0003135c835d2fa09d54363a28a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ed04194b0fd1c0325c1565470553a0d5960c2409","unresolved":false,"context_lines":[{"line_number":1573,"context_line":"            LOG.exception(\"Error while rendering table rows.\")"},{"line_number":1574,"context_line":"            exc_info \u003d sys.exc_info()"},{"line_number":1575,"context_line":"            raise template.TemplateSyntaxError, exc_info[1], exc_info[2]"},{"line_number":1576,"context_line":""},{"line_number":1577,"context_line":"        return rows"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F%2BUKU%3D","line":1576,"updated":"2014-03-27 17:19:47.000000000","message":"Looks unnecessary. Please remove it if we need another patch set.","commit_id":"0bf864eff4188b0e9e62a7e2e66599582a31d567"}],"horizon/test/tests/tables.py":[{"author":{"_account_id":9412,"name":"Andres Buraschi","email":"andres.buraschi@intel.com","username":"aburaschi"},"change_message_id":"b7046cd755fa54c76a7c049a1d1d9845598fcd33","unresolved":false,"context_lines":[{"line_number":1012,"context_line":"        res \u003d http.HttpResponse(table.render())"},{"line_number":1013,"context_line":"        self.assertNotContains(res, \"\u003cform\")"},{"line_number":1014,"context_line":""},{"line_number":1015,"context_line":"    def test_table_actions_not_allowed_hide_nultiselect(self):"},{"line_number":1016,"context_line":"        table \u003d DisabledActionsTable(self.request, TEST_DATA)"},{"line_number":1017,"context_line":"        self.assertFalse(table.has_actions)"},{"line_number":1018,"context_line":"        self.assertFalse(table.needs_form_wrapper)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F9998%3D","line":1015,"updated":"2014-01-31 15:25:18.000000000","message":"Tiny typo: nultiselect, it says.","commit_id":"605a8bbf41b0674b6f396e906bb0b18daf42090c"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"ef1d0be88f9dbd5edebe53f18800acd55f1c9c4f","unresolved":false,"context_lines":[{"line_number":1012,"context_line":"        res \u003d http.HttpResponse(table.render())"},{"line_number":1013,"context_line":"        self.assertNotContains(res, \"\u003cform\")"},{"line_number":1014,"context_line":""},{"line_number":1015,"context_line":"    def test_table_actions_not_allowed_hide_nultiselect(self):"},{"line_number":1016,"context_line":"        table \u003d DisabledActionsTable(self.request, TEST_DATA)"},{"line_number":1017,"context_line":"        self.assertFalse(table.has_actions)"},{"line_number":1018,"context_line":"        self.assertFalse(table.needs_form_wrapper)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F99yw%3D","line":1015,"in_reply_to":"AAAAUH%2F9998%3D","updated":"2014-01-31 15:50:15.000000000","message":"Good catch! That needs to be fixed.","commit_id":"605a8bbf41b0674b6f396e906bb0b18daf42090c"},{"author":{"_account_id":9275,"name":"Leandro Ignacio Costantino","email":"leandro.i.costantino@intel.com","username":"lcostantino"},"change_message_id":"2fef143a5f43f677dd7e58366eb0b24bae537daa","unresolved":false,"context_lines":[{"line_number":1012,"context_line":"        res \u003d http.HttpResponse(table.render())"},{"line_number":1013,"context_line":"        self.assertNotContains(res, \"\u003cform\")"},{"line_number":1014,"context_line":""},{"line_number":1015,"context_line":"    def test_table_actions_not_allowed_hide_nultiselect(self):"},{"line_number":1016,"context_line":"        table \u003d DisabledActionsTable(self.request, TEST_DATA)"},{"line_number":1017,"context_line":"        self.assertFalse(table.has_actions)"},{"line_number":1018,"context_line":"        self.assertFalse(table.needs_form_wrapper)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F99r8%3D","line":1015,"in_reply_to":"AAAAUH%2F99yw%3D","updated":"2014-01-31 16:05:03.000000000","message":"Done","commit_id":"605a8bbf41b0674b6f396e906bb0b18daf42090c"}]}