)]}'
{"openstack_dashboard/api/glance.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"7117aefa61616cb19326ffc6b2aec5389d491bb0","unresolved":false,"context_lines":[{"line_number":358,"context_line":"            if value in glance_formats:"},{"line_number":359,"context_line":"                supported_formats.append((value, name))"},{"line_number":360,"context_line":"            else:"},{"line_number":361,"context_line":"                LOG.warning(\u0027OPENSTACK_IMAGE_BACKEND has an unsupported by \u0027"},{"line_number":362,"context_line":"                            \u0027glance format \"%s\"\u0027, value)"},{"line_number":363,"context_line":"    except Exception:"},{"line_number":364,"context_line":"        supported_formats \u003d image_format_choices"},{"line_number":365,"context_line":"        msg \u003d _(\u0027Unable to retrieve image formats list.\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_2278c52a","line":362,"range":{"start_line":361,"start_character":57,"end_line":362,"end_character":42},"updated":"2019-12-17 04:38:24.000000000","message":"\"an unsupported by ...\" looks odd.\nHow about \"a format unsupported by glance\"?","commit_id":"e71cc52baa745efd66ea6e3b03b105a8020c3971"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"7117aefa61616cb19326ffc6b2aec5389d491bb0","unresolved":false,"context_lines":[{"line_number":362,"context_line":"                            \u0027glance format \"%s\"\u0027, value)"},{"line_number":363,"context_line":"    except Exception:"},{"line_number":364,"context_line":"        supported_formats \u003d image_format_choices"},{"line_number":365,"context_line":"        msg \u003d _(\u0027Unable to retrieve image formats list.\u0027)"},{"line_number":366,"context_line":"        messages.error(request, msg)"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"    return supported_formats"}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_4275c132","line":365,"range":{"start_line":365,"start_character":36,"end_line":365,"end_character":54},"updated":"2019-12-17 04:38:24.000000000","message":"-\u003e image format list","commit_id":"e71cc52baa745efd66ea6e3b03b105a8020c3971"}],"openstack_dashboard/api/rest/config.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"d0fed2e8f35ba9d43efb8512746b546dab91e62d","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        openstack_image_formats \u003d {\u0027OPENSTACK_IMAGE_FORMATS\u0027: ["},{"line_number":67,"context_line":"            value for (value, name)"},{"line_number":68,"context_line":"            in settings.OPENSTACK_IMAGE_BACKEND[\u0027image_formats\u0027]"},{"line_number":69,"context_line":"            if value in glance_formats"},{"line_number":70,"context_line":"        ]}"},{"line_number":71,"context_line":"        return openstack_image_formats"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_16bed663","line":69,"range":{"start_line":69,"start_character":12,"end_line":69,"end_character":38},"updated":"2019-12-04 16:56:57.000000000","message":"Could you please add some logging here if OPENSTACK_IMAGE_BACKEND[\u0027image_formats\u0027] has something not supported by glance? It would be helpful in troubleshooting","commit_id":"2be27037f00ee9a5ca0e72e2c476c889a1e7d466"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"92112b647c2a474a0b059228d84973e6b8aa9ab4","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        openstack_image_formats \u003d {\u0027OPENSTACK_IMAGE_FORMATS\u0027: ["},{"line_number":67,"context_line":"            value for (value, name)"},{"line_number":68,"context_line":"            in settings.OPENSTACK_IMAGE_BACKEND[\u0027image_formats\u0027]"},{"line_number":69,"context_line":"            if value in glance_formats"},{"line_number":70,"context_line":"        ]}"},{"line_number":71,"context_line":"        return openstack_image_formats"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_d02806ef","line":69,"range":{"start_line":69,"start_character":12,"end_line":69,"end_character":38},"in_reply_to":"3fa7e38b_16bed663","updated":"2019-12-09 17:13:13.000000000","message":"Done","commit_id":"2be27037f00ee9a5ca0e72e2c476c889a1e7d466"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"7117aefa61616cb19326ffc6b2aec5389d491bb0","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        # The purpose of OPENSTACK_IMAGE_FORMATS is to provide a simple object"},{"line_number":66,"context_line":"        # that does not contain the lazy-loaded translations, so the list can"},{"line_number":67,"context_line":"        # be sent as JSON to the client-side (Angular)."},{"line_number":68,"context_line":"        openstack_image_formats \u003d {\u0027OPENSTACK_IMAGE_FORMATS\u0027: ["},{"line_number":69,"context_line":"            value"},{"line_number":70,"context_line":"            for (value, name) in api.glance.get_image_formats(request)"},{"line_number":71,"context_line":"        ]}"}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_c289b125","line":68,"range":{"start_line":68,"start_character":8,"end_line":68,"end_character":33},"updated":"2019-12-17 04:38:24.000000000","message":"Let\u0027s just return the value.\n\n  return {\u0027OPENSTACK_IMAGE_FORMATS\u0027: [ ....","commit_id":"e71cc52baa745efd66ea6e3b03b105a8020c3971"}],"openstack_dashboard/dashboards/project/images/images/forms.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"d0fed2e8f35ba9d43efb8512746b546dab91e62d","unresolved":false,"context_lines":[{"line_number":175,"context_line":"            self._hide_is_public()"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        try:"},{"line_number":178,"context_line":"            glance_schemas \u003d api.glance.get_image_schemas(request)"},{"line_number":179,"context_line":"            glance_formats \u003d \\"},{"line_number":180,"context_line":"                glance_schemas[\u0027properties\u0027][\u0027disk_format\u0027][\u0027enum\u0027]"},{"line_number":181,"context_line":"            supported_formats \u003d ["},{"line_number":182,"context_line":"                (value, name)"},{"line_number":183,"context_line":"                for value, name in IMAGE_FORMAT_CHOICES"},{"line_number":184,"context_line":"                if value in glance_formats"},{"line_number":185,"context_line":"            ]"},{"line_number":186,"context_line":"            self.fields[\u0027disk_format\u0027].choices \u003d supported_formats"},{"line_number":187,"context_line":"        except Exception:"},{"line_number":188,"context_line":"            self.fields[\u0027disk_format\u0027].choices \u003d IMAGE_FORMAT_CHOICES"},{"line_number":189,"context_line":"            msg \u003d _(\u0027Unable to retrieve disk format list.\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_1663361b","line":186,"range":{"start_line":178,"start_character":11,"end_line":186,"end_character":66},"updated":"2019-12-04 16:56:57.000000000","message":"It looks pretty the same as [1]. Let\u0027s move this to openstack_dashboard/api/glance to not duplicate the code\n\n[1] https://review.opendev.org/#/c/695877/6/openstack_dashboard/api/rest/config.py","commit_id":"2be27037f00ee9a5ca0e72e2c476c889a1e7d466"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"92112b647c2a474a0b059228d84973e6b8aa9ab4","unresolved":false,"context_lines":[{"line_number":175,"context_line":"            self._hide_is_public()"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        try:"},{"line_number":178,"context_line":"            glance_schemas \u003d api.glance.get_image_schemas(request)"},{"line_number":179,"context_line":"            glance_formats \u003d \\"},{"line_number":180,"context_line":"                glance_schemas[\u0027properties\u0027][\u0027disk_format\u0027][\u0027enum\u0027]"},{"line_number":181,"context_line":"            supported_formats \u003d ["},{"line_number":182,"context_line":"                (value, name)"},{"line_number":183,"context_line":"                for value, name in IMAGE_FORMAT_CHOICES"},{"line_number":184,"context_line":"                if value in glance_formats"},{"line_number":185,"context_line":"            ]"},{"line_number":186,"context_line":"            self.fields[\u0027disk_format\u0027].choices \u003d supported_formats"},{"line_number":187,"context_line":"        except Exception:"},{"line_number":188,"context_line":"            self.fields[\u0027disk_format\u0027].choices \u003d IMAGE_FORMAT_CHOICES"},{"line_number":189,"context_line":"            msg \u003d _(\u0027Unable to retrieve disk format list.\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_f02d02fd","line":186,"range":{"start_line":178,"start_character":11,"end_line":186,"end_character":66},"in_reply_to":"3fa7e38b_1663361b","updated":"2019-12-09 17:13:13.000000000","message":"Done","commit_id":"2be27037f00ee9a5ca0e72e2c476c889a1e7d466"}],"openstack_dashboard/dashboards/project/volumes/forms.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"d0fed2e8f35ba9d43efb8512746b546dab91e62d","unresolved":false,"context_lines":[{"line_number":718,"context_line":"        # and \u0027qcow\u0027 which are not supported by glance."},{"line_number":719,"context_line":"        # I can only use \u0027raw\u0027, \u0027vmdk\u0027, \u0027vdi\u0027 or \u0027qcow2\u0027 so qemu-img will not"},{"line_number":720,"context_line":"        # have issues when processes image request from cinder."},{"line_number":721,"context_line":"        glance_schemas \u003d glance.get_image_schemas(request)"},{"line_number":722,"context_line":"        glance_formats \u003d glance_schemas[\u0027properties\u0027][\u0027disk_format\u0027][\u0027enum\u0027]"},{"line_number":723,"context_line":"        disk_format_choices \u003d [(value, name) for value, name"},{"line_number":724,"context_line":"                               in IMAGE_FORMAT_CHOICES"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_d66cbe08","line":721,"updated":"2019-12-04 16:56:57.000000000","message":"The same as for images form","commit_id":"2be27037f00ee9a5ca0e72e2c476c889a1e7d466"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"92112b647c2a474a0b059228d84973e6b8aa9ab4","unresolved":false,"context_lines":[{"line_number":718,"context_line":"        # and \u0027qcow\u0027 which are not supported by glance."},{"line_number":719,"context_line":"        # I can only use \u0027raw\u0027, \u0027vmdk\u0027, \u0027vdi\u0027 or \u0027qcow2\u0027 so qemu-img will not"},{"line_number":720,"context_line":"        # have issues when processes image request from cinder."},{"line_number":721,"context_line":"        glance_schemas \u003d glance.get_image_schemas(request)"},{"line_number":722,"context_line":"        glance_formats \u003d glance_schemas[\u0027properties\u0027][\u0027disk_format\u0027][\u0027enum\u0027]"},{"line_number":723,"context_line":"        disk_format_choices \u003d [(value, name) for value, name"},{"line_number":724,"context_line":"                               in IMAGE_FORMAT_CHOICES"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_503c162f","line":721,"in_reply_to":"3fa7e38b_d66cbe08","updated":"2019-12-09 17:13:13.000000000","message":"Done","commit_id":"2be27037f00ee9a5ca0e72e2c476c889a1e7d466"}],"openstack_dashboard/settings.py":[{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"dd6c64015bcf4fd0e89949693537e87af6bb55b5","unresolved":false,"context_lines":[{"line_number":281,"context_line":"# The purpose of OPENSTACK_IMAGE_FORMATS is to provide a simple object"},{"line_number":282,"context_line":"# that does not contain the lazy-loaded translations, so the list can"},{"line_number":283,"context_line":"# be sent as JSON to the client-side (Angular)."},{"line_number":284,"context_line":"# TODO(amotoki): Do we really need this here? Can\u0027t we calculate this"},{"line_number":285,"context_line":"# in openstack_dashboard.api.rest.config?"},{"line_number":286,"context_line":"OPENSTACK_IMAGE_FORMATS \u003d [fmt for (fmt, name)"},{"line_number":287,"context_line":"                           in OPENSTACK_IMAGE_BACKEND[\u0027image_formats\u0027]]"},{"line_number":288,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_111b9280","side":"PARENT","line":285,"range":{"start_line":284,"start_character":0,"end_line":285,"end_character":41},"updated":"2019-11-28 06:07:20.000000000","message":"added amotoki to review to address his todo :-)","commit_id":"f592481cc05abe0f061969a6cbeccf0989cf8b67"}],"releasenotes/notes/glance_disk_formats-a13cb994a2d5c1fe.yaml":[{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"8d40012cc25ed925e3419159c39004cd9b4c8785","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support to retrieve supported disk formats from glance,"},{"line_number":5,"context_line":"    so you can adjuct disk_formats only inside glance-api.conf."},{"line_number":6,"context_line":"    You still can use IMAGE_BACKEND_SETTINGS to adjust format naming."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_ecebb4d9","line":5,"range":{"start_line":5,"start_character":15,"end_line":5,"end_character":21},"updated":"2019-11-25 11:03:29.000000000","message":"typo: this needs to be adjust.","commit_id":"3e6682fef602c8f96acc996e3971f1b22f3356ff"}]}