)]}'
{"openstack_dashboard/dashboards/project/security_groups/tests.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ee3554595ac01dfa5fece34326cf83b5bf24cf3c","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from django.conf import settings"},{"line_number":23,"context_line":"from django.urls import reverse"},{"line_number":24,"context_line":"from django.utils import html"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from horizon import exceptions"},{"line_number":27,"context_line":"from horizon import forms"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_78d2095e","line":24,"updated":"2019-11-26 13:12:45.000000000","message":"Python 3.7 document suggests to use html.escape instead of cgi.escape [1]. Is it better to use django.utils.html.escape rather than html.escape?\n\n[1] https://docs.python.org/3.7/library/cgi.html#cgi.escape","commit_id":"33fe0fef334ace8b19f1aad78602bb1903806892"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"fbdb4b953744f49223be01d63df3ffb20e110179","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from django.conf import settings"},{"line_number":23,"context_line":"from django.urls import reverse"},{"line_number":24,"context_line":"from django.utils import html"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from horizon import exceptions"},{"line_number":27,"context_line":"from horizon import forms"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_89a28f3e","line":24,"in_reply_to":"3fa7e38b_3d1e780d","updated":"2019-12-06 07:35:42.000000000","message":"I checked both escape functions and confirmed both do the same. The python3 version has quote argument but the default value of quote is True, so both are equivalent.\n\nConsidering the above and the consistency in the code, your idea sounds reasonable.\n\nNote that I don\u0027t know what +1 from Vishal is for.....","commit_id":"33fe0fef334ace8b19f1aad78602bb1903806892"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"54dd360fdd294e7a0e82e5dd3d9069de5cfba273","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from django.conf import settings"},{"line_number":23,"context_line":"from django.urls import reverse"},{"line_number":24,"context_line":"from django.utils import html"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from horizon import exceptions"},{"line_number":27,"context_line":"from horizon import forms"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_3d1e780d","line":24,"in_reply_to":"3fa7e38b_78d2095e","updated":"2019-12-02 18:58:36.000000000","message":"+1.","commit_id":"33fe0fef334ace8b19f1aad78602bb1903806892"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"8fdbffde33b7756c8da8eea64c35ea23c3bf9efe","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from django.conf import settings"},{"line_number":23,"context_line":"from django.urls import reverse"},{"line_number":24,"context_line":"from django.utils import html"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from horizon import exceptions"},{"line_number":27,"context_line":"from horizon import forms"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_9a2b32e9","line":24,"in_reply_to":"3fa7e38b_78d2095e","updated":"2019-11-26 21:33:06.000000000","message":"Yes, it suggests to use html.escape and of course it is working. But I\u0027ve searched usage of escape function in other python files in horizon and I  found that all developers were using django.utils.escape before me, so I decided to use django.utils.escape also as they. If you are more familiar with html.escape .. I can replace all occurences of that in a code. So , what do you think ?","commit_id":"33fe0fef334ace8b19f1aad78602bb1903806892"}]}