)]}'
{"horizon/static/framework/conf/resource-type-registry.service.js":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"23668f3a299998b99d6be3b1c949c9a7d4ce82d1","unresolved":false,"context_lines":[{"line_number":600,"context_line":"       ```"},{"line_number":601,"context_line":"       */"},{"line_number":602,"context_line":"      function setNames(singular, plural, translated) {"},{"line_number":603,"context_line":"        names \u003d translated;"},{"line_number":604,"context_line":"        names \u003d [singular, plural];"},{"line_number":605,"context_line":"        return self;"},{"line_number":606,"context_line":"      }"}],"source_content_type":"text/javascript","patch_set":4,"id":"3fa7e38b_9c6f99f9","line":603,"range":{"start_line":603,"start_character":7,"end_line":603,"end_character":27},"updated":"2019-11-28 08:30:48.000000000","message":"This looks tricky. \"names\" will be overridden in the next line. Is it required?","commit_id":"4b8ec7965b588e263739cf4b8e62d923897702df"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"619a79da0c3fb9a1802a344803c7663a63a6afe1","unresolved":false,"context_lines":[{"line_number":600,"context_line":"       ```"},{"line_number":601,"context_line":"       */"},{"line_number":602,"context_line":"      function setNames(singular, plural, translated) {"},{"line_number":603,"context_line":"        names \u003d translated;"},{"line_number":604,"context_line":"        names \u003d [singular, plural];"},{"line_number":605,"context_line":"        return self;"},{"line_number":606,"context_line":"      }"}],"source_content_type":"text/javascript","patch_set":4,"id":"3fa7e38b_029102f8","line":603,"range":{"start_line":603,"start_character":7,"end_line":603,"end_character":27},"in_reply_to":"3fa7e38b_9c6f99f9","updated":"2019-11-28 10:19:45.000000000","message":"Otherwise I get a \"unused variable\" error from the linter, and the comments that were supposed to suppress that error don\u0027t work.","commit_id":"4b8ec7965b588e263739cf4b8e62d923897702df"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"c6d0e61235b36a92a304f59bad503caca4f620a8","unresolved":false,"context_lines":[{"line_number":599,"context_line":""},{"line_number":600,"context_line":"       ```"},{"line_number":601,"context_line":"       */"},{"line_number":602,"context_line":"      /* eslint-disable no-unused-vars */"},{"line_number":603,"context_line":"      function setNames(singular, plural, translated) {"},{"line_number":604,"context_line":"        names \u003d [singular, plural];"},{"line_number":605,"context_line":"        return self;"}],"source_content_type":"text/javascript","patch_set":5,"id":"3fa7e38b_14b4d535","line":602,"range":{"start_line":602,"start_character":6,"end_line":602,"end_character":41},"updated":"2019-11-28 19:08:56.000000000","message":"I\u0027m not a fan of this but it looks necessary here","commit_id":"b8cefb5c4901ff53a203fecede85be222f88343e"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"fcf200b0674c05b13e92c611cd0cabe5c3130e84","unresolved":false,"context_lines":[{"line_number":599,"context_line":""},{"line_number":600,"context_line":"       ```"},{"line_number":601,"context_line":"       */"},{"line_number":602,"context_line":"      /* eslint-disable no-unused-vars */"},{"line_number":603,"context_line":"      function setNames(singular, plural, translated) {"},{"line_number":604,"context_line":"        names \u003d [singular, plural];"},{"line_number":605,"context_line":"        return self;"}],"source_content_type":"text/javascript","patch_set":5,"id":"3fa7e38b_e3a7fe08","line":602,"range":{"start_line":602,"start_character":6,"end_line":602,"end_character":41},"in_reply_to":"3fa7e38b_14b4d535","updated":"2019-11-29 08:29:37.000000000","message":"Generally ngettext shouldn\u0027t be called on a variable, but fixing it here would require rewriting the whole thing.","commit_id":"b8cefb5c4901ff53a203fecede85be222f88343e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"5adc9d236941955d75064f908cac9de74858e94b","unresolved":false,"context_lines":[{"line_number":600,"context_line":"       ```"},{"line_number":601,"context_line":"       */"},{"line_number":602,"context_line":"      /* eslint-disable no-unused-vars */"},{"line_number":603,"context_line":"      function setNames(singular, plural, translated) {"},{"line_number":604,"context_line":"        names \u003d [singular, plural];"},{"line_number":605,"context_line":"        return self;"},{"line_number":606,"context_line":"      }"}],"source_content_type":"text/javascript","patch_set":7,"id":"3fa7e38b_21b4f5d3","line":603,"range":{"start_line":603,"start_character":42,"end_line":603,"end_character":52},"updated":"2019-12-23 06:17:25.000000000","message":"NOTE: In JavaScript, When an argument is not specified by a caller, it will defaults to \"undefined\". This change does not break horizon plugins. I think the only side effect is to lose existing translations for languages which do not hit this issue.","commit_id":"ef4055e2888bb0fe67d64e9c422a31f925469200"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"f32b14177442ab721ed8d46c52a084766875f11f","unresolved":false,"context_lines":[{"line_number":600,"context_line":"       ```"},{"line_number":601,"context_line":"       */"},{"line_number":602,"context_line":"      /* eslint-disable no-unused-vars */"},{"line_number":603,"context_line":"      function setNames(singular, plural, translated) {"},{"line_number":604,"context_line":"        names \u003d [singular, plural];"},{"line_number":605,"context_line":"        return self;"},{"line_number":606,"context_line":"      }"}],"source_content_type":"text/javascript","patch_set":7,"id":"3fa7e38b_9814fe43","line":603,"range":{"start_line":603,"start_character":42,"end_line":603,"end_character":52},"in_reply_to":"3fa7e38b_21b4f5d3","updated":"2020-01-06 08:52:15.000000000","message":"It looks like this issue has been somewhat mitigated in newer Django version by better handling missing translations. This makes the main error case go away — they fall back to the English translation, which happens to be the same. However, it will still use the wrong plural form in languages that, unlike English, have more than one plural, and it may leave the titles untranslated in other languages.","commit_id":"ef4055e2888bb0fe67d64e9c422a31f925469200"}]}