)]}'
{"openstack_dashboard/api/keystone.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"f2c181bc9f1316f05a35e92628a573cab96e039d","unresolved":false,"context_lines":[{"line_number":149,"context_line":"    token_id \u003d user.token.id"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    if is_multi_domain_enabled():"},{"line_number":152,"context_line":"        is_domain_context_changed \u003d bool("},{"line_number":153,"context_line":"            request.session.get(\"domain_context\", None))"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        # If user is Cloud Admin, Domain Admin or Mixed Domain Admin and there"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_98183784","line":152,"range":{"start_line":152,"start_character":8,"end_line":152,"end_character":33},"updated":"2019-12-13 04:09:04.000000000","message":"I think that a better naming is \"is_domain_context_specified\". We use \"Set\" and \"Clear\" in the domain table so I think \"specified\" or \"set\" is better than \"changed\". \n\nIn addition, \"changed\" associates me that a situation that a domain context is changed from the one in the previous request in this request. This is not the case.","commit_id":"8f167c081c9c5a895429852ed5d2980a9d4898b4"},{"author":{"_account_id":10366,"name":"Hemanth N","email":"hemanth.nakkina@canonical.com","username":"Hemanth"},"change_message_id":"afa5de358053d801e8dd73eaf5c1ad63ced9f269","unresolved":false,"context_lines":[{"line_number":149,"context_line":"    token_id \u003d user.token.id"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    if is_multi_domain_enabled():"},{"line_number":152,"context_line":"        is_domain_context_changed \u003d bool("},{"line_number":153,"context_line":"            request.session.get(\"domain_context\", None))"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        # If user is Cloud Admin, Domain Admin or Mixed Domain Admin and there"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_dbb2294a","line":152,"range":{"start_line":152,"start_character":8,"end_line":152,"end_character":33},"in_reply_to":"3fa7e38b_98183784","updated":"2019-12-13 04:39:53.000000000","message":"Done","commit_id":"8f167c081c9c5a895429852ed5d2980a9d4898b4"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"f2c181bc9f1316f05a35e92628a573cab96e039d","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    if is_multi_domain_enabled():"},{"line_number":152,"context_line":"        is_domain_context_changed \u003d bool("},{"line_number":153,"context_line":"            request.session.get(\"domain_context\", None))"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        # If user is Cloud Admin, Domain Admin or Mixed Domain Admin and there"},{"line_number":156,"context_line":"        # is no change in domain context, use domain scoped token"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_d828ef98","line":153,"range":{"start_line":153,"start_character":50,"end_line":153,"end_character":54},"updated":"2019-12-13 04:09:04.000000000","message":"nit: The default value is None, so .get(\u0027domain_context\u0027) is enough. If so, this fits into a single line.","commit_id":"8f167c081c9c5a895429852ed5d2980a9d4898b4"},{"author":{"_account_id":10366,"name":"Hemanth N","email":"hemanth.nakkina@canonical.com","username":"Hemanth"},"change_message_id":"afa5de358053d801e8dd73eaf5c1ad63ced9f269","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    if is_multi_domain_enabled():"},{"line_number":152,"context_line":"        is_domain_context_changed \u003d bool("},{"line_number":153,"context_line":"            request.session.get(\"domain_context\", None))"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        # If user is Cloud Admin, Domain Admin or Mixed Domain Admin and there"},{"line_number":156,"context_line":"        # is no change in domain context, use domain scoped token"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_fbada5e6","line":153,"range":{"start_line":153,"start_character":50,"end_line":153,"end_character":54},"in_reply_to":"3fa7e38b_d828ef98","updated":"2019-12-13 04:39:53.000000000","message":"Done","commit_id":"8f167c081c9c5a895429852ed5d2980a9d4898b4"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"f2c181bc9f1316f05a35e92628a573cab96e039d","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        is_domain_context_changed \u003d bool("},{"line_number":153,"context_line":"            request.session.get(\"domain_context\", None))"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        # If user is Cloud Admin, Domain Admin or Mixed Domain Admin and there"},{"line_number":156,"context_line":"        # is no change in domain context, use domain scoped token"},{"line_number":157,"context_line":"        if is_domain_admin(request) and not is_domain_context_changed:"},{"line_number":158,"context_line":"            domain_token \u003d request.session.get(\u0027domain_token\u0027)"},{"line_number":159,"context_line":"            if domain_token:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_d801cf08","line":156,"range":{"start_line":155,"start_character":73,"end_line":156,"end_character":41},"updated":"2019-12-13 04:09:04.000000000","message":"Per my comment at L.152, could you consider \"no domain context is specified\"?","commit_id":"8f167c081c9c5a895429852ed5d2980a9d4898b4"},{"author":{"_account_id":10366,"name":"Hemanth N","email":"hemanth.nakkina@canonical.com","username":"Hemanth"},"change_message_id":"afa5de358053d801e8dd73eaf5c1ad63ced9f269","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        is_domain_context_changed \u003d bool("},{"line_number":153,"context_line":"            request.session.get(\"domain_context\", None))"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        # If user is Cloud Admin, Domain Admin or Mixed Domain Admin and there"},{"line_number":156,"context_line":"        # is no change in domain context, use domain scoped token"},{"line_number":157,"context_line":"        if is_domain_admin(request) and not is_domain_context_changed:"},{"line_number":158,"context_line":"            domain_token \u003d request.session.get(\u0027domain_token\u0027)"},{"line_number":159,"context_line":"            if domain_token:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_9b827151","line":156,"range":{"start_line":155,"start_character":73,"end_line":156,"end_character":41},"in_reply_to":"3fa7e38b_d801cf08","updated":"2019-12-13 04:39:53.000000000","message":"Done","commit_id":"8f167c081c9c5a895429852ed5d2980a9d4898b4"}]}