)]}'
{"openstack_dashboard/dashboards/project/volumes/forms.py":[{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"01940d0dde7f24b890d3244e3ee7e5a28f480fcd","unresolved":false,"context_lines":[{"line_number":217,"context_line":"            for vol in volumes:"},{"line_number":218,"context_line":"                if vol.display_name \u003d\u003d data[\u0027name\u0027]:"},{"line_number":219,"context_line":"                    message \u003d _(\u0027The name \"%s\" is already used \u0027 +"},{"line_number":220,"context_line":"                        \u0027by another volume.\u0027) % data[\u0027name\u0027]"},{"line_number":221,"context_line":"                    self.api_error(message)"},{"line_number":222,"context_line":"                    return False"},{"line_number":223,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2BF%2B0%3D","line":220,"updated":"2014-01-30 07:11:10.000000000","message":"\u0027+\u0027 is not needed here (see L#198-199 for example).","commit_id":"719f9ffa6cb2a7d8eea5147a18e77fc83000e703"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"01940d0dde7f24b890d3244e3ee7e5a28f480fcd","unresolved":false,"context_lines":[{"line_number":435,"context_line":"        if volumes is not None:"},{"line_number":436,"context_line":"            for vol in volumes:"},{"line_number":437,"context_line":"                if vol.display_name \u003d\u003d data[\u0027name\u0027] and vol.id !\u003d volume_id:"},{"line_number":438,"context_line":"                    message \u003d _(\u0027The name \"%s\" is already used \u0027 +"},{"line_number":439,"context_line":"                        \u0027by another volume.\u0027) % data[\u0027name\u0027]"},{"line_number":440,"context_line":"                    self.api_error(message)"},{"line_number":441,"context_line":"                    return False"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2BF%2Bs%3D","line":438,"updated":"2014-01-30 07:11:10.000000000","message":"ditto","commit_id":"719f9ffa6cb2a7d8eea5147a18e77fc83000e703"},{"author":{"_account_id":10007,"name":"Tapan Sharma","email":"tapan.sharma@workday.com","username":"taps"},"change_message_id":"7bc2148d7cb1a15766a5a3d6d7671f06e3cf2c43","unresolved":false,"context_lines":[{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        return zone_list"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def handle(self, request, data):"},{"line_number":208,"context_line":"        volumes \u003d []"},{"line_number":209,"context_line":"        try:"},{"line_number":210,"context_line":"            volumes \u003d cinder.volume_list(request, None)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2BAvA%3D","line":207,"updated":"2014-01-31 00:20:15.000000000","message":"This validation code should be part of clean() method for this forms.SelfHandlingForm. We should override the clean method and then put this code in there.\n\nWhat do you think?","commit_id":"56aefe882f203283338dfaff1fd821c620211bca"},{"author":{"_account_id":6966,"name":"Jeffrey J. Walls","email":"jeff.walls@hpe.com","username":"ftcjeff"},"change_message_id":"861f285cc262a0eefe403da4eaaeec26d0dc2d21","unresolved":false,"context_lines":[{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        return zone_list"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def handle(self, request, data):"},{"line_number":208,"context_line":"        volumes \u003d []"},{"line_number":209,"context_line":"        try:"},{"line_number":210,"context_line":"            volumes \u003d cinder.volume_list(request, None)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F99Us%3D","line":207,"in_reply_to":"AAAAUH%2F%2BAvA%3D","updated":"2014-01-31 17:14:02.000000000","message":"+1 doing it in clean will give them a chance to type in a new name without having to set all of the other fields again.  Doing it in handle will cause them to have to go back into the create dialog and re-enter all their data.","commit_id":"56aefe882f203283338dfaff1fd821c620211bca"}]}