)]}'
{"openstack_dashboard/api/cinder.py":[{"author":{"_account_id":2455,"name":"Tihomir Trifonov","email":"t.trifonov@gmail.com","username":"ttrifonov"},"change_message_id":"201ad913aaf4769e2cea0ffdfab03e8e0c7518e6","unresolved":false,"context_lines":[{"line_number":44,"context_line":"DEFAULT_QUOTA_NAME \u003d \u0027default\u0027"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"class CinderAPIResourceWrapper(base.APIResourceWrapper):"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    @property"},{"line_number":50,"context_line":"    def name(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F9XqA%3D","line":47,"updated":"2014-02-07 11:58:42.000000000","message":"May this be called something like BaseCinderAPI..., as it is a base class, not to be confused with wrapper implementation(it lacks the _attrs).","commit_id":"f233a891c91b859be11aa83bb395a9f8966e7349"},{"author":{"_account_id":4978,"name":"Julie Pichon","email":"jpichon@redhat.com","username":"jpichon"},"change_message_id":"c8c6139053d424e60ab3d52588f7a5bb827943b7","unresolved":false,"context_lines":[{"line_number":44,"context_line":"DEFAULT_QUOTA_NAME \u003d \u0027default\u0027"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"class CinderAPIResourceWrapper(base.APIResourceWrapper):"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    @property"},{"line_number":50,"context_line":"    def name(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F9W%2BQ%3D","line":47,"in_reply_to":"AAAAUH%2F9XqA%3D","updated":"2014-02-07 13:45:00.000000000","message":"That makes sense. I was aiming to be consistent with the naming scheme in neutron.py ( https://github.com/openstack/horizon/blob/master/openstack_dashboard/api/neutron.py#L43 ) but I don\u0027t feel strongly about it and will change it.","commit_id":"f233a891c91b859be11aa83bb395a9f8966e7349"},{"author":{"_account_id":2455,"name":"Tihomir Trifonov","email":"t.trifonov@gmail.com","username":"ttrifonov"},"change_message_id":"201ad913aaf4769e2cea0ffdfab03e8e0c7518e6","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    @name.setter"},{"line_number":55,"context_line":"    def name(self, value):"},{"line_number":56,"context_line":"        self._apiresource.name \u003d value"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @property"},{"line_number":59,"context_line":"    def description(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F9Xm0%3D","line":56,"updated":"2014-02-07 11:58:42.000000000","message":"This value setting here looks suspicious. As I see in code, it is used few times for:\n\n    if not volume.name:\n        volume.name \u003d volume.id\n\nMay we move this check in the name property above, and remove the name setting from outside?","commit_id":"f233a891c91b859be11aa83bb395a9f8966e7349"},{"author":{"_account_id":4978,"name":"Julie Pichon","email":"jpichon@redhat.com","username":"jpichon"},"change_message_id":"c8c6139053d424e60ab3d52588f7a5bb827943b7","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    @name.setter"},{"line_number":55,"context_line":"    def name(self, value):"},{"line_number":56,"context_line":"        self._apiresource.name \u003d value"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @property"},{"line_number":59,"context_line":"    def description(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F9W8s%3D","line":56,"in_reply_to":"AAAAUH%2F9Xm0%3D","updated":"2014-02-07 13:45:00.000000000","message":"Handling it all nicely in one place is a neat suggestion, thanks! Will do so in the next patch set.","commit_id":"f233a891c91b859be11aa83bb395a9f8966e7349"}]}