)]}'
{"openstack_dashboard/test/integration_tests/helpers.py":[{"author":{"_account_id":31541,"name":"Swapnil Chhanikar","email":"swapnilchhanikar@gmail.com","username":"swapnilchhanikar"},"change_message_id":"e4cc00909170b6b74d22addd3754eff51c7231cc","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    try:"},{"line_number":53,"context_line":"        SCREEN_SIZE \u003d subprocess.check_output("},{"line_number":54,"context_line":"            \u0027xdpyinfo | grep dimensions\u0027,"},{"line_number":55,"context_line":"            shell\u003dTrue).decode(\u0027utf-8\u0027).split()[1].split(\u0027x\u0027)"},{"line_number":56,"context_line":"    except subprocess.CalledProcessError:"},{"line_number":57,"context_line":"        LOG.info(\"Can\u0027t run \u0027xdpyinfo\u0027\")"},{"line_number":58,"context_line":"else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_c400486c","line":55,"range":{"start_line":55,"start_character":23,"end_line":55,"end_character":39},"updated":"2020-02-11 17:56:42.000000000","message":"Python 3+ string does not have decode method, so this will fail with AttributeError.","commit_id":"bde2be80b58ace5c899d5d830f38f14da5b897a7"},{"author":{"_account_id":23467,"name":"Pallav Gupta","email":"pallavgupta84@gmail.com","username":"pallav"},"change_message_id":"6fa3c3b53d103124c1c9763838b2c93cee5dbb93","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    try:"},{"line_number":53,"context_line":"        SCREEN_SIZE \u003d subprocess.check_output("},{"line_number":54,"context_line":"            \u0027xdpyinfo | grep dimensions\u0027,"},{"line_number":55,"context_line":"            shell\u003dTrue).decode(\u0027utf-8\u0027).split()[1].split(\u0027x\u0027)"},{"line_number":56,"context_line":"    except subprocess.CalledProcessError:"},{"line_number":57,"context_line":"        LOG.info(\"Can\u0027t run \u0027xdpyinfo\u0027\")"},{"line_number":58,"context_line":"else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_a47e6cdf","line":55,"range":{"start_line":55,"start_character":23,"end_line":55,"end_character":39},"in_reply_to":"3fa7e38b_c400486c","updated":"2020-02-11 18:07:13.000000000","message":"you are understanding it wrong. subprocess.check_output returns the data as encoded bytes [1] and we need to decode it. And bytes type supports decode in python3. Pls refer https://docs.python.org/3/library/stdtypes.html#bytes.decode\n\n[1] https://docs.python.org/3/library/subprocess.html#subprocess.check_output","commit_id":"bde2be80b58ace5c899d5d830f38f14da5b897a7"}],"openstack_dashboard/test/integration_tests/pages/project/compute/instancespage.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c3a4f9168c86ca356cb0b0ae92e00759e9f2c6c1","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":"import netaddr"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"from selenium.webdriver.common import by"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from openstack_dashboard.test.integration_tests.pages import basepage"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_ddccd697","line":13,"updated":"2020-02-07 08:44:42.000000000","message":"The blank line here is unnecessary. selenium and netaddr are both third-party.","commit_id":"c91d8d6d453ec40b191795adc4d9846a22ce6808"},{"author":{"_account_id":23467,"name":"Pallav Gupta","email":"pallavgupta84@gmail.com","username":"pallav"},"change_message_id":"e12867a404dfe5e3688e95bb7930fc7b44e99a35","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":"import netaddr"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"from selenium.webdriver.common import by"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from openstack_dashboard.test.integration_tests.pages import basepage"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_6a6aa818","line":13,"in_reply_to":"3fa7e38b_ddccd697","updated":"2020-02-08 17:13:23.000000000","message":"Done. Thanks.","commit_id":"c91d8d6d453ec40b191795adc4d9846a22ce6808"}],"openstack_dashboard/test/integration_tests/regions/menus.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"772ccfc30c984838587b62c57b090e1a31364ff7","unresolved":false,"context_lines":[{"line_number":441,"context_line":""},{"line_number":442,"context_line":""},{"line_number":443,"context_line":"class InstanceNetworkMenuRegion(InstanceAvailableResourceRegion):"},{"line_number":444,"context_line":"    pass"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_e68fa573","line":444,"updated":"2020-02-12 04:31:52.000000000","message":"This is same as InstanceAvailableResourceRegion. I don\u0027t see the reason we need. Do we need to define some class attribute as the above InstanceFlavorMenuRegion does?","commit_id":"bde2be80b58ace5c899d5d830f38f14da5b897a7"},{"author":{"_account_id":23467,"name":"Pallav Gupta","email":"pallavgupta84@gmail.com","username":"pallav"},"change_message_id":"2b5d75c19da6f16920c1dd4646214fc75439b51a","unresolved":false,"context_lines":[{"line_number":441,"context_line":""},{"line_number":442,"context_line":""},{"line_number":443,"context_line":"class InstanceNetworkMenuRegion(InstanceAvailableResourceRegion):"},{"line_number":444,"context_line":"    pass"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_f90638cc","line":444,"in_reply_to":"3fa7e38b_e68fa573","updated":"2020-02-12 17:50:07.000000000","message":"Currently It doesn\u0027t have any attribute. I\u0027ve added just for having dedicated class for each wizard step eg: Network, Flavor. But I removed it now per suggestion. In future, if new attributes or functions needed, we can separate it.","commit_id":"bde2be80b58ace5c899d5d830f38f14da5b897a7"}],"openstack_dashboard/test/integration_tests/regions/tables.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"772ccfc30c984838587b62c57b090e1a31364ff7","unresolved":false,"context_lines":[{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    def get_column_data(self, name_column\u003d\u0027Name\u0027):"},{"line_number":232,"context_line":"        names \u003d [row.cells[name_column].text for row in self.rows]"},{"line_number":233,"context_line":"        return names"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"    def assert_definition(self,"},{"line_number":236,"context_line":"                          expected_table_definition,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_66e97517","line":233,"updated":"2020-02-12 04:31:52.000000000","message":"nit: Personally, I prefer to \"return [row.cells[....\" without assigning a variable.","commit_id":"bde2be80b58ace5c899d5d830f38f14da5b897a7"},{"author":{"_account_id":23467,"name":"Pallav Gupta","email":"pallavgupta84@gmail.com","username":"pallav"},"change_message_id":"2b5d75c19da6f16920c1dd4646214fc75439b51a","unresolved":false,"context_lines":[{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    def get_column_data(self, name_column\u003d\u0027Name\u0027):"},{"line_number":232,"context_line":"        names \u003d [row.cells[name_column].text for row in self.rows]"},{"line_number":233,"context_line":"        return names"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"    def assert_definition(self,"},{"line_number":236,"context_line":"                          expected_table_definition,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_99d94482","line":233,"in_reply_to":"3fa7e38b_66e97517","updated":"2020-02-12 17:50:07.000000000","message":"Done. Thanks.","commit_id":"bde2be80b58ace5c899d5d830f38f14da5b897a7"}]}