)]}'
{"openstack_dashboard/dashboards/admin/volumes/templates/volumes/volume_types/_update_volume_type_encryption.html":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"82f2ee02fc4dba313db8bb95f6ad7abb6ce34ae3","unresolved":false,"context_lines":[{"line_number":6,"context_line":"{% block form_action %}{% url \u0027horizon:admin:volumes:volume_types:update_type_encryption\u0027 volume_type_id %}{% endblock %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% block modal_id %}update_volume_type_modal{% endblock %}"},{"line_number":9,"context_line":"{% block modal-header %}{% trans \"Update Volume Type Encryption\" %}{% endblock %}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"{% block modal-body %}"},{"line_number":12,"context_line":"\u003cdiv class\u003d\"left\"\u003e"}],"source_content_type":"text/html","patch_set":14,"id":"9aa53dc9_8f30f8e9","line":9,"updated":"2015-04-07 23:27:54.000000000","message":"modal form can be cleaned up based on this patch: https://review.openstack.org/#/c/123472/\n\nexample usage: https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/admin/volumes/volume_types/views.py#L81","commit_id":"5b287ba058bcd9d46e18988962ffc865e2878c1a"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"e389f8eecba26a880140f73e9481cedddbdd1ba4","unresolved":false,"context_lines":[{"line_number":6,"context_line":"{% block form_action %}{% url \u0027horizon:admin:volumes:volume_types:update_type_encryption\u0027 volume_type_id %}{% endblock %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% block modal_id %}update_volume_type_modal{% endblock %}"},{"line_number":9,"context_line":"{% block modal-header %}{% trans \"Update Volume Type Encryption\" %}{% endblock %}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"{% block modal-body %}"},{"line_number":12,"context_line":"\u003cdiv class\u003d\"left\"\u003e"}],"source_content_type":"text/html","patch_set":14,"id":"7aaa499b_2f3c8392","line":9,"in_reply_to":"9aa53dc9_8f30f8e9","updated":"2015-04-13 20:50:20.000000000","message":"Done.  Thank you for pointing me to an example!","commit_id":"5b287ba058bcd9d46e18988962ffc865e2878c1a"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"f300648f7f00805bab8db6e8f051d0483d67b251","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    {% trans \"Encryption information cannot be updated for a volume type if volumes are currently in use with the volume type.\" %}"},{"line_number":8,"context_line":"  \u003c/p\u003e"},{"line_number":9,"context_line":"  \u003cp\u003e"},{"line_number":10,"context_line":"    {% blocktrans %}The \u003cstrong\u003eProvider\u003c/strong\u003e is the class providing encryption support (e.g. LuksEncryptor).{% endblocktrans %}"},{"line_number":11,"context_line":"  \u003c/p\u003e"},{"line_number":12,"context_line":"  \u003cp\u003e"},{"line_number":13,"context_line":"    {% blocktrans %}The \u003cstrong\u003eControl Location\u003c/strong\u003e is the notional service where encryption is performed (e.g., front-end\u003dNova). The default value is \u0027front-end.\u0027{% endblocktrans %}"}],"source_content_type":"text/html","patch_set":21,"id":"1a7b0d38_64f4de86","line":10,"updated":"2015-12-24 13:42:05.000000000","message":"very nits.\nThis sentence is only \u0027e.g. \u0027, other is \u0027e.g.,\u0027 (before have no comma ).","commit_id":"81fa646123f5c37ecaadc23c0c6eeed784b32817"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"6b336676f9359dd3afa3d66d3c28fec759718eb8","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    {% trans \"Encryption information cannot be updated for a volume type if volumes are currently in use with the volume type.\" %}"},{"line_number":8,"context_line":"  \u003c/p\u003e"},{"line_number":9,"context_line":"  \u003cp\u003e"},{"line_number":10,"context_line":"    {% blocktrans %}The \u003cstrong\u003eProvider\u003c/strong\u003e is the class providing encryption support (e.g. LuksEncryptor).{% endblocktrans %}"},{"line_number":11,"context_line":"  \u003c/p\u003e"},{"line_number":12,"context_line":"  \u003cp\u003e"},{"line_number":13,"context_line":"    {% blocktrans %}The \u003cstrong\u003eControl Location\u003c/strong\u003e is the notional service where encryption is performed (e.g., front-end\u003dNova). The default value is \u0027front-end.\u0027{% endblocktrans %}"}],"source_content_type":"text/html","patch_set":21,"id":"fa69d971_48009e01","line":10,"in_reply_to":"1a7b0d38_64f4de86","updated":"2016-01-04 22:08:27.000000000","message":"Done","commit_id":"81fa646123f5c37ecaadc23c0c6eeed784b32817"}],"openstack_dashboard/dashboards/admin/volumes/templates/volumes/volume_types/update_volume_type_encryption.html":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"82f2ee02fc4dba313db8bb95f6ad7abb6ce34ae3","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block page_header %}"},{"line_number":6,"context_line":"  {% include \"horizon/common/_page_header.html\" with title\u003d_(\"Update an Encrypted Volume Type\") %}"},{"line_number":7,"context_line":"{% endblock page_header %}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"{% block main %}"},{"line_number":10,"context_line":"    {% include \u0027admin/volumes/volume_types/_update_volume_type_encryption.html\u0027 %}"}],"source_content_type":"text/html","patch_set":14,"id":"9aa53dc9_4f78b08f","line":7,"updated":"2015-04-07 23:27:54.000000000","message":"can be cleaned up https://review.openstack.org/#/c/154577/","commit_id":"5b287ba058bcd9d46e18988962ffc865e2878c1a"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"e389f8eecba26a880140f73e9481cedddbdd1ba4","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block page_header %}"},{"line_number":6,"context_line":"  {% include \"horizon/common/_page_header.html\" with title\u003d_(\"Update an Encrypted Volume Type\") %}"},{"line_number":7,"context_line":"{% endblock page_header %}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"{% block main %}"},{"line_number":10,"context_line":"    {% include \u0027admin/volumes/volume_types/_update_volume_type_encryption.html\u0027 %}"}],"source_content_type":"text/html","patch_set":14,"id":"7aaa499b_0f58a7f9","line":7,"in_reply_to":"9aa53dc9_4f78b08f","updated":"2015-04-13 20:50:20.000000000","message":"Done","commit_id":"5b287ba058bcd9d46e18988962ffc865e2878c1a"}],"openstack_dashboard/dashboards/admin/volumes/volume_types/forms.py":[{"author":{"_account_id":13161,"name":"Kamil Rykowski","email":"kamil.rykowski@gmail.com","username":"krykowski"},"change_message_id":"67fd74caf1cab327a61aad38ac0607f6f4152827","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    def handle(self, request, data):"},{"line_number":80,"context_line":"        try:"},{"line_number":81,"context_line":"            # Set Cipher to None if empty"},{"line_number":82,"context_line":"            if data[\u0027cipher\u0027] is u\u0027\u0027:"},{"line_number":83,"context_line":"                data[\u0027cipher\u0027] \u003d None"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"            # Update encryption for the volume type"}],"source_content_type":"text/x-python","patch_set":13,"id":"baa041b7_3a923558","line":82,"updated":"2015-04-03 19:26:51.000000000","message":"String comparison in python should be done using \u003d\u003d instead of is operator.","commit_id":"114cb346db55df30fa3a3fe99c9dd489601c73bd"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"cf6338816978437a2bf582a0188a9b143489f2e3","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    def handle(self, request, data):"},{"line_number":80,"context_line":"        try:"},{"line_number":81,"context_line":"            # Set Cipher to None if empty"},{"line_number":82,"context_line":"            if data[\u0027cipher\u0027] is u\u0027\u0027:"},{"line_number":83,"context_line":"                data[\u0027cipher\u0027] \u003d None"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"            # Update encryption for the volume type"}],"source_content_type":"text/x-python","patch_set":13,"id":"9aa53dc9_fae1bbff","line":82,"in_reply_to":"baa041b7_3a923558","updated":"2015-04-06 20:18:11.000000000","message":"Done","commit_id":"114cb346db55df30fa3a3fe99c9dd489601c73bd"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"82f2ee02fc4dba313db8bb95f6ad7abb6ce34ae3","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            # Set Cipher to None if empty"},{"line_number":44,"context_line":"            if data[\u0027cipher\u0027] is u\u0027\u0027:"},{"line_number":45,"context_line":"                data[\u0027cipher\u0027] \u003d None"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"            # Create encyrption for the volume type"},{"line_number":48,"context_line":"            volume_type \u003d cinder.\\"},{"line_number":49,"context_line":"                volume_encryption_type_create(request,"}],"source_content_type":"text/x-python","patch_set":14,"id":"9aa53dc9_afe85c11","line":46,"updated":"2015-04-07 23:27:54.000000000","message":"random unrelated nit: encryption*","commit_id":"5b287ba058bcd9d46e18988962ffc865e2878c1a"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"e389f8eecba26a880140f73e9481cedddbdd1ba4","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            # Set Cipher to None if empty"},{"line_number":44,"context_line":"            if data[\u0027cipher\u0027] is u\u0027\u0027:"},{"line_number":45,"context_line":"                data[\u0027cipher\u0027] \u003d None"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"            # Create encyrption for the volume type"},{"line_number":48,"context_line":"            volume_type \u003d cinder.\\"},{"line_number":49,"context_line":"                volume_encryption_type_create(request,"}],"source_content_type":"text/x-python","patch_set":14,"id":"7aaa499b_ef5c5bef","line":46,"in_reply_to":"9aa53dc9_afe85c11","updated":"2015-04-13 20:50:20.000000000","message":"Done -- thanks for the catch!","commit_id":"5b287ba058bcd9d46e18988962ffc865e2878c1a"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"82f2ee02fc4dba313db8bb95f6ad7abb6ce34ae3","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    key_size \u003d forms.IntegerField(label\u003d_(\"Key Size (bits)\"),"},{"line_number":75,"context_line":"                                  required\u003dFalse,"},{"line_number":76,"context_line":"                                  min_value\u003d1)"},{"line_number":77,"context_line":"    volume_type_id \u003d forms.CharField(widget\u003dforms.HiddenInput())"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def handle(self, request, data):"},{"line_number":80,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":14,"id":"9aa53dc9_cfd96085","line":77,"updated":"2015-04-07 23:27:54.000000000","message":"this is identical to CreateVolumeTypeEncryption. Can we inherit?","commit_id":"5b287ba058bcd9d46e18988962ffc865e2878c1a"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"e389f8eecba26a880140f73e9481cedddbdd1ba4","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    key_size \u003d forms.IntegerField(label\u003d_(\"Key Size (bits)\"),"},{"line_number":75,"context_line":"                                  required\u003dFalse,"},{"line_number":76,"context_line":"                                  min_value\u003d1)"},{"line_number":77,"context_line":"    volume_type_id \u003d forms.CharField(widget\u003dforms.HiddenInput())"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def handle(self, request, data):"},{"line_number":80,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":14,"id":"7aaa499b_30e5db08","line":77,"in_reply_to":"9aa53dc9_cfd96085","updated":"2015-04-13 20:50:20.000000000","message":"Done","commit_id":"5b287ba058bcd9d46e18988962ffc865e2878c1a"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"82f2ee02fc4dba313db8bb95f6ad7abb6ce34ae3","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            messages.error(request, _(\u0027Updating encryption is not \u0027"},{"line_number":95,"context_line":"                                      \u0027implemented.\u0027))"},{"line_number":96,"context_line":"            return True"},{"line_number":97,"context_line":"        except Exception:"},{"line_number":98,"context_line":"            exceptions.handle(request,"},{"line_number":99,"context_line":"                              _(\u0027Unable to update encrypted volume type.\u0027))"},{"line_number":100,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":14,"id":"9aa53dc9_0f806845","line":97,"updated":"2015-04-07 23:27:54.000000000","message":"should there be a redirect here too?","commit_id":"5b287ba058bcd9d46e18988962ffc865e2878c1a"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"e389f8eecba26a880140f73e9481cedddbdd1ba4","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            messages.error(request, _(\u0027Updating encryption is not \u0027"},{"line_number":95,"context_line":"                                      \u0027implemented.\u0027))"},{"line_number":96,"context_line":"            return True"},{"line_number":97,"context_line":"        except Exception:"},{"line_number":98,"context_line":"            exceptions.handle(request,"},{"line_number":99,"context_line":"                              _(\u0027Unable to update encrypted volume type.\u0027))"},{"line_number":100,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":14,"id":"7aaa499b_57f9817f","line":97,"in_reply_to":"9aa53dc9_0f806845","updated":"2015-04-13 20:50:20.000000000","message":"Done","commit_id":"5b287ba058bcd9d46e18988962ffc865e2878c1a"},{"author":{"_account_id":6162,"name":"Dan Nguyen","email":"dan.nguyens.mail@gmail.com","username":"daniel-a-nguyen"},"change_message_id":"db5b03f552afe45ea90eab16c5b7a3ec3e555f5c","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        except NotImplementedError:"},{"line_number":79,"context_line":"            messages.error(request, _(\u0027Updating encryption is not \u0027"},{"line_number":80,"context_line":"                                      \u0027implemented.\u0027))"},{"line_number":81,"context_line":"            return True"},{"line_number":82,"context_line":"        except Exception:"},{"line_number":83,"context_line":"            redirect \u003d reverse(\"horizon:admin:volumes:index\")"},{"line_number":84,"context_line":"            exceptions.handle(request,"}],"source_content_type":"text/x-python","patch_set":16,"id":"5aa745d1_eaac32ef","line":81,"updated":"2015-04-16 16:08:22.000000000","message":"I\u0027m not sure you\u0027d want to return True here.\n\nsuccess returns the \u0027volume_type\u0027\nerrors return False\n\nreturn True might confuse the caller into thinking the update was successful.  \n\nCould you omit return True and fall through to return False?","commit_id":"30f4b7bd797dfc55573aa9318c95b258258d30cc"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"0fdadf2549622113be0b1dad8787bda7c370d4c8","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        except NotImplementedError:"},{"line_number":79,"context_line":"            messages.error(request, _(\u0027Updating encryption is not \u0027"},{"line_number":80,"context_line":"                                      \u0027implemented.\u0027))"},{"line_number":81,"context_line":"            return True"},{"line_number":82,"context_line":"        except Exception:"},{"line_number":83,"context_line":"            redirect \u003d reverse(\"horizon:admin:volumes:index\")"},{"line_number":84,"context_line":"            exceptions.handle(request,"}],"source_content_type":"text/x-python","patch_set":16,"id":"3ab451fb_9c2ac52b","line":81,"in_reply_to":"5aa745d1_eaac32ef","updated":"2015-04-16 20:01:09.000000000","message":"Thank you for the comment; I agree with your suggestion.\n\nThis is fixed in the upcoming patch.","commit_id":"30f4b7bd797dfc55573aa9318c95b258258d30cc"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"f300648f7f00805bab8db6e8f051d0483d67b251","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                                        \u0027volume type: %s\u0027) % data[\u0027name\u0027])"},{"line_number":77,"context_line":"            return volume_type"},{"line_number":78,"context_line":"        except NotImplementedError:"},{"line_number":79,"context_line":"            messages.error(request, _(\u0027Updating encryption is not \u0027"},{"line_number":80,"context_line":"                                      \u0027implemented.\u0027))"},{"line_number":81,"context_line":"        except Exception:"},{"line_number":82,"context_line":"            redirect \u003d reverse(\"horizon:admin:volumes:index\")"}],"source_content_type":"text/x-python","patch_set":21,"id":"1a7b0d38_8f20039d","line":79,"updated":"2015-12-24 13:42:05.000000000","message":"IMO. this string is just a reason and it is not a result.\nSo it is better to add string(\"Unable to update encrypted volume type.\") to express a result.","commit_id":"81fa646123f5c37ecaadc23c0c6eeed784b32817"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"6b336676f9359dd3afa3d66d3c28fec759718eb8","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                                        \u0027volume type: %s\u0027) % data[\u0027name\u0027])"},{"line_number":77,"context_line":"            return volume_type"},{"line_number":78,"context_line":"        except NotImplementedError:"},{"line_number":79,"context_line":"            messages.error(request, _(\u0027Updating encryption is not \u0027"},{"line_number":80,"context_line":"                                      \u0027implemented.\u0027))"},{"line_number":81,"context_line":"        except Exception:"},{"line_number":82,"context_line":"            redirect \u003d reverse(\"horizon:admin:volumes:index\")"}],"source_content_type":"text/x-python","patch_set":21,"id":"fa69d971_08b146e1","line":79,"in_reply_to":"1a7b0d38_8f20039d","updated":"2016-01-04 22:08:27.000000000","message":"Done","commit_id":"81fa646123f5c37ecaadc23c0c6eeed784b32817"}],"openstack_dashboard/dashboards/admin/volumes/volume_types/tables.py":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"82f2ee02fc4dba313db8bb95f6ad7abb6ce34ae3","unresolved":false,"context_lines":[{"line_number":97,"context_line":"            return (hasattr(volume_type, \u0027encryption\u0027)"},{"line_number":98,"context_line":"                    and hasattr(volume_type.encryption, \u0027provider\u0027))"},{"line_number":99,"context_line":"        else:"},{"line_number":100,"context_line":"            return False"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"class DeleteVolumeTypeEncryption(tables.DeleteAction):"}],"source_content_type":"text/x-python","patch_set":14,"id":"9aa53dc9_0f450816","line":100,"updated":"2015-04-07 23:27:54.000000000","message":"nit: same as allowed() above... reuse?","commit_id":"5b287ba058bcd9d46e18988962ffc865e2878c1a"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"e389f8eecba26a880140f73e9481cedddbdd1ba4","unresolved":false,"context_lines":[{"line_number":97,"context_line":"            return (hasattr(volume_type, \u0027encryption\u0027)"},{"line_number":98,"context_line":"                    and hasattr(volume_type.encryption, \u0027provider\u0027))"},{"line_number":99,"context_line":"        else:"},{"line_number":100,"context_line":"            return False"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"class DeleteVolumeTypeEncryption(tables.DeleteAction):"}],"source_content_type":"text/x-python","patch_set":14,"id":"7aaa499b_17ae5985","line":100,"in_reply_to":"9aa53dc9_0f450816","updated":"2015-04-13 20:50:20.000000000","message":"I refactored it so that all three (Create, Update, Delete) use the same method (_does_vol_type_enc_exist) as part of their allowed method.\n\nCreate is only allowed if encryption doesn\u0027t exist yet, and Update and Delete are only allowed if encryption already exists.","commit_id":"5b287ba058bcd9d46e18988962ffc865e2878c1a"}],"openstack_dashboard/dashboards/admin/volumes/volume_types/views.py":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"82f2ee02fc4dba313db8bb95f6ad7abb6ce34ae3","unresolved":false,"context_lines":[{"line_number":146,"context_line":"                msg \u003d _(\u0027Unable to retrieve volume type name.\u0027)"},{"line_number":147,"context_line":"                url \u003d reverse(\u0027horizon:admin:volumes:index\u0027)"},{"line_number":148,"context_line":"                exceptions.handle(self.request, msg, redirect\u003durl)"},{"line_number":149,"context_line":"        return self.name"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    def get_context_data(self, **kwargs):"},{"line_number":152,"context_line":"        context \u003d super(UpdateVolumeTypeEncryptionView, self).\\"}],"source_content_type":"text/x-python","patch_set":14,"id":"9aa53dc9_4f30b09e","line":149,"updated":"2015-04-07 23:27:54.000000000","message":"same as in CreateVolumeTypeEncryptionView, can we reuse?","commit_id":"5b287ba058bcd9d46e18988962ffc865e2878c1a"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"e389f8eecba26a880140f73e9481cedddbdd1ba4","unresolved":false,"context_lines":[{"line_number":146,"context_line":"                msg \u003d _(\u0027Unable to retrieve volume type name.\u0027)"},{"line_number":147,"context_line":"                url \u003d reverse(\u0027horizon:admin:volumes:index\u0027)"},{"line_number":148,"context_line":"                exceptions.handle(self.request, msg, redirect\u003durl)"},{"line_number":149,"context_line":"        return self.name"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    def get_context_data(self, **kwargs):"},{"line_number":152,"context_line":"        context \u003d super(UpdateVolumeTypeEncryptionView, self).\\"}],"source_content_type":"text/x-python","patch_set":14,"id":"7aaa499b_d0d35737","line":149,"in_reply_to":"9aa53dc9_4f30b09e","updated":"2015-04-13 20:50:20.000000000","message":"I now reuse the same method for both Update and Create, a method named _get_volume_type_name","commit_id":"5b287ba058bcd9d46e18988962ffc865e2878c1a"},{"author":{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},"change_message_id":"30c92e854f06096df20c49a7fa587497365d8c35","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        msg \u003d _(\u0027Unable to retrieve volume type name.\u0027)"},{"line_number":120,"context_line":"        url \u003d reverse(\u0027horizon:admin:volumes:index\u0027)"},{"line_number":121,"context_line":"        exceptions.handle(request, msg, redirect\u003durl)"},{"line_number":122,"context_line":"    return name"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"class UpdateVolumeTypeEncryptionView(forms.ModalFormView):"}],"source_content_type":"text/x-python","patch_set":15,"id":"7aaa499b_69332e63","line":122,"updated":"2015-04-15 17:00:21.000000000","message":"Name may not be initialized if there\u0027s an exception or the volume type id is not found. Perhaps the return statement should appear directly within the if block above?","commit_id":"5c79f0ee2f06d0746d5901dcdcbd35785e1647a2"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"a27c0f6f96ec90898770491c35196682be420535","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        msg \u003d _(\u0027Unable to retrieve volume type name.\u0027)"},{"line_number":120,"context_line":"        url \u003d reverse(\u0027horizon:admin:volumes:index\u0027)"},{"line_number":121,"context_line":"        exceptions.handle(request, msg, redirect\u003durl)"},{"line_number":122,"context_line":"    return name"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"class UpdateVolumeTypeEncryptionView(forms.ModalFormView):"}],"source_content_type":"text/x-python","patch_set":15,"id":"5aa745d1_ca74dbfe","line":122,"in_reply_to":"7aaa499b_69332e63","updated":"2015-04-16 14:41:02.000000000","message":"Done","commit_id":"5c79f0ee2f06d0746d5901dcdcbd35785e1647a2"}]}