)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9317,"name":"Ana Krivokapic","email":"akrivoka@redhat.com","username":"akrivoka"},"change_message_id":"3efd9ff69709360015a408d11e2267e7c4656d27","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix Instance Image Name cell value"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It shows up differently in Project/Admin table for instances with no instance."},{"line_number":10,"context_line":"Project table shows \u0027-\u0027 while Admin table shows \u0027(not found)\u0027"},{"line_number":11,"context_line":"\u003d\u003e Now both tables show \u0027-\u0027 as it is consistent with other tables"},{"line_number":12,"context_line":"Also in the Instance detail page, Image Name shows as a hyperlinked \"(not found)\""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAU3%2F%2FeCs%3D","line":9,"updated":"2014-02-26 13:43:52.000000000","message":"\"with no instance\" -\u003e \"with no image\"","commit_id":"26bd18e8cb9bd65163b5f2943a6f88f7b2065eb0"}],"openstack_dashboard/api/nova.py":[{"author":{"_account_id":6825,"name":"Gary W. Smith","email":"garysmith123@gmail.com","username":"gary-w-smith"},"change_message_id":"f66b4807ad5dd4e27cda00176a5035ff1df5fd98","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        import glanceclient.exc as glance_exceptions"},{"line_number":95,"context_line":"        from openstack_dashboard.api import glance"},{"line_number":96,"context_line":"        if not self.image:"},{"line_number":97,"context_line":"            return \"-\""},{"line_number":98,"context_line":"        if hasattr(self.image, \u0027name\u0027):"},{"line_number":99,"context_line":"            return self.image.name"},{"line_number":100,"context_line":"        if \u0027name\u0027 in self.image:"}],"source_content_type":"text/x-python","patch_set":7,"id":"7adec928_0b9f5460","line":97,"updated":"2014-05-23 02:16:41.000000000","message":"Shouldn\u0027t this be localizable, i.e.  _(\"-\")  ?? Also for the \"(not found)\" string on line 107.","commit_id":"6235d26af953841b89f7fd7397299b94dc52435e"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"e00dcb49971f511602208144732b09ba0dc8adb6","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        import glanceclient.exc as glance_exceptions"},{"line_number":95,"context_line":"        from openstack_dashboard.api import glance"},{"line_number":96,"context_line":"        if not self.image:"},{"line_number":97,"context_line":"            return \"-\""},{"line_number":98,"context_line":"        if hasattr(self.image, \u0027name\u0027):"},{"line_number":99,"context_line":"            return self.image.name"},{"line_number":100,"context_line":"        if \u0027name\u0027 in self.image:"}],"source_content_type":"text/x-python","patch_set":7,"id":"7adec928_9fe0fefb","line":97,"in_reply_to":"7adec928_0b9f5460","updated":"2014-05-23 06:38:08.000000000","message":"I don\u0027t think \"-\" need to be localizable, it\u0027s a symbol rather than a letter.","commit_id":"6235d26af953841b89f7fd7397299b94dc52435e"},{"author":{"_account_id":6825,"name":"Gary W. Smith","email":"garysmith123@gmail.com","username":"gary-w-smith"},"change_message_id":"2488845ac42421ca7cc476f58de927e0d66db4f0","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        import glanceclient.exc as glance_exceptions"},{"line_number":95,"context_line":"        from openstack_dashboard.api import glance"},{"line_number":96,"context_line":"        if not self.image:"},{"line_number":97,"context_line":"            return \"-\""},{"line_number":98,"context_line":"        if hasattr(self.image, \u0027name\u0027):"},{"line_number":99,"context_line":"            return self.image.name"},{"line_number":100,"context_line":"        if \u0027name\u0027 in self.image:"}],"source_content_type":"text/x-python","patch_set":7,"id":"7adec928_37b463d0","line":97,"in_reply_to":"7adec928_9fe0fefb","updated":"2014-05-28 00:00:40.000000000","message":"It is localizable in the other change in this patchset.  I would expect them to match.","commit_id":"6235d26af953841b89f7fd7397299b94dc52435e"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"e00dcb49971f511602208144732b09ba0dc8adb6","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                image \u003d glance.image_get(self.request, self.image[\u0027id\u0027])"},{"line_number":105,"context_line":"                return image.name"},{"line_number":106,"context_line":"            except glance_exceptions.ClientException:"},{"line_number":107,"context_line":"                return \"(not found)\""},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    @property"},{"line_number":110,"context_line":"    def internal_name(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7adec928_5fbd96d6","line":107,"updated":"2014-05-23 06:38:08.000000000","message":"You should change this \"(not found)\" to \"-\" as well.","commit_id":"6235d26af953841b89f7fd7397299b94dc52435e"}],"openstack_dashboard/dashboards/admin/instances/views.py":[{"author":{"_account_id":9317,"name":"Ana Krivokapic","email":"akrivoka@redhat.com","username":"akrivoka"},"change_message_id":"3efd9ff69709360015a408d11e2267e7c4656d27","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                if hasattr(inst, \u0027image\u0027):"},{"line_number":111,"context_line":"                    if not isinstance(inst.image, dict):"},{"line_number":112,"context_line":"                        inst.image \u003d {\u0027name\u0027:"},{"line_number":113,"context_line":"                                inst.image if inst.image else _(\"-\")}"},{"line_number":114,"context_line":"                flavor_id \u003d inst.flavor[\"id\"]"},{"line_number":115,"context_line":"                try:"},{"line_number":116,"context_line":"                    if flavor_id in full_flavors:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAU3%2F%2Fdqo%3D","line":113,"updated":"2014-02-26 13:43:52.000000000","message":"A bit short way to write it:\n\n inst.image \u003d {\u0027name\u0027: inst.image or _(\"-\")}","commit_id":"26bd18e8cb9bd65163b5f2943a6f88f7b2065eb0"}],"openstack_dashboard/dashboards/project/instances/tables.py":[{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"7b63fbcf5ddc96a0ad5ca152caeefed98ab6d563","unresolved":false,"context_lines":[{"line_number":575,"context_line":"    def get_data(self, request, instance_id):"},{"line_number":576,"context_line":"        instance \u003d api.nova.server_get(request, instance_id)"},{"line_number":577,"context_line":"        if hasattr(instance, \u0027image\u0027):"},{"line_number":578,"context_line":"                    if not isinstance(instance.image, dict):"},{"line_number":579,"context_line":"                        instance.image \u003d {\u0027name\u0027:"},{"line_number":580,"context_line":"                                instance.image if instance.image else _(\"-\")}"},{"line_number":581,"context_line":"        instance.full_flavor \u003d api.nova.flavor_get(request,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAU3%2F%2FhDo%3D","line":578,"updated":"2014-02-26 06:59:01.000000000","message":"bad indentation here.","commit_id":"26bd18e8cb9bd65163b5f2943a6f88f7b2065eb0"},{"author":{"_account_id":9317,"name":"Ana Krivokapic","email":"akrivoka@redhat.com","username":"akrivoka"},"change_message_id":"3efd9ff69709360015a408d11e2267e7c4656d27","unresolved":false,"context_lines":[{"line_number":577,"context_line":"        if hasattr(instance, \u0027image\u0027):"},{"line_number":578,"context_line":"                    if not isinstance(instance.image, dict):"},{"line_number":579,"context_line":"                        instance.image \u003d {\u0027name\u0027:"},{"line_number":580,"context_line":"                                instance.image if instance.image else _(\"-\")}"},{"line_number":581,"context_line":"        instance.full_flavor \u003d api.nova.flavor_get(request,"},{"line_number":582,"context_line":"                                                   instance.flavor[\"id\"])"},{"line_number":583,"context_line":"        error \u003d get_instance_error(instance)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAU3%2F%2FdqI%3D","line":580,"updated":"2014-02-26 13:43:52.000000000","message":"A bit short way to write it:\n\n inst.image \u003d {\u0027name\u0027: inst.image or _(\"-\")}","commit_id":"26bd18e8cb9bd65163b5f2943a6f88f7b2065eb0"},{"author":{"_account_id":7386,"name":"Tzu-Mainn Chen","email":"tzumainn@redhat.com","username":"tzumainn"},"change_message_id":"25b2ee1c4ae7452c0e8e421b3fe9501441b63365","unresolved":false,"context_lines":[{"line_number":576,"context_line":"        instance \u003d api.nova.server_get(request, instance_id)"},{"line_number":577,"context_line":"        if hasattr(instance, \u0027image\u0027):"},{"line_number":578,"context_line":"            if not isinstance(instance.image, dict):"},{"line_number":579,"context_line":"                instance.image \u003d {\u0027name\u0027: instance.image or _(\"-\")}"},{"line_number":580,"context_line":"        instance.full_flavor \u003d api.nova.flavor_get(request,"},{"line_number":581,"context_line":"                                                   instance.flavor[\"id\"])"},{"line_number":582,"context_line":"        error \u003d get_instance_error(instance)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAW3%2F%2F7DQ%3D","line":579,"updated":"2014-04-09 13:24:43.000000000","message":"Seeing as how this code is entirely duplicated from openstack_dashboard/dashboards/admin/instances/views.py, would it make sense to turn it into a method for the Server class in api/nova.py?","commit_id":"c3c01cf19a8295f4d936fb3eb7c47adf88aa6e15"},{"author":{"_account_id":9450,"name":"Juan Manuel Ollé","email":"juan.m.olle@intel.com","username":"jmolle"},"change_message_id":"f235da083e3a5cb176e452859b99adf55158b30e","unresolved":false,"context_lines":[{"line_number":576,"context_line":"        instance \u003d api.nova.server_get(request, instance_id)"},{"line_number":577,"context_line":"        if hasattr(instance, \u0027image\u0027):"},{"line_number":578,"context_line":"            if not isinstance(instance.image, dict):"},{"line_number":579,"context_line":"                instance.image \u003d {\u0027name\u0027: instance.image or _(\"-\")}"},{"line_number":580,"context_line":"        instance.full_flavor \u003d api.nova.flavor_get(request,"},{"line_number":581,"context_line":"                                                   instance.flavor[\"id\"])"},{"line_number":582,"context_line":"        error \u003d get_instance_error(instance)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7adec928_9d1758ed","line":579,"in_reply_to":"AAAAW3%2F%2F7DQ%3D","updated":"2014-05-08 20:29:21.000000000","message":"Agree, and it will be nice to add a test. Thanks","commit_id":"c3c01cf19a8295f4d936fb3eb7c47adf88aa6e15"}]}
