)]}'
{"openstack_dashboard/api/heat.py":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"340f9b2a1846f341d40f9942af8f4f60bfbdf185","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        kwargs[\u0027marker\u0027] \u003d marker"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    stacks_iter \u003d heatclient(request).stacks.list(page_size\u003drequest_size,"},{"line_number":71,"context_line":"                                                  limit\u003dlimit,"},{"line_number":72,"context_line":"                                                  **kwargs)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    has_more_data \u003d False"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2FJZA%3D","line":71,"updated":"2014-02-16 04:30:54.000000000","message":"page_size is not a supported parameter for stacks.list(): https://github.com/openstack/python-heatclient/blob/master/heatclient/v1/stacks.py#L73\n\nThis should be limit\u003drequest_size?","commit_id":"29d99475da85fac69f1cd46e857f2f4e54cf3606"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"340f9b2a1846f341d40f9942af8f4f60bfbdf185","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    has_more_data \u003d False"},{"line_number":75,"context_line":"    if paginate:"},{"line_number":76,"context_line":"        stacks \u003d list(itertools.islice(stacks_iter, request_size))"},{"line_number":77,"context_line":"        if len(stacks) \u003e page_size:"},{"line_number":78,"context_line":"            stacks.pop(-1)"},{"line_number":79,"context_line":"            has_more_data \u003d True"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2FJY4%3D","line":76,"updated":"2014-02-16 04:30:54.000000000","message":"This is not required anymore if we already limit the result by request_size.","commit_id":"29d99475da85fac69f1cd46e857f2f4e54cf3606"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"f29b886b5a390da641a01ef60b5dbe22eab20bfb","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"# under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"import itertools"},{"line_number":16,"context_line":"import logging"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from django.conf import settings"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAVn%2F%2FmR8%3D","line":15,"updated":"2014-03-05 05:52:44.000000000","message":"pep8 error due to unused import","commit_id":"150ba61cac8e3d5e0f1c4694a4cfa24cc4d9c821"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"dead1f8a4f9833e3b33360fe840ead0cff6882c2","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    if paginate:"},{"line_number":74,"context_line":"        stacks \u003d list(stacks_iter)"},{"line_number":75,"context_line":"        if len(stacks) \u003e page_size:"},{"line_number":76,"context_line":"            stacks.pop(-1)"},{"line_number":77,"context_line":"            has_more_data \u003d True"},{"line_number":78,"context_line":"    else:"},{"line_number":79,"context_line":"        stacks \u003d list(stacks_iter)"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAWH%2F%2Fgwc%3D","line":76,"updated":"2014-03-17 13:08:04.000000000","message":"nitpick: pop() removes the last element by default, no need for -1","commit_id":"a781b30109ffd9037dc310b0451ac37949ea2b6c"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"dead1f8a4f9833e3b33360fe840ead0cff6882c2","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            stacks.pop(-1)"},{"line_number":77,"context_line":"            has_more_data \u003d True"},{"line_number":78,"context_line":"    else:"},{"line_number":79,"context_line":"        stacks \u003d list(stacks_iter)"},{"line_number":80,"context_line":"    return (stacks, has_more_data)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAWH%2F%2Fgwk%3D","line":79,"updated":"2014-03-17 13:08:04.000000000","message":"This line repeats in both branches -- just move it before the if.","commit_id":"a781b30109ffd9037dc310b0451ac37949ea2b6c"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"dead1f8a4f9833e3b33360fe840ead0cff6882c2","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            has_more_data \u003d True"},{"line_number":78,"context_line":"    else:"},{"line_number":79,"context_line":"        stacks \u003d list(stacks_iter)"},{"line_number":80,"context_line":"    return (stacks, has_more_data)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"def stack_delete(request, stack_id):"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAWH%2F%2Fgwg%3D","line":80,"updated":"2014-03-17 13:08:04.000000000","message":"nitpick: parens not required","commit_id":"a781b30109ffd9037dc310b0451ac37949ea2b6c"}],"openstack_dashboard/dashboards/project/stacks/tests.py":[{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"dead1f8a4f9833e3b33360fe840ead0cff6882c2","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        url \u003d \"?\".join([reverse(\u0027horizon:project:stacks:index\u0027),"},{"line_number":140,"context_line":"                    \"\u003d\".join([tables.StacksTable._meta.pagination_param,"},{"line_number":141,"context_line":"                              stacks[2].id])])"},{"line_number":142,"context_line":"        res \u003d self.client.get(url)"},{"line_number":143,"context_line":"        # get second page (items 2-4)"},{"line_number":144,"context_line":"        self.assertEqual(len(res.context[\u0027stacks_table\u0027].data),"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAWH%2F%2Fgv4%3D","line":141,"updated":"2014-03-17 13:08:04.000000000","message":"nitpick: using \"\".join() just to concatenate two strings is ugly, please just use + or %.","commit_id":"a781b30109ffd9037dc310b0451ac37949ea2b6c"}],"openstack_dashboard/dashboards/project/stacks/views.py":[{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"dead1f8a4f9833e3b33360fe840ead0cff6882c2","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    template_name \u003d \u0027project/stacks/index.html\u0027"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def has_more_data(self, table):"},{"line_number":50,"context_line":"        return self._more"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def get_data(self):"},{"line_number":53,"context_line":"        stacks \u003d []"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAWH%2F%2Fgu0%3D","line":50,"updated":"2014-03-17 13:08:04.000000000","message":"Can you make sure that always exists, even if you didn\u0027t call get_data yet?","commit_id":"a781b30109ffd9037dc310b0451ac37949ea2b6c"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"dead1f8a4f9833e3b33360fe840ead0cff6882c2","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    def get_data(self):"},{"line_number":53,"context_line":"        stacks \u003d []"},{"line_number":54,"context_line":"        marker \u003d self.request.GET.get("},{"line_number":55,"context_line":"            project_tables.StacksTable._meta.pagination_param, None)"},{"line_number":56,"context_line":"        try:"},{"line_number":57,"context_line":"            stacks, self._more \u003d api.heat.stacks_list(self.request,"},{"line_number":58,"context_line":"                                                      marker\u003dmarker,"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAWH%2F%2Fgto%3D","line":55,"updated":"2014-03-17 13:08:04.000000000","message":"nitpick: None is the default default value in dict.get()","commit_id":"a781b30109ffd9037dc310b0451ac37949ea2b6c"}],"openstack_dashboard/test/api_tests/heat_tests.py":[{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"129f563a3f1eed64ccebe08c1758cac4bba3d9d1","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"        heatclient \u003d self.stub_heatclient()"},{"line_number":28,"context_line":"        heatclient.stacks \u003d self.mox.CreateMockAnything()"},{"line_number":29,"context_line":"        heatclient.stacks.list(page_size\u003dlimit,"},{"line_number":30,"context_line":"                            limit\u003dlimit).AndReturn(iter(api_stacks))"},{"line_number":31,"context_line":"        self.mox.ReplayAll()"},{"line_number":32,"context_line":"        stacks, has_more \u003d api.heat.stacks_list(self.request)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAVn%2F%2FmOk%3D","line":29,"updated":"2014-03-05 06:02:21.000000000","message":"page_size is not a supported parameter.","commit_id":"150ba61cac8e3d5e0f1c4694a4cfa24cc4d9c821"}]}