)]}'
{"openstack_dashboard/test/integration_tests/pages/admin/volume/grouptypespage.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3c14fe961b0fefb61e292c04612a9e2ecf9060de","unresolved":true,"context_lines":[{"line_number":19,"context_line":"    name \u003d \u0027group_types\u0027"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    CREATE_GROUP_TYPE_FORM_FIELDS \u003d ("},{"line_number":22,"context_line":"        \"name\", \"group_type_description\")"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    @tables.bind_table_action(\u0027create\u0027)"},{"line_number":25,"context_line":"    def create_group_type(self, create_button):"}],"source_content_type":"text/x-python","patch_set":4,"id":"76eebf83_ad1a408f","line":22,"updated":"2020-11-26 10:54:18.000000000","message":"nit: This is a tuple, so I prefer:\n\n  CREATE_GROUP_TYPE_FORM_FIELDS \u003d (\"name\", \"group_type_description\")\n\nor\n\n  CREATE_GROUP_TYPE_FORM_FIELDS \u003d (\n      \"name\",\n      \"group_type_description\",\n  )\n\nIn a list or a tuple, when items are listed in multiple lines, one item per line would increase the readability.","commit_id":"0cc115b8483772556d5ba1ec978c4417a33caa31"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"aa69faf77a04d53096806fcd19c8402c7fb74f6c","unresolved":true,"context_lines":[{"line_number":19,"context_line":"    name \u003d \u0027group_types\u0027"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    CREATE_GROUP_TYPE_FORM_FIELDS \u003d ("},{"line_number":22,"context_line":"        \"name\", \"group_type_description\")"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    @tables.bind_table_action(\u0027create\u0027)"},{"line_number":25,"context_line":"    def create_group_type(self, create_button):"}],"source_content_type":"text/x-python","patch_set":4,"id":"6a365a4f_f1da5964","line":22,"in_reply_to":"76eebf83_ad1a408f","updated":"2020-11-26 11:08:28.000000000","message":"Done.","commit_id":"0cc115b8483772556d5ba1ec978c4417a33caa31"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3c14fe961b0fefb61e292c04612a9e2ecf9060de","unresolved":true,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def __init__(self, driver, conf):"},{"line_number":41,"context_line":"        super().__init__(driver, conf)"},{"line_number":42,"context_line":"        self._page_title \u003d \"Group Types\""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @property"},{"line_number":45,"context_line":"    def group_types_table(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"55e713c1_e2a2683b","line":42,"updated":"2020-11-26 10:54:18.000000000","message":"I wonder why _page_title can be a class attribute. It is a constant per class, so I see no reason to assign it in __init__().\n\n(This is not related to this commit. It is related to the design of this class and it can be a future improvement.)","commit_id":"0cc115b8483772556d5ba1ec978c4417a33caa31"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"aa69faf77a04d53096806fcd19c8402c7fb74f6c","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def __init__(self, driver, conf):"},{"line_number":41,"context_line":"        super().__init__(driver, conf)"},{"line_number":42,"context_line":"        self._page_title \u003d \"Group Types\""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @property"},{"line_number":45,"context_line":"    def group_types_table(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"a109acc6_220b4e0b","line":42,"in_reply_to":"55e713c1_e2a2683b","updated":"2020-11-26 11:08:28.000000000","message":"Ack","commit_id":"0cc115b8483772556d5ba1ec978c4417a33caa31"}]}